unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: EuAndreh via Guix-patches via <guix-patches@gnu.org>
To: 58595@debbugs.gnu.org
Cc: EuAndreh <eu@euandre.org>
Subject: [bug#58595] [PATCH 2/2] services: nginx: Improve reload action documentation.
Date: Mon, 17 Oct 2022 18:33:25 -0300	[thread overview]
Message-ID: <20221017213325.29154-1-eu@euandre.org> (raw)
In-Reply-To: <58590@debbugs.gnu.org>

* gnu/services/web.scm (nginx-shepherd-service): Be explicit about the
reload action not changing the configuration file, but instead
respawning worker processes.
---

Correct placement of the second patch.  I'll close the other bugs opened
when I replied to my own email, instead of debbugs' email.
 gnu/services/web.scm | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/gnu/services/web.scm b/gnu/services/web.scm
index 7fde8824b3..2023119037 100644
--- a/gnu/services/web.scm
+++ b/gnu/services/web.scm
@@ -819,7 +819,11 @@ (define (nginx-shepherd-service config)
               (list
                (shepherd-action
                  (name 'reload)
-                 (documentation "Reload NGINX configuration file and restart worker processes.")
+                 (documentation "Reload nginx configuration file and restart worker processes.
+This has the effect of killing old worker processes and starting new ones, using
+the same configuration file.  It is useful for situations where the same nginx
+configuration file can point to different things after a reload, such as
+renewed TLS certificates, or @code{include}d files.")
                  (procedure (nginx-action "-s" "reload"))))))))))
 
 (define nginx-service-type
-- 
2.38.0





       reply	other threads:[~2022-10-17 21:34 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <58590@debbugs.gnu.org>
2022-10-17 21:33 ` EuAndreh via Guix-patches via [this message]
     [not found]   ` <handler.58595.B.16660424324863.ack@debbugs.gnu.org>
2022-10-17 21:50     ` [bug#58595] Acknowledgement ([PATCH 2/2] services: nginx: Improve reload action documentation.) EuAndreh via Guix-patches via

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221017213325.29154-1-eu@euandre.org \
    --to=guix-patches@gnu.org \
    --cc=58595@debbugs.gnu.org \
    --cc=eu@euandre.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).