unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: EuAndreh via Guix-patches via <guix-patches@gnu.org>
To: 58590@debbugs.gnu.org
Cc: EuAndreh <eu@euandre.org>
Subject: [bug#58590] [PATCH 1/2] services: nginx: Use nginx-action over inline gexp.
Date: Mon, 17 Oct 2022 17:57:18 -0300	[thread overview]
Message-ID: <20221017205719.5704-2-eu@euandre.org> (raw)
In-Reply-To: <20221017205719.5704-1-eu@euandre.org>

* gnu/services/web.scm (nginx-shepherd-service): Use the simpler
"nginx-action" helper, for the same reload side-effect.
---
 gnu/services/web.scm | 8 +-------
 1 file changed, 1 insertion(+), 7 deletions(-)

diff --git a/gnu/services/web.scm b/gnu/services/web.scm
index 227a577de3..7fde8824b3 100644
--- a/gnu/services/web.scm
+++ b/gnu/services/web.scm
@@ -820,13 +820,7 @@ (define (nginx-shepherd-service config)
                (shepherd-action
                  (name 'reload)
                  (documentation "Reload NGINX configuration file and restart worker processes.")
-                 (procedure
-                   #~(lambda (pid)
-                       (if pid
-                         (begin
-                           (kill pid SIGHUP)
-                           (format #t "Service NGINX (PID ~a) has been reloaded." pid))
-                         (format #t "Service NGINX is not running."))))))))))))
+                 (procedure (nginx-action "-s" "reload"))))))))))
 
 (define nginx-service-type
   (service-type (name 'nginx)
-- 
2.38.0





  reply	other threads:[~2022-10-17 20:59 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-17 20:57 [bug#58590] [PATCH 0/2] Rework nginx-shepherd reload EuAndreh via Guix-patches via
2022-10-17 20:57 ` EuAndreh via Guix-patches via [this message]
2022-10-17 21:28   ` [bug#58594] [PATCH 2/2] services: nginx: Improve reload action documentation EuAndreh via Guix-patches via
     [not found]     ` <handler.58594.B.16660421334234.ack@debbugs.gnu.org>
2022-10-17 21:42       ` [bug#58594] Acknowledgement ([PATCH 2/2] services: nginx: Improve reload action documentation.) EuAndreh via Guix-patches via
2022-10-17 20:57 ` [bug#58589] [PATCH 2/2] services: nginx: Improve reload action documentation EuAndreh via Guix-patches via
     [not found]   ` <handler.58589.B.1666040265948.ack@debbugs.gnu.org>
2022-10-17 21:49     ` [bug#58589] Acknowledgement ([PATCH 2/2] services: nginx: Improve reload action documentation.) EuAndreh via Guix-patches via
2022-10-18 10:16 ` bug#58590: [PATCH 0/2] Rework nginx-shepherd reload Christopher Baines

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221017205719.5704-2-eu@euandre.org \
    --to=guix-patches@gnu.org \
    --cc=58590@debbugs.gnu.org \
    --cc=eu@euandre.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).