unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
* [bug#58465] [PATCH] gnu: Add guile-dns.
@ 2022-10-12  9:48 Arun Isaac
  2022-10-13 10:05 ` Christopher Baines
  0 siblings, 1 reply; 8+ messages in thread
From: Arun Isaac @ 2022-10-12  9:48 UTC (permalink / raw)
  To: 58465; +Cc: Arun Isaac

* gnu/packages/guile-xyz.scm (guile-dns): New variable.
---
 gnu/packages/guile-xyz.scm | 36 ++++++++++++++++++++++++++++++++++++
 1 file changed, 36 insertions(+)

diff --git a/gnu/packages/guile-xyz.scm b/gnu/packages/guile-xyz.scm
index 379d9aa264..b7909e8f8d 100644
--- a/gnu/packages/guile-xyz.scm
+++ b/gnu/packages/guile-xyz.scm
@@ -4426,6 +4426,42 @@ (define-public guile-avahi
       (home-page "https://www.nongnu.org/guile-avahi/")
       (license license:lgpl3+))))
 
+(define-public guile-dns
+  (package
+    (name "guile-dns")
+    (version "0.1")
+    (source (origin
+              (method git-fetch)
+              (uri (git-reference
+                    (url "https://git.lysator.liu.se/hugo/guile-dns")
+                    (commit version)))
+              (file-name (git-file-name name version))
+              (sha256
+               (base32
+                "18skivracv6jh1zab9dknkcpbizc416n0pb2mcwb20dpzc2md9yf"))))
+    (build-system gnu-build-system)
+    (arguments
+     (list #:make-flags #~(list (string-append "PREFIX=" #$output))
+           #:phases
+           #~(modify-phases %standard-phases
+               (add-after 'unpack 'prefer-curdir
+                 (lambda _
+                   ;; CURDIR is a standard GNU Make variable. Prefer it to
+                   ;; PWD. PWD is set by the shell and is absent in the build
+                   ;; process.
+                   (substitute* "Makefile"
+                     (("PWD") "CURDIR"))))
+               (delete 'configure))))
+    (inputs
+     (list guile-3.0))
+    (native-inputs
+     (list texinfo))
+    (home-page "https://git.lysator.liu.se/hugo/guile-dns")
+    (synopsis "Guile DNS library")
+    (description "@code{guile-dns} is a DNS library written in pure Guile
+Scheme.")
+    (license license:gpl3+)))
+
 (define-public guile-jwt
   (package
     (name "guile-jwt")
-- 
2.37.3





^ permalink raw reply related	[flat|nested] 8+ messages in thread

* [bug#58465] [PATCH] gnu: Add guile-dns.
  2022-10-12  9:48 [bug#58465] [PATCH] gnu: Add guile-dns Arun Isaac
@ 2022-10-13 10:05 ` Christopher Baines
  2022-10-14 20:40   ` Arun Isaac
  0 siblings, 1 reply; 8+ messages in thread
From: Christopher Baines @ 2022-10-13 10:05 UTC (permalink / raw)
  To: Arun Isaac; +Cc: 58465

[-- Attachment #1: Type: text/plain, Size: 435 bytes --]


Arun Isaac <arunisaac@systemreboot.net> writes:

> * gnu/packages/guile-xyz.scm (guile-dns): New variable.
> ---
>  gnu/packages/guile-xyz.scm | 36 ++++++++++++++++++++++++++++++++++++
>  1 file changed, 36 insertions(+)

This looks to fail to build on i686-linux:

  https://qa.guix.gnu.org/issue/58465

Given this is a new package, ideally we'd either fix that, or change the
supported systems to match what builds.

Thanks,

Chris

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 987 bytes --]

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [bug#58465] [PATCH] gnu: Add guile-dns.
  2022-10-13 10:05 ` Christopher Baines
@ 2022-10-14 20:40   ` Arun Isaac
  2022-10-14 20:41     ` Arun Isaac
                       ` (3 more replies)
  0 siblings, 4 replies; 8+ messages in thread
From: Arun Isaac @ 2022-10-14 20:40 UTC (permalink / raw)
  To: Christopher Baines; +Cc: 58465


Hi Chris,

> This looks to fail to build on i686-linux:
>
>   https://qa.guix.gnu.org/issue/58465

Good catch, and love the new QA system! :-)

> Given this is a new package, ideally we'd either fix that, or change the
> supported systems to match what builds.

Disabling the coverage report fixes this. Is that a satisfactory
solution? A patch follows.

Thanks,
Arun




^ permalink raw reply	[flat|nested] 8+ messages in thread

* [bug#58465] [PATCH] gnu: Add guile-dns.
  2022-10-14 20:40   ` Arun Isaac
@ 2022-10-14 20:41     ` Arun Isaac
  2022-10-14 20:55     ` [bug#58465] [PATCH v3 0/1] " Arun Isaac
                       ` (2 subsequent siblings)
  3 siblings, 0 replies; 8+ messages in thread
From: Arun Isaac @ 2022-10-14 20:41 UTC (permalink / raw)
  To: Arun Isaac, Christopher Baines; +Cc: 58465

* gnu/packages/guile-xyz.scm (guile-dns): New variable.
---
 gnu/packages/guile-xyz.scm | 42 ++++++++++++++++++++++++++++++++++++++
 1 file changed, 42 insertions(+)

diff --git a/gnu/packages/guile-xyz.scm b/gnu/packages/guile-xyz.scm
index 379d9aa264..934762f631 100644
--- a/gnu/packages/guile-xyz.scm
+++ b/gnu/packages/guile-xyz.scm
@@ -4426,6 +4426,48 @@ (define-public guile-avahi
       (home-page "https://www.nongnu.org/guile-avahi/")
       (license license:lgpl3+))))
 
+(define-public guile-dns
+  (package
+    (name "guile-dns")
+    (version "0.1")
+    (source (origin
+              (method git-fetch)
+              (uri (git-reference
+                    (url "https://git.lysator.liu.se/hugo/guile-dns")
+                    (commit version)))
+              (file-name (git-file-name name version))
+              (sha256
+               (base32
+                "18skivracv6jh1zab9dknkcpbizc416n0pb2mcwb20dpzc2md9yf"))))
+    (build-system gnu-build-system)
+    (arguments
+     (list #:make-flags #~(list (string-append "PREFIX=" #$output)
+                                ;; Prevent guild warnings.
+                                "GUILE_AUTO_COMPILE=0"
+                                ;; Make tests verbose and disable coverage
+                                ;; report. The coverage report fails on
+                                ;; i686-linux.
+                                "TEST_FLAGS=--verbose")
+           #:phases
+           #~(modify-phases %standard-phases
+               (add-after 'unpack 'prefer-curdir
+                 (lambda _
+                   ;; CURDIR is a standard GNU Make variable. Prefer it to
+                   ;; PWD. PWD is set by the shell and is absent in the build
+                   ;; process.
+                   (substitute* "Makefile"
+                     (("PWD") "CURDIR"))))
+               (delete 'configure))))
+    (inputs
+     (list guile-3.0))
+    (native-inputs
+     (list texinfo))
+    (home-page "https://git.lysator.liu.se/hugo/guile-dns")
+    (synopsis "Guile DNS library")
+    (description "@code{guile-dns} is a DNS library written in pure Guile
+Scheme.")
+    (license license:gpl3+)))
+
 (define-public guile-jwt
   (package
     (name "guile-jwt")
-- 
2.37.3





^ permalink raw reply related	[flat|nested] 8+ messages in thread

* [bug#58465] [PATCH v3 0/1] Add guile-dns
  2022-10-14 20:40   ` Arun Isaac
  2022-10-14 20:41     ` Arun Isaac
@ 2022-10-14 20:55     ` Arun Isaac
  2022-10-14 20:55     ` [bug#58465] [PATCH v3 1/1] gnu: " Arun Isaac
  2022-10-15 20:30     ` [bug#58465] [PATCH] " Christopher Baines
  3 siblings, 0 replies; 8+ messages in thread
From: Arun Isaac @ 2022-10-14 20:55 UTC (permalink / raw)
  To: Arun Isaac, Christopher Baines; +Cc: 58465

I just found that the info file was installed into the wrong path. I have
fixed it in this v3 patch.

Arun Isaac (1):
  gnu: Add guile-dns.

 gnu/packages/guile-xyz.scm | 44 ++++++++++++++++++++++++++++++++++++++
 1 file changed, 44 insertions(+)

-- 
2.37.3





^ permalink raw reply	[flat|nested] 8+ messages in thread

* [bug#58465] [PATCH v3 1/1] gnu: Add guile-dns.
  2022-10-14 20:40   ` Arun Isaac
  2022-10-14 20:41     ` Arun Isaac
  2022-10-14 20:55     ` [bug#58465] [PATCH v3 0/1] " Arun Isaac
@ 2022-10-14 20:55     ` Arun Isaac
  2022-10-15 20:30     ` [bug#58465] [PATCH] " Christopher Baines
  3 siblings, 0 replies; 8+ messages in thread
From: Arun Isaac @ 2022-10-14 20:55 UTC (permalink / raw)
  To: Arun Isaac, Christopher Baines; +Cc: 58465

* gnu/packages/guile-xyz.scm (guile-dns): New variable.
---
 gnu/packages/guile-xyz.scm | 44 ++++++++++++++++++++++++++++++++++++++
 1 file changed, 44 insertions(+)

diff --git a/gnu/packages/guile-xyz.scm b/gnu/packages/guile-xyz.scm
index 379d9aa264..16ee197c2a 100644
--- a/gnu/packages/guile-xyz.scm
+++ b/gnu/packages/guile-xyz.scm
@@ -4426,6 +4426,50 @@ (define-public guile-avahi
       (home-page "https://www.nongnu.org/guile-avahi/")
       (license license:lgpl3+))))
 
+(define-public guile-dns
+  (package
+    (name "guile-dns")
+    (version "0.1")
+    (source (origin
+              (method git-fetch)
+              (uri (git-reference
+                    (url "https://git.lysator.liu.se/hugo/guile-dns")
+                    (commit version)))
+              (file-name (git-file-name name version))
+              (sha256
+               (base32
+                "18skivracv6jh1zab9dknkcpbizc416n0pb2mcwb20dpzc2md9yf"))))
+    (build-system gnu-build-system)
+    (arguments
+     (list #:make-flags #~(list (string-append "PREFIX=" #$output)
+                                ;; Prevent guild warnings.
+                                "GUILE_AUTO_COMPILE=0"
+                                ;; Make tests verbose and disable coverage
+                                ;; report. The coverage report fails on
+                                ;; i686-linux.
+                                "TEST_FLAGS=--verbose")
+           #:phases
+           #~(modify-phases %standard-phases
+               (add-after 'unpack 'fix-makefile
+                 (lambda _
+                   (substitute* "Makefile"
+                     ;; CURDIR is a standard GNU Make variable. Prefer it to
+                     ;; PWD. PWD is set by the shell and is absent in the
+                     ;; build process.
+                     (("PWD") "CURDIR")
+                     ;; Install info file at share/info, not at share.
+                     (("share doc") "share/info doc"))))
+               (delete 'configure))))
+    (inputs
+     (list guile-3.0))
+    (native-inputs
+     (list texinfo))
+    (home-page "https://git.lysator.liu.se/hugo/guile-dns")
+    (synopsis "Guile DNS library")
+    (description "@code{guile-dns} is a DNS library written in pure Guile
+Scheme.")
+    (license license:gpl3+)))
+
 (define-public guile-jwt
   (package
     (name "guile-jwt")
-- 
2.37.3





^ permalink raw reply related	[flat|nested] 8+ messages in thread

* [bug#58465] [PATCH] gnu: Add guile-dns.
  2022-10-14 20:40   ` Arun Isaac
                       ` (2 preceding siblings ...)
  2022-10-14 20:55     ` [bug#58465] [PATCH v3 1/1] gnu: " Arun Isaac
@ 2022-10-15 20:30     ` Christopher Baines
  2022-10-16  8:37       ` bug#58465: " Arun Isaac
  3 siblings, 1 reply; 8+ messages in thread
From: Christopher Baines @ 2022-10-15 20:30 UTC (permalink / raw)
  To: Arun Isaac; +Cc: 58465

[-- Attachment #1: Type: text/plain, Size: 466 bytes --]


Arun Isaac <arunisaac@systemreboot.net> writes:

>> This looks to fail to build on i686-linux:
>>
>>   https://qa.guix.gnu.org/issue/58465
>
> Good catch, and love the new QA system! :-)
>
>> Given this is a new package, ideally we'd either fix that, or change the
>> supported systems to match what builds.
>
> Disabling the coverage report fixes this. Is that a satisfactory
> solution? A patch follows.

Yeah, that sounds fine to me, please go ahead and push :)

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 987 bytes --]

^ permalink raw reply	[flat|nested] 8+ messages in thread

* bug#58465: [PATCH] gnu: Add guile-dns.
  2022-10-15 20:30     ` [bug#58465] [PATCH] " Christopher Baines
@ 2022-10-16  8:37       ` Arun Isaac
  0 siblings, 0 replies; 8+ messages in thread
From: Arun Isaac @ 2022-10-16  8:37 UTC (permalink / raw)
  To: Christopher Baines; +Cc: 58465-done


Pushed, thanks!




^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2022-10-16  8:38 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-10-12  9:48 [bug#58465] [PATCH] gnu: Add guile-dns Arun Isaac
2022-10-13 10:05 ` Christopher Baines
2022-10-14 20:40   ` Arun Isaac
2022-10-14 20:41     ` Arun Isaac
2022-10-14 20:55     ` [bug#58465] [PATCH v3 0/1] " Arun Isaac
2022-10-14 20:55     ` [bug#58465] [PATCH v3 1/1] gnu: " Arun Isaac
2022-10-15 20:30     ` [bug#58465] [PATCH] " Christopher Baines
2022-10-16  8:37       ` bug#58465: " Arun Isaac

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).