unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
* [bug#58461] [PATCH] gnu: emacs-eval-in-repl-erlang: Fix unbound variable.
@ 2022-10-12  2:20 Brian Kubisiak
  2022-10-14 21:52 ` Liliana Marie Prikler
  0 siblings, 1 reply; 3+ messages in thread
From: Brian Kubisiak @ 2022-10-12  2:20 UTC (permalink / raw)
  To: 58461

Commit 0b120ad5f88d32e0c716b1442fe1ea3c562b5586 introduced a circular
dependency where (gnu packages erlang) would transitively load (gnu
packages emacs-xyz) before the emacs-erlang package was defined. This
would result in "error: emacs-erlang: unbound variable" in the
definition of emacs-eval-in-repl-erlang when trying to use (gnu
packages erlang) from the repl.

This commit fixes the unbound variable by adding a delay to the inputs
in make-emacs-eval-in-repl.

* gnu/packages/emacs-xyz.scm (emacs-eval-in-repl-erlang): Add delay.
---
 gnu/packages/emacs-xyz.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 2ac29e8225..1b0f07731d 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -27911,7 +27911,7 @@ (define-public emacs-eval-in-repl-elm
   (make-emacs-eval-in-repl "elm" #:inputs (list emacs-elm-mode)))
 
 (define-public emacs-eval-in-repl-erlang
-  (make-emacs-eval-in-repl "erlang" #:inputs (list emacs-erlang)))
+  (make-emacs-eval-in-repl "erlang" #:inputs (delay (list emacs-erlang))))
 
 (define-public emacs-eval-in-repl-geiser
   (make-emacs-eval-in-repl "geiser" #:language "Scheme"
-- 
2.37.3






^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [bug#58461] [PATCH] gnu: emacs-eval-in-repl-erlang: Fix unbound variable.
  2022-10-12  2:20 [bug#58461] [PATCH] gnu: emacs-eval-in-repl-erlang: Fix unbound variable Brian Kubisiak
@ 2022-10-14 21:52 ` Liliana Marie Prikler
  2022-10-16 17:12   ` bug#58461: " Christopher Baines
  0 siblings, 1 reply; 3+ messages in thread
From: Liliana Marie Prikler @ 2022-10-14 21:52 UTC (permalink / raw)
  To: Brian Kubisiak, 58461

Am Dienstag, dem 11.10.2022 um 19:20 -0700 schrieb Brian Kubisiak:
> Commit 0b120ad5f88d32e0c716b1442fe1ea3c562b5586 introduced a circular
> dependency where (gnu packages erlang) would transitively load (gnu
> packages emacs-xyz) before the emacs-erlang package was defined. This
> would result in "error: emacs-erlang: unbound variable" in the
> definition of emacs-eval-in-repl-erlang when trying to use (gnu
> packages erlang) from the repl.
> 
> This commit fixes the unbound variable by adding a delay to the
> inputs in make-emacs-eval-in-repl.
Pushed with a slightly shorter commit message.

Cheers




^ permalink raw reply	[flat|nested] 3+ messages in thread

* bug#58461: [PATCH] gnu: emacs-eval-in-repl-erlang: Fix unbound variable.
  2022-10-14 21:52 ` Liliana Marie Prikler
@ 2022-10-16 17:12   ` Christopher Baines
  0 siblings, 0 replies; 3+ messages in thread
From: Christopher Baines @ 2022-10-16 17:12 UTC (permalink / raw)
  To: 58461-done

[-- Attachment #1: Type: text/plain, Size: 57 bytes --]


Marking as done as the patch has been pushed to master.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 987 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2022-10-16 17:15 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-10-12  2:20 [bug#58461] [PATCH] gnu: emacs-eval-in-repl-erlang: Fix unbound variable Brian Kubisiak
2022-10-14 21:52 ` Liliana Marie Prikler
2022-10-16 17:12   ` bug#58461: " Christopher Baines

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).