From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id 6NJpCAhZNGMUZgAAbAwnHQ (envelope-from ) for ; Wed, 28 Sep 2022 16:24:08 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id WDWiBwhZNGN8rAAAG6o9tA (envelope-from ) for ; Wed, 28 Sep 2022 16:24:08 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 9BF3B454F for ; Wed, 28 Sep 2022 16:24:07 +0200 (CEST) Received: from localhost ([::1]:48210 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1odXyo-0004qF-Q0 for larch@yhetil.org; Wed, 28 Sep 2022 10:24:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53368) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1odWDO-0004eP-Nf for guix-patches@gnu.org; Wed, 28 Sep 2022 08:31:09 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:33160) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1odWDO-0006jj-FS for guix-patches@gnu.org; Wed, 28 Sep 2022 08:31:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1odWDO-00026F-5Q for guix-patches@gnu.org; Wed, 28 Sep 2022 08:31:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#58072] [PATCH] gnu: Add python-textual. Resent-From: Brian Kubisiak Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 28 Sep 2022 12:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58072 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: =?UTF-8?Q?Bj=C3=B6rn_?= =?UTF-8?Q?H=C3=B6fling?= Cc: 58072@debbugs.gnu.org Received: via spool by 58072-submit@debbugs.gnu.org id=B58072.16643682217996 (code B ref 58072); Wed, 28 Sep 2022 12:31:02 +0000 Received: (at 58072) by debbugs.gnu.org; 28 Sep 2022 12:30:21 +0000 Received: from localhost ([127.0.0.1]:60466 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1odWCj-00024u-9v for submit@debbugs.gnu.org; Wed, 28 Sep 2022 08:30:21 -0400 Received: from [75.171.8.149] (port=1681 helo=mail.kubisiak.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1odWCe-00024W-Pe for 58072@debbugs.gnu.org; Wed, 28 Sep 2022 08:30:20 -0400 Received: from peregrine (108-237-41-25.lightspeed.sntcca.sbcglobal.net [108.237.41.25]) by mail.kubisiak.com with ESMTPSA (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256) ; Wed, 28 Sep 2022 07:30:01 -0500 Date: Wed, 28 Sep 2022 05:30:06 -0700 From: Brian Kubisiak Message-ID: <20220928123006.uy7tevbbft2f36cg@peregrine> References: <20220925125924.sifu3hzebvuoc6ay@peregrine> <20220927230930.37137e42@alma-ubu.fritz.box> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220927230930.37137e42@alma-ubu.fritz.box> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1664375047; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post; bh=uV7IyzR1zBW9jUC9RMkfmxM5hb3hvAEusn4y1OF+cD0=; b=fpOePWaR4acgfHISA1yx4KFuR/mekag0hQhqKdauqMf0JgrY0kvukRkc2fHcP37m8EQyAO nj7SfgcWyiNu7PqDiFaG96Ii3vidbgY9JcN9hZFzE8w9Mofzq6KK+7xnfvB7XeoNOo3abK qVyBSOdZJSljgz7hMPqgBTb88YbG81CySJ41ppgTYtuDZEb3oCNhD7Y7zlPlZyn227HVIy 7QkH6zvu+yMlYoQTlVk54UwisfqWKukqm6Pr9bRtoIH+C5SUKwHcv6iVSXoZ+OMeyxa7Ln aWoAkZQnBWEpTS1vGaMRbLyL7M/EG3kyANzX81Dgbj3CAE5GDfhbt0VzLi4yjA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1664375047; a=rsa-sha256; cv=none; b=Q2f2tAfkldWJABCN2menNoN2LmKeLHH1LDyF/g4X/XNcH3YO34IDKMN5/gKokTpjTDaQh5 W3vPiMF3UpmZqa3BALW1jHJ93L3biZ75hAAGx01r02Bs3daH1lm9WsWALGZzl3+fLAcnqK hOOujtl/n5J01wu4rdr91U2Bsgn/kvZZEi1SBbFu0261sNdJFESIJZ77BP3u88hW79jvB3 NdTLyf1NHCBk2GWeYBJBajsFNW94ZUVD/X0fu+18dWrfFbVh/PIRFiFK+mmsd2SgayguAD rcLdGGgeNbaekRj0ZQcDv7XnGWmdDeTSX/NkgYB813v69yje+qlUzItjefKALA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -2.35 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 9BF3B454F X-Spam-Score: -2.35 X-Migadu-Scanner: scn1.migadu.com X-TUID: iMcH+/QLxEUu > You download the sources twice: Once from pypi, and another time from > GitHub as "test" input. I would suggest you use directly the GitHub > sources as main sources. Then you also don't need the modified 'check > phase. The GitHub sources are built with poetry and do not have setup.py or setup.cfg; in order to use the existing python-build-system, the package must be built from the PyPi sources. The other option would be to disable the tests completely instead of downloading them from GitHub, but I think keeping the tests is a better option. > As an example, I found python-identify, which also comments on the > sources that there are no tests in PyPi The patch I wrote is based on python-rich (which is a similar package by the same author). > (please add that comment too, it makes it clear why not to use > PyPi). I've already got that comment here: > + ;; The release on pypi comes without tests. We can't build from this > + ;; checkout, though, because installation requires an invocation of > + ;; poetry. Thanks, Brian