unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Brian Kubisiak <brian@kubisiak.com>
To: "Björn Höfling" <bjoern.hoefling@bjoernhoefling.de>
Cc: 58072@debbugs.gnu.org
Subject: [bug#58072] [PATCH] gnu: Add python-textual.
Date: Wed, 28 Sep 2022 05:30:06 -0700	[thread overview]
Message-ID: <20220928123006.uy7tevbbft2f36cg@peregrine> (raw)
In-Reply-To: <20220927230930.37137e42@alma-ubu.fritz.box>

> You download the sources twice: Once from pypi, and another time from
> GitHub as "test" input. I would suggest you use directly the GitHub
> sources as main sources. Then you also don't need the modified 'check
> phase.

The GitHub sources are built with poetry and do not have setup.py or
setup.cfg; in order to use the existing python-build-system, the
package must be built from the PyPi sources. The other option would be
to disable the tests completely instead of downloading them from
GitHub, but I think keeping the tests is a better option.

> As an example, I found python-identify, which also comments on the
> sources that there are no tests in PyPi

The patch I wrote is based on python-rich (which is a similar package
by the same author).

> (please add that comment too, it makes it clear why not to use
> PyPi).

I've already got that comment here:

> +        ;; The release on pypi comes without tests.  We can't build from this
> +        ;; checkout, though, because installation requires an invocation of
> +        ;; poetry.

Thanks,
Brian





  reply	other threads:[~2022-09-28 14:24 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-25 12:59 [bug#58072] [PATCH] gnu: Add python-textual Brian Kubisiak
2022-09-27 21:09 ` Björn Höfling
2022-09-28 12:30   ` Brian Kubisiak [this message]
2022-10-06 20:42 ` bug#58072: " Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220928123006.uy7tevbbft2f36cg@peregrine \
    --to=brian@kubisiak.com \
    --cc=58072@debbugs.gnu.org \
    --cc=bjoern.hoefling@bjoernhoefling.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).