From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id wB9dDp3PM2PWEQEAbAwnHQ (envelope-from ) for ; Wed, 28 Sep 2022 06:37:49 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id 0KmRDZ3PM2OCHAEAG6o9tA (envelope-from ) for ; Wed, 28 Sep 2022 06:37:49 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id AF4153C285 for ; Wed, 28 Sep 2022 06:37:48 +0200 (CEST) Received: from localhost ([::1]:57830 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1odOpP-0002BU-T0 for larch@yhetil.org; Wed, 28 Sep 2022 00:37:47 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43266) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1odOml-00087k-Mr for guix-patches@gnu.org; Wed, 28 Sep 2022 00:35:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:59191) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1odOml-0000oA-Cb for guix-patches@gnu.org; Wed, 28 Sep 2022 00:35:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1odOmk-0004VR-78 for guix-patches@gnu.org; Wed, 28 Sep 2022 00:35:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#57927] [PATCH] gnu: source-highlight: Fix lesspipe file name and use gexps. Resent-From: kiasoc5 Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 28 Sep 2022 04:35:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57927 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Tobias Geerinckx-Rice Cc: 57927@debbugs.gnu.org Received: via spool by 57927-submit@debbugs.gnu.org id=B57927.166433966017266 (code B ref 57927); Wed, 28 Sep 2022 04:35:02 +0000 Received: (at 57927) by debbugs.gnu.org; 28 Sep 2022 04:34:20 +0000 Received: from localhost ([127.0.0.1]:58269 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1odOm3-0004UQ-J6 for submit@debbugs.gnu.org; Wed, 28 Sep 2022 00:34:19 -0400 Received: from knopi.disroot.org ([178.21.23.139]:47428) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1odOly-0004U4-LR for 57927@debbugs.gnu.org; Wed, 28 Sep 2022 00:34:16 -0400 Received: from localhost (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id 0B0044C37C; Wed, 28 Sep 2022 06:34:13 +0200 (CEST) X-Virus-Scanned: SPAM Filter at disroot.org Received: from knopi.disroot.org ([127.0.0.1]) by localhost (disroot.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id VQK4Fh3wle4y; Wed, 28 Sep 2022 06:34:11 +0200 (CEST) Date: Wed, 28 Sep 2022 04:34:07 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1664339651; bh=Rb6Zv9pLR4Sr1kETxGdYjV5zJdpzyocFhxmzOjkEnZM=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=EHC+1QOoYugrBHz9v+5ke1HDDiHFPSjf7Qh5Roupd3QlcdzGS+vlTYB72oywh/B8M XEGX9FS8Xbj41nxabmP4uxCKytgRBrnGAicwavngNma5QqEV2HQx2Ts7GCYyJ7Vkd7 IsnKpMpOonT9N1ABTt5+l5LIXmEzogED1j4ZdmK3nIHFbPzVzYdl5tt34mgw+gGcIK C0Lv+pcsqvA8P5PJlwrx3LcCbE/rG4hMAER1ylg4hVVu7a21opMrUuf3RgGDCsH7SL 1sw2akzDUO3Q9Rlw96VyfRXsDmOjQo33VJAjjpxLwfKjTCEnCr3k5Z+jMROwXK099Y 9IQYZh0vZOvEw== Message-ID: <20220928043407.181d9060@aria> In-Reply-To: <87bkr1ey8x.fsf@nckx> References: <29d55f693128126558e2e3e0a030194453312187.1663570649.git.kiasoc5@disroot.org> <87bkr1ey8x.fsf@nckx> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" Reply-to: kiasoc5 X-ACL-Warn: , kiasoc5 via Guix-patches From: kiasoc5 via Guix-patches via X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1664339869; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=zkj4vicOlSxnpQ52udpnHj0X66AGn5Hee6PcUsoVWus=; b=RzbQVj4rHvo8hhp+xQNSY/Q4McNZ5zyGMtQPoLnLdbbbxjcSPrPWUB77cDbDAr+sku3lwE wXp6D9MJyJanPJEZhF7LWt0ck8CbRbaWlylwN1n+ZHDW9MjAyzNAlydMkU3NJ8KtrMbdoh SIr4bO7QMN7IjRXrLnSwhr2BvNf13+488cgN+rD6xliKOqEoYOprSKUtWwuUb4EodZk/du M4xNH2kWStsLnJURKNvnUyAv+vYUJ0dCLxK6y1z3+wRncR1FCUbdABAYropNYT7rp7vVkq O3tskgp7VCqeiJWD7ExhLekf7aBs2WxZ7rt61UIdXW6Uve8AJ7JBbQt9GrWKNA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1664339869; a=rsa-sha256; cv=none; b=Tw9w85LHjRfikG8cxw5zAOpMkzq+EQed/3q+YZi6Ih5/QD2UsadrWKKB6X+NB8HNckqiQI 0rVFRDdxVeb0yL8a4BR+vrZuOEnhXWGmD5Kae2y9w1viWi3fOGNfo45voW1mDhsJkHWfkp w/rkxjZ1cNEy5VGI852nRxpWx1OJFiPCWBunXB3rX7EJLIZ4qCtljuZR7KdmEdqCHIz4Gn lADKamRuXP5R7WwrZEpY6Q9iN9oOjkHA7aNOCXlkvtsqCHTO9K5gCSonAgYMT/3Bgp37GB pxkcNEKK34S+5RdtveUPScZDquSnPRYNQaxWX+ee5UwoaPJykAVr2jLmkE9ckA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=disroot.org header.s=mail header.b=EHC+1QOo; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -3.15 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=disroot.org header.s=mail header.b=EHC+1QOo; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: AF4153C285 X-Spam-Score: -3.15 X-Migadu-Scanner: scn0.migadu.com X-TUID: FmhGoIWuUWap Hi Tobias, On Tue, Sep 27 2022, 03:22:19 PM +0200 Tobias Geerinckx-Rice wrote: > Hi kiasoc5, >=20 > kiasoc5 via Guix-patches via =E5=86=99=E9=81=93=EF=BC=9A > > This fixes src-hilite-lesspipe.sh so that lesspipe.sh is called=20 > > instead of lesspipe. >=20 > When you notice a rebuild count higher than the thresholds given=20 > here[0], please add a =E2=80=98[PATCH core-updates]=E2=80=99 or =E2=80=98= [PATCH staging]=E2=80=99=20 > warning to your patch subject. It reduces the chance of these=20 > slipping through. I didn't realize source-highlight was used by so many projects, I'll be more careful next time. Just so I understand the rebuilds are occuring because the store path of source-highlight changed, and the result could not be grafted? > > * gnu/packages/pretty-print.scm (source-highlight): > > [arguments]: Use gexps, remove trailing #ts. > > [phases]: Add phase to make src-highlight-lesspipe.sh work. >=20 > These unrelated changes should be separated into at least two=20 > patches next time: one to gexp and remove the #ts, the other to=20 > make the functional change. > < to go=20 > straight to master. 1. Does trailing #t change the hash? 2. Why might Gexpification change the hash?