From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id 4Na6BrFmM2OPJAAAbAwnHQ (envelope-from ) for ; Tue, 27 Sep 2022 23:10:09 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id qPKpBrFmM2ONigAAauVa8A (envelope-from ) for ; Tue, 27 Sep 2022 23:10:09 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id D555C320F2 for ; Tue, 27 Sep 2022 23:10:08 +0200 (CEST) Received: from localhost ([::1]:46756 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1odHqB-0000Do-Lq for larch@yhetil.org; Tue, 27 Sep 2022 17:10:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39446) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1odHq6-0000D6-KT for guix-patches@gnu.org; Tue, 27 Sep 2022 17:10:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:57844) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1odHq6-0002u4-Be for guix-patches@gnu.org; Tue, 27 Sep 2022 17:10:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1odHq6-0007E3-0e for guix-patches@gnu.org; Tue, 27 Sep 2022 17:10:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#58072] [PATCH] gnu: Add python-textual. Resent-From: =?UTF-8?Q?Bj=C3=B6rn_?= =?UTF-8?Q?H=C3=B6fling?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 27 Sep 2022 21:10:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58072 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Brian Kubisiak Cc: 58072@debbugs.gnu.org Received: via spool by 58072-submit@debbugs.gnu.org id=B58072.166431297927743 (code B ref 58072); Tue, 27 Sep 2022 21:10:01 +0000 Received: (at 58072) by debbugs.gnu.org; 27 Sep 2022 21:09:39 +0000 Received: from localhost ([127.0.0.1]:56922 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1odHpj-0007DN-2X for submit@debbugs.gnu.org; Tue, 27 Sep 2022 17:09:39 -0400 Received: from m4s11.vlinux.de ([83.151.27.109]:45230 helo=bjoernhoefling.de) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1odHpd-0007DB-87 for 58072@debbugs.gnu.org; Tue, 27 Sep 2022 17:09:36 -0400 Received: from alma-ubu.fritz.box (pd951fa38.dip0.t-ipconnect.de [217.81.250.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by bjoernhoefling.de (Postfix) with ESMTPSA id 5D0FF3F9A5; Tue, 27 Sep 2022 23:09:31 +0200 (CEST) Date: Tue, 27 Sep 2022 23:09:30 +0200 From: =?UTF-8?Q?Bj=C3=B6rn_?= =?UTF-8?Q?H=C3=B6fling?= Message-ID: <20220927230930.37137e42@alma-ubu.fritz.box> In-Reply-To: <20220925125924.sifu3hzebvuoc6ay@peregrine> References: <20220925125924.sifu3hzebvuoc6ay@peregrine> X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/rLkC.F4lC8kXafx74suFf2w"; protocol="application/pgp-signature"; micalg=pgp-sha512 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1664313008; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post; bh=ttrIPNfNXBEvC5tRLS5XF76QP0hUhfi0W2dNYUlmS6c=; b=h/nBDkZ2peo+VReuV5/NtYbQxsakq17BVP93tB6Tjn5cmwcIw5Yf2xXxKSFMZFjAV6bja1 fxbyROLrL88h+cS8IlHJRBkVXo2QKSPK+c8kZjrhuLma0NEpGy9l7obSLv2Kfie9tqR+d8 3JnbE/KmyixFfxhlhrPbz0zJlfPSNsYlx/QirPPn+HDTiSYmOCb+x484JnwNJrbWyyx32N Jumz7Z2gaLHW6k5m4l4gmqL2XjfdOXVyPYGPZdXBXkRitFuQUB8GyMGnlPV7J3C9lxvmd9 w/MMe4/HAdkxZMAM7US3xiym6TuR3NzXxzmXXou1byxx1y5mljNCM374+MLe9w== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1664313008; a=rsa-sha256; cv=none; b=LBb3SOcR/JwCbN2U88w2COMjtCfNre9XUxKYPMyMDpWj3F167+ZuV5Kwoc7oFFQZcI4hfr lqXvrM+hVi5tnJ+eYF7PCSppVj+IhIMtR9P7yChWE290i/s8oHDqvtPmlavmdYCxXdUhOK 5lal/atFxDvYLFpK46kc6jN4l0Arrd4UyJDpyoI2KRNbc8gu7SpuwmFUMaPYPGMVTyWS1G D23iGhRfn3EkisbS+1zHzPSha7j/JBmHQPrzEdT+JvpLY7mBIw4dzgsbUIhBVIznouNz2d uoCFaXVPBR87zW6oR5yxybC+wh5v5saFWkm3G/9pzXOlumzfCIG8336a7jLF8Q== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -3.44 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: D555C320F2 X-Spam-Score: -3.44 X-Migadu-Scanner: scn1.migadu.com X-TUID: QpzhZtzeOs9V --Sig_/rLkC.F4lC8kXafx74suFf2w Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Hi Brian, On Sun, 25 Sep 2022 05:59:24 -0700 Brian Kubisiak wrote: > * gnu/packages/python-xyz.scm (python-textual): New variable. > --- > gnu/packages/python-xyz.scm | 44 [..] > + (source (origin > + (method url-fetch) > + (uri (pypi-uri "textual" version)) > + (sha256 > + (base32 > + > "08yg5a51hz1axfj5hx28hx31gq5apcj6vpkkmawmiplisa73z25j")))) > + (build-system python-build-system) > + (arguments > + (list #:phases > + #~(modify-phases %standard-phases > + (replace 'check > + (lambda* (#:key inputs tests? #:allow-other-keys) > + (when tests? > + (copy-recursively (string-append > + (assoc-ref inputs "tests") > "/tests") > + "tests") > + (invoke "python" "-m" "pytest" "-vv"))))))) > + (propagated-inputs > + (list python-rich python-typing-extensions)) > + (native-inputs > + `(("python-pytest" ,python-pytest) > + ("tests" > + ;; The release on pypi comes without tests. We can't build > from this > + ;; checkout, though, because installation requires an > invocation of > + ;; poetry. > + ,(origin > + (method git-fetch) > + (uri (git-reference > + (url "https://github.com/Textualize/textual") > + (commit (string-append "v" version)))) > + (file-name (git-file-name name version)) > + (sha256 > + (base32 > + > "0b3ycwqhp21mg9fvmadgxhgbvkwq6fd784l2xcmvy77rravrnnax")))))) You download the sources twice: Once from pypi, and another time from GitHub as "test" input. I would suggest you use directly the GitHub sources as main sources. Then you also don't need the modified 'check phase.=20 As an example, I found python-identify, which also comments on the sources that there are no tests in PyPi (please add that comment too, it makes it clear why not to use PyPi). Would you like to send an updated patch? Thanks, Bj=C3=B6rn --Sig_/rLkC.F4lC8kXafx74suFf2w Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iF0EAREKAB0WIQQiGUP0np8nb5SZM4K/KGy2WT5f/QUCYzNmigAKCRC/KGy2WT5f /SM7AKCdRRK5+nLy143Waklae+PARTq6wQCeLDwNjR+vZIInKZ2QJz3ANkkqjD8= =XZRO -----END PGP SIGNATURE----- --Sig_/rLkC.F4lC8kXafx74suFf2w--