From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id SFAaBw9PL2NhGgAAbAwnHQ (envelope-from ) for ; Sat, 24 Sep 2022 20:40:15 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id 6FkbBw9PL2PnGgAA9RJhRA (envelope-from ) for ; Sat, 24 Sep 2022 20:40:15 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 93F9F18C38 for ; Sat, 24 Sep 2022 20:40:14 +0200 (CEST) Received: from localhost ([::1]:53374 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ocA4T-00082a-B7 for larch@yhetil.org; Sat, 24 Sep 2022 14:40:13 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50348) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ocA4I-00082R-RI for guix-patches@gnu.org; Sat, 24 Sep 2022 14:40:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:46191) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ocA4I-0004E7-CL for guix-patches@gnu.org; Sat, 24 Sep 2022 14:40:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ocA4I-0002rE-1Y for guix-patches@gnu.org; Sat, 24 Sep 2022 14:40:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#57540] [PATCH] Add ocaml-elpi (a dependency of coq-mathcomp-analysis) Resent-From: Julien Lepiller Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 24 Sep 2022 18:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57540 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: Garek Dyszel , 57540@debbugs.gnu.org Received: via spool by 57540-submit@debbugs.gnu.org id=B57540.166404475510921 (code B ref 57540); Sat, 24 Sep 2022 18:40:02 +0000 Received: (at 57540) by debbugs.gnu.org; 24 Sep 2022 18:39:15 +0000 Received: from localhost ([127.0.0.1]:45268 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ocA3W-0002q5-HD for submit@debbugs.gnu.org; Sat, 24 Sep 2022 14:39:14 -0400 Received: from lepiller.eu ([89.234.186.109]:55454) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ocA3T-0002pv-NL for 57540@debbugs.gnu.org; Sat, 24 Sep 2022 14:39:12 -0400 Received: from lepiller.eu (localhost [127.0.0.1]) by lepiller.eu (OpenSMTPD) with ESMTP id f72eb7e4; Sat, 24 Sep 2022 18:39:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=lepiller.eu; h=date:from :to:cc:subject:message-id:in-reply-to:references:mime-version :content-type:content-transfer-encoding; s=dkim; bh=u2UjKl/GfSTq 6/H05w2crTF1tqxoexDgagL2mPpkiJg=; b=OvA4gBTbYWrF3XeMhclW8jPVvQ9v Rl3NsBI5I/0FhZBR6UYqlXWiBB3ySGp5qLoEEHOAhFFNFKu4kFbN9W+vOYlX2B3A FRSBbmRsJ1074CUr4EHXLWsnMxgz1TvHvaSl2yCIhRS9A8Kr4Hw4PuDgf92E+1nh 0ElAPJO+tlYhcEZhe+sHqgCCLce+TBb1aHnEZiTUj0iQanJOtdyclzoSbOQtNLbI wWmemNAcuE7vpSVNWBVRXV2NNyT7FJE2PpVcWLhWFpd043MknwAC8NX5SyVOcNvp 3J9iv//DZwge2oCmuDTiddrjbm7shQoGZPs2Da1zpYkD2W6eSe/sfCUdWA== Received: by lepiller.eu (OpenSMTPD) with ESMTPSA id 12c6f744 (TLSv1.3:AEAD-AES256-GCM-SHA384:256:NO); Sat, 24 Sep 2022 18:39:09 +0000 (UTC) Date: Sat, 24 Sep 2022 20:39:07 +0200 From: Julien Lepiller Message-ID: <20220924203907.5ad1e922@sybil.lepiller.eu> In-Reply-To: <87tu4wapo1.fsf_-_@gnu.org> References: <79d544f7d8ba64b631a6f0f1d2ef0b08@disroot.org> <20220903204035.22e3b372@sybil.lepiller.eu> <87tu4wapo1.fsf_-_@gnu.org> X-Mailer: Claws Mail 4.1.0 (GTK 3.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1664044814; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=BwiWVuWb8q5Zdb3zG2sfePp/2I1ckGEBfnW/oz8qjQY=; b=sz1OD4d0XKDAUVYfmJG4BdwINv1b+58A1zMytim4WlXGZZTuBqaiekXo8XvSIqwu2NT+z3 4/FYy/eBTut2ZlSSVfQ0Kf2SKXbHhcwLWzH2QMCSUS9TLdh7CoOGCMlNdjGICQwUdoywON pHobG+cK9ZrbqvROZyRzX3fdRN2zd8INwUbdiR78kW16BWtKMFK+Hwjmtfv3H4eW0oFPvc k6j6i2sQxNqYRgS/oybuVUtk0VMsDIeMcRK4/PfaM3QLdy/BLiWVmjaXIGmrj6cVVWVDP0 u2q4QNTzKYV2snVD4+yaOuym6NEZ5/Z/XXNO4ZTUHNa6optEO8jIssUvVjCFHg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1664044814; a=rsa-sha256; cv=none; b=nrO1XYXTqasM9uCRf3oGRtUdLoIMi8OgDcx9JwM0ypj0Qam7Ih5wFwHM6Kgo6iCdqrZem9 E1hieGATMQ3fHszCjaKGH+J0rjx892DXSM7XPqke4xTWH/AiOCJZCEmsWE5Zl0YzL9k7M8 kczfkWJb1h/wBGixJdu25406aAwlmuD3c3Y+RmAYbupjloPc/X+EgE9r2xzTKpBAM/GV4X xNHAwyWjCefOXOuMuxyOWOPm3Tri8Kabh3A9dsHSD5fv2hvhAAmLT0Fkx9boE6Pva3TInu WpD0WUeWcbrU4G14x56fOmjMCUPWMCShb/BT49KInmgjAkIkHj6snCNqOG91bg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=lepiller.eu header.s=dkim header.b=OvA4gBTb; dmarc=fail reason="SPF not aligned (relaxed)" header.from=lepiller.eu (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 7.64 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=lepiller.eu header.s=dkim header.b=OvA4gBTb; dmarc=fail reason="SPF not aligned (relaxed)" header.from=lepiller.eu (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 93F9F18C38 X-Spam-Score: 7.64 X-Migadu-Scanner: scn1.migadu.com X-TUID: i/MQdO4Hda3W Le Sat, 24 Sep 2022 15:05:18 +0200, Ludovic Court=C3=A8s a =C3=A9crit : > Hi Julien, >=20 > Julien Lepiller skribis: >=20 > > thanks for the patches! As I understand it, these patches introduce > > 8 new packages, but I count only 7 (with this one which didn't make > > it as a part of the series). Could you split the last patch, so > > each new package has its own patch? =20 >=20 > Could you take a look at v2 of this patch series? >=20 > https://issues.guix.gnu.org/57540 >=20 > TIA! >=20 > Ludo=E2=80=99. Haha! This went under my radar. I pushed a part of this series on master as 8371ad64083970f68c8e1dd5f04b1f10d9cf029d to d46e955d93692f3c4b5387aaf709a2e5e43b57b4. These were: ocaml-ansiterminal, coq-mathcomp-{finmap,bigenough}, python-version, python-editables and python-icdiff. I made a few changes esp. to extend descriptions, remove a few comments that were unneeded. I also removed the recursive? flag for mathcomp packages since it was not needed. This already took quite a bit of time because patches were malformed (not your fault, but somehow the subject line was always incorrect) and in a seemingly random order. Also, they almost all have conflicts with current master. I'm a bit too tired to figure out the rest. Could you rebase the remaining patches on top of master? Please make sure that when applying a patch, it is possible to build the package without applying more patches. So, make sure dependencies are added before dependents. If you lack inspiration, the README is often a good place to use. A few notes on the patches: The description is often a single line, a copy of the synopsis, or missing a final point. In the description of ocaml-elpi, it says (last line): "ELPI is free software released under the terms of LGPL 2.1 or above.". No need to repeat the license here. Also, this means that the license should be lgpl2.1+, instead of plain lgpl2.1. For python packages, I see you add python to the inputs. Why is that? The python-build-system already provides python. python-hatchling should go in python-build instead of xyz. For jsonschema, please don't change the name of the package. It looks like python-jsonschema-next (4.5.1) does not have any dependent, so updating this package instead might be better than adding a new one, wdyt? Thanks!