From: Julien Lepiller <julien@lepiller.eu>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: Garek Dyszel <garekdyszel@disroot.org>, 57540@debbugs.gnu.org
Subject: [bug#57540] [PATCH] Add ocaml-elpi (a dependency of coq-mathcomp-analysis)
Date: Sat, 24 Sep 2022 20:39:07 +0200 [thread overview]
Message-ID: <20220924203907.5ad1e922@sybil.lepiller.eu> (raw)
In-Reply-To: <87tu4wapo1.fsf_-_@gnu.org>
Le Sat, 24 Sep 2022 15:05:18 +0200,
Ludovic Courtès <ludo@gnu.org> a écrit :
> Hi Julien,
>
> Julien Lepiller <julien@lepiller.eu> skribis:
>
> > thanks for the patches! As I understand it, these patches introduce
> > 8 new packages, but I count only 7 (with this one which didn't make
> > it as a part of the series). Could you split the last patch, so
> > each new package has its own patch?
>
> Could you take a look at v2 of this patch series?
>
> https://issues.guix.gnu.org/57540
>
> TIA!
>
> Ludo’.
Haha! This went under my radar.
I pushed a part of this series on master as
8371ad64083970f68c8e1dd5f04b1f10d9cf029d to
d46e955d93692f3c4b5387aaf709a2e5e43b57b4.
These were: ocaml-ansiterminal, coq-mathcomp-{finmap,bigenough},
python-version, python-editables and python-icdiff.
I made a few changes esp. to extend descriptions, remove a few comments
that were unneeded. I also removed the recursive? flag for
mathcomp packages since it was not needed. This already took quite a bit
of time because patches were malformed (not your fault, but somehow the
subject line was always incorrect) and in a seemingly random order.
Also, they almost all have conflicts with current master.
I'm a bit too tired to figure out the rest. Could you rebase the
remaining patches on top of master? Please make sure that when applying
a patch, it is possible to build the package without applying more
patches. So, make sure dependencies are added before dependents. If you
lack inspiration, the README is often a good place to use.
A few notes on the patches:
The description is often a single line, a copy of the synopsis, or
missing a final point. In the description of ocaml-elpi, it says (last
line): "ELPI is free software released under the terms of LGPL 2.1 or
above.". No need to repeat the license here. Also, this means that the
license should be lgpl2.1+, instead of plain lgpl2.1.
For python packages, I see you add python to the inputs. Why is that?
The python-build-system already provides python.
python-hatchling should go in python-build instead of xyz.
For jsonschema, please don't change the name of the package. It looks
like python-jsonschema-next (4.5.1) does not have any dependent, so
updating this package instead might be better than adding a new one,
wdyt?
Thanks!
next prev parent reply other threads:[~2022-09-24 18:40 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-02 1:44 [bug#57540] [PATCH] Add ocaml-elpi (a dependency of coq-mathcomp-analysis) Garek Dyszel via Guix-patches via
2022-09-02 15:20 ` [bug#57540] [PATCH 1/6] gnu: Add ocaml-atd Garek Dyszel via Guix-patches via
2022-09-02 15:22 ` [bug#57540] [PATCH 2/6] gnu: Add ocaml-ansiterminal Garek Dyszel via Guix-patches via
2022-09-02 15:23 ` [bug#57540] [PATCH 3/6] gnu: Add coq-elpi Garek Dyszel via Guix-patches via
2022-09-02 15:24 ` [bug#57540] [PATCH 4/6] gnu: Add coq-mathcomp-hierarchy-builder Garek Dyszel via Guix-patches via
2022-09-02 15:24 ` [bug#57540] [PATCH 5/6] gnu: Add coq-mathcomp-finmap Garek Dyszel via Guix-patches via
2022-09-02 15:25 ` [bug#57540] [PATCH 6/6] gnu: Add coq-mathcomp-bigenough and coq-mathcomp-analysis Garek Dyszel via Guix-patches via
2022-09-03 18:40 ` [bug#57540] [PATCH] Add ocaml-elpi (a dependency of coq-mathcomp-analysis) Julien Lepiller
2022-09-24 13:05 ` Ludovic Courtès
2022-09-24 18:39 ` Julien Lepiller [this message]
2022-09-07 18:31 ` [bug#57540] [RFC PATCH v2 01/19] gnu: Add ocaml-elpi Garek Dyszel via Guix-patches via
2022-09-26 16:52 ` [bug#57540] [PATCH] Please rebase (was: Add ocaml-elpi (a dependency of coq-mathcomp-analysis)) zimoun
2022-09-27 13:04 ` Garek Dyszel via Guix-patches via
2022-09-29 17:13 ` Garek Dyszel via Guix-patches via
2022-09-29 17:39 ` Julien Lepiller
2022-09-30 15:02 ` bug#57540: Splitting into several packages instead Garek Dyszel via Guix-patches via
2022-09-30 15:02 ` [bug#57540] [PATCH] Please rebase (was: Add ocaml-elpi (a dependency of coq-mathcomp-analysis)) Garek Dyszel via Guix-patches via
2022-09-30 12:06 ` zimoun
2022-10-02 20:52 ` Garek Dyszel via Guix-patches via
2022-10-02 22:22 ` zimoun
2022-09-07 18:32 ` [bug#57540] [RFC PATCH v2 02/19] gnu: Add ocaml-atd.* gnu/packages/ocaml.scm (ocaml-atd): New variable Garek Dyszel via Guix-patches via
2022-09-07 18:33 ` [bug#57540] [RFC PATCH v2 03/19] gnu: Add ocaml-ansiterminal.* gnu/packages/ocaml.scm (ocaml-ansiterminal): " Garek Dyszel via Guix-patches via
2022-09-07 18:33 ` [bug#57540] [RFC PATCH v2 04/19] gnu: Add coq-elpi.* gnu/packages/coq.scm (coq-elpi): " Garek Dyszel via Guix-patches via
2022-09-07 18:33 ` [bug#57540] [RFC PATCH v2 05/19] gnu: Add coq-mathcomp-hierarchy-builder.* gnu/packages/coq.scm (coq-mathcomp-hierarchy-builder): " Garek Dyszel via Guix-patches via
2022-09-07 18:33 ` [bug#57540] [RFC PATCH v2 06/19] gnu: Add coq-mathcomp-finmap.* gnu/packages/coq.scm (coq-mathcomp-finmap): " Garek Dyszel via Guix-patches via
2022-09-07 18:33 ` [bug#57540] [RFC PATCH v2 07/19] gnu: Add coq-mathcomp-bigenough.* gnu/packages/coq.scm (coq-mathcomp-bigenough): " Garek Dyszel via Guix-patches via
2022-09-07 18:33 ` [bug#57540] [RFC PATCH v2 08/19] gnu: Add coq-mathcomp-analysis.* gnu/packages/coq.scm (coq-mathcomp-analysis): " Garek Dyszel via Guix-patches via
2022-09-07 18:33 ` [bug#57540] [RFC PATCH v2 09/19] gnu: Add python-version.* gnu/packages/python-xyz.scm (python-version): " Garek Dyszel via Guix-patches via
2022-09-07 18:34 ` [bug#57540] [RFC PATCH v2 10/19] gnu: Add python-hatchling.* gnu/packages/python-xyz.scm (python-hatchling): " Garek Dyszel via Guix-patches via
2022-09-07 18:34 ` [bug#57540] [RFC PATCH v2 11/19] gnu: Add python-hatch-vcs.* gnu/packages/python-xyz.scm (python-hatch-vcs): " Garek Dyszel via Guix-patches via
2022-09-07 18:34 ` [bug#57540] [RFC PATCH v2 12/19] gnu: Add python-hatch-fancy-pypi-readme.* gnu/packages/python-xyz.scm (python-hatch-fancy-pypi-readme): " Garek Dyszel via Guix-patches via
2022-09-07 18:34 ` [bug#57540] [RFC PATCH v2 13/19] gnu: Add python-pprintpp.* gnu/packages/python-xyz.scm (python-pprintpp): " Garek Dyszel via Guix-patches via
2022-09-07 18:34 ` [bug#57540] [RFC PATCH v2 14/19] gnu: Add python-icdiff.* gnu/packages/python-xyz.scm (python-icdiff): " Garek Dyszel via Guix-patches via
2022-09-07 18:34 ` [bug#57540] [RFC PATCH v2 15/19] gnu: Add python-pytest-icdiff.* gnu/packages/python-check.scm (python-pytest-icdiff): " Garek Dyszel via Guix-patches via
2022-09-07 18:34 ` [bug#57540] [RFC PATCH v2 16/19] gnu: Add python-editables.* gnu/packages/python-build.scm (python-editables): " Garek Dyszel via Guix-patches via
2022-09-07 18:34 ` [bug#57540] [RFC PATCH v2 17/19] gnu: Add python-pluggy-1.0.* gnu/packages/python-xyz.scm (python-pluggy-1.0): " Garek Dyszel via Guix-patches via
2022-09-07 18:34 ` [bug#57540] [RFC PATCH v2 18/19] gnu: Add python-setuptools-scm-7.* gnu/packages/python.xyz.scm (python-setuptools-scm-7): " Garek Dyszel via Guix-patches via
2022-09-07 18:34 ` [bug#57540] [RFC PATCH v2 19/19] gnu: Add python-jsonschema-4.15.* gnu/packages/python-xyz.scm (python-jsonschema-4.15): " Garek Dyszel via Guix-patches via
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220924203907.5ad1e922@sybil.lepiller.eu \
--to=julien@lepiller.eu \
--cc=57540@debbugs.gnu.org \
--cc=garekdyszel@disroot.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).