unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: "Björn Höfling" <bjoern.hoefling@bjoernhoefling.de>
To: Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org>
Cc: iyzsong@envs.net, 57253-done@debbugs.gnu.org
Subject: bug#57253: [PATCH 2/2] gnu: Add keychain.
Date: Thu, 22 Sep 2022 10:00:57 +0200	[thread overview]
Message-ID: <20220922100057.5d6c170a@alma-ubu.fritz.box> (raw)
In-Reply-To: <20220921235254.27a5b0a4@primary_laptop>

[-- Attachment #1: Type: text/plain, Size: 1509 bytes --]

On Wed, 21 Sep 2022 23:52:54 +0200
Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org> wrote:

> The reason might be related to the fact that I sent two unrelated
> patches in the same serie (I'm unsure how best to send unrelated
> patches).


OK. I reviewed it and pushed under

da3bbcc9916b08324e7b85f5b9c528b4696c39d4

with some slight changes:

diff --git a/gnu/packages/crypto.scm b/gnu/packages/crypto.scm
index 3553415ad5..074fa5bf31 100644
--- a/gnu/packages/crypto.scm
+++ b/gnu/packages/crypto.scm
@@ -47,7 +47,6 @@ (define-module (gnu packages crypto)
   #:use-module (gnu packages aidc)
   #:use-module (gnu packages attr)
   #:use-module (gnu packages autotools)
-  #:use-module (gnu packages bash)
   #:use-module (gnu packages boost)
   #:use-module (gnu packages check)
   #:use-module (gnu packages compression)
@@ -1716,9 +1715,9 @@ (define-public keychain
                (base32
                 "1bkjlg0a2bbdjhwp37ci1rwikvrl4s3xlbf2jq2z4azc96dr83mj"))))
     (build-system gnu-build-system)
-    (native-inputs (list bash))
+    (propagated-inputs (list procps))
     (arguments
-     `(#:tests? #f
+     `(#:tests? #f ; No test suite
        #:phases (modify-phases %standard-phases
                   (delete 'configure)
                   (replace 'install

* There is no need to use/import bash
* ps is required to find the agent, so I propagated procps
* Tests disabled because there are none. Commented about that fact.

Thanks,

Björn

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

  reply	other threads:[~2022-09-22  8:02 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-16 23:46 [bug#57253] [PATCH 1/2] gnu: greybird-gtk-theme: Build with librsvg-for-system Denis 'GNUtoo' Carikli
2022-08-17  0:03 ` [bug#57253] [PATCH 2/2] gnu: Add keychain Denis 'GNUtoo' Carikli
2022-09-21 16:14   ` Björn Höfling
2022-09-21 21:52     ` Denis 'GNUtoo' Carikli
2022-09-22  8:00       ` Björn Höfling [this message]
2022-08-17  5:38 ` [bug#57253] [PATCH 1/2] gnu: greybird-gtk-theme: Build with librsvg-for-system 宋文武 via Guix-patches via

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220922100057.5d6c170a@alma-ubu.fritz.box \
    --to=bjoern.hoefling@bjoernhoefling.de \
    --cc=57253-done@debbugs.gnu.org \
    --cc=GNUtoo@cyberdimension.org \
    --cc=iyzsong@envs.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).