From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id +H6uNPVxK2PHdAAAbAwnHQ (envelope-from ) for ; Wed, 21 Sep 2022 22:20:05 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id 6IGnNPVxK2PUcgEA9RJhRA (envelope-from ) for ; Wed, 21 Sep 2022 22:20:05 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 740818776 for ; Wed, 21 Sep 2022 22:20:05 +0200 (CEST) Received: from localhost ([::1]:56108 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ob6CR-0005HX-9m for larch@yhetil.org; Wed, 21 Sep 2022 16:20:03 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46202) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ob6BS-0005Fl-DB for guix-patches@gnu.org; Wed, 21 Sep 2022 16:19:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:36247) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ob6BS-0006NQ-5G for guix-patches@gnu.org; Wed, 21 Sep 2022 16:19:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ob6BR-0003yJ-LE for guix-patches@gnu.org; Wed, 21 Sep 2022 16:19:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#55751] [PATCH 1/8] gnu: openjdk9: Make build reproducible. Resent-From: Danny Milosavljevic Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 21 Sep 2022 20:19:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55751 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxime Devos Cc: 55751@debbugs.gnu.org Received: via spool by 55751-submit@debbugs.gnu.org id=B55751.166379152115243 (code B ref 55751); Wed, 21 Sep 2022 20:19:01 +0000 Received: (at 55751) by debbugs.gnu.org; 21 Sep 2022 20:18:41 +0000 Received: from localhost ([127.0.0.1]:35325 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ob6B7-0003xm-Fq for submit@debbugs.gnu.org; Wed, 21 Sep 2022 16:18:41 -0400 Received: from dd30410.kasserver.com ([85.13.145.193]:47752) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ob6B5-0003xc-Cc for 55751@debbugs.gnu.org; Wed, 21 Sep 2022 16:18:39 -0400 Received: from localhost (84-115-234-55.cable.dynamic.surfer.at [84.115.234.55]) by dd30410.kasserver.com (Postfix) with ESMTPSA id B438211200AE; Wed, 21 Sep 2022 22:18:36 +0200 (CEST) Date: Wed, 21 Sep 2022 22:18:10 +0200 From: Danny Milosavljevic Message-ID: <20220921221810.4b4021b7@scratchpost.org> In-Reply-To: References: <20220601125741.9898-1-dannym@scratchpost.org> <20220601130011.9910-2-dannym@scratchpost.org> X-Mailer: Claws Mail 4.1.0 (GTK 3.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/VuJZcXnjGOAJj83VTFAf=Ud"; protocol="application/pgp-signature"; micalg=pgp-sha512 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1663791605; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post; bh=/9A4IqYR4ZvqYzhYv3CR0apZJgBHSKxGeShF2PfX7+A=; b=L9PJ9Cc9k1YstRIWY5g2AD2qoc629KBNaYuageONU5dH7/3Ly29RzjsH3Q4eNKKdNyTjAa LvSsnFqxDlYdR/kmPiPTVvH0ZVUibo8dtZMy4dXVVokklb/65u7uXzxPWDWlzyJlV8cSWz T66yyT2DH03yMNLIUplr1qS/Xdhizv7c4eHY2U3mCOz4KqkJDNpKK/CeXgbflAQZRXUZ2g vY331RJdt2GuZBl9CC34Hd1QXRdnu2JpXd92hB4J91qYAPHEU59Dxx6fTpsaAg2qfwknti xzX4ZaUnCLq8jjIQ4w1B1QTU5Z3uMhnz360W98WQr/0Pax8tokpAWZN+5ZXU5g== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1663791605; a=rsa-sha256; cv=none; b=BQOFEdNl1uP0J3PVXKYpN3cA1C2kRB3FrOyU0al7BDJVwagwlV0j/ELfB9/2j3RQc3eafK 7jFPz/pyVYrKnXCK9bh8/+QbgNV0ZITPVDGx/twgmsWhj3HmWjTVH+ZxuQJZH20oc/Sxpv MN+4cCF8pxiRy6UBEMZpVPv+WcTBumMZhI0UtehmUMuWqc68D8ZYUIsnAbCpdqxE67X0Xo OS/mijxBQxCjeK10MqrzdeqZBXR57w+EubC1tpPmj3j1HNwH0qWeo8ObwiS3LmcyxjjKW0 qfihVZfOoqUzTw1HcxS4lWnWJKd8RtRgWpb0Sk1jQWrEek+JG71FXSmePGXAHQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -5.04 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 740818776 X-Spam-Score: -5.04 X-Migadu-Scanner: scn1.migadu.com X-TUID: o6fltLKr+Cuw --Sig_/VuJZcXnjGOAJj83VTFAf=Ud Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Hi, On Wed, 01 Jun 2022 15:18:24 +0200 Maxime Devos wrote: > dannym@scratchpost.org schreef op wo 01-06-2022 om 15:00 [+0200]: > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0 (let ((code (system* "unzip" "--" zip))) > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (write code) > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (newline) > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (when (> (status:exit-val code) 1) ; 1= is just a warning =20 >=20 > What's the warning? Maybe the warning can be addressed or we could ask > unzip to not do warnings and then this could simplified to (invoke > "unzip" ...). In jmod files, there's a weird header in front and the warning is that it's skipping that header. >=20 > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (raise (condition (&invoke= -error > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0 (program "unzip") > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0 (arguments (list "--" zip)) > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0 (exit-status (status:exit-val code)) > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0 (term-signal (status:term-sig code)) > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0 (stop-signal (status:stop-sig code)))))))) =20 >=20 > This block could use a block explaining what it's for. > Likewise for the other undocumented block of code. Sure. I'll add a comment. It's basically just like "invoke" with a change in the exit-val check (1 instead of 0). --Sig_/VuJZcXnjGOAJj83VTFAf=Ud Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEds7GsXJ0tGXALbPZ5xo1VCwwuqUFAmMrcYIACgkQ5xo1VCww uqW2aQf/Z3i9PU77GuI8PaN6eTtLOE0AfN4oRO88bu0dn08//5wdno3nzTezRgdx UDEefJoVr48A3sNsOYnE0mi9OoTiaH7fvGhXj6ERcXGEFXIX9xrpvhsFhrDKlln9 mhfYmZ5i9YJgC1ib97u+2J3jY2s4ZjVGR938o/aFE2OncHM0QzkGceGuVCtWDTgz jfgyoJytmMFo4KWPxBK4zwGCB36K+o5dIPr4ynzP2OWtdKM2pFoBevSqQrP71J4U GKVbqnVpnpstAFOhdt+adiHQGJOFrmCuJfmyJCf3HsilxGvuYaMaFghvvGLRw9lM WfRZc48DI8w26IJSBeDm/edeAUzPFw== =dWXq -----END PGP SIGNATURE----- --Sig_/VuJZcXnjGOAJj83VTFAf=Ud--