From: muradm <mail@muradm.net>
To: 57473@debbugs.gnu.org
Cc: Maxim Cournoyer <maxim.cournoyer@gmail.com>
Subject: [bug#57473] [PATCH v2 3/4] gnu: fail2ban-service-type: Fix type of enabled? field.
Date: Mon, 29 Aug 2022 16:51:20 +0300 [thread overview]
Message-ID: <20220829135121.23392-3-mail@muradm.net> (raw)
In-Reply-To: <20220829135121.23392-1-mail@muradm.net>
* gnu/services/security.scm (fail2ban-jail-configuration)
[enabled?]: Should be maybe-boolean, which is how normaly fail2ban
is configured. This also allows sections without enabled field
like @samp{[DEFAULT]}.
* doc/guix.texi: Type of enabled? is maybe-boolean.
---
doc/guix.texi | 2 +-
gnu/services/security.scm | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/doc/guix.texi b/doc/guix.texi
index 7199ff6bc2..ebfc8fb3fa 100644
--- a/doc/guix.texi
+++ b/doc/guix.texi
@@ -36656,7 +36656,7 @@ Available @code{fail2ban-jail-configuration} fields are:
@item @code{name} (type: string)
Required name of this jail configuration.
-@item @code{enabled?} (default: @code{#t}) (type: boolean)
+@item @code{enabled?} (type: maybe-boolean)
Whether this jail is enabled.
@item @code{backend} (type: maybe-symbol)
diff --git a/gnu/services/security.scm b/gnu/services/security.scm
index 7f66c462f3..3283a582f2 100644
--- a/gnu/services/security.scm
+++ b/gnu/services/security.scm
@@ -197,7 +197,7 @@ (define-configuration fail2ban-jail-configuration
"Required name of this jail configuration."
empty-serializer)
(enabled?
- (boolean #t)
+ maybe-boolean
"Whether this jail is enabled.")
(backend
maybe-symbol
--
2.37.2
next prev parent reply other threads:[~2022-08-29 13:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-29 9:42 [bug#57473] [PATCH] gnu: fail2ban-service-type: Fix field name serialization muradm
2022-08-29 13:51 ` [bug#57473] [PATCH v2 1/4] " muradm
2022-08-29 13:51 ` [bug#57473] [PATCH v2 2/4] gnu: fail2ban-service-type: Improve jail configuration serialization muradm
2022-08-29 13:51 ` muradm [this message]
2022-08-29 20:56 ` [bug#57473] [PATCH v2 3/4] gnu: fail2ban-service-type: Fix type of enabled? field Maxim Cournoyer
2022-08-30 6:42 ` muradm
2022-09-01 13:03 ` bug#57473: " Maxim Cournoyer
2022-08-29 13:51 ` [bug#57473] [PATCH v2 4/4] gnu: fail2ban-service-type: Fix documentation typos muradm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220829135121.23392-3-mail@muradm.net \
--to=mail@muradm.net \
--cc=57473@debbugs.gnu.org \
--cc=maxim.cournoyer@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).