unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: "Wiktor Żelazny" <wz@freeshell.de>
To: 57337@debbugs.gnu.org
Cc: "Wiktor Żelazny" <wz@freeshell.de>
Subject: [bug#57337] [PATCH 0/2] Add docxbox
Date: Mon, 22 Aug 2022 11:27:53 +0200	[thread overview]
Message-ID: <20220822092753.31295-1-wz@freeshell.de> (raw)

The docxbox patch is probably not ready for applying, yet (but it should
be close). This is my first attempt at “unvendoring”. The thing builds
and seems to work. The problem is that etc/ld.so.cache gets created. I
have no idea where it comes from, but I suspect that it shouldn’t be
there, as it’s easy to imagine a conflict if multiple packages with
etc/ld.so.cache are being installed.

miniz-cpp-fixed-duplicated-symbols.patch is the last commit in

   https://github.com/kstenschke/miniz-cpp/tree/patch-2

I think I just used `git show` and redirected the output to the file.
I’m noting this because I’m not sure if there are any potential
copyright issues involved in such a workflow.

I couldn’t get the test suite to work. Please, see the comment in the
package definition for the details.

Then, there are linter messages:

   /home/<USER>/guix/guix-git/gnu/packages/textutils.scm:1512:12: docxbox@0.0.5: the source file name should contain the package name

Adding the

   (file-name (git-file-name name version))

line removes the warning, but breaks the build.

   /home/<USER>/guix/guix-git/gnu/packages/textutils.scm:1512:12: docxbox@0.0.5: the source URI should not be an autogenerated tarball

I’m guessing this refers to GitHub Automatic Releases feature.
Unfortunately, there are no other releases to choose from in that
repository.

Finally, there’s the question related to the MS Word being proprietary
software. I don’t think there should be controversies here, as docxbox
is about interacting with the docx format, rather than the software
itself. And the format itself is standardized. Perhaps the synopsis
the package should avoid mentioning MS Word. I borrowed it from the
docxbox repository.

Wiktor Żelazny (2):
  gnu: Add miniz-cpp.
  gnu: Add docxbox.

 gnu/local.mk                                  |    1 +
 gnu/packages/cpp.scm                          |   27 +
 .../miniz-cpp-fixed-duplicated-symbols.patch  | 2734 +++++++++++++++++
 gnu/packages/textutils.scm                    |   73 +-
 4 files changed, 2833 insertions(+), 2 deletions(-)
 create mode 100644 gnu/packages/patches/miniz-cpp-fixed-duplicated-symbols.patch


base-commit: b8f2eb286ec52c97048e23d326d94ae5772797e8
-- 
2.37.2





             reply	other threads:[~2022-08-22  9:40 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-22  9:27 Wiktor Żelazny [this message]
2022-08-22  9:36 ` [bug#57337] [PATCH 1/2] gnu: Add miniz-cpp Wiktor Żelazny
2022-08-22  9:36   ` [bug#57337] [PATCH 2/2] gnu: Add docxbox Wiktor Żelazny
2022-09-08 12:49     ` [bug#57337] [PATCH 0/2] " Ludovic Courtès
2022-09-23 18:04       ` Wiktor Żelazny
2022-09-08 12:46   ` Ludovic Courtès
2022-09-23 17:46     ` Wiktor Żelazny
2022-09-08 12:44 ` Ludovic Courtès
2022-09-23 18:21   ` Wiktor Żelazny
2022-12-26 14:57 ` [bug#57337] [v2 " Wiktor Żelazny
2022-12-26 14:57   ` [bug#57337] [v2 1/2] gnu: Add miniz-cpp Wiktor Żelazny
2023-01-25 22:17     ` Ludovic Courtès
2022-12-26 14:57   ` [bug#57337] [v2 2/2] gnu: Add docxbox Wiktor Żelazny
2023-01-25 22:21     ` Ludovic Courtès
2023-01-28 19:50       ` Wiktor Żelazny
2023-02-05 20:18 ` [bug#57337] [PATCH v3 1/2] gnu: Add miniz-cpp Wiktor Żelazny
2023-02-05 20:18   ` [bug#57337] [PATCH v3 2/2] gnu: Add docxbox Wiktor Żelazny

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220822092753.31295-1-wz@freeshell.de \
    --to=wz@freeshell.de \
    --cc=57337@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).