From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id yH7VC/Ql62Jw/AAAbAwnHQ (envelope-from ) for ; Thu, 04 Aug 2022 03:50:44 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id mH4GC/Ql62KIVAAAG6o9tA (envelope-from ) for ; Thu, 04 Aug 2022 03:50:44 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id B238F1F867 for ; Thu, 4 Aug 2022 03:50:43 +0200 (CEST) Received: from localhost ([::1]:47332 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oJQ0Y-0001S2-IB for larch@yhetil.org; Wed, 03 Aug 2022 21:50:42 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42690) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oJPxy-0007g9-Va for guix-patches@gnu.org; Wed, 03 Aug 2022 21:48:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:60866) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oJPxy-0001Qn-Hu for guix-patches@gnu.org; Wed, 03 Aug 2022 21:48:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oJPxy-00076s-73 for guix-patches@gnu.org; Wed, 03 Aug 2022 21:48:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#54439] [PATCH core-updates] gnu: rust: Use rust-1.60.0 References: In-Reply-To: Resent-From: Jim Newsome Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 04 Aug 2022 01:48:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54439 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 54439@debbugs.gnu.org, Maxime Devos Cc: Paul Alesius , Felipe Balbi , kiasoc5@tutanota.com, Pierre Langlois Received: via spool by 54439-submit@debbugs.gnu.org id=B54439.165957767827298 (code B ref 54439); Thu, 04 Aug 2022 01:48:02 +0000 Received: (at 54439) by debbugs.gnu.org; 4 Aug 2022 01:47:58 +0000 Received: from localhost ([127.0.0.1]:50613 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oJPxu-00076B-1P for submit@debbugs.gnu.org; Wed, 03 Aug 2022 21:47:58 -0400 Received: from wnew3-smtp.messagingengine.com ([64.147.123.17]:40963) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oJPxr-00075G-OB for 54439@debbugs.gnu.org; Wed, 03 Aug 2022 21:47:57 -0400 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailnew.west.internal (Postfix) with ESMTP id 4895D2B05C43; Wed, 3 Aug 2022 21:47:49 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Wed, 03 Aug 2022 21:47:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jimnewsome.net; h=cc:cc:content-transfer-encoding:date:date:from:from :in-reply-to:message-id:mime-version:reply-to:sender:subject :subject:to:to; s=fm1; t=1659577668; x=1659581268; bh=p/lf3BglSf f9WsmRkd1XDQoQB+MB/usELoCa8GQKkSk=; b=JT7Pb+y6FeYHmiUfZgIlK2OSXD m7vjV6lq86OSkO+wdvhgy/rS5hihIE+ZqCCI6OEP6WQJ+7EOuKscpvg6O1IIyVki 3wiEeZutJ0dS88djgJi3Dz5Q+CIB/ZjY0GJdC/BuhbnAkbks3jiepY/j5RwNW8fE Z98IS50krQGxHN6w2bY46CcpNqrgqp79a6MTnDiYTo1QxfRnP5CcjJyoUcsfKePQ oRUAW3uspgUdlgIEjAFyI07j43x3JtcNfUmQjrU1f3CP/KK1MR6/cr1hVjQf6NGW GBITrf3eq/ckBmkayob2aSLOIKrE1W4XOor1Oc5B62SpJyJLFNzUNy3e9HMg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding:date:date :feedback-id:feedback-id:from:from:in-reply-to:message-id :mime-version:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1659577668; x=1659581268; bh=p/lf3BglSff9WsmRkd1XDQoQB+MB/usELoC a8GQKkSk=; b=Ahh3e8qRTuIWiU8PTF5UNR+UfZa0/gC56z7j6+XQgQXPJZfAl6W 8izLUH46l6n9WB2SvITOcBBX2SpdIRtQakYjITJmTtkbCI5rlDzXPiHfnaN+PRyD 5qT4UBUij/mOtfX1sPaQHjJTbFr15pAAscLpBkkAHCO4a7B1euVtVLf0Qm47KxHm C+GJ83EG1K56nNvZZFMu7MLp4pvG5xMxCqCYrprYSohxKsIJPNeXvMJPGzsKWXiX Sc1Ht9+7XIy7KTNhtEoL04pRZRfQB+zMPeIwct2/OvCJBq1pykfPyu0JIMj1HJkC XUIstNACR8N+P+h6YWdTfTiQtsId8nyMwMw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrvddvkedghedvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkofgggfestdekredtredttdenucfhrhhomheplfhimhcupfgv fihsohhmvgcuoehjihhmsehjihhmnhgvfihsohhmvgdrnhgvtheqnecuggftrfgrthhtvg hrnhepvdefffelkeelhefggfduieeuleegiedvgfduheehfeegjefgledvveffvdekieeg necuffhomhgrihhnpehgnhhurdhorhhgnecuvehluhhsthgvrhfuihiivgeptdenucfrrg hrrghmpehmrghilhhfrhhomhepjhhimhesjhhimhhnvgifshhomhgvrdhnvght X-ME-Proxy: Feedback-ID: ib1a94636:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 3 Aug 2022 21:47:47 -0400 (EDT) From: Jim Newsome Date: Wed, 3 Aug 2022 20:47:15 -0500 Message-Id: <20220804014716.785308-1-jim@jimnewsome.net> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1659577843; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=p/lf3BglSff9WsmRkd1XDQoQB+MB/usELoCa8GQKkSk=; b=fJyPGzUvgXeghJe1cvqC4dO8Tza77wOwGq/CjLVzpUESWDMvR8JOmhPHBMJX4aviN1S2ZB QQrvJf+YRi7SQhElYsZclX2tfLqYC2cUYmuJ6dGwf0eXSokoHRE5k8iwis7O5alkxOe2Xw PMP7gQX3x8hJoV9GSjn3QtYq7DgPJXIJSgz+BG4aGxosTBXe4vCFwzY7F1hbBk9IA0/unN 4SULi9aiZ8X0MGUNIu2Xhy2x4RmTLuBOXNZxsCABhsCPwQJ5exlvUNP0FYMIP0oiH4d8J+ z0YyoDqN5MSaveqeWGWSsKpbbiNXTJHoueZuInBpuf00gXGPrvrF3fmRpQzM7A== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1659577843; a=rsa-sha256; cv=none; b=lYLMhcBtn2klX5xsFG5mZOIMssSJLUFk+ZhMzDXduiSR5hxoEnmEDPrQ68tr6He0ugoC8E mHONQWF9W9ERG5F5Zx3/nsEGi/LvmifZUoV0ZaeYlWNFiCQPjgcI6eM/KJP60+J4Z/bqRs LjIHhJoH1OXRre2z3B8Ud7XUUhTVTzwV2Q1tBHCKtVnw+dOP9wyibtLA4jDUxzis0oQTgm 7rZE1ql5WfNz4IALQP9ivctFoURY20sWUeFbm3PzmjAB7XqiYrmcdwY5Ur5KXyk4ItD7mi t3Z1etKGzMq+P8nWiyCo8ZLUNNjd1m7qe719FfRFiYj+cTdZJX402Ooe5Bo+RA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=jimnewsome.net header.s=fm1 header.b=JT7Pb+y6; dkim=fail ("headers rsa verify failed") header.d=messagingengine.com header.s=fm3 header.b=Ahh3e8qR; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 2.69 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=jimnewsome.net header.s=fm1 header.b=JT7Pb+y6; dkim=fail ("headers rsa verify failed") header.d=messagingengine.com header.s=fm3 header.b=Ahh3e8qR; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: B238F1F867 X-Spam-Score: 2.69 X-Migadu-Scanner: scn0.migadu.com X-TUID: srKlP7KW41XV Hi, I'm new to this project and this code-review workflow, so please bear with me :). It looks like there have been a few attempts here at updating Rust, including [Paul's], [Felipe's], and [my own]. [Paul's]: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=54439#5 [Felipe's]: https://issues.guix.gnu.org/54475#0 [my own]: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=56684 There's some discussion in this thread about using an updated mrustc and using that to cut out some earlier steps of the bootstrap chain. I propose leaving that out for the moment. It seems both nontrivial and orthogonal, so IMO would make more sense as its own thread / patch-set, which could be reviewed and merged independently, before or after this one. I think there's some confusion about where and how tests are enabled/disabled. IIUC in the current baseline, they are disabled in `rust-1.55`, which is the first version built with an earlier "official" rust: ``` ;; Only the final Rust is tested, not the intermediate bootstrap ones, ;; for performance and simplicity. #:tests? #f ``` and subsequent versions inherit that via the `rust-bootstrapped-package` function. The latest and public version (currently `rust-1.57`) re-enables most of the tests and fixes up some things so that the tests pass. So I think the approach here when adding versions is to change the current latest (1.57) to the simpler form that keeps tests disabled, add any additional necessary steps, and have the test-reenabling code again in the latest version. 2 patches included: * First is a pure refactor to decouple "rust-1.57" from "rust" to help avoid confusion in the future. * Second adds 1.58, 1.59, and 1.60, and makes rust-1.60 the new rust. In the latter patch I also tried building each version with a Rust 2 versions back instead of just 1 version back, to see if any can be left out. Unfortunately they couldn't. I'm including some of the errors in the comments for reference. -Jim