unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: "Paul A. Patience" <paul@apatience.com>
To: 56760@debbugs.gnu.org
Cc: "Paul A. Patience" <paul@apatience.com>
Subject: [bug#56760] [PATCH v2 6/6] gnu: trilinos-for-dealii-openmpi: Update to 13.4.0.
Date: Mon, 25 Jul 2022 15:12:33 +0000	[thread overview]
Message-ID: <20220725151135.3924177-7-paul@apatience.com> (raw)
In-Reply-To: <20220725151135.3924177-1-paul@apatience.com>

* gnu/packages/maths.scm (trilinos-for-dealii-openmpi): Update to
13.4.0.
[native-inputs]: Remove gcc-7.
[arguments]: Remove 'fix-kokkos-config' phase.
---
 gnu/packages/maths.scm | 70 ++++++++++++++++++++----------------------
 1 file changed, 33 insertions(+), 37 deletions(-)

diff --git a/gnu/packages/maths.scm b/gnu/packages/maths.scm
index 751f1b4fd8..d3481da0a6 100644
--- a/gnu/packages/maths.scm
+++ b/gnu/packages/maths.scm
@@ -5139,7 +5139,7 @@ (define-public lpsolve
 (define trilinos-for-dealii-openmpi
   (package
     (name "trilinos-for-dealii-openmpi")
-    (version "12.18.1")
+    (version "13.4.0")
     (source
      (origin
        (method git-fetch)
@@ -5150,31 +5150,28 @@ (define trilinos-for-dealii-openmpi
                              (string-replace-substring version "." "-")))))
        (file-name (git-file-name "trilinos" version))
        (sha256
-        (base32 "0fnwlhzsh85qj38cq3igbs8nm1b2jdgr2z734sapmyyzsy21mkgp"))))
+        (base32 "11vkn86dbvyvsf3zipd65y2f8vg5if9n3k7h3i8ybj95d4ck5r2n"))))
     (build-system cmake-build-system)
     (native-inputs
-     (list
-      ;; The build fails with the current gcc.
-      ;; Use the version from when Trilinos was added.
-      gcc-7
-      gfortran
-      ;; Trilinos's repository contains several C-shell scripts, but adding
-      ;; tcsh to the native inputs does not result in the check phase running
-      ;; any more tests than without it (nor is tcsh required to build
-      ;; Trilinos).
-      ;; It seems that Trilinos has replaced its use of C-shell test scripts
-      ;; with CMake's testing facilities.
-      ;; For example,
-      ;; packages/zoltan/doc/Zoltan_html/dev_html/dev_test_script.html [1]
-      ;; states that Zoltan's C-shell test script
-      ;; packages/zoltan/test/test_zoltan has been obsoleted by the tests now
-      ;; performed through CMake.
-      ;;
-      ;; Perl is required for some Zoltan tests and Python 2 for one ML test.
-      ;;
-      ;; [1]: https://cs.sandia.gov/zoltan/dev_html/dev_test_script.html
-      perl
-      python-2))
+     (list gfortran
+           ;; Trilinos's repository contains several C-shell scripts, but
+           ;; adding tcsh to the native inputs does not result in the check
+           ;; phase running any more tests than without it (nor is tcsh
+           ;; required to build Trilinos).
+           ;; It seems that Trilinos has replaced its use of C-shell test
+           ;; scripts with CMake's testing facilities.
+           ;; For example,
+           ;; packages/zoltan/doc/Zoltan_html/dev_html/dev_test_script.html [1]
+           ;; states that Zoltan's C-shell test script
+           ;; packages/zoltan/test/test_zoltan has been obsoleted by the tests
+           ;; now performed through CMake.
+           ;;
+           ;; Perl is required for some Zoltan tests and Python 2 for one ML
+           ;; test.
+           ;;
+           ;; [1]: https://cs.sandia.gov/zoltan/dev_html/dev_test_script.html
+           perl
+           python-2))
     (inputs
      (list openblas
            lapack
@@ -5248,22 +5245,21 @@ (define trilinos-for-dealii-openmpi
                    "-DTrilinos_ENABLE_Ifpack2=OFF"
                    "-DTeuchos_ENABLE_FLOAT=ON"
                    "-DTpetra_INST_INT_LONG=ON"
+                   ;; Disabling Tpetra_INST_INT_LONG_LONG is required only
+                   ;; because Tpetra's CMakeLists.txt [1] is incorrectly
+                   ;; testing for
+                   ;;
+                   ;;   DEFINED Tpetra_INST_INT_LONG AND Tpetra_INST_INT_UNSIGNED_LONG
+                   ;;
+                   ;; instead of
+                   ;;
+                   ;;   DEFINED Tpetra_INST_INT_LONG AND Tpetra_INST_INT_LONG
+                   ;;
+                   ;; [1]: https://github.com/trilinos/Trilinos/blob/0976cf2a8f9ee2991f4fb479f1056ca569eb22b9/packages/tpetra/CMakeLists.txt#L697
+                   "-DTpetra_INST_INT_LONG_LONG=OFF"
                    "-DTPL_ENABLE_Boost=OFF")
            #:phases
            #~(modify-phases %standard-phases
-               (add-after 'configure 'fix-kokkos-config
-                 (lambda _
-                   ;; GNU Make 4.3 accidentally leaves the backslash preceding
-                   ;; the number sign in strings containing a literal
-                   ;; backslash–number sign (\#) [1, 2].
-                   ;; This is still an issue in Trilinos 13.0.1, but should be
-                   ;; fixed in the following version.
-                   ;; (The latest versions of Kokkos incorporate the fix [2].)
-                   ;;
-                   ;; [1]: https://github.com/GEOSX/thirdPartyLibs/issues/136
-                   ;; [2]: https://github.com/kokkos/kokkos/blob/3.4.00/Makefile.kokkos#L441
-                   (substitute* "KokkosCore_config.h"
-                     (("\\\\#") "#"))))
                (add-before 'check 'mpi-setup
                  #$%openmpi-setup))))
     (home-page "https://trilinos.github.io/")
--
2.37.1






  parent reply	other threads:[~2022-07-25 15:13 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-25 12:30 [bug#56760] [PATCH 0/6] dealii: Update to 9.4.0 and its Trilinos to 13.4.0 Paul A. Patience
2022-07-25 12:33 ` [bug#56760] [PATCH 1/6] gnu: trilinos-for-dealii-openmpi: Fix build Paul A. Patience
2022-07-25 12:33   ` [bug#56760] [PATCH 2/6] gnu: dealii: Use G-expressions Paul A. Patience
2022-07-25 12:33   ` [bug#56760] [PATCH 3/6] gnu: dealii: Update to 9.4.0 Paul A. Patience
2022-07-25 12:33   ` [bug#56760] [PATCH 4/6] gnu: trilinos-for-dealii-openmpi: Remove input labels Paul A. Patience
2022-07-25 12:33   ` [bug#56760] [PATCH 5/6] gnu: trilinos-for-dealii-openmpi: Use G-expressions Paul A. Patience
2022-07-25 12:33   ` [bug#56760] [PATCH 6/6] gnu: trilinos-for-dealii-openmpi: Update to 13.4.0 Paul A. Patience
2022-07-25 15:11 ` [bug#56760] [PATCH v2 0/6] dealii: Update to 9.4.0 and its Trilinos " Paul A. Patience
2022-07-25 15:11   ` [bug#56760] [PATCH v2 1/6] gnu: trilinos-for-dealii-openmpi: Fix build Paul A. Patience
2022-07-25 15:12   ` [bug#56760] [PATCH v2 2/6] gnu: dealii: Use G-expressions Paul A. Patience
2022-07-25 15:12   ` [bug#56760] [PATCH v2 3/6] gnu: dealii: Update to 9.4.0 Paul A. Patience
2022-07-25 15:12   ` [bug#56760] [PATCH v2 4/6] gnu: trilinos-for-dealii-openmpi: Remove input labels Paul A. Patience
2022-07-25 15:12   ` [bug#56760] [PATCH v2 5/6] gnu: trilinos-for-dealii-openmpi: Use G-expressions Paul A. Patience
2022-07-25 15:12   ` Paul A. Patience [this message]
2022-07-26 11:41     ` [bug#56760] [PATCH v2 6/6] gnu: trilinos-for-dealii-openmpi: Update to 13.4.0 Paul A. Patience
2022-08-01 15:22   ` bug#56760: [PATCH 0/6] dealii: Update to 9.4.0 and its Trilinos " Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220725151135.3924177-7-paul@apatience.com \
    --to=paul@apatience.com \
    --cc=56760@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).