From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id yAOROZBzx2IMcwAAbAwnHQ (envelope-from ) for ; Fri, 08 Jul 2022 02:00:17 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id sMFyOZBzx2KPPQEAauVa8A (envelope-from ) for ; Fri, 08 Jul 2022 02:00:16 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 66A731076E for ; Fri, 8 Jul 2022 02:00:16 +0200 (CEST) Received: from localhost ([::1]:33120 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o9bPq-0007pW-Db for larch@yhetil.org; Thu, 07 Jul 2022 20:00:15 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52380) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o9bPe-0007p7-Tx for guix-patches@gnu.org; Thu, 07 Jul 2022 20:00:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:36190) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o9bPe-0004bV-Jt for guix-patches@gnu.org; Thu, 07 Jul 2022 20:00:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1o9bPe-0005hk-EQ for guix-patches@gnu.org; Thu, 07 Jul 2022 20:00:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#55896] [PATCH] gnu: Add python-pybare. Resent-From: jgart Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 08 Jul 2022 00:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55896 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: moreinfo patch To: Maxim Cournoyer Cc: 55896@debbugs.gnu.org, Maxime Devos Received: via spool by 55896-submit@debbugs.gnu.org id=B55896.165723836621854 (code B ref 55896); Fri, 08 Jul 2022 00:00:02 +0000 Received: (at 55896) by debbugs.gnu.org; 7 Jul 2022 23:59:26 +0000 Received: from localhost ([127.0.0.1]:58320 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o9bP3-0005gQ-S4 for submit@debbugs.gnu.org; Thu, 07 Jul 2022 19:59:26 -0400 Received: from mx1.dismail.de ([78.46.223.134]:48333) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o9bP2-0005gC-2F for 55896@debbugs.gnu.org; Thu, 07 Jul 2022 19:59:24 -0400 Received: from mx1.dismail.de (localhost [127.0.0.1]) by mx1.dismail.de (OpenSMTPD) with ESMTP id 6742c1df; Fri, 8 Jul 2022 01:59:17 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=dismail.de; h=date :message-id:from:to:cc:subject:in-reply-to:references :mime-version:content-type:content-transfer-encoding; s= 20190914; bh=i8ozvtDypbcrEx3U8Z+GCcXCI1elCZ4ufoDwI17n+SQ=; b=qkh 4wdO7J+paixNBtVoU5k+mgMIbd27vvnRQhgvG8NyA5BWS67/8Cj8MIknIKzxc/Lk 2vi0xQCN+Fa8hOifAhoAJYVfDPBFySmY5Jon+zd1t3JcRkXUl+7PanDtce+8fBAA 7k85zA20ia6X9uPC1vrbvx5cRH4jVmaE5bq2POio6D+s8b9QbhUJYMyQsLLQBVN1 oiVqYKfGHFnOxtCMZPsAijvs0ONFwoXrWPT+Iz3he7w9up+8BFDD7nBbmAlohRr6 TXkBpFzunR8wiaAnoVpZYwAiy8fD0t7lx1kiP/Xb2t52zLe36JTgCWoC7ure3UQy HqILrQ0nOqmGL0H85Ng== Received: from smtp2.dismail.de ( [10.240.26.12]) by mx1.dismail.de (OpenSMTPD) with ESMTP id 1e1008b5; Fri, 8 Jul 2022 01:59:17 +0200 (CEST) Received: from smtp2.dismail.de (localhost [127.0.0.1]) by smtp2.dismail.de (OpenSMTPD) with ESMTP id 7ef0bb04; Fri, 8 Jul 2022 01:59:17 +0200 (CEST) Received: by dismail.de (OpenSMTPD) with ESMTPSA id 35e74f5d (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Fri, 8 Jul 2022 01:59:16 +0200 (CEST) Date: Thu, 7 Jul 2022 18:59:23 -0500 Message-ID: <20220707185923.GD1675@gac> In-Reply-To: <87h73swtm7.fsf_-_@gmail.com> References: <20220611202700.5655-1-jgart@dismail.de> <20220612155418.GC1648@gac> <87h73swtm7.fsf_-_@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" Reply-to: jgart X-ACL-Warn: , jgart via Guix-patches From: jgart via Guix-patches via X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1657238416; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=tvajw5hLRDygwZabPCZOz62Zp1rAQ+ZnZOQv67aeem8=; b=L05MeYYyUP+dv0IFlqbxcSWXUw8ZWqJW572p5vXWQKdCK6pOKZQ3oMb5KlGag4A8nsKOu6 V2gweqpvSvo4vhnP5RZTqVWspQiME7s5YLaUxLpWQuni+evhMIUJpVMfN/ptCExn5C8y3/ j+xDdm+I6mx6xoVEIM2sYasRhr3GP5TNoYZD0PPX58fPAh2SVSH6cwnS+mQqba/3vxw3FR TrZTnMtrxXHYBBeLlo+p87r8WkTGQqxIjMF+GSitpAow7HnLyfSDqv8OZB1Q8kD/64E1qW 3UnPbY7sPUvIqnEYLconaHV+4HaMxTnd1SXqafNY/uqOVjtu7mu7VzB3i2CzVA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1657238416; a=rsa-sha256; cv=none; b=RCSOynkJGi9lX8KlLlPiF9NOZntMC1II3pOK2LhB7bIl0sUagHg3oBGqid5HJCdzk//WM/ Cr7QrIqZDuM+Ai8F4EGXpMKgDM3vwfJ08wrqfK9mqERf+kPqAsujxrV/k2ERTyvjcF+2BN 8OjhAUNn+JXwG/Tb6IjOYQrWkfw/e2bTmtH0xn0XRjWAL1vKVDHCb/n8RhsVluGwrAZGZt AlL18EQNdlVFKndLP2uD7KrtqPJa/sekb6sRyJppH6XrCktWSDcHuPvN+oddK8R9yyD6Km 6oipBaYppGAsVaapvgFh4Wmhp0rJyWTvQ2ExtyaNlqyV1W6U9lAdMQiwEgx/MA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=dismail.de header.s=20190914 header.b="qkh 4wdO"; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -3.04 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=dismail.de header.s=20190914 header.b="qkh 4wdO"; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 66A731076E X-Spam-Score: -3.04 X-Migadu-Scanner: scn1.migadu.com X-TUID: pjUAfE9jclzN On Thu, 07 Jul 2022 16:33:20 -0400 Maxim Cournoyer wrote: > Hello, > > jgart writes: > > [...] > > > Hi Maxime, no worries. Take your time. The review is much appreciated. > > > > I just looked at the sources again myself and noticed that the tests > > use pre-generated BARE binaries to test against. > > > > See here: > > > > https://git.sr.ht/~chiefnoah/pybare/tree/master/item/bare/test_encoder.py#L225 > > > > and here: > > > > https://git.sr.ht/~chiefnoah/pybare/tree/master/item/bare/_examples > > > > Should I ask the author if they can provide a way to generate those > > binaries for testing instead of vendoring the pre-compiled binaries > > without their sources? > > Yes, please ask. Otherwise, we'll have to delete the binaries from > unknown source in a source snippet and not run the test suite... I asked already. But I'll have to do some more research. The author mentioned that they go the binaries from Drew Devault's implementation of the same library in golang. I think Drew Devault is also vendoring the binaries iirc. TODO: So, I'll have to contact Drew and ask him if he can generate the binaries instead of vendoring them in. all best, jgart