[bug#55896] [PATCH] gnu: Add python-pybare.

[bug#55896] [PATCH] gnu: Add python-pybare.

[jgart via Guix-patches via]

* gnu/packages/python-xyz.scm (python-pybare): New variable.
---
 gnu/packages/python-xyz.scm | 32 ++++++++++++++++++++++++++++++++
 1 file changed, 32 insertions(+)

diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index 4104472848..ceedacd714 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -29418,6 +29418,38 @@ (define-public python-gatt
 Currently, Linux is the only platform supported by this library.")
     (license license:expat)))
 
+(define-public python-pybare
+  (package
+    (name "python-pybare")
+    (version "0.1.1")
+    (source
+      (origin
+        (method git-fetch)
+        (uri
+         (git-reference
+          (url "https://git.sr.ht/~chiefnoah/pybare")
+          (commit (string-append "v" version))))
+        (file-name (git-file-name name version))
+        (sha256
+         (base32 "1ibmwwf1rdxlwyxlzhv3v1i0ybsqg0kppim90sm8rsbns86yy4by"))))
+    (build-system python-build-system)
+    (native-inputs
+      (list python-pytest))
+    (arguments
+     `(#:phases
+       (modify-phases %standard-phases
+         (replace 'check
+           (lambda _
+             (chdir "bare")
+             (invoke "pytest" "."))))))
+    (home-page "https://sr.ht/~chiefnoah/PyBARE/")
+    (synopsis "Declarative implementation of BARE for Python")
+    (description
+"@code{python-pybare} is a general purpose library for strongly
+typed primitives in Python that supports serializing to and from BARE
+messages.")
+    (license license:expat)))
+
 (define-public python-musical-scales
   (package
     (name "python-musical-scales")
-- 
2.36.1

[bug#55896] [PATCH] gnu: Add python-pybare.

[Maxime Devos]

[-- Attachment #1: Type: text/plain, Size: 813 bytes --]

jgart via Guix-patches via schreef op vr 10-06-2022 om 23:27 [-0500]:
> +    (arguments
> +     `(#:phases
> +       (modify-phases %standard-phases
> +         (replace 'check
> +           (lambda _
> +             (chdir "bare")
> +             (invoke "pytest" "."))))))

"./pre-inst-env guix lint python-pybare" will have a warning about
this.  Also, apparently 'list' is considered more readable than
quasiquote/unquote, see [1], so maybe eliminate the quasiquote in
favour of 'list'?

> BARE

Looks like a not well-known acronym, maybe use @acronym?

[1] https://logs.guix.gnu.org/guix/2022-06-09.log#194339

Otherwise the package definition LGTM, but I haven't built or tested it
or read the source code.

Greetings,
Maxime.

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 260 bytes --]

[bug#55896] [PATCH v2] gnu: Add python-pybare.

[jgart via Guix-patches via]

* gnu/packages/python-xyz.scm (python-pybare): New variable.

Hi Maxime,

Thanks for the review. It is much appreciated.

Here is version 2 with your requested changes.

all best,

jgart
---
 gnu/packages/python-xyz.scm | 33 +++++++++++++++++++++++++++++++++
 1 file changed, 33 insertions(+)

diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index 4104472848..5109434cbf 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -29418,6 +29418,39 @@ (define-public python-gatt
 Currently, Linux is the only platform supported by this library.")
     (license license:expat)))
 
+(define-public python-pybare
+  (package
+    (name "python-pybare")
+    (version "0.1.1")
+    (source
+      (origin
+        (method git-fetch)
+        (uri
+         (git-reference
+          (url "https://git.sr.ht/~chiefnoah/pybare")
+          (commit (string-append "v" version))))
+        (file-name (git-file-name name version))
+        (sha256
+         (base32 "1ibmwwf1rdxlwyxlzhv3v1i0ybsqg0kppim90sm8rsbns86yy4by"))))
+    (build-system python-build-system)
+    (arguments
+      (list #:phases
+            #~(modify-phases %standard-phases
+                (replace 'check
+                  (lambda* (#:key tests? #:allow-other-keys)
+                    (when tests?
+                      (chdir "bare")
+                      (invoke "pytest" "-vv" ".")))))))
+    (native-inputs
+      (list python-pytest))
+    (home-page "https://sr.ht/~chiefnoah/PyBARE/")
+    (synopsis "Declarative implementation of BARE for Python")
+    (description
+"@code{python-pybare} is a general purpose library for strongly typed
+primitives in Python that supports serializing to and from @acronym{BARE,
+Binary Application Record Encoding} messages.")
+    (license license:expat)))
+
 (define-public python-musical-scales
   (package
     (name "python-musical-scales")
-- 
2.36.1

[bug#55896] [PATCH v2] gnu: Add python-pybare.

[Maxime Devos]

[-- Attachment #1: Type: text/plain, Size: 1607 bytes --]

jgart schreef op za 11-06-2022 om 15:27 [-0500]:
> +(define-public python-pybare
> +  (package
> +    (name "python-pybare")
> +    (version "0.1.1")
> +    (source
> +      (origin
> +        (method git-fetch)
> +        (uri
> +         (git-reference
> +          (url "https://git.sr.ht/~chiefnoah/pybare")
> +          (commit (string-append "v" version))))
> +        (file-name (git-file-name name version))
> +        (sha256
> +         (base32 "1ibmwwf1rdxlwyxlzhv3v1i0ybsqg0kppim90sm8rsbns86yy4by"))))
> +    (build-system python-build-system)
> +    (arguments
> +      (list #:phases
> +            #~(modify-phases %standard-phases
> +                (replace 'check
> +                  (lambda* (#:key tests? #:allow-other-keys)
> +                    (when tests?
> +                      (chdir "bare")
> +                      (invoke "pytest" "-vv" ".")))))))
> +    (native-inputs
> +      (list python-pytest))
> +    (home-page "https://sr.ht/~chiefnoah/PyBARE/")
> +    (synopsis "Declarative implementation of BARE for Python")
> +    (description
> +"@code{python-pybare} is a general purpose library for strongly typed
> +primitives in Python that supports serializing to and from @acronym{BARE,
> +Binary Application Record Encoding} messages.")
> +    (license license:expat


Package definition LGTM, but I have only looked at the definition, not
the sources etc.

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 260 bytes --]

[bug#55896] [PATCH v2] gnu: Add python-pybare.

[jgart via Guix-patches via]

On Sun, 12 Jun 2022 17:41:57 +0200 Maxime Devos <maximedevos@telenet.be> wrote:
> jgart schreef op za 11-06-2022 om 15:27 [-0500]:
> > +(define-public python-pybare
> > +  (package
> > +    (name "python-pybare")
> > +    (version "0.1.1")
> > +    (source
> > +      (origin
> > +        (method git-fetch)
> > +        (uri
> > +         (git-reference
> > +          (url "https://git.sr.ht/~chiefnoah/pybare")
> > +          (commit (string-append "v" version))))
> > +        (file-name (git-file-name name version))
> > +        (sha256
> > +         (base32 "1ibmwwf1rdxlwyxlzhv3v1i0ybsqg0kppim90sm8rsbns86yy4by"))))
> > +    (build-system python-build-system)
> > +    (arguments
> > +      (list #:phases
> > +            #~(modify-phases %standard-phases
> > +                (replace 'check
> > +                  (lambda* (#:key tests? #:allow-other-keys)
> > +                    (when tests?
> > +                      (chdir "bare")
> > +                      (invoke "pytest" "-vv" ".")))))))
> > +    (native-inputs
> > +      (list python-pytest))
> > +    (home-page "https://sr.ht/~chiefnoah/PyBARE/")
> > +    (synopsis "Declarative implementation of BARE for Python")
> > +    (description
> > +"@code{python-pybare} is a general purpose library for strongly typed
> > +primitives in Python that supports serializing to and from @acronym{BARE,
> > +Binary Application Record Encoding} messages.")
> > +    (license license:expat
> 
> 
> Package definition LGTM, but I have only looked at the definition, not
> the sources etc.

Hi Maxime, no worries. Take your time. The review is much appreciated.

I just looked at the sources again myself and noticed that the tests
use pre-generated BARE binaries to test against.

See here:

https://git.sr.ht/~chiefnoah/pybare/tree/master/item/bare/test_encoder.py#L225

and here:

https://git.sr.ht/~chiefnoah/pybare/tree/master/item/bare/_examples

Should I ask the author if they can provide a way to generate those
binaries for testing instead of vendoring the pre-compiled binaries
without their sources?

all best,

jgart

[bug#55896] [PATCH] gnu: Add python-pybare.

[Maxim Cournoyer]

Hello,

jgart <jgart@dismail.de> writes:

[...]

> Hi Maxime, no worries. Take your time. The review is much appreciated.
>
> I just looked at the sources again myself and noticed that the tests
> use pre-generated BARE binaries to test against.
>
> See here:
>
> https://git.sr.ht/~chiefnoah/pybare/tree/master/item/bare/test_encoder.py#L225
>
> and here:
>
> https://git.sr.ht/~chiefnoah/pybare/tree/master/item/bare/_examples
>
> Should I ask the author if they can provide a way to generate those
> binaries for testing instead of vendoring the pre-compiled binaries
> without their sources?

Yes, please ask.  Otherwise, we'll have to delete the binaries from
unknown source in a source snippet and not run the test suite...

Thank you!

Maxim

[bug#55896] [PATCH] gnu: Add python-pybare.

[jgart via Guix-patches via]

On Thu, 07 Jul 2022 16:33:20 -0400 Maxim Cournoyer <maxim.cournoyer@gmail.com> wrote:
> Hello,
> 
> jgart <jgart@dismail.de> writes:
> 
> [...]
> 
> > Hi Maxime, no worries. Take your time. The review is much appreciated.
> >
> > I just looked at the sources again myself and noticed that the tests
> > use pre-generated BARE binaries to test against.
> >
> > See here:
> >
> > https://git.sr.ht/~chiefnoah/pybare/tree/master/item/bare/test_encoder.py#L225
> >
> > and here:
> >
> > https://git.sr.ht/~chiefnoah/pybare/tree/master/item/bare/_examples
> >
> > Should I ask the author if they can provide a way to generate those
> > binaries for testing instead of vendoring the pre-compiled binaries
> > without their sources?
> 
> Yes, please ask.  Otherwise, we'll have to delete the binaries from
> unknown source in a source snippet and not run the test suite...

I asked already. But I'll have to do some more research.

The author mentioned that they go the binaries from Drew Devault's implementation of the same library in golang.

I think Drew Devault is also vendoring the binaries iirc.

TODO:

So, I'll have to contact Drew and ask him if he can generate the binaries instead of vendoring them in.

all best,

jgart

bug#55896:

[jgart via Guix-patches via]

I'm closing for now.

Feel free to reopen if anyone wants to work on this.