From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id YIetGnK9umLD0gAAbAwnHQ (envelope-from ) for ; Tue, 28 Jun 2022 10:36:02 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id UJ2OGnK9umL4TAAAauVa8A (envelope-from ) for ; Tue, 28 Jun 2022 10:36:02 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id DCAF1362A6 for ; Tue, 28 Jun 2022 10:36:01 +0200 (CEST) Received: from localhost ([::1]:44398 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o66hU-0007s9-SX for larch@yhetil.org; Tue, 28 Jun 2022 04:36:01 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39264) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o65v9-0006tt-7r for guix-patches@gnu.org; Tue, 28 Jun 2022 03:46:10 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:59981) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o65v8-0006aR-Td for guix-patches@gnu.org; Tue, 28 Jun 2022 03:46:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1o65v8-0003YP-T6 for guix-patches@gnu.org; Tue, 28 Jun 2022 03:46:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#56140] [Patches] Add and update music packages References: In-Reply-To: Resent-From: Alice BRENON Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 28 Jun 2022 07:46:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56140 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 56140@debbugs.gnu.org Received: via spool by 56140-submit@debbugs.gnu.org id=B56140.165640234113618 (code B ref 56140); Tue, 28 Jun 2022 07:46:02 +0000 Received: (at 56140) by debbugs.gnu.org; 28 Jun 2022 07:45:41 +0000 Received: from localhost ([127.0.0.1]:53876 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o65um-0003XZ-P2 for submit@debbugs.gnu.org; Tue, 28 Jun 2022 03:45:41 -0400 Received: from lxc-smtp2.ens-lyon.fr ([140.77.167.81]:52782) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o65ua-0003X3-Lr for 56140@debbugs.gnu.org; Tue, 28 Jun 2022 03:45:29 -0400 Received: from localhost (localhost [127.0.0.1]) by lxc-smtp2.ens-lyon.fr (Postfix) with ESMTP id 3F1FBE3732 for <56140@debbugs.gnu.org>; Tue, 28 Jun 2022 09:45:27 +0200 (CEST) X-Virus-Scanned: by amavisd-new-2.11.0 (20160426) (Debian) at ens-lyon.fr Received: from lxc-smtp2.ens-lyon.fr ([127.0.0.1]) by localhost (lxc-smtp2.ens-lyon.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 5Y4tnSkYgK6Q for <56140@debbugs.gnu.org>; Tue, 28 Jun 2022 09:45:27 +0200 (CEST) Received: from localhost (dhcp-152-246.ens-lyon.fr [140.77.152.246]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (Client did not present a certificate) by lxc-smtp2.ens-lyon.fr (Postfix) with ESMTPSA id 3534FE371E for <56140@debbugs.gnu.org>; Tue, 28 Jun 2022 09:45:27 +0200 (CEST) Date: Tue, 28 Jun 2022 09:45:26 +0200 From: Alice BRENON Message-ID: <20220628094526.7ca71999@ens-lyon.fr> Organization: ENS de Lyon X-Mailer: Claws Mail 4.1.0 (GTK 3.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1656405362; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=yyscawqf/ru8hfGFx7YdPxdRXVLmqP6hSHrCDyjKm0U=; b=QzO6YAUaaloq/ixkZ60vyjva4ALdAi68hnfAWfAn9RqB+cJGuuxP7T2DmyEfDX4NKHuyCI IlB8LVaRNP/DB7zTpNA1k52i+SjgaD1gdy7swq/NEyZifoNt7xiZifDOP3Uzh53oaNdaNG jwmtlgbQSMVZT+cBUZmvP09GffL+wrJebwDNvab+72NEn3yz9IRaicT/Q+AQffJXYqvWrc 2tc/lvRc8jFGrL6UcwOYQC49RMs+3v5bVJB107XUhV8mas9rbkBZgcjeCeHbA70abaIvI0 34E/3sXrpKFJQl4oLDrvzdriauNUONMB9stJn8UtqPtOI5ED0K2D62uMMYO3PA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1656405362; a=rsa-sha256; cv=none; b=YbapiIKBXNiLW0ZtItXO5z7f3vJo+emGjVhbQv7fwk2UHWTuELACKiLQJhxNscy7HKJgtF INxzNBStCcJVuzpn5aYzLaCs0z3dtpzimrcT/uCUlqPuD68KK4Pwzj0r0wAtYViDc1+VGz VAcBBLGivwpAvab9x4g5GMGoNQj/ulxOWM9gHnYr2vohCtYSGZDBmtxk5Fjxc0J4VQTU4O AnM5VMRHWDGA5S2cPbppz2kkOtXlgvjbgQdB5UIBlUkRiyJORwtU5VSaY+RFMAuNWOEZTU 6os5IJ7QxaNZbWzpCtDbns58iL1ea7q42VQ/qzseY9KCtl85OSlgxeRbQuXd9w== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -2.95 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: DCAF1362A6 X-Spam-Score: -2.95 X-Migadu-Scanner: scn1.migadu.com X-TUID: iBDgG/DbAT1r Hi ! Thanks for submitting this patch ! I'm in no position to provide a definitive answer to accept or reject this but here are some immediate things that could be improved. - your description of Fabla doesn't add much information compared to the synopsis. What makes it special ? How is it different from the other similar tools ? (see https://guix.gnu.org/fr/manual/devel/en/html_node/Synopses-and-Descriptio= ns.html#Synopses-and-Descriptions for inspiration) - the other packages seem to have more extensive description, but they make very long lines, have you tried formatting your package using the `guix style` command ? (https://guix.gnu.org/fr/manual/devel/en/html_node/Formatting-Code.html#F= ormatting-Code) - you seem to consistently use the "old" syntax for packages in native-inputs, as opposed to inputs, is there a good reason for that or have you maybe only found examples where the native-inputs haven't been modernized ? While it makes sense to rename `cmake-minimal` to `cmake` in the definition of `distrho-ports` (though I wonder `luppp` didn't require the same renaming and keeps the key "cmake-minimal" for `cmake-minimal`, all the others occurrences (`("pkg-config" ,pkg-config)`, `("lv2" ,lv2)`=E2= =80=A6) are totally unneeded for as far as I understand and could be simplified as `(list pkg-config lv2 mesa)`. I'm also a bit curious as to why tests need to be explicitly deactivated in `sorcer`, does running the default cmake command to test the project result in a failure, not just a NOP ? I hope some other people will take it over from there because I don't have much more to contribute : ) Cheers, Alice