From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id INguM6Jvt2LgGQAAbAwnHQ (envelope-from ) for ; Sat, 25 Jun 2022 22:27:14 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id 2M9hMqJvt2IBGQEAG6o9tA (envelope-from ) for ; Sat, 25 Jun 2022 22:27:14 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 3DD4929123 for ; Sat, 25 Jun 2022 22:27:14 +0200 (CEST) Received: from localhost ([::1]:39664 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o5CN7-00054e-4m for larch@yhetil.org; Sat, 25 Jun 2022 16:27:13 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44164) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o5CMw-00053c-9S for guix-patches@gnu.org; Sat, 25 Jun 2022 16:27:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:52364) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o5CMw-0005pR-0w for guix-patches@gnu.org; Sat, 25 Jun 2022 16:27:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1o5CMv-0002yQ-UN for guix-patches@gnu.org; Sat, 25 Jun 2022 16:27:01 -0400 Subject: bug#56213: [PATCH] gnu: Add maven-doxia-core Resent-From: Julien Lepiller Original-Sender: "Debbugs-submit" Resent-To: guix-patches@gnu.org Resent-Date: Sat, 25 Jun 2022 20:27:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 56213 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: "Artyom V. Poptsov" Cc: 56213-done@debbugs.gnu.org Mail-Followup-To: 56213@debbugs.gnu.org, julien@lepiller.eu, poptsov.artyom@gmail.com Received: via spool by 56213-done@debbugs.gnu.org id=D56213.165618876711364 (code D ref 56213); Sat, 25 Jun 2022 20:27:01 +0000 Received: (at 56213-done) by debbugs.gnu.org; 25 Jun 2022 20:26:07 +0000 Received: from localhost ([127.0.0.1]:46261 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o5CM3-0002xD-ES for submit@debbugs.gnu.org; Sat, 25 Jun 2022 16:26:07 -0400 Received: from lepiller.eu ([89.234.186.109]:41816) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o5CLz-0002x2-5p for 56213-done@debbugs.gnu.org; Sat, 25 Jun 2022 16:26:06 -0400 Received: from lepiller.eu (localhost [127.0.0.1]) by lepiller.eu (OpenSMTPD) with ESMTP id 3da5e5f1; Sat, 25 Jun 2022 20:26:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=lepiller.eu; h=date:from :to:cc:subject:message-id:in-reply-to:references:mime-version :content-type; s=dkim; bh=XXNrP/dJhC6/vPjwxhOAkHtUF9pcKtX5uiUEo9 xsYBg=; b=byAu9+QO9o1bNeNT5NCl1qqvuWrr27EsgJ6bsNcg3WkRLQqq86D7Ry woxM+Lmw9tEVTRmfOLeQYz5S07Df08vPF1erOJbRS8igVPRsgxFqEbdczSXxgsfc GKdnU6OAVwwTAA+ddOL4/Sytf+Bio/3pDewV5CYt/gAjhIvQFc4Vpu/23iL6938e INwj6vFly1csApO0Sw+x6HSTKhlIgIHaGovAJ9wcJwWRHNkHeQWETO9WnIO+Acak n1pxj4nTc5TcFuzXxbYy8I8nth21R008UnGOuGNlAVXYPao9U8I/Q3VLuE2lrCH7 jEGslEsALgVOuYnI/O0473YpJtYsXEow== Received: by lepiller.eu (OpenSMTPD) with ESMTPSA id 3e4df399 (TLSv1.3:AEAD-AES256-GCM-SHA384:256:NO); Sat, 25 Jun 2022 20:26:00 +0000 (UTC) Date: Sat, 25 Jun 2022 22:25:59 +0200 From: Julien Lepiller Message-ID: <20220625222559.5e92b63f@sybil.lepiller.eu> In-Reply-To: <87wnd52b3x.fsf@gmail.com> References: <878rplniny.fsf@gmail.com> <20220625132117.6da69dda@sybil.lepiller.eu> <87wnd52b3x.fsf@gmail.com> X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/=K=/eIdr.eYUB=uEh0O3C3H"; protocol="application/pgp-signature"; micalg=pgp-sha512 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1656188834; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-to:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=j1M+Z4Hw09/wZ3kVCfHzAwZpAAhWxCp7RKfnDAQ738w=; b=RSVwSL50kEUnfJX+eYjDDssxbTjfUjZxC5r0vFwhGM3j9wzlhosbhnVYEhl5bXx8MZjtky 7c2e74FEdpcojsKbS0OBcP5XkDTw6ix2RvDbIuxblQuEIESh9YeV3BQtEvYTh3lg2NBmNb 0p/L3fgwOY7Uj8ui60HhxhGLYwrSEx7KRWAsV2szRk+UC5Y1GVyDPGAGabZvnTSFkC5duR /i+B/FdfUiHY5n0araWZhjdK73kh3sOLr1/g3Es4G3HYS2pUnFMj3AN7avdJ8rFY4jThaO 8daGwM7tFylmtl1G2ZhCAIdrcXrh0ImVo90hIsVFbbPcCt/DmvpIqxW4F/YrzA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1656188834; a=rsa-sha256; cv=none; b=tyy6tw6d/l/Lo4QKbdtr0csaPG9RZ8AcUj4aNiJA48AkVPe0qQRTlWoD3CXhiJlJX1RRUe FTqIiXRvwqg7Q9EU4MZYvKtHlwVkLXz6lw7Nv1/XXBTyHqJU7QurVaQ6kMbgiYYlroLAl4 qfcFZU10u9b/O/3apYpBjbm9mZzUBZZo4O4SPuoGfEwa9eA0Kjon2qx7KnpVe7Fl/46NNA bCO63WYWaHNsT7TZiY7jftnRMtrL7KNnGP22jR7zURRtbzxWmmlWZUk1YPYjiKb7JreSIm 1kSKSIuulzFwg93pgd0xWKKJKjK9dgRFQCHdMlR4RMLd8a3aMzOVNG7xf9JkNQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=lepiller.eu header.s=dkim header.b=byAu9+QO; dmarc=fail reason="SPF not aligned (relaxed)" header.from=lepiller.eu (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 5.44 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=lepiller.eu header.s=dkim header.b=byAu9+QO; dmarc=fail reason="SPF not aligned (relaxed)" header.from=lepiller.eu (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 3DD4929123 X-Spam-Score: 5.44 X-Migadu-Scanner: scn0.migadu.com X-TUID: 0szfJcTaDRDN --Sig_/=K=/eIdr.eYUB=uEh0O3C3H Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Pushed to master as d039f9dc151eed8017a7f54682dbf713221b8005, thank you! A few answers below: Le Sat, 25 Jun 2022 15:14:58 +0300, "Artyom V. Poptsov" a =C3=A9crit : > Hello Julien. >=20 > > Thanks for the patch! =20 >=20 > Thanks for taking your time for reviewing my patch. :-) >=20 > > Missing full stop at the end of the subject line. =20 >=20 > Okay, added a full-stop. >=20 > FWIW, I'm usually following those rules when writing commit messages: > https://cbea.ms/git-commit/#end >=20 > The rules explicitly say that a committer should not add a full-stop > at the end of the first line. We follow our own rules that mandate a full stop. I thought I could send you to the manual, but apart a vague mention of the ChangeLog format, I can't find the rules. Have we always applied such strict rules without writing them down properly? >=20 > However, 'guix lint' gave me the following warning: > --8<---------------cut here---------------start------------->8--- > /home/avp/src/dist/guix/gnu/packages/maven.scm:3943:2: > maven-doxia-core@2.0.0-M2: propagated inputs plexus-parent-pom@5.1 > and plexus-parent-pom@4.0 collide --8<---------------cut > here---------------end--------------->8--- >=20 > I don't know yet how to properly fix that; probably the issue is that > I made all the inputs propagated, but I don't see how to differentiate > them looking at the Doxia Core 'pom.xml'. You can ignore these issues about parent poms. There's no real collision except for the package name. No files in common between the two packages, so that's fine. Nothing we can do anyway. --Sig_/=K=/eIdr.eYUB=uEh0O3C3H Content-Type: application/pgp-signature Content-Description: Signature digitale OpenPGP -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEHvsJCR8X0ozL+bE6U9RXstY27oIFAmK3b1cACgkQU9RXstY2 7oKi/Q/8Dhz8akLG818fVqtRoD6u4pqEjqkb+ZJWwmxyIhpm9KfTscqmcn09gGI+ DMjJC6xTPfiZMCaHA3v3ElF8RZISCjapOV/QvoWHxJDrPkjluQ/JUdoTTRMp6F4W IytwPtvil0U6gaH7+2y7L0eMHLCUuiaQFn450Y4MmVIyhRd3hdvCt3gVsaB4Xxt/ UPTbVW2GYrGe1CYUKpst3Rh0OwDr9ezOKt2Dv1w9MDm0rkDOp0/4XXQq6tfpPEXD SBNLH1Ab7pUEof0I53rtXKb7wsvANIn1pjS/fSz3MT7m3WOYfySuot0YT/vrOD9d huR+o9eL8Fwrzj3/pmFDopy5XeMpP0+u1QYcebH+xrRS7EbSCZo+DyzpLIZ2zRt2 HvlY8c1r54vYks1+shPWIm6Lu166z3IXXySFKYsKquQtrmQzps+15nSgk9cfEgmq XhWk9ihYZSs4OlqoKyErUTvVIcvXuVWS27QxcSver2+c4lDspT9+1rc/qWbDm6r7 4GSrB1WlHxWLfjhzL52dwlpBmvaQEN3FIT/oiD3bAPhLq4+LSan4HBBU50AyvIdg eJ5rWjJBWbtCUVWeTvSBStzKBadR8ciuN/8CjLBpBSG4vUfKxppWhBBFu/PTHcrG BJULGKMrdm7H/xnP04CO8XquNffcRMIFZRMtO3oCdiw6ZC4zX1Y= =CebK -----END PGP SIGNATURE----- --Sig_/=K=/eIdr.eYUB=uEh0O3C3H--