From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id SCm+DAXwtmJhhgEAbAwnHQ (envelope-from ) for ; Sat, 25 Jun 2022 13:22:45 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id CKClDAXwtmIXTgEAauVa8A (envelope-from ) for ; Sat, 25 Jun 2022 13:22:45 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id F0DBD1DEF5 for ; Sat, 25 Jun 2022 13:22:44 +0200 (CEST) Received: from localhost ([::1]:47870 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o53sB-0004da-Ml for larch@yhetil.org; Sat, 25 Jun 2022 07:22:43 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35522) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o53rX-0004GN-40 for guix-patches@gnu.org; Sat, 25 Jun 2022 07:22:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:50335) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o53rW-0005kF-Mg for guix-patches@gnu.org; Sat, 25 Jun 2022 07:22:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1o53rW-0003Ij-JU for guix-patches@gnu.org; Sat, 25 Jun 2022 07:22:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#56213] [PATCH] gnu: Add maven-doxia-core Resent-From: Julien Lepiller Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 25 Jun 2022 11:22:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56213 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: "Artyom V. Poptsov" Cc: 56213@debbugs.gnu.org Received: via spool by 56213-submit@debbugs.gnu.org id=B56213.165615608712618 (code B ref 56213); Sat, 25 Jun 2022 11:22:02 +0000 Received: (at 56213) by debbugs.gnu.org; 25 Jun 2022 11:21:27 +0000 Received: from localhost ([127.0.0.1]:44227 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o53qw-0003HR-So for submit@debbugs.gnu.org; Sat, 25 Jun 2022 07:21:27 -0400 Received: from lepiller.eu ([89.234.186.109]:41778) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o53qs-0003HG-3u for 56213@debbugs.gnu.org; Sat, 25 Jun 2022 07:21:25 -0400 Received: from lepiller.eu (localhost [127.0.0.1]) by lepiller.eu (OpenSMTPD) with ESMTP id 07b55e55; Sat, 25 Jun 2022 11:21:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=lepiller.eu; h=date:from :to:cc:subject:message-id:in-reply-to:references:mime-version :content-type; s=dkim; bh=rlwrIj5c2Rf2yJJJ9zGxn8xiYQKLCNLR/GC9eR SKOJs=; b=iibuxj24ajiLlb5g1tqwRvzwE+YMu0XcBwuY3bEs3+WffweZghX85o 99zyGoUR6tbnfff4ubE2/kX1SjrSmZ8CHMEOcoYDHKARK73nlpfQvKDQbfciqq88 r/v3PV44RdRNNoKerKhYfgFSCUw1QZQAY33teetKGV7Y3rAE3P2Qw6hVv+d/65Bx knwGA5sSWI0h/R0A3vtB24DLyqlL2dBuwCj7SDVcCwW06yV6gWYphczw7gyEykjF 0SnTGUnpuuTcIW5VOPosb70wnYpWRiFwgPhIIOEg7F9RYdjaq8mTXTkHi7UUAFHm K9LaqunshphtBukPrCR111KyBluqq8Gg== Received: by lepiller.eu (OpenSMTPD) with ESMTPSA id 6218102c (TLSv1.3:AEAD-AES256-GCM-SHA384:256:NO); Sat, 25 Jun 2022 11:21:19 +0000 (UTC) Date: Sat, 25 Jun 2022 13:21:17 +0200 From: Julien Lepiller Message-ID: <20220625132117.6da69dda@sybil.lepiller.eu> In-Reply-To: <878rplniny.fsf@gmail.com> References: <878rplniny.fsf@gmail.com> X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/FaL3PV_5jyrggGzJzQsuumc"; protocol="application/pgp-signature"; micalg=pgp-sha512 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1656156165; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=dzptdHZmzI4jDunSe7PGCQOyhSF1mQog29HSPjfz4FE=; b=OjjEKdV57vdD74oT0yBp/FBLY/tnn7FdKHeRbJGhIxjvxT+XF3B570rU7CTaAAuOfxJlHk pL7TtHydESwhImhL7ZF9j5oGUIYhw61U6x5NIg+Eb9z5vkuqe5kAAMLPnRjGIzgd0ZQ5VZ Irx64Qlj4dUT/Zi+zMDLLc2Ml2yjU0wVQtJQ+nkBYGZ3kknngCmMfmhxeC5HxLZ8jbWMeu poQTLQEZ7J3Iq2ubeKZ+KnMUhipQPgTG3wpm2uSUDmqLADnDyKKvKjkER+rtsKtmVABCn8 G3/h3JyARd1crRfO/MP1xvkZuwyfX8mFYr2fslmSv8K5wNeLva04fWe1VNnfmA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1656156165; a=rsa-sha256; cv=none; b=kpYLdK6/UbGjAeht6Mm5jTzWKn0ClpJJ6qPioilFY6jIE4GVI5gaYS8a43Jq0MvB0o1zDG cQNHhpRtHI+TekyB9Uatcrm64u+o9JAeqj9wPlXBgwm2pLGOjBL8ecJ+UuoXhKSqB3nP6i Pq949AIxPyphKG1ztCzjrwjDbthL07tc7hNM8wW36jpYjntmobCYaN1+Dip+bgt/YFYeEs otMHQ1P+sUWLP6ZWxZcLmYGS9axAL9y1mOsogxwUw9YCXuK8Nz42luS6AlfE5fewFvGveh Nn2X1Q1Huse4YHkgkn85j75XziAlT2ujeZ9fJSLaDVXPpXlSN7Tos6grSANpGQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=lepiller.eu header.s=dkim header.b=iibuxj24; dmarc=fail reason="SPF not aligned (relaxed)" header.from=lepiller.eu (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 2.83 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=lepiller.eu header.s=dkim header.b=iibuxj24; dmarc=fail reason="SPF not aligned (relaxed)" header.from=lepiller.eu (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: F0DBD1DEF5 X-Spam-Score: 2.83 X-Migadu-Scanner: scn0.migadu.com X-TUID: J+haoLG37xSh --Sig_/FaL3PV_5jyrggGzJzQsuumc Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Thanks for the patch! A few remarks below :) Le Sat, 25 Jun 2022 13:26:09 +0300, "Artyom V. Poptsov" a =C3=A9crit : > From 4e06642ac47d0b69fb5aeb5e8b21efaacbc7ed67 Mon Sep 17 00:00:00 2001 > From: "Artyom V. Poptsov" > Date: Sat, 25 Jun 2022 13:20:02 +0300 > Subject: [PATCH] gnu: Add maven-doxia-core Missing full stop at the end of the subject line. >=20 > * gnu/packages/maven.scm (maven-doxia-core): New variable. > --- > gnu/packages/maven.scm | 26 ++++++++++++++++++++++++++ > 1 file changed, 26 insertions(+) >=20 > diff --git a/gnu/packages/maven.scm b/gnu/packages/maven.scm > index e5831ee614..95de84e845 100644 > --- a/gnu/packages/maven.scm > +++ b/gnu/packages/maven.scm > @@ -3921,6 +3921,32 @@ encapsulate common text syntax. A start tag > is denoted by @code{xxxx()} method and a end of tag by @code{xxxx_()} > method.") (license license:asl2.0))) > =20 > +(define-public maven-doxia-core > + (package > + (inherit maven-doxia-sink-api) > + (name "maven-doxia-core") > + (arguments > + `(#:jar-name "doxia-core.jar" > + #:source-dir "doxia-core/src/main/java" > + #:tests? #f ;no tests This package actually has tests, could you enable them? > + #:phases (modify-phases %standard-phases > + (replace 'install > + (install-from-pom "doxia-core/pom.xml"))))) > + (inputs (list maven-doxia-sink-api > + java-slf4j-api > + java-javax-inject > + java-plexus-utils > + java-eclipse-sisu-plexus > + java-commons-text)) The pom file references most of these as runtime dependencies, so we need to propagate them, so maven can find them. We also need to propagated the parent pom :) > + (home-page "https://maven.apache.org/doxia/index.html") > + (synopsis "Doxia core classes and interfaces") > + (description > + "Doxia is a content generation framework that provides powerful > +techniques for generating static and dynamic content, supporting a > variety of +markup languages.") This feels like a description of the whole Doxia project. Could you add maybe one sentence to explain how this package is related to the whole doxia project? > + (license license:asl2.0))) > + > + > (define maven-doxia-parent-pom > (package > (inherit maven-doxia-sink-api) Lastly, I would put this package just below maven-doxia-parent-pom, but that's mostly aesthetic :) --Sig_/FaL3PV_5jyrggGzJzQsuumc Content-Type: application/pgp-signature Content-Description: Signature digitale OpenPGP -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEHvsJCR8X0ozL+bE6U9RXstY27oIFAmK2760ACgkQU9RXstY2 7oLK9BAAh67JwhTBb2zicG3lnhL98lvv9tNyKS3nuzZQTsFWNgYHim5U96bnAVxi drKWUd13enoFCvOt6hCg+AEFk0eZyq+XYBT1rL0aXbzMqXSeg47z1xO2L0yYkQ42 5M/npDu8dpuDSdvRh64rQr0XsSgTpGiR5Tu9UH97DoxHI2eBQkIjQmycsDJz/Llv JVlocCgoiHjXegw9Z4eVXBLh5C7eKEzFFyY0ger25Cj3AeQ5gtZq1vJ61gHWh4kf b8N+7lLFAcxwJyikMfzeDYhS68/ySnjmp1yPS21PTZJZEJ3yjcI/xJZBjKk5zmQO JZ3Ph/PW0VOmNcA3HwP62bcmOeBu0BKz8D8IJiZh506zleIIirCYgf2kHtmi+Sld 1l+xfnjbAdh8SwpbXnkn5lFh+O45HwfS33yzMMqzB5/ZU1JJI9uQH+iCRYt4CheV cb+00fAQ+W4NPxeo+8wd9lowAi7UwStguETypgYNQEEwj/dNeAErx+zdljzXMpIP BtVilynJGH9LgSOU4dw9U5iDRLXraEv3DbTeUyjyhZAjtXll89uV/j1aYU6n+NcK u8vru4jG/OmzmPGJdz43lgXpFkv4qnN8nB7xSn/jNF/FGh3EFm2vt13bstRnrpfa yS4yLr0J1/0Rt3sxJPb32BWmJrNaRZ0AVgZ8fjN+VcA44QmlM28= =w0ok -----END PGP SIGNATURE----- --Sig_/FaL3PV_5jyrggGzJzQsuumc--