From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id YfgSJZvutmIBhgEAbAwnHQ (envelope-from ) for ; Sat, 25 Jun 2022 13:16:43 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id WIVAI5vutmJ8DQEAG6o9tA (envelope-from ) for ; Sat, 25 Jun 2022 13:16:43 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 4B5E8110CF for ; Sat, 25 Jun 2022 13:16:40 +0200 (CEST) Received: from localhost ([::1]:43786 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o53mI-0001Za-QQ for larch@yhetil.org; Sat, 25 Jun 2022 07:16:38 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34656) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o53li-0001ZN-Lf for guix-patches@gnu.org; Sat, 25 Jun 2022 07:16:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:50326) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o53li-0004ES-D4 for guix-patches@gnu.org; Sat, 25 Jun 2022 07:16:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1o53li-0001yA-3X for guix-patches@gnu.org; Sat, 25 Jun 2022 07:16:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#56212] [PATCH] gnu: Add maven-release-api Resent-From: Julien Lepiller Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 25 Jun 2022 11:16:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56212 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: "Artyom V. Poptsov" Cc: 56212@debbugs.gnu.org Received: via spool by 56212-submit@debbugs.gnu.org id=B56212.16561557396039 (code B ref 56212); Sat, 25 Jun 2022 11:16:02 +0000 Received: (at 56212) by debbugs.gnu.org; 25 Jun 2022 11:15:39 +0000 Received: from localhost ([127.0.0.1]:44223 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o53lK-0001Yt-LR for submit@debbugs.gnu.org; Sat, 25 Jun 2022 07:15:39 -0400 Received: from lepiller.eu ([89.234.186.109]:41770) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o53lI-0001UO-C8 for 56212@debbugs.gnu.org; Sat, 25 Jun 2022 07:15:37 -0400 Received: from lepiller.eu (localhost [127.0.0.1]) by lepiller.eu (OpenSMTPD) with ESMTP id 7d3191a4; Sat, 25 Jun 2022 11:15:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=lepiller.eu; h=date:from :to:cc:subject:message-id:in-reply-to:references:mime-version :content-type; s=dkim; bh=WdPNjp9xPy+TS9GOAoEEQOUf/h5w8jaFBuBExK n7s8g=; b=n3YDq40XfHzo+TkW66nDxPySWFqFQMLI/qocrqzdp2g1EqfhxfJ5AZ hWDihUUERXyv4UgQYfJUpbJN/mw+Jim9pc7ehDHlcmASe5fN6lUFGU3L+l5UYZd9 xQlp65Li3ReRWmGppKxfK97rW+m70iOXibDNoVLyV7Opz9Gl04DI2V5kYAKU12K4 8C4SHQvCoC48V9qy/Bq9CCPQa/Z7WpOIFLkrkBUWyuiRtwbXwuXcFY3tFQKQlxir 31MdYTGlxLbu+kX8StKK3mkCP8UcgXgsrOfgwcr1QQ3YElSrokiLYH/S581BXdri RxLqfuadw9GNurdsCAc8wMSCx078gJdg== Received: by lepiller.eu (OpenSMTPD) with ESMTPSA id 3fc8e667 (TLSv1.3:AEAD-AES256-GCM-SHA384:256:NO); Sat, 25 Jun 2022 11:15:16 +0000 (UTC) Date: Sat, 25 Jun 2022 13:15:08 +0200 From: Julien Lepiller Message-ID: <20220625131502.691b1ee1@sybil.lepiller.eu> In-Reply-To: <871qvd3xgd.fsf@gmail.com> References: <871qvd3xgd.fsf@gmail.com> X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/IVi.9t+oeaIdPBlr17Cwv_U"; protocol="application/pgp-signature"; micalg=pgp-sha512 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1656155802; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=A++d53pbjh7bf6kbqPQ4z8W1FD/oC3ma7C1A6hEoBmE=; b=NMKcLkjyUV2V3WoPoNrfD8/nHHdDUMXnx3wibsLhZm3XWK6wr4++PQZJ8VgMVjNJ6ypog0 VtOHuK3v0Z9TyRHgPw8+1IEisAcUn8D1YgyDwebIsfkf4xVW/jx2g4f/yjy488o5eJ8F4t miPd24KnAsdsHt3Bls4gA6QdIJEySKGlFm+c757AvyAFzceNxDq08RkdQd0ooh6bTKqcZO m3Kfl8RAatcZK8Dq3ijvBF0oZ18XOQqBqP1z3OGx72pn2Ok7ECJumthaj4XDx29cTBcENu VH3EU779jQlffqGdKsGUVyBwMerqVWjUXwM3nh1jiwN579kbhDoMdoOIkFfWVA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1656155802; a=rsa-sha256; cv=none; b=YGZdI/YrEDpqBD2kO85EHXOErcnMafp08/+Q6ncZ+TIF/WIU1Qj1M5r/2u3iKytOuVpSVD ujEifJJmJGsb+/14GQD2omQG+s4PUD2wtmZXt84RAZVN2SYu+VMKcDuQCSXZSxdyTTh2sK MESA9vl8pl9dwBvB3dQCIcV9li/AAWFR+CXVTA1p32AylWDCK+puBoxASH1HjM3KA+VeNd vb+Z9syphipDRytqhF5xrc8v+yoiMDnJeqF7IjBdeYNDIMzsa1JVYRP4NPNjNmItXeDdpP 8keYsIpNu2XGtfGu9jdXt6PVXLt83NR23yp+TUuRAShU/vbMbPIrlK7uEK7/uA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=lepiller.eu header.s=dkim header.b=n3YDq40X; dmarc=fail reason="SPF not aligned (relaxed)" header.from=lepiller.eu (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 2.83 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=lepiller.eu header.s=dkim header.b=n3YDq40X; dmarc=fail reason="SPF not aligned (relaxed)" header.from=lepiller.eu (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 4B5E8110CF X-Spam-Score: 2.83 X-Migadu-Scanner: scn0.migadu.com X-TUID: scgTFbCLHBSB --Sig_/IVi.9t+oeaIdPBlr17Cwv_U Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Thanks for the patch! A few remarks below. Le Sat, 25 Jun 2022 12:26:58 +0300, "Artyom V. Poptsov" a =C3=A9crit : > From f071547eaf36804cfe0fc7ee0ef418e2db1abb7a Mon Sep 17 00:00:00 2001 > From: "Artyom V. Poptsov" > Date: Sat, 25 Jun 2022 12:16:29 +0300 > Subject: [PATCH] gnu: Add maven-release-api Missing full stop in the subject line. >=20 > * gnu/packages/maven.scm (maven-release-api): New variable. > (maven-release-parent-pom): New variable. > --- > gnu/packages/maven.scm | 58 > ++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 58 > insertions(+) >=20 > diff --git a/gnu/packages/maven.scm b/gnu/packages/maven.scm > index e5831ee614..7ff2d6d69e 100644 > --- a/gnu/packages/maven.scm > +++ b/gnu/packages/maven.scm > @@ -3938,3 +3938,61 @@ method and a end of tag by @code{xxxx_()} > method.") (description "@samp{Doxia} is a content generation > framework that provides powerful techniques for generating static and > dynamic content, supporting a variety of markup languages."))) > + > +(define-public maven-release-api > + (package > + (name "maven-release-api") > + (version "3.0.0-M5") > + (source (origin > + (method git-fetch) > + (uri (git-reference > + (url "https://github.com/apache/maven-release") > + (commit (string-append "maven-release-" > version)))) > + (file-name (git-file-name "maven-release" version)) > + (modules '((guix build utils))) > + (snippet > + '(begin > + ;; XXX: Delete dummy JAR-files. > + (delete-file-recursively > + > "maven-release-manager/src/test/remote-repository") > + #t)) No need to end the snippet with #t. Since we're going to build maven-release-manager at some point (I suppose?), we'll need these files in order to run the tests. Could you add something to the snippet to regenerate the files (if that's possible from the snippet, otherwise we'll regenerate them in a phase once we have a maven-release-manager package)? > + (sha256 > + (base32 > + > "13yxjl29jp4zkb8xvy0b045b5fpqz9nais1jsf4r9krczyxyj96k")))) > + (build-system ant-build-system) > + (propagated-inputs (list maven-release-parent-pom)) > + (inputs (list maven-repository-metadata > + maven-artifact > + maven-core > + maven-model > + java-eclipse-aether-util > + java-slf4j-api > + java-plexus-utils)) I think most of these inputs should be propagated because the pom file references these packages in its dependencies: ... whatever's not a test dependency will be required at runtime by maven, so we need to propagate. > + (arguments > + `(#:jar-name "maven-release-api.jar" > + #:source-dir "maven-release-api/src/main/java" > + #:tests? #f ; no tests > + #:phases (modify-phases %standard-phases > + (replace 'install > + (install-from-pom > "maven-release-api/pom.xml"))))) > + (home-page "https://maven.apache.org/maven-release/") > + (synopsis "APIs to implement to extend maven-release-plugin") It's hard to understand this sentence. maybe s/to implement/required/ > + (description "APIs to implement to extend maven-release-plugin") This should be full sentences. Can you come up with maybe two sentences that briefly explain what this package does? > + (license license:asl2.0))) > + > +(define maven-release-parent-pom > + (package > + (inherit maven-release-api) > + (name "maven-release-parent-pom") > + (arguments > + `(#:tests? #f ; no tests > + #:phases (modify-phases %standard-phases > + (delete 'configure) > + (delete 'build) > + (replace 'install > + (install-pom-file "pom.xml"))))) > + (propagated-inputs > + (list maven-parent-pom-34)) > + (synopsis "Apache Maven Release (Plugin)") > + (description "This plugin is used to release a project with > Maven, saving +a lot of repetitive, manual work."))) I would replace "(Plugin)" with "parent pom". The description is for the plugin, not the parent pom, so maybe: This is the parent for the maven release plugin that is used to release ... WDYT? --Sig_/IVi.9t+oeaIdPBlr17Cwv_U Content-Type: application/pgp-signature Content-Description: Signature digitale OpenPGP -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEHvsJCR8X0ozL+bE6U9RXstY27oIFAmK27jwACgkQU9RXstY2 7oIDKg//bY1mTqDctJTv4Ib8FMGYvrkM5UETeMteK2/3ThP31NwCsS6DAKmrn+py X1wVuyGlfNDoXK/rbzcii2JsgzQu2mwkyKudSb8z337vitbeOHdJnxn5KFwrAk2C Az1VnOotdjrLHo7YYbUX+/H2R+R67X01HJbxD7VC8orDrX/if4aAgmyUYtgjZ7/4 iVFGxnLRGMyzLaQVvlC9Dc7rbgODFVb+CkCVehFGPFs//QUsXL5DFRaaDeM3MsvY DdYGEGH4naZP6ipiJhhdixeAcubZqOMS/O2l2fAlpzwp1IEEGymRMdFzu1Ek+IwO egb9MMyBeVFyDOtOlz8KHCYYUQCqqgVarFTTs46ncRqVsuZxK/qeihzK/nNZDMCk Hy9DreZz2azl/iGvVMSdpewemtoVpW8XEGjTFe3fbz4A9cGelA1/VfssbQ2BqYp6 zHEV7FOgYuUBCO3+gIYaibIrftdpyFLS8fPj+FQwfOFqQmAxkHpiTAmKmetFRcNd 7H1Xxt562fkVJQe73FJ65apY0EApUiKpM1hdaPTSWgPIjPQDMU1aPNF0crNeugWJ mWsA5mqc+PGcTxa//atXXXeI2nKfwihTihoCnJ8NZIcUOc2bqtBaOQYMgj/dGJl4 visx+uiGmLiLOPwGqzTUSzkRP7b8Y4HfUHyKP82BGfPh3XzsyjA= =HyKr -----END PGP SIGNATURE----- --Sig_/IVi.9t+oeaIdPBlr17Cwv_U--