From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id CEWHF8//sWLyWwEAbAwnHQ (envelope-from ) for ; Tue, 21 Jun 2022 19:28:47 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id QE9oF8//sWIuMQEA9RJhRA (envelope-from ) for ; Tue, 21 Jun 2022 19:28:47 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 5B8F2C3F5 for ; Tue, 21 Jun 2022 19:28:46 +0200 (CEST) Received: from localhost ([::1]:60434 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o3hgC-0000cr-H0 for larch@yhetil.org; Tue, 21 Jun 2022 13:28:44 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59256) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o3hfW-0008Ua-2c for guix-patches@gnu.org; Tue, 21 Jun 2022 13:28:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:39308) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o3hfV-0001Ll-QO for guix-patches@gnu.org; Tue, 21 Jun 2022 13:28:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1o3hfV-0005gs-KG for guix-patches@gnu.org; Tue, 21 Jun 2022 13:28:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#41360] [PATCH v5] finalize java-openjfx packages Resent-From: Julien Lepiller Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 21 Jun 2022 17:28:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41360 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ioannis Kappas Cc: 41360@debbugs.gnu.org, ludo@gnu.org, levenson@mmer.org Received: via spool by 41360-submit@debbugs.gnu.org id=B41360.165583243821815 (code B ref 41360); Tue, 21 Jun 2022 17:28:01 +0000 Received: (at 41360) by debbugs.gnu.org; 21 Jun 2022 17:27:18 +0000 Received: from localhost ([127.0.0.1]:33205 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o3heo-0005fn-7c for submit@debbugs.gnu.org; Tue, 21 Jun 2022 13:27:18 -0400 Received: from lepiller.eu ([89.234.186.109]:41250) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o3hei-0005fa-W2 for 41360@debbugs.gnu.org; Tue, 21 Jun 2022 13:27:16 -0400 Received: from lepiller.eu (localhost [127.0.0.1]) by lepiller.eu (OpenSMTPD) with ESMTP id 83ecabe3; Tue, 21 Jun 2022 17:27:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=lepiller.eu; h=date:from :to:cc:subject:message-id:in-reply-to:references:mime-version :content-type:content-transfer-encoding; s=dkim; bh=zZ8e6I4noiyd S8F2Ez+cCkrHoRfNDjPZxczXQR/HTNI=; b=euPlBpeh2FWYkiwpyVJsfGl7lIlI Wt+8JzSUH0FuVDzrM4gVuRw44PS1Xd1ErsoqXKEoOZSRvuS9itryXFmNG5bbv3O3 tatphnM7lC06p/AARCj2+IvN6Vl530lFYWKTQ0Sbu/oENpzhNZwT2I7lXB26Jj70 8BHVnF5xSQN4FJNDB3BfoqR7ytgagWMQyMQaLlYIBOAn5mTvHnIVWZ01ExAifBbD Kc/i2CcxR84Fuknh1Vcm4QHfqdJ0fkDLjsfNz4ff5NcelQpM6p57Mihp3SfgPf18 T0U6BKyErXv4zx5c+1+DwmHTKdFptVRac3k0rFjERbdIGYyxcs+0JS+1/Q== Received: by lepiller.eu (OpenSMTPD) with ESMTPSA id 3e356990 (TLSv1.3:AEAD-AES256-GCM-SHA384:256:NO); Tue, 21 Jun 2022 17:27:09 +0000 (UTC) Date: Tue, 21 Jun 2022 19:27:06 +0200 From: Julien Lepiller Message-ID: <20220621192706.39031ffd@sybil.lepiller.eu> In-Reply-To: References: X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1655832527; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=zZ8e6I4noiydS8F2Ez+cCkrHoRfNDjPZxczXQR/HTNI=; b=mLLzJC+eneQZexk2p6zGTt9zswML3iBbcijr3jQeqZFLXuPHHCfsqYR50npJcUnxNTojeC 0kcTSHJ3p4Hz2wxhATiYM3TwssBJzL1gR+OsToHuE/BzSkzx03hmSGupR/RPXVltCeMOqP 5cXsgrmyS9rZzZfJB0gYrCmF/OrWWXn7l58/+qU/popijmi1fiXXwJPyoMu9LzSdE88bIv IBr8HE2DHv2vBb0OWjguNLtLbHUjUR8BkbevNtMepFBGT5HU40Ez8Nt0+8IfyH6bNrdVcY cexMGe/EczDnMrCw5MeaNf2t/M1bkUb55rtLmMqxeaGS7wt51SoyXVMMaCemtw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1655832527; a=rsa-sha256; cv=none; b=H/FhXk5KFUmCAEL4b/mLmllzUY4+q1X8fvBpd2ZIVAOtHUm4seetsjtrKQZTgBxIXyj3JU SB23HManGi/gBUXXi4qaSgMcVQ8iFugY/VAYa2cKpCnasgrbuMXvaVoWqTKdIkzFk4ZiEo 9M7CsfjfO0kyGoeqjK+/dbkj73fKo6CUb/bleumw9nHnFaI7j7xH82IA8THTMJIOMJQo3p k1EWOWiTqd647zyi/PUoBkp6EZhSxgRTrCdnFKMzeaQv5K6NcZr7XrxjguFT5Gjpqun35i 5Kr2uQ7YaHdi7chmJiVIp0w2XTTEMfiR4QyqvWG0xFX/w3+C7V9gQoJbnXig0Q== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=lepiller.eu header.s=dkim header.b=euPlBpeh; dmarc=fail reason="SPF not aligned (relaxed)" header.from=lepiller.eu (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 7.93 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=lepiller.eu header.s=dkim header.b=euPlBpeh; dmarc=fail reason="SPF not aligned (relaxed)" header.from=lepiller.eu (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 5B8F2C3F5 X-Spam-Score: 7.93 X-Migadu-Scanner: scn0.migadu.com X-TUID: bLKmZZHhDCYK Hi Ioannis, So, I read only patches 2 and 3. In the third patch, I have a couple suggestions, in addition to what I told you in my previous message. java-openjfx-build-web-js-test.patch doesn't seem to be present in the patch. > 2. Output native libs to openjfx standard share/amd64 dir. That would only work on x86_64-linux I think. Could you either install to some common directory, and then fix loading, or to a directory that depends on the architecture, so it can find the libraries on other architectures too? We could get rid of all the #t at the end of phases, it's deprecated now. Could you fix all this and send a new patch series, with one patch per package, so we can try applying them and checking them more closely?