unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
* [bug#53007] [PATCH] gnu: networking: Add arp-scan
@ 2022-01-04 15:34 manolis837
  2022-01-04 15:40 ` Manolis Ragkousis
                   ` (2 more replies)
  0 siblings, 3 replies; 7+ messages in thread
From: manolis837 @ 2022-01-04 15:34 UTC (permalink / raw)
  To: 53007; +Cc: Manolis Ragkousis

From: Manolis Ragkousis <manolis837@gmail.com>

* gnu/packages/networking.scm (arp-scan): New variable.
---
 gnu/packages/networking.scm | 30 ++++++++++++++++++++++++++++++
 1 file changed, 30 insertions(+)

diff --git a/gnu/packages/networking.scm b/gnu/packages/networking.scm
index cc9cc61164..ac67d58541 100644
--- a/gnu/packages/networking.scm
+++ b/gnu/packages/networking.scm
@@ -47,6 +47,7 @@
 ;;; Copyright © 2021 Milkey Mouse <milkeymouse@meme.institute>
 ;;; Copyright © 2021 Guillaume Le Vaillant <glv@posteo.net>
 ;;; Copyright © 2021 Maxime Devos <maximedevos@telenet.be>
+;;; Copyright © 2022 Manolis Fragkiskos Ragkousis <manolis837@gmail.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -4143,3 +4144,32 @@ (define-public putty
 implementations.")
     (home-page "https://www.chiark.greenend.org.uk/~sgtatham/putty/")
     (license license:expat)))
+
+(define-public arp-scan
+  (package
+    (name "arp-scan")
+    (version "1.9.7")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "https://github.com/royhills/arp-scan/"
+                           "archive/refs/tags/" version ".tar.gz"))
+       (sha256
+        (base32 "0ff0c43rw1b4cm52rx7s6q0wsix3ahjjfhd8wk85nr9wjgj3cg70"))))
+    (build-system gnu-build-system)
+    (arguments
+     `(#:phases
+       (modify-phases %standard-phases
+         (replace 'bootstrap
+           (lambda _
+             (invoke "autoreconf" "-vfi"))))))
+    (inputs
+     (list libpcap))
+    (native-inputs
+     (list autoconf automake libtool pkg-config))
+    (propagated-inputs
+     (list perl-libwww))
+    (home-page "https://github.com/royhills/arp-scan")
+    (synopsis "Dscover and fingerprint IP hosts on the local network using ARP")
+    (description "A tool that uses ARP to discover and fingerprint IP hosts on the local network")
+    (license license:gpl3)))
-- 
2.33.1





^ permalink raw reply	[flat|nested] 7+ messages in thread

* [bug#53007] [PATCH] gnu: networking: Add arp-scan
  2022-01-04 15:34 [bug#53007] [PATCH] gnu: networking: Add arp-scan manolis837
@ 2022-01-04 15:40 ` Manolis Ragkousis
  2022-01-06 11:18   ` Manolis Ragkousis
  2022-01-11 18:54 ` Leo Famulari
  2022-06-20 21:41 ` manolis837
  2 siblings, 1 reply; 7+ messages in thread
From: Manolis Ragkousis @ 2022-01-04 15:40 UTC (permalink / raw)
  To: 53007

[-- Attachment #1: Type: text/plain, Size: 2156 bytes --]

This is the correct version. :)

On Tue, 4 Jan 2022, 17:34 , <manolis837@gmail.com> wrote:

> From: Manolis Ragkousis <manolis837@gmail.com>
>
> * gnu/packages/networking.scm (arp-scan): New variable.
> ---
>  gnu/packages/networking.scm | 30 ++++++++++++++++++++++++++++++
>  1 file changed, 30 insertions(+)
>
> diff --git a/gnu/packages/networking.scm b/gnu/packages/networking.scm
> index cc9cc61164..ac67d58541 100644
> --- a/gnu/packages/networking.scm
> +++ b/gnu/packages/networking.scm
> @@ -47,6 +47,7 @@
>  ;;; Copyright © 2021 Milkey Mouse <milkeymouse@meme.institute>
>  ;;; Copyright © 2021 Guillaume Le Vaillant <glv@posteo.net>
>  ;;; Copyright © 2021 Maxime Devos <maximedevos@telenet.be>
> +;;; Copyright © 2022 Manolis Fragkiskos Ragkousis <manolis837@gmail.com>
>  ;;;
>  ;;; This file is part of GNU Guix.
>  ;;;
> @@ -4143,3 +4144,32 @@ (define-public putty
>  implementations.")
>      (home-page "https://www.chiark.greenend.org.uk/~sgtatham/putty/")
>      (license license:expat)))
> +
> +(define-public arp-scan
> +  (package
> +    (name "arp-scan")
> +    (version "1.9.7")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append "https://github.com/royhills/arp-scan/"
> +                           "archive/refs/tags/" version ".tar.gz"))
> +       (sha256
> +        (base32 "0ff0c43rw1b4cm52rx7s6q0wsix3ahjjfhd8wk85nr9wjgj3cg70"))))
> +    (build-system gnu-build-system)
> +    (arguments
> +     `(#:phases
> +       (modify-phases %standard-phases
> +         (replace 'bootstrap
> +           (lambda _
> +             (invoke "autoreconf" "-vfi"))))))
> +    (inputs
> +     (list libpcap))
> +    (native-inputs
> +     (list autoconf automake libtool pkg-config))
> +    (propagated-inputs
> +     (list perl-libwww))
> +    (home-page "https://github.com/royhills/arp-scan")
> +    (synopsis "Dscover and fingerprint IP hosts on the local network
> using ARP")
> +    (description "A tool that uses ARP to discover and fingerprint IP
> hosts on the local network")
> +    (license license:gpl3)))
> --
> 2.33.1
>
>

[-- Attachment #2: Type: text/html, Size: 3382 bytes --]

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [bug#53007] [PATCH] gnu: networking: Add arp-scan
  2022-01-04 15:40 ` Manolis Ragkousis
@ 2022-01-06 11:18   ` Manolis Ragkousis
  0 siblings, 0 replies; 7+ messages in thread
From: Manolis Ragkousis @ 2022-01-06 11:18 UTC (permalink / raw)
  To: 53007

Did anyone have some time to check this?

On 1/4/22 17:40, Manolis Ragkousis wrote:
> This is the correct version. :)
> 
> On Tue, 4 Jan 2022, 17:34 , <manolis837@gmail.com 
> <mailto:manolis837@gmail.com>> wrote:
> 
>     From: Manolis Ragkousis <manolis837@gmail.com
>     <mailto:manolis837@gmail.com>>
> 
>     * gnu/packages/networking.scm (arp-scan): New variable.
>     ---
>       gnu/packages/networking.scm | 30 ++++++++++++++++++++++++++++++
>       1 file changed, 30 insertions(+)
> 
>     diff --git a/gnu/packages/networking.scm b/gnu/packages/networking.scm
>     index cc9cc61164..ac67d58541 100644
>     --- a/gnu/packages/networking.scm
>     +++ b/gnu/packages/networking.scm
>     @@ -47,6 +47,7 @@
>       ;;; Copyright © 2021 Milkey Mouse <milkeymouse@meme.institute>
>       ;;; Copyright © 2021 Guillaume Le Vaillant <glv@posteo.net
>     <mailto:glv@posteo.net>>
>       ;;; Copyright © 2021 Maxime Devos <maximedevos@telenet.be
>     <mailto:maximedevos@telenet.be>>
>     +;;; Copyright © 2022 Manolis Fragkiskos Ragkousis
>     <manolis837@gmail.com <mailto:manolis837@gmail.com>>
>       ;;;
>       ;;; This file is part of GNU Guix.
>       ;;;
>     @@ -4143,3 +4144,32 @@ (define-public putty
>       implementations.")
>           (home-page
>     "https://www.chiark.greenend.org.uk/~sgtatham/putty/
>     <https://www.chiark.greenend.org.uk/~sgtatham/putty/>")
>           (license license:expat)))
>     +
>     +(define-public arp-scan
>     +  (package
>     +    (name "arp-scan")
>     +    (version "1.9.7")
>     +    (source
>     +     (origin
>     +       (method url-fetch)
>     +       (uri (string-append "https://github.com/royhills/arp-scan/
>     <https://github.com/royhills/arp-scan/>"
>     +                           "archive/refs/tags/" version ".tar.gz"))
>     +       (sha256
>     +        (base32
>     "0ff0c43rw1b4cm52rx7s6q0wsix3ahjjfhd8wk85nr9wjgj3cg70"))))
>     +    (build-system gnu-build-system)
>     +    (arguments
>     +     `(#:phases
>     +       (modify-phases %standard-phases
>     +         (replace 'bootstrap
>     +           (lambda _
>     +             (invoke "autoreconf" "-vfi"))))))
>     +    (inputs
>     +     (list libpcap))
>     +    (native-inputs
>     +     (list autoconf automake libtool pkg-config))
>     +    (propagated-inputs
>     +     (list perl-libwww))
>     +    (home-page "https://github.com/royhills/arp-scan
>     <https://github.com/royhills/arp-scan>")
>     +    (synopsis "Dscover and fingerprint IP hosts on the local
>     network using ARP")
>     +    (description "A tool that uses ARP to discover and fingerprint
>     IP hosts on the local network")
>     +    (license license:gpl3)))
>     -- 
>     2.33.1
> 




^ permalink raw reply	[flat|nested] 7+ messages in thread

* [bug#53007] [PATCH] gnu: networking: Add arp-scan
  2022-01-04 15:34 [bug#53007] [PATCH] gnu: networking: Add arp-scan manolis837
  2022-01-04 15:40 ` Manolis Ragkousis
@ 2022-01-11 18:54 ` Leo Famulari
  2022-06-20 21:41 ` manolis837
  2 siblings, 0 replies; 7+ messages in thread
From: Leo Famulari @ 2022-01-11 18:54 UTC (permalink / raw)
  To: manolis837; +Cc: 53007

Thanks for the patch!

On Tue, Jan 04, 2022 at 05:34:15PM +0200, manolis837@gmail.com wrote:
> +    (version "1.9.7")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append "https://github.com/royhills/arp-scan/"
> +                           "archive/refs/tags/" version ".tar.gz"))

This type of tarball is automatically generated by Git / Github based on
the Git tag. However, whenever Github updates their software, the
generated tarballs may change, invalidating our hash. [0]

For that reason, we either use tarballs created by the upstream
developers, or the git-fetch method. For this program, the developers
stopped making tarballs after version 1.9, so we have to use git-fetch
to package 1.9.7.

> +    (build-system gnu-build-system)
> +    (arguments
> +     `(#:phases
> +       (modify-phases %standard-phases
> +         (replace 'bootstrap
> +           (lambda _
> +             (invoke "autoreconf" "-vfi"))))))

The bootstrap phase of gnu-build-system runs autoreconf when 'configure'
is missing. I'm guessing this package was written before
gnu-build-system learned to do that, because the package does build
successfully without this replacement.

> +    (inputs
> +     (list libpcap))
> +    (native-inputs
> +     (list autoconf automake libtool pkg-config))
> +    (propagated-inputs
> +     (list perl-libwww))
> +    (home-page "https://github.com/royhills/arp-scan")
> +    (synopsis "Dscover and fingerprint IP hosts on the local network using ARP")
                  ^
Typo here --------|

> +    (description "A tool that uses ARP to discover and fingerprint IP hosts on the local network")

Descriptions should be written in "complete" sentences. How about the
following?

"Arp-scan is a tool that uses ARP to discover and fingerprint IP hosts
on the local network."

> +    (license license:gpl3)))

The source headers of 'arp-scan.c' say that the program can be
distributed "either version 3 of the License, or (at your option) any
later version." So I think it's gpl3+.

Can you send a revised patch?

[0] https://github.com/libgit2/libgit2/issues/4343




^ permalink raw reply	[flat|nested] 7+ messages in thread

* [bug#53007] [PATCH] gnu: networking: Add arp-scan
  2022-01-04 15:34 [bug#53007] [PATCH] gnu: networking: Add arp-scan manolis837
  2022-01-04 15:40 ` Manolis Ragkousis
  2022-01-11 18:54 ` Leo Famulari
@ 2022-06-20 21:41 ` manolis837
  2022-06-21 11:41   ` bug#53007: " Christopher Baines
  2022-06-25 10:37   ` [bug#53007] " ( via Guix-patches via
  2 siblings, 2 replies; 7+ messages in thread
From: manolis837 @ 2022-06-20 21:41 UTC (permalink / raw)
  To: 53007; +Cc: Manolis Ragkousis

From: Manolis Ragkousis <manolis837@gmail.com>

* gnu/packages/networking.scm (arp-scan): New variable.
---
 gnu/packages/networking.scm | 29 +++++++++++++++++++++++++++++
 1 file changed, 29 insertions(+)

diff --git a/gnu/packages/networking.scm b/gnu/packages/networking.scm
index 065a190321..cb384f23bb 100644
--- a/gnu/packages/networking.scm
+++ b/gnu/packages/networking.scm
@@ -50,6 +50,7 @@
 ;;; Copyright © 2022 Simon South <simon@simonsouth.net>
 ;;; Copyright © 2022 Pierre Langlois <pierre.langlois@gmx.com>
 ;;; Copyright © 2022 Petr Hodina <phodina@protonmail.com>
+;;; Copyright © 2022 Manolis Fragkiskos Ragkousis <manolis837@gmail.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -4259,3 +4260,31 @@ (define-public putty
 implementations.")
     (home-page "https://www.chiark.greenend.org.uk/~sgtatham/putty/")
     (license license:expat)))
+
+(define-public arp-scan
+  (package
+    (name "arp-scan")
+    (version "1.9.7")
+    (source
+     (origin
+       (method git-fetch)
+       (uri
+        (git-reference
+         (url "https://github.com/royhills/arp-scan/")
+         (commit version)))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32 "1mf7a4f9vzvnkiavc87aqyciswggsb4fpy7j05jxnvjyyxv3l7gp"))))
+    (build-system gnu-build-system)
+    (inputs
+     (list libpcap))
+    (native-inputs
+     (list autoconf automake libtool pkg-config))
+    (propagated-inputs
+     (list perl-libwww))
+    (home-page "https://github.com/royhills/arp-scan")
+    (synopsis "Discover and fingerprint IP hosts on the local network
+ using ARP")
+    (description "Arp-scan is a tool that uses ARP to discover and fingerprint IP hosts
+on the local network.")
+    (license license:gpl3+)))
-- 
2.33.1





^ permalink raw reply	[flat|nested] 7+ messages in thread

* bug#53007: [PATCH] gnu: networking: Add arp-scan
  2022-06-20 21:41 ` manolis837
@ 2022-06-21 11:41   ` Christopher Baines
  2022-06-25 10:37   ` [bug#53007] " ( via Guix-patches via
  1 sibling, 0 replies; 7+ messages in thread
From: Christopher Baines @ 2022-06-21 11:41 UTC (permalink / raw)
  To: manolis837; +Cc: 53007-done

[-- Attachment #1: Type: text/plain, Size: 379 bytes --]


manolis837@gmail.com writes:

> From: Manolis Ragkousis <manolis837@gmail.com>
>
> * gnu/packages/networking.scm (arp-scan): New variable.
> ---
>  gnu/packages/networking.scm | 29 +++++++++++++++++++++++++++++
>  1 file changed, 29 insertions(+)

I moved this new package off the bottom of the file, and pushed this as
0fe0c739f53bbb635eb5c4a3b172f4be45293c82.

Thanks,

Chris

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 987 bytes --]

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [bug#53007] [PATCH] gnu: networking: Add arp-scan
  2022-06-20 21:41 ` manolis837
  2022-06-21 11:41   ` bug#53007: " Christopher Baines
@ 2022-06-25 10:37   ` ( via Guix-patches via
  1 sibling, 0 replies; 7+ messages in thread
From: ( via Guix-patches via @ 2022-06-25 10:37 UTC (permalink / raw)
  To: manolis837, 53007

LGTM. I was going to raise the point that 1.9.7 was in 2019, and the
latest commit at the time of writing was made on 2022-06-16, but it
looks like there's not been too many commits between 7f88dc0 "Increment
version to 1.9.7 in preparation for next release." and 840373f "Updated
changelog and IEEE IAB and OUI files."

    -- (




^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2022-06-25 10:38 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-04 15:34 [bug#53007] [PATCH] gnu: networking: Add arp-scan manolis837
2022-01-04 15:40 ` Manolis Ragkousis
2022-01-06 11:18   ` Manolis Ragkousis
2022-01-11 18:54 ` Leo Famulari
2022-06-20 21:41 ` manolis837
2022-06-21 11:41   ` bug#53007: " Christopher Baines
2022-06-25 10:37   ` [bug#53007] " ( via Guix-patches via

Code repositories for project(s) associated with this inbox:

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).