From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id eEfDGMFFrmIC6QAAbAwnHQ (envelope-from ) for ; Sat, 18 Jun 2022 23:38:09 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id 0NjZGMFFrmKJYQEAauVa8A (envelope-from ) for ; Sat, 18 Jun 2022 23:38:09 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 9566D69AB for ; Sat, 18 Jun 2022 23:38:08 +0200 (CEST) Received: from localhost ([::1]:39520 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o2g8t-0005bF-Dt for larch@yhetil.org; Sat, 18 Jun 2022 17:38:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48230) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o2g8o-0005b3-Az for guix-patches@gnu.org; Sat, 18 Jun 2022 17:38:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:56379) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o2g8o-0006S1-2m for guix-patches@gnu.org; Sat, 18 Jun 2022 17:38:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1o2g8n-0004UW-VU for guix-patches@gnu.org; Sat, 18 Jun 2022 17:38:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#56075] [PATCH 0/2] Report location of invalid configuration field values Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 18 Jun 2022 21:38:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 56075 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 56075@debbugs.gnu.org Cc: Ludovic =?UTF-8?Q?Court=C3=A8s?= X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.165558822117189 (code B ref -1); Sat, 18 Jun 2022 21:38:01 +0000 Received: (at submit) by debbugs.gnu.org; 18 Jun 2022 21:37:01 +0000 Received: from localhost ([127.0.0.1]:50276 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o2g7p-0004T0-DV for submit@debbugs.gnu.org; Sat, 18 Jun 2022 17:37:01 -0400 Received: from lists.gnu.org ([209.51.188.17]:46840) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o2g7l-0004Sk-4R for submit@debbugs.gnu.org; Sat, 18 Jun 2022 17:36:59 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47728) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o2g7k-0005QP-UZ for guix-patches@gnu.org; Sat, 18 Jun 2022 17:36:56 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:45052) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o2g7j-0006DI-S0; Sat, 18 Jun 2022 17:36:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:Subject:To:From:in-reply-to: references; bh=6kEeTT6vYh4+B1K/28/3vgoKDBwD/vTEMs0E4lJkfc0=; b=nYIvuPXacuK7Up QAcJAlFiVa428bGMOOuSZbZw0h73t+R0wRGO5lniJ30JDVwTTXhnR4y7utWXlR8mv21d7CbRCUdkZ uLhb0yijZkhp/hybo/CNUpCHSwBSA61ScKQU/WMHglkQjr2EY71yXuEAGB23wXJ3/yZaCr+lENtK+ LL+VSPZKKNCGTh0Bpxp2H/PExb4RIpnMvfo3YAyoHmIQdbuC5iBEgmde130jpbn9+zQJK5n6zEQrf yvozUYqi0jeQIaTTHJMsizbqxPyp00SVTd98Z3DeYL+wJ6HIsEPQXGsH4+mpn3LSg3SnRN9d9BP8/ AgFVNiETUgsV0aDqf7Mw==; Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201]:56130 helo=gnu.org) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o2g7j-0004rO-Fo; Sat, 18 Jun 2022 17:36:55 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Date: Sat, 18 Jun 2022 23:36:40 +0200 Message-Id: <20220618213640.25039-1-ludo@gnu.org> X-Mailer: git-send-email 2.36.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1655588289; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=6kEeTT6vYh4+B1K/28/3vgoKDBwD/vTEMs0E4lJkfc0=; b=fwXS+ur0vcaZJu4dTglU5GS4eNbxOu+CTZPuzNmEytX1Ch2SyxOLdKlm2ZOEn9QtnD0WFV Q+qbKQ7d+4YCsDrB0RPDUGGkURhG3MxqIi07TvqTbaumrFvGfvReBkHLi1L4GB0L0U03tU Z9I8kmyL1StB/qgkPSGKiX28MHQ0GkEvN75ZCI1q5oJ4HvDHK4E06QZOszPqxewxnHLeGt 0PwIJcXoq/owoQxVrpIfgNzm+MivXgugmTOErsL8jJ56AYhbPihuyMpa4SHlmNwbJ6d/am WSr3raRO72eTzaaeb70eMaLBMuWkUlUQbKbVXh0Cg1Hwi0g11LBYqm1p2kOQ5g== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1655588289; a=rsa-sha256; cv=none; b=YtHAAQhXG35/EKsi8kIwHAN77SjQ2mhm4+oshp5/BlJU8zHfOag+uvVDPD7lXHHAdEKpEz UQi17pUwSA0GGRdofNdMpV9TY6Mx60oGp2Yx2BjwigiVSCGD4W2WFtR+mD4Dmfd/0z7D+5 Ysr1VJufvd0GzPn9hNnXyt8LqkTCYlBMmnD6ia6idV2iG8PLhqCRzv++Mc7s15V5+SjaIQ 78ikm9d/AU7r/ik0hu0ZC8gKDKg57NLbEkyeoQTnEsShtyjvaS4vrqK4ryrWIDjzENam91 k+d35riXDB0pgrf7QdVrGb7DwEQh/St6ECAiQ2tkOQ30qL4ItqfINMj7+nZbcg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=nYIvuPXa; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -4.59 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=nYIvuPXa; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 9566D69AB X-Spam-Score: -4.59 X-Migadu-Scanner: scn0.migadu.com X-TUID: ENVH9KbBDIKs Hello Guix! This change has ‘define-configuration’ use the ‘sanitize’ property to type-check fields instead of a custom mechanism. More importantly, it improves error reporting of invalid field value such that instead of: guix home: error: Invalid value for field latitude: "44.81" you get the location of the faulty field value: home-config.scm:391:23: error: invalid value "44.81" for field 'latitude' Additionally the message is now internationalized. Thoughts? Ludo’. Ludovic Courtès (2): services: configuration: Report the location of field type errors. services: configuration: Remove 'validate-configuration'. doc/guix.texi | 6 --- gnu/services/configuration.scm | 64 +++++++++++++++++++++----------- gnu/services/mail.scm | 6 +-- gnu/services/vpn.scm | 2 - po/guix/POTFILES.in | 1 + tests/services/configuration.scm | 12 ++++++ 6 files changed, 57 insertions(+), 34 deletions(-) base-commit: 7f208f68dea828fe02718ca8ce81d5975136cff8 -- 2.36.1