From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id EL6oBs9UpmLBZAAAbAwnHQ (envelope-from ) for ; Sun, 12 Jun 2022 23:04:15 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id gECsBs9UpmKVfgEA9RJhRA (envelope-from ) for ; Sun, 12 Jun 2022 23:04:15 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 9DAC3125EF for ; Sun, 12 Jun 2022 23:04:14 +0200 (CEST) Received: from localhost ([::1]:46426 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o0Ukn-00031S-75 for larch@yhetil.org; Sun, 12 Jun 2022 17:04:13 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36004) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o0Ukc-00031J-VI for guix-patches@gnu.org; Sun, 12 Jun 2022 17:04:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:34453) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o0Ukc-0002Ye-Kf for guix-patches@gnu.org; Sun, 12 Jun 2022 17:04:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1o0Ukc-0005dF-Df for guix-patches@gnu.org; Sun, 12 Jun 2022 17:04:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#55929] [PATCH] gnu: maven: Add maven-doxia-sink-api Resent-From: Julien Lepiller Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 12 Jun 2022 21:04:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55929 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: "Artyom V. Poptsov" Cc: 55929@debbugs.gnu.org Received: via spool by 55929-submit@debbugs.gnu.org id=B55929.165506781121606 (code B ref 55929); Sun, 12 Jun 2022 21:04:02 +0000 Received: (at 55929) by debbugs.gnu.org; 12 Jun 2022 21:03:31 +0000 Received: from localhost ([127.0.0.1]:56583 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o0Uk6-0005cP-PC for submit@debbugs.gnu.org; Sun, 12 Jun 2022 17:03:31 -0400 Received: from lepiller.eu ([89.234.186.109]:40096) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o0Uk3-0005cF-H9 for 55929@debbugs.gnu.org; Sun, 12 Jun 2022 17:03:28 -0400 Received: from lepiller.eu (localhost [127.0.0.1]) by lepiller.eu (OpenSMTPD) with ESMTP id c6809160; Sun, 12 Jun 2022 21:03:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=lepiller.eu; h=date:from :to:cc:subject:message-id:in-reply-to:references:mime-version :content-type:content-transfer-encoding; s=dkim; bh=xDEIAyyTm1+2 HuGAe98Vd6o1k/teaSa6XnRnUeACY3g=; b=QZZuFk/SUfHzC6oWAH9EQAprM+cI SlyRGfTU/RZz3znBNf0WJbG28TlYV/eyfrVsyQSFbMt7YqzeKhhTxgFSC/xt+tlF uZYNT/MnpJSWkoKyzvJuf3+frGZMnDVqXz92VUvtGGUqT1d3Rix7vpv8xEP+QUfO GHVvs6rslNSli6zhuFZt5Xc/c3nnRr49MhgEErmX5aLyAIb77+Gyfgp8D4VnJjnM dSmQmh19a9qqxJp0F/eT8qTRCp9GheNQpHyh5PnfaRyHykWuTLYllPdfgd/TZe/M 9QlTuel7Y6S8cXeBZYAuBrARMTbfIi7ohIL4Qsoih9m7Zx8fOI9g/V02/w== Received: by lepiller.eu (OpenSMTPD) with ESMTPSA id d8cf5c78 (TLSv1.3:AEAD-AES256-GCM-SHA384:256:NO); Sun, 12 Jun 2022 21:03:24 +0000 (UTC) Date: Sun, 12 Jun 2022 23:03:22 +0200 From: Julien Lepiller Message-ID: <20220612230317.547a056f@sybil.lepiller.eu> In-Reply-To: <87czfdyb3j.fsf@gmail.com> References: <87h74pyc1s.fsf@gmail.com> <87czfdyb3j.fsf@gmail.com> X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1655067854; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=D9afi9nmg7twOeDHDpUBZAMe6lo1csZ2aLKqjzSTizY=; b=Wrx11oAGAbnYROmoQdTPvzjvaNtXHoz7hu5Yhmt5x1rBGDyTc5ikvQ3kzeKjXrKKLl8TmE A8UNR0UIuVp3mSG3NKZxKhBXqyk2BhlHD/tijb9NT2xblmdPuC9q7VGFUS5hK2kDDlLdeA xF1XZZqdG+5UkgUxc67lGQKfbQ9RfHWOZ9YINhaE3F185sYCfG0o59gkQr6T0poPML1Ncr Rpc+/q7rb0nnqGJKY+c8q1oet9x7a6eL5F9QKv34QDjS+XIHqDVRLVxH/DOrviK+Fcy2Ql lMVsu4kAapQv93GD7YZ12h51kJDn6yN1OVGsVfLRgILH1A3dg6OBSiT+yZhqjQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1655067854; a=rsa-sha256; cv=none; b=OLRcFZ8cvJ0niTKbDARAQSm9lnp3F4ZP5mNzf4S/rRzjhDAzfLjlXHuqsVhAT+DA0zMBaK GIgBnO1RgC6NTxAhB8h96I5N0PZn5YwlZS6hTLNBNSCSqRbdlOg8V9IvJKu6Mst0O6Rfh8 5VZK90GPA4AmHrEX1EgaKiUstQZU9tz5ivb/qXZs422VIFMippd2BvnOEMh3sJAViKHX8r 8PM70ly19hCdXwgI97JJqLmxnmNZ9/LXpQKAEOXUhpaSvJJC5ErkvzS/5kA1A7VJWP5DQW YLD6cKov1YYOcKCgy6fKzftQF+09TzQ1OT1V6L9dnJ24wusFHP7l6Ji1N4mkhQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=lepiller.eu header.s=dkim header.b="QZZuFk/S"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=lepiller.eu (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 5.71 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=lepiller.eu header.s=dkim header.b="QZZuFk/S"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=lepiller.eu (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 9DAC3125EF X-Spam-Score: 5.71 X-Migadu-Scanner: scn0.migadu.com X-TUID: gsltAtQFX3gR Great to see someone trying to package more maven-related stuff! I think I've seen it in the dependency graph to the maven-plugin-plugin, which I'd like to package at some point to make our life easier. Le Sun, 12 Jun 2022 21:45:36 +0300, "Artyom V. Poptsov" a =C3=A9crit : > From b4020bc283f18d7b7394976c4288d04130f1e651 Mon Sep 17 00:00:00 2001 > From: "Artyom V. Poptsov" > Date: Sun, 12 Jun 2022 21:42:33 +0300 > Subject: [PATCH] gnu: maven: Add maven-doxia-sink-api Here the subject should omit "maven", so simply: gnu: Add maven-doxia-sink-api. >=20 > * gnu/packages/maven.scm (maven-doxia-sink-api): New variable. > --- > gnu/packages/maven.scm | 29 +++++++++++++++++++++++++++++ > 1 file changed, 29 insertions(+) >=20 > diff --git a/gnu/packages/maven.scm b/gnu/packages/maven.scm > index 817fee1c71..93c1538bae 100644 > --- a/gnu/packages/maven.scm > +++ b/gnu/packages/maven.scm > @@ -3,6 +3,7 @@ > ;;; Copyright =C2=A9 2019 Tobias Geerinckx-Rice > ;;; Copyright =C2=A9 2019 Bj=C3=B6rn H=C3=B6fling > ;;; Copyright =C2=A9 2020 Efraim > Flashner +;;; Copyright =C2=A9 2022 Artyom V. > Poptsov ;;; > ;;; This file is part of GNU Guix. > ;;; > @@ -3887,3 +3888,31 @@ reports in two different file formats, plain > text and xml."))) (description "This plugin provides the capability > to build jars. If you would like to sign jars please use the Maven > Jarsigner Plugin instead.") (license license:asl2.0))) > + > +(define-public maven-doxia-sink-api > + (package > + (name "maven-doxia-sink-api") > + (version "2.0.0-M2") > + (source (origin > + (method git-fetch) > + (uri (git-reference > + (url > "https://gitbox.apache.org/repos/asf/maven-doxia.git") > + (commit (string-append "doxia-" version)))) > + (file-name (git-file-name "doxia" version)) > + (sha256 > + (base32 > + > "0jx96lg0hgjsrm8mynhac4hwh2hmgiwjpwpx2k03yr14040zcr48")))) > + (build-system ant-build-system) > + (native-inputs > + (list java-javax-inject)) > + (arguments > + (list #:jar-name "doxia-core.jar" Is this intentional? Shouldn't it be doxia-sink-api.jar? > + #:source-dir "doxia-sink-api/src/main/java" > + #:tests? #f)) ; no tests Also I'm wondering, since this will be used by maven eventually, shouldn't we install it to lib/m2 with its pom file? To do so, we would change the install phase to something like this: (replace 'install (install-from-pom "doxia-sink-api/pom.xml")) This might require a parent-pom (probably the top-level pom.xml and maybe its own parent pom), so you'll have to provide a patch for it as well. You can have a look at (gnu packages maven-parent) for examples. > + (home-page "https://maven.apache.org/doxia/index.html") > + (synopsis "Generic markup language interface") > + (description "The @code{Sink} interface is a generic markup > language +interface provided as a Java API. It contains several > methods that encapsulate +common text syntax. A start tag is denoted > by @code{xxxx()} method and a end +of tag by @code{xxxx_()} method.") The description doesn't follow all our conventions, in particular, double space between sentences :) > + (license license:asl2.0))) Thanks!