unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Brian Kubisiak <brian@kubisiak.com>
To: Maxime Devos <maximedevos@telenet.be>
Cc: 55693@debbugs.gnu.org
Subject: [bug#55693] [PATCH 2/2] gnu: Add gitlint.
Date: Sun, 29 May 2022 14:37:02 -0700	[thread overview]
Message-ID: <20220529213702.jelf6uslxarm3x5k@peregrine> (raw)
In-Reply-To: <971ed4bbb39e323ff0c707efa0a2ef5aa3112de6.camel@telenet.be>

> > +    (propagated-inputs (list git))
>
> Propagtion is not required, a regular input + substitute* 'git' by
> (search-input-file inputs "bin/git") in  gitlint-core/gitlint/shell.py
> should be sufficient.

shell.py only uses the 'subprocess' code path on windows (or if the
GITLINT_USE_SH_LIB environment variable is set, for testing). On
linux, git is called through 'from sh import git' (through the
python-sh library), which will look for git on $PATH and requires this
to be a propagated input.

Thanks,
Brian





  reply	other threads:[~2022-05-29 21:38 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-28 23:53 [bug#55693] [PATCH 0/2] gnu: Add gitlint Brian Kubisiak
2022-05-28 23:55 ` [bug#55693] [PATCH 1/2] gnu: python-sh: Update to 1.14.2 Brian Kubisiak
2022-05-28 23:55 ` [bug#55693] [PATCH 2/2] gnu: Add gitlint Brian Kubisiak
2022-05-29 10:51   ` Maxime Devos
2022-05-29 21:37     ` Brian Kubisiak [this message]
2022-05-29 21:43       ` Maxime Devos
2022-05-30 23:17 ` [bug#55693] [PATCH v2 1/2] gnu: python-sh: Update to 1.14.2 Brian Kubisiak
2022-05-30 23:17 ` [bug#55693] [PATCH v2 2/2] gnu: Add gitlint Brian Kubisiak
2022-06-01 23:04   ` Maxime Devos
2022-06-05 21:19     ` [bug#55693] [PATCH 0/2] " Ludovic Courtès
2022-06-02  1:56 ` [bug#55693] [PATCH v3 1/2] gnu: python-sh: Update to 1.14.2 Brian Kubisiak
2022-06-05 21:25   ` bug#55693: [PATCH 0/2] gnu: Add gitlint Ludovic Courtès
2022-06-02  1:56 ` [bug#55693] [PATCH v3 2/2] " Brian Kubisiak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220529213702.jelf6uslxarm3x5k@peregrine \
    --to=brian@kubisiak.com \
    --cc=55693@debbugs.gnu.org \
    --cc=maximedevos@telenet.be \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).