From: Luis Henrique Gomes Higino <luishenriquegh2701@gmail.com>
To: 55466@debbugs.gnu.org
Cc: luishgh <51053603+luishgh@users.noreply.github.com>
Subject: [bug#55466] [PATCH v2 1/2] gnu: emacs-racer: Update to 1e63e98.
Date: Mon, 16 May 2022 22:48:44 -0300 [thread overview]
Message-ID: <20220517014845.10441-1-luishenriquegh2701@gmail.com> (raw)
In-Reply-To: <20220516234553.24531-1-luishenriquegh2701@gmail.com>
From: luishgh <51053603+luishgh@users.noreply.github.com>
* gnu/packages/emacs-xyz.scm (emacs-racer): Update to 1e63e98.
---
I noticed that this comment above the `fix-failing-tests' build phase
suggests it is not necessary with Emacs 28, so I removed it and the
package built just fine.
gnu/packages/emacs-xyz.scm | 77 +++++++++++++++++---------------------
1 file changed, 34 insertions(+), 43 deletions(-)
diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 8d66278b8f..c8a19e5e9e 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -22487,52 +22487,43 @@ (define-public emacs-adoc-mode
(license license:gpl2+)))
(define-public emacs-racer
- (package
- (name "emacs-racer")
- (version "1.2")
- (source
- (origin
- (method git-fetch)
- (uri
- (git-reference
- (url "https://github.com/racer-rust/emacs-racer")
- (commit version)))
- (file-name (git-file-name name version))
- (sha256
- (base32 "0xj5iki10cg8j8vvqjlw6lfx97k3agwirhchcjnzbnkry48x9qi6"))))
- (arguments
- `(#:tests? #t
- #:test-command '("make" "test")
- #:phases
- (modify-phases %standard-phases
- (add-before 'check 'fix-makefile
- (lambda _
- (substitute* "Makefile"
- (("\\$\\{CASK\\} exec ") ""))
- #t))
- ;; Two tests are failing with Emacs 27, as reported here:
- ;; <https://github.com/racer-rust/emacs-racer/issues/136>. Disable
- ;; them.
- (add-before 'check 'fix-failing-tests
- (lambda _
- (substitute* "test/racer-test.el"
- (("`Write`") "Write")
- (("^\\\\\\[`str\\]:.*") "")
- ((" \\[`str`\\]") " str"))
- #t)))))
- (native-inputs
- (list emacs-ert-runner emacs-undercover))
- (propagated-inputs
- (list emacs-dash emacs-f emacs-pos-tip emacs-rust-mode emacs-s))
- (build-system emacs-build-system)
- (home-page "https://github.com/racer-rust/emacs-racer")
- (synopsis "Racer support for Emacs")
- (description
- "This is the official Emacs package for Racer. It supports code
+ (let ((commit "1e63e98626737ea9b662d4a9b1ffd6842b1c648c")
+ (revision "0"))
+ (package
+ (name "emacs-racer")
+ (version (git-version "1.2" revision commit))
+ (source
+ (origin
+ (method git-fetch)
+ (uri
+ (git-reference
+ (url "https://github.com/racer-rust/emacs-racer")
+ (commit commit)))
+ (file-name (git-file-name name version))
+ (sha256
+ (base32 "12a429lajk09qp1jxgig54p8z6wndfgr4jwdmgkc9s2df9sw02d3"))))
+ (arguments
+ `(#:tests? #t
+ #:test-command '("ert-runner")
+ #:phases
+ (modify-phases %standard-phases
+ ;; Added to replicate original behavior of "make test"
+ (add-after 'build 'test-after-build
+ (lambda _
+ (invoke "ert-runner"))))))
+ (native-inputs
+ (list emacs-ert-runner emacs-undercover))
+ (propagated-inputs
+ (list emacs-dash emacs-f emacs-pos-tip emacs-rust-mode emacs-s))
+ (build-system emacs-build-system)
+ (home-page "https://github.com/racer-rust/emacs-racer")
+ (synopsis "Racer support for Emacs")
+ (description
+ "This is the official Emacs package for Racer. It supports code
completion of variables, functions and modules. It can also jump to
definition of functions and types, and show a help buffer based on the
docstring of the thing at point.")
- (license license:expat)))
+ (license license:expat))))
(define-public emacs-rust-mode
(package
--
2.36.0
next prev parent reply other threads:[~2022-05-17 1:52 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-16 23:45 [bug#55466] [PATCH 0/2] Fix emacs packages failing to build luishgh
2022-05-16 23:45 ` [bug#55467] [PATCH 1/2] gnu: emacs-racer: Update to 1e63e98 luishgh
2022-05-16 23:50 ` [bug#55467] Apologies Luis Henrique Gomes Higino
2022-05-17 7:19 ` [bug#55467] [PATCH 1/2] gnu: emacs-racer: Update to 1e63e98 Nicolas Goaziou
2022-05-16 23:45 ` [bug#55468] [PATCH 2/2] gnu: emacs-explain-pause-mode: Fix failing tests luishgh
2022-05-17 7:19 ` Nicolas Goaziou
2022-05-16 23:49 ` [bug#55466] [PATCH 1/2] gnu: emacs-racer: Update to 1e63e98 luishgh
2022-05-16 23:49 ` [bug#55466] [PATCH 2/2] gnu: emacs-explain-pause-mode: Fix failing tests luishgh
2022-05-17 1:48 ` Luis Henrique Gomes Higino [this message]
2022-05-17 1:48 ` [bug#55466] [PATCH v2 " Luis Henrique Gomes Higino
2022-05-17 7:17 ` Nicolas Goaziou
2022-05-17 14:38 ` Luis Henrique Gomes Higino
2022-05-17 20:02 ` Nicolas Goaziou
2022-05-17 20:24 ` Luis Henrique Gomes Higino
2022-05-17 7:16 ` [bug#55466] [PATCH v2 1/2] gnu: emacs-racer: Update to 1e63e98 Nicolas Goaziou
2022-05-17 7:18 ` bug#55466: [PATCH 0/2] Fix emacs packages failing to build Nicolas Goaziou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220517014845.10441-1-luishenriquegh2701@gmail.com \
--to=luishenriquegh2701@gmail.com \
--cc=51053603+luishgh@users.noreply.github.com \
--cc=55466@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).