unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: jgart via Guix-patches via <guix-patches@gnu.org>
To: Maxim Cournoyer <maxim.cournoyer@gmail.com>
Cc: 50833@debbugs.gnu.org, "Ludovic Courtès" <ludo@gnu.org>,
	"Sarah Morgensen" <iskarian@mgsn.dev>
Subject: [bug#50833] [PATCH] Add Bower (notmuch curses email client)
Date: Thu, 5 May 2022 14:31:10 +0000	[thread overview]
Message-ID: <20220505143110.GB5411@gac> (raw)
In-Reply-To: <878rrzwjj1.fsf_-_@gmail.com>

On Wed, 20 Apr 2022 17:07:46 -0400 Maxim Cournoyer <maxim.cournoyer@gmail.com> wrote:
> Hello,
> 
> Ludovic Courtès <ludo@gnu.org> writes:
> 
> > Hi!
> >
> > jgart <jgart@dismail.de> skribis:
> >
> >> On Thu, 30 Sep 2021 19:11:24 -0700 Sarah Morgensen <iskarian@mgsn.dev> wrote:
> >>> default_html_dump_command = command_prefix(shell_quoted(Lynx), quote_once) :-
> >>>     Lynx = "lynx -dump -force-html -stdin -display-charset=utf-8".
> >>
> >> Hi again,
> >>
> >> If lynx is being detected without needing to be wrapped should I still wrap it?
> >
> > It’s detected if it happens to be in $PATH, otherwise it won’t be found.
> >
> > Like Sarah suggested, I’d recommend using ‘substitute*’ to replace, say,
> > /usr/bin/sendmail by /gnu/store/…/bin/sendmail.  You can grep the code
> > for examples on how to do that; see also:
> >
> >   https://guix.gnu.org/manual/en/html_node/Build-Utilities.html#index-substitute_002a
> >
> > As for Lynx specifically, whether you’d leave it as is (in which case
> > it’s found if and only if it’s in $PATH), or whether you’d use
> > ‘substitute*’ depends on whether it’s an optional dependency or not.  If
> > Bower can gracefully handle lack of Lynx and, for instance, fall back to
> > another rendering method, then perhaps you can leave it as is.
> 
> jgart, could you look into that?  Then we can bring this review to
> completion :-)

Hi Ludo, Maxim,


Thanks for the review and encouragement. Sorry for the delay. I've been
in the process of relocating/starting a new job and haven't been able
to catch up on Guix stuff I have pending.

I spoke with wangp regading Lynx as an optional dependency:

https://github.com/wangp/bower/issues/103

> Like Sarah suggested, I’d recommend using ‘substitute*’ to
replace, say, /usr/bin/sendmail by /gnu/store/…/bin/sendmail.

I can patch sendmail and the others mentioned by Sarah. What should we
do about lynx given wangp's insight on lynx as default in bower?

all best,

jgart





  reply	other threads:[~2022-05-05 14:32 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-26 23:08 [bug#50833] Add bower (it's not what you're thinking) jgart via Guix-patches via
2021-09-26 23:11 ` [bug#50833] [PATCH] gnu: Add bower jgart via Guix-patches via
2021-09-27  1:01   ` Sarah Morgensen
2021-09-29  1:12     ` jgart via Guix-patches via
2021-10-01  2:11       ` Sarah Morgensen
2021-10-01  3:31         ` jgart via Guix-patches via
2021-10-02  7:58         ` jgart via Guix-patches via
2021-10-25  4:32         ` jgart via Guix-patches via
2021-10-25 12:25           ` [bug#50833] Add bower (it's not what you're thinking) Ludovic Courtès
2022-04-20 21:07             ` [bug#50833] [PATCH] Add Bower (notmuch curses email client) Maxim Cournoyer
2022-05-05 14:31               ` jgart via Guix-patches via [this message]
2022-07-07 18:01                 ` Maxim Cournoyer
2022-07-08  0:23                   ` jgart via Guix-patches via
2022-07-08 10:33                     ` Munyoki Kilyungi
2022-07-08 18:47                       ` jgart via Guix-patches via
2022-07-08 19:42                         ` jgart via Guix-patches via
2022-07-14  8:54                           ` Munyoki Kilyungi
2022-07-11 16:09                     ` Maxim Cournoyer
2022-07-15  1:50                       ` jgart via Guix-patches via
2021-09-29  1:12 ` [bug#50833] [PATCH] gnu: Add bower jgart via Guix-patches via
2021-10-01  3:31 ` jgart via Guix-patches via
2022-07-20  5:18 ` [bug#50833] [PATCH v2] " jgart via Guix-patches via
2022-07-20 11:59   ` Maxime Devos
2022-07-24 17:45     ` jgart via Guix-patches via
2022-08-21  6:53 ` [bug#50833] [PATCH v3] " jgart via Guix-patches via
2022-09-02 14:05 ` bug#50833: [PATCH] Add Bower (notmuch curses email client) Maxim Cournoyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220505143110.GB5411@gac \
    --to=guix-patches@gnu.org \
    --cc=50833@debbugs.gnu.org \
    --cc=iskarian@mgsn.dev \
    --cc=jgart@dismail.de \
    --cc=ludo@gnu.org \
    --cc=maxim.cournoyer@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).