unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
* [bug#54572] [PATCH] gnu: solfege: Remove trailing booleans.
@ 2022-03-26  1:15 jgart via Guix-patches via
  2022-03-26  9:14 ` Liliana Marie Prikler
  0 siblings, 1 reply; 3+ messages in thread
From: jgart via Guix-patches via @ 2022-03-26  1:15 UTC (permalink / raw)
  To: 54572; +Cc: jgart

* gnu/packages/music.scm (solfege): Remove trailing booleans.
---
 gnu/packages/music.scm | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm
index 2c6b530aac..d7f0c0d39d 100644
--- a/gnu/packages/music.scm
+++ b/gnu/packages/music.scm
@@ -2058,16 +2058,14 @@ (define-public solfege
                (("/usr/bin/aplay") "aplay")
                (("/usr/bin/timidity") "timidity")
                (("/usr/bin/mpg123") "mpg123")
-               (("/usr/bin/ogg123") "ogg123"))
-             #t))
+               (("/usr/bin/ogg123") "ogg123"))))
          (add-before 'build 'patch-python-shebangs
            (lambda _
              ;; Two python scripts begin with a Unicode BOM, so patch-shebang
              ;; has no effect.
              (substitute* '("solfege/parsetree.py"
                             "solfege/presetup.py")
-               (("#!/usr/bin/python") (string-append "#!" (which "python"))))
-             #t))
+               (("#!/usr/bin/python") (string-append "#!" (which "python"))))))
          (add-before 'build 'add-sitedirs
            ;; .pth files are not automatically interpreted unless the
            ;; directories containing them are added as "sites".  The directories
-- 
2.34.0





^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [bug#54572] [PATCH] gnu: solfege: Remove trailing booleans.
  2022-03-26  1:15 [bug#54572] [PATCH] gnu: solfege: Remove trailing booleans jgart via Guix-patches via
@ 2022-03-26  9:14 ` Liliana Marie Prikler
  2022-03-29  8:57   ` bug#54572: " Mathieu Othacehe
  0 siblings, 1 reply; 3+ messages in thread
From: Liliana Marie Prikler @ 2022-03-26  9:14 UTC (permalink / raw)
  To: jgart, 54572

Hi jgart

Am Freitag, dem 25.03.2022 um 21:15 -0400 schrieb jgart:
> * gnu/packages/music.scm (solfege): Remove trailing booleans.
> ---
>  gnu/packages/music.scm | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm
> index 2c6b530aac..d7f0c0d39d 100644
> --- a/gnu/packages/music.scm
> +++ b/gnu/packages/music.scm
> @@ -2058,16 +2058,14 @@ (define-public solfege
>                 (("/usr/bin/aplay") "aplay")
>                 (("/usr/bin/timidity") "timidity")
>                 (("/usr/bin/mpg123") "mpg123")
> -               (("/usr/bin/ogg123") "ogg123"))
> -             #t))
> +               (("/usr/bin/ogg123") "ogg123"))))
>           (add-before 'build 'patch-python-shebangs
>             (lambda _
>               ;; Two python scripts begin with a Unicode BOM, so
> patch-shebang
>               ;; has no effect.
>               (substitute* '("solfege/parsetree.py"
>                              "solfege/presetup.py")
> -               (("#!/usr/bin/python") (string-append "#!" (which
> "python"))))
> -             #t))
> +               (("#!/usr/bin/python") (string-append "#!" (which
> "python"))))))
Questionable uses of which.

It'd also be nice if you could update arguments to be a list of G-
expressions and do all the other modernizations.

Cheers




^ permalink raw reply	[flat|nested] 3+ messages in thread

* bug#54572: [PATCH] gnu: solfege: Remove trailing booleans.
  2022-03-26  9:14 ` Liliana Marie Prikler
@ 2022-03-29  8:57   ` Mathieu Othacehe
  0 siblings, 0 replies; 3+ messages in thread
From: Mathieu Othacehe @ 2022-03-29  8:57 UTC (permalink / raw)
  To: Liliana Marie Prikler; +Cc: 54572-done, jgart


Hey,

> Questionable uses of which.
>
> It'd also be nice if you could update arguments to be a list of G-
> expressions and do all the other modernizations.

That can come in a follow-up patch, pushed that one in the meantime.

Thanks,

Mathieu




^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2022-03-29  8:58 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-03-26  1:15 [bug#54572] [PATCH] gnu: solfege: Remove trailing booleans jgart via Guix-patches via
2022-03-26  9:14 ` Liliana Marie Prikler
2022-03-29  8:57   ` bug#54572: " Mathieu Othacehe

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).