From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id 6CNYKEY0O2K1YwAAgWs5BA (envelope-from ) for ; Wed, 23 Mar 2022 15:52:54 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id oOLeJUY0O2IzbQEA9RJhRA (envelope-from ) for ; Wed, 23 Mar 2022 15:52:54 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id CD2D2393EB for ; Wed, 23 Mar 2022 15:52:15 +0100 (CET) Received: from localhost ([::1]:45394 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nX2LO-0002Cy-Bm for larch@yhetil.org; Wed, 23 Mar 2022 10:52:14 -0400 Received: from eggs.gnu.org ([209.51.188.92]:42556) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nX2GN-0003aJ-9K for guix-patches@gnu.org; Wed, 23 Mar 2022 10:47:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:51586) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nX2GN-0007SA-03 for guix-patches@gnu.org; Wed, 23 Mar 2022 10:47:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nX2GL-0002Wl-Uh for guix-patches@gnu.org; Wed, 23 Mar 2022 10:47:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#54529] [PATCH v3] Added orca-lang package References: <20220322224614.5605-1-yewscion@gmail.com> In-Reply-To: <20220322224614.5605-1-yewscion@gmail.com> Resent-From: Christopher Rodriguez Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 23 Mar 2022 14:47:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54529 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 54529@debbugs.gnu.org Cc: Christopher Rodriguez Received: via spool by 54529-submit@debbugs.gnu.org id=B54529.16480467839663 (code B ref 54529); Wed, 23 Mar 2022 14:47:01 +0000 Received: (at 54529) by debbugs.gnu.org; 23 Mar 2022 14:46:23 +0000 Received: from localhost ([127.0.0.1]:45483 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nX2Fd-0002Vg-RC for submit@debbugs.gnu.org; Wed, 23 Mar 2022 10:46:23 -0400 Received: from mail-qk1-f175.google.com ([209.85.222.175]:36378) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nX2Fc-0002VT-Kw for 54529@debbugs.gnu.org; Wed, 23 Mar 2022 10:46:17 -0400 Received: by mail-qk1-f175.google.com with SMTP id v13so1188800qkv.3 for <54529@debbugs.gnu.org>; Wed, 23 Mar 2022 07:46:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=kQUWfN6gFuXkfyXoCFnV3AEUxy8gD98vQSIs8H7hpTU=; b=bI+wk8J/b/3PmgqppA6HO2bpNPBRyQ8avoFJXNBXbQp09MsncJDhkY7JfiGu5dXiHn oeJqYlPdQE7W4lf82DH1ECCg/9TWzJnGzrN2/KKzOB21FnFggaMXw90V7LlLx3WZcBad 0jTPM8ujIj1tDpisOTvHq/9pTMRIxqKscQHajjHWnEAG4F9nO6zs+to/BUOnwRiKMReT +fKl03pBoqkEpEPdw35FQE+8ONNTn9p7sxnefI9KXmv0BecTQ6KEnrCH+6l1CoKt6W8/ xi5PGIsa9HKkhDrPZoMyC6Iv8uYG7KeQgwnwHLKK70QXnBle/ZfZOQJmmTBI9+P68XMI MjtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=kQUWfN6gFuXkfyXoCFnV3AEUxy8gD98vQSIs8H7hpTU=; b=MbymVVHJP6cKcfhiMr5HumcfYCPQIEHynTO+QeOJ0MBr3oJGd0nSlfW1QHfc5CBV+M 2NiifO9OKubgOGksb7wpX5jSHGpVFiBXsRCCrvfD7oBefGnuyvRKXC5V1hBMNF+WOhIF rMfMj0OdQwxpyiOmCRu523bAaK/TouhbFg9HcVH4rgbgzAgWfaPfM3Ryils/v/euNyUA VlmPvm2NMZLrr9LFiuTbpBL8i6Pv5Q+8NCmKOMydwNm16McvmwyIOMtNvFmVzMLSfzcG g8BV/8Yiw7vBNlRrG5I6tKl8bJ2B3mO3bGoLevJnAhnfJdcVUBsCAKp9x/HCO1txg23h XXqQ== X-Gm-Message-State: AOAM5310AO6rlJwVsca8kiNntBJBmB6YluTWhGKhpoPfruiX5UYJZDCt JS5DMIzeXSyeroof/BHy2Lw2E/bxFJU= X-Google-Smtp-Source: ABdhPJzCoDyyYeqi2FDVNIUInKa4w4ZwzSpVuOsVSCBMZZ6D8GC59/ykfeZwiLkuEflYrK2jvotDuQ== X-Received: by 2002:a37:410:0:b0:67d:ddd4:77d0 with SMTP id 16-20020a370410000000b0067dddd477d0mr87567qke.620.1648046770565; Wed, 23 Mar 2022 07:46:10 -0700 (PDT) Received: from gorse.members.linode.com ([2600:3c03::f03c:92ff:fec0:a2d7]) by smtp.gmail.com with ESMTPSA id k13-20020a05622a03cd00b002e21621c243sm169741qtx.39.2022.03.23.07.46.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Mar 2022 07:46:09 -0700 (PDT) From: Christopher Rodriguez Date: Wed, 23 Mar 2022 10:45:47 -0400 Message-Id: <20220323144547.23041-1-yewscion@gmail.com> X-Mailer: git-send-email 2.34.0 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1648047135; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=kQUWfN6gFuXkfyXoCFnV3AEUxy8gD98vQSIs8H7hpTU=; b=X4VpCbr82JHPck8DQq9ay2b0ZuGoBt+EO6qTs+zmmBHoWI7L1UBplEFIJLAwjh+E1ehoxh mDSk/8F8ALie0i19N8MumzsrIV05HUuD/HlRmQyp67g3c+dDG/0Q1znd3ieNTyhOf/snd6 kiPfjq8c1uz3Td95QOxtSPOahxY/4P92qa2EgBjiq9oApbOSKGCAtqJ4baVWALEdvyMqsd IHR6RtzuNu1gBAAEimU+AAJNtjXVIxACxAmf0UtFgX/cVKFSmiiY9DJDe3IxYWu0eb9BIE ZyOPeHck6Smx4UpmxxcOSOXvpomygkfeuPxNX20aFrDJj05M0EU7WMxtpCMWYA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1648047135; a=rsa-sha256; cv=none; b=gu7G+nwn6qCo7sVIMyUkxwRkO+8+7ZjJqOhXAqABYVL13bTFgLqnatxz+7RUnpRuYmRAsQ EJjyQZakg6M194YxYDIRWkneOxVS5rtWpzhNWgdbtmWnWhSsaCmoKCQtQZDTzqWfw6kPeh CulxpfSw3aJsLnRIZH9yhP440PIJtQQ5We3SYzEO1YmiVBjyzT5Slhw6U+Ky55QfgwaMBC +v3FTHmy2AAbH1nv8H+n5zkV7NMA1NgwLb8126Mf6pjn3bVeEvhAyOAwejdUM81OQEXkzB KLiFOoYqRcHLl9zXQk8hBWbuGLd2F50CXRVmSGn/zmbCo4YwQXTIQLECrlCkNA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b="bI+wk8J/"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 10.91 X-Spam: Yes Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b="bI+wk8J/"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: CD2D2393EB X-Spam-Score: 10.91 X-Migadu-Spam: Yes X-Migadu-Scanner: scn0.migadu.com X-TUID: rJttqcBYSrCJ --- > This is broken when cross-compiling, try 'cc-for-target'. > Additionally, 'outputs' and 'inputs' are unused here. > Why? > Why the capital letters? And why mention ‘Esoteric’ in the synopsis and > description? Also, it is not actually a programming language, it is > more an implementation of a language for producing music. > This is not texinfo markup. > Personally I'd go with "orca-music". > I don't think that abbreviations are necessary here, these's enough > space here. > Spacing went wrong here, try running "./pre-inst-env guix style" on the > package. > This seems rather confusing naming. Libraries are put in [...]/lib, > not [...]/share. Alsso, I think you could drop the 'dest-' prefix > here. > Phases do not need to return #f anymore. All of the above were amended as written in this version of the patch. > Why are these phases deleted? Went back and audited the phases I initially deleted; Two remain deleted in this patch: configure, and check. This is due to the package not using a configure script, nor having any 'check' defined for make. > Why are these propagated? I've propagated both alsa-plugins and alsa-plugins:pulseaudio because this package using portmidi for midi output, and needs to load the `libasound_module_conf_pulse.so` shared library to interface with MIDI when using `pulseaudio`. Is there another way to do this without propagating these? > Where does this revision come from? This is the first version of orca > in Guix. The revision was in my personal channel; I kept bumping the revision number because I needed to recompile the package, and `guix build -f` would assume the package was already compiled. I've reverted it to revision 1. > "git" is not a version numberr, I suggest "0" instead. > Also, why is a ‘random’ git commit used instead of an upstream version? The upstream package at https://git.sr.ht/~rabbits/orca does not have any tags, let alone version tags. And as near as I can tell, it does not use semantic versioning at all. I used "git" because of my experience with rpm packaging; I have changed this to 0 here, to align with Guix conventions. > Is it agpl3-only or agpl3+? It is actually expat; apparently I neglected to update this field when defining this package. I have fixed this here. > If you do this, you'll have to add the native-search-paths of ncurses > to orca-lang, because of https://issues.guix.gnu.org/issue/22138. Discussed this with maximed on #guix. When I tried to apply `(package-native-search-paths ncurses)` it introduced a bunch of undefined variable errors. This may be due to cyclic imports; either way, it seems to be an issue outside the scope of this package. I've chosen to instead explicitly define the same native search path (namely, for TERMINFO_DIRS) as ncurses in this package, to work around this bug. Here's the patch. Let me know what else can be improved. Particularly, I am worried about the name of the binary. It is currently installed as `orca`, which is (I believe) the same name given to the binary for the orca screen reader. Should I change this? And if so, how? gnu/packages/music.scm | 57 ++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 57 insertions(+) diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm index 9c8203aa80..1240027050 100644 --- a/gnu/packages/music.scm +++ b/gnu/packages/music.scm @@ -6879,3 +6879,60 @@ (define-public musikcube streaming audio server.") (home-page "https://musikcube.com/") (license license:bsd-3))) +(define-public orca-music + (let ((commit "5ba56ca67baae3db140f8b7a2b2fc46bbac5602f") (revision "1")) + (package + (name "orca-music") + ;; No upstream version numbers; Using commit instead. + (version (git-version "0" revision commit)) + (source (origin + (method git-fetch) + (uri (git-reference + (url "https://git.sr.ht/~rabbits/orca") + (commit commit))) + (file-name (git-file-name name version)) + (sha256 + (base32 + "1mnhk68slc6g5y5348vj86pmnz90a385jxvm3463fic79k90gckd")))) + (build-system gnu-build-system) + (arguments + `(#:phases (modify-phases %standard-phases + (delete 'configure) ;; No autoconf + (delete 'check) ;; No make check + (replace 'build + (lambda* (#:key inputs outputs #:allow-other-keys) + (setenv "CC" + ,(cc-for-target)) + (invoke "make" "release"))) + (replace 'install + (lambda* (#:key outputs #:allow-other-keys) + (let* ((out (assoc-ref outputs "out")) (dest-bin (string-append + out + "/bin")) + (share (string-append out "/share")) + (dest-examples (string-append share "/examples")) + (dest-doc (string-append share "/doc"))) + (install-file "./build/orca" dest-bin) + (copy-recursively "./examples" dest-examples) + (install-file "./README.md" dest-doc))))))) + (inputs (list ncurses portmidi)) + (native-inputs (list pkg-config)) + ;; The below are needed as propagated inputs to let orca interact with + ;; alsa/pulse MIDI. + (propagated-inputs `(("alsa-plugins" ,alsa-plugins) ("alsa-plugins:pulseaudio" ,alsa-plugins + "pulseaudio"))) + (native-search-paths (list + (search-path-specification + (variable "TERMINFO_DIRS") + (files '("share/terminfo"))))) + (synopsis "musical live-coding environment") + (description + "This is the C implementation of the ORCΛ language and terminal +livecoding environment. It's designed to be power efficient. It can handle +large files, even if your terminal is small. + +Orca is not a synthesizer, but a flexible livecoding environment capable of +sending MIDI, OSC, and UDP to your audio/visual interfaces like Ableton, +Renoise, VCV Rack, or SuperCollider.") + (home-page "https://100r.co/site/orca.html") + (license license:expat)))) -- 2.34.0