[bug#54362] [PATCH] gnu: cl-find-port: Update to 20190601.

[bug#54362] [PATCH] gnu: cl-find-port: Update to 20190601.

[jgart via Guix-patches via]

* gnu/packages/lisp-xyz.scm (cl-find-port): Update to 20190601.
[version]: Use git-version function with date of commit.
---
 gnu/packages/lisp-xyz.scm | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/gnu/packages/lisp-xyz.scm b/gnu/packages/lisp-xyz.scm
index fc18742e3c..53aa9c6ae5 100644
--- a/gnu/packages/lisp-xyz.scm
+++ b/gnu/packages/lisp-xyz.scm
@@ -5120,12 +5120,12 @@ (define-public cl-verbose
   (sbcl-package->cl-source-package sbcl-verbose))
 
 (define-public sbcl-find-port
-  (let ((commit "00c96a25af93a0f8681d34ec548861f2d7485478")
-        (revision "1"))
+  (let ((commit "811727f88d7f000623bf92fdb0e64678a7112a28")
+        (revision "2"))
     (package
       (name "sbcl-find-port")
       (build-system asdf-build-system/sbcl)
-      (version "0.1")
+      (version (git-version "20190601" revision commit))
       (home-page "https://github.com/eudoxia0/find-port")
       (source
        (origin
@@ -5136,7 +5136,7 @@ (define-public sbcl-find-port
          (file-name (git-file-name name version))
          (sha256
           (base32
-           "0d6dzbb45jh0rx90wgs6v020k2xa87mvzas3mvfzvivjvqqlpryq"))))
+           "1fw6q7d2bxxb7fqk548ylq8mx4sz95yc0q5h0rwd0mnqjrbwbari"))))
       (native-inputs
        (list sbcl-fiveam))
       (inputs
-- 
2.35.1

[bug#54362] [PATCH] gnu: cl-find-port: Update to 20190601.

[Tobias Geerinckx-Rice via Guix-patches via]

On 12 March 2022 23:18:08 UTC, jgart via Guix-patches via <guix-patches@gnu.org> wrote:
> (define-public sbcl-find-port
>-  (let ((commit "00c96a25af93a0f8681d34ec548861f2d7485478")
>-        (revision "1"))
>+  (let ((commit "811727f88d7f000623bf92fdb0e64678a7112a28")
>+        (revision "2"))

LGTM.

>-      (version "0.1")
>+      (version (git-version "20190601" revision commit))

Err... LNSGTM.  Why?  I can't find a justification for this upstream.

If there is one, please always add it as comment.

Otherwise, it should remain 0.1 but (indeed) with git-version which should have been there from the start.
Hi jgart,

Thanks!

T G-R

Sent on the go.  Excuse or enjoy my brevity.

[bug#54362] [PATCH] gnu: cl-find-port: Update to 20190601.

[jgart via Guix-patches via]

On Sat, 12 Mar 2022 23:27:09 +0000 Tobias Geerinckx-Rice <me@tobias.gr> wrote:
> If there is one, please always add it as comment.

Hi Tobias!

I'll make sure to add a comment in the future for packages that don't
have version numbers.

It seems like a fairly common practice in the common lisp community to
not make version releases though.

Do you need me to send a v2 with the comment?

> Otherwise, it should remain 0.1 but (indeed) with git-version which should have been there from the start.
> Hi jgart,

There's no mention of 0.1 in the current commit. Is it a Guix convention
to use 0.1 when we don't know the version of the package and only have
a particular commit?

all best,

jgart

[bug#54362] [PATCH] gnu: cl-find-port: Update to 20190601.

[Guillaume Le Vaillant]

[-- Attachment #1: Type: text/plain, Size: 337 bytes --]

jgart via Guix-patches via <guix-patches@gnu.org> skribis:

> There's no mention of 0.1 in the current commit. Is it a Guix convention
> to use 0.1 when we don't know the version of the package and only have
> a particular commit?

Hi,

In the "find-port.asd" file, the find-port system definition has a field
indicating ":version 0.1".

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 247 bytes --]

bug#54362: [PATCH] gnu: cl-find-port: Update to 20190601.

[Raghav Gururajan via Guix-patches via]

[-- Attachment #1.1: Type: text/plain, Size: 348 bytes --]

I agree with T G-R. It should have been git-version from the beginning. 
Also, for packages with no releases, we usually start version and 
revision with "0", and increment revision by one for every update. Not 
sure why the version was started with "0.1", but lets keep it that way 
for now. :)

Pushed as 1a36fb51a8..f69727278b to master.

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 236 bytes --]

[bug#54362] [PATCH v2] gnu: cl-find-port: Update to 242cfc6.

[jgart via Guix-patches via]

* gnu/packages/lisp-xyz.scm (cl-find-port): Update to 242cfc6.
[version]: Use git-version function with version stated in asd file.
---
Hi all,

Thanks for the review. It is much appreciated.

Here is a v2 of the requested changes.

Guillaume, thanks for pointing out the version number in the asd file.

That version number is from 7 years ago according to `git blame` but if
you think we should still use it that is fine with me. I think the author
is probably just not making version releases and just releasing commits.

all best,

jgart

 gnu/packages/lisp-xyz.scm | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/gnu/packages/lisp-xyz.scm b/gnu/packages/lisp-xyz.scm
index fc18742e3c..b95466d93b 100644
--- a/gnu/packages/lisp-xyz.scm
+++ b/gnu/packages/lisp-xyz.scm
@@ -5120,12 +5120,12 @@ (define-public cl-verbose
   (sbcl-package->cl-source-package sbcl-verbose))
 
 (define-public sbcl-find-port
-  (let ((commit "00c96a25af93a0f8681d34ec548861f2d7485478")
-        (revision "1"))
+  (let ((commit "811727f88d7f000623bf92fdb0e64678a7112a28")
+        (revision "2"))
     (package
       (name "sbcl-find-port")
       (build-system asdf-build-system/sbcl)
-      (version "0.1")
+      (version (git-version "0.1" revision commit))
       (home-page "https://github.com/eudoxia0/find-port")
       (source
        (origin
@@ -5136,7 +5136,7 @@ (define-public sbcl-find-port
          (file-name (git-file-name name version))
          (sha256
           (base32
-           "0d6dzbb45jh0rx90wgs6v020k2xa87mvzas3mvfzvivjvqqlpryq"))))
+           "1fw6q7d2bxxb7fqk548ylq8mx4sz95yc0q5h0rwd0mnqjrbwbari"))))
       (native-inputs
        (list sbcl-fiveam))
       (inputs
-- 
2.35.1