From: Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org>
To: 54323@debbugs.gnu.org
Subject: [bug#54323] [PATCH] Add font-google-roboto-mono
Date: Fri, 11 Mar 2022 15:57:57 +0100 [thread overview]
Message-ID: <20220311155757.424f9fc1@primarylaptop.localdomain> (raw)
In-Reply-To: <CAP+X-ca=SFUnTDuE+-3tMsJG9v+-Kny0kqvAJt+EME5Pkwuwig@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 918 bytes --]
Hi,
Thanks for working on this patch.
Note that I'm not a Guix maintainer (I only managed to send some patches
and get them accepted), but I've seen several things to fix in this
patch and I've also some questions:
- You used 'license:asl2.0' as the license, while looking rapidly at
the source I didn't find any license. Do you know where the license
is stated in the font source code?
- If you really want to fix font-adobe-source-code-pro and font-dseg
code style, it should be done in one or two separate patches. Two
patches are probably easier for maintainers to review.
- I've also noticed that this patch lacks any commit message details.
Something like that should work:
gnu: Add font-google-roboto-mono
* gnu/packages/fonts.scm (font-google-roboto-mono): New variable.
Also there may or may not be additional issues as I've only looked at
it rapidly.
Denis.
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2022-03-11 14:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-09 21:02 [bug#54323] [PATCH] Add font-google-roboto-mono remimimimi
2022-03-11 14:57 ` Denis 'GNUtoo' Carikli [this message]
2022-03-18 14:03 ` [bug#54323] remimimimi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220311155757.424f9fc1@primarylaptop.localdomain \
--to=gnutoo@cyberdimension.org \
--cc=54323@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).