[bug#53825] [PATCH] gnu: Add sbase.

[bug#53825] [PATCH] gnu: Add sbase.

[jgart via Guix-patches via]

* gnu/packages/suckless.scm (sbase): New variable.
---
 gnu/packages/suckless.scm | 32 ++++++++++++++++++++++++++++++++
 1 file changed, 32 insertions(+)

diff --git a/gnu/packages/suckless.scm b/gnu/packages/suckless.scm
index 708eb2c338..af7c0a8801 100644
--- a/gnu/packages/suckless.scm
+++ b/gnu/packages/suckless.scm
@@ -988,6 +988,38 @@ (define-public snooze
 running a command.")
     (license license:cc0)))
 
+(define-public sbase
+  (let ((commit "2c2a7f54ab55a022a617e510b6e00c3e2736fabd")
+        (revision "0"))
+    (package
+      (name "sbase")
+      (version (git-version "0" revision commit))
+      (source
+       (origin
+         (method git-fetch)
+         (uri
+          (git-reference
+           (url "https://github.com/dylanaraps/sbase")
+           (commit commit)))
+         (file-name (git-file-name name version))
+         (sha256
+          (base32 "119v1lpgsx8bx9h57wg454ddhzz2awqavl3wrn35a704vifg28g0"))))
+      (build-system gnu-build-system)
+      (arguments
+       `(#:tests? #f ; There are no tests.
+         #:make-flags
+         (list (string-append "CC=" ,(cc-for-target))
+               (string-append "PREFIX=" %output))
+         #:phases
+         (modify-phases %standard-phases
+           (delete 'configure))))
+      (home-page "https://core.suckless.org/sbase/")
+      (synopsis "Collection of unix tools that are portable across unix-systems")
+      (description
+  "@command{sbase} is a collection of unix tools that are portable across
+  unix-systems.")
+      (license license:expat))))
+
 (define-public scron
   (package
     (name "scron")
-- 
2.35.0

[bug#53825] [PATCH] gnu: Add sbase.

[Xinglu Chen]

[-- Attachment #1: Type: text/plain, Size: 2836 bytes --]

jgart via schrieb am Sonntag der 06. Februar 2022 um 12:56 -05:

> * gnu/packages/suckless.scm (sbase): New variable.
> ---
>  gnu/packages/suckless.scm | 32 ++++++++++++++++++++++++++++++++
>  1 file changed, 32 insertions(+)
>
> diff --git a/gnu/packages/suckless.scm b/gnu/packages/suckless.scm
> index 708eb2c338..af7c0a8801 100644
> --- a/gnu/packages/suckless.scm
> +++ b/gnu/packages/suckless.scm
> @@ -988,6 +988,38 @@ (define-public snooze
>  running a command.")
>      (license license:cc0)))
>  
> +(define-public sbase
> +  (let ((commit "2c2a7f54ab55a022a617e510b6e00c3e2736fabd")
> +        (revision "0"))

What’s the reason for using a specific commit instead of a tag?  There
should be a comment about this.

> +    (package
> +      (name "sbase")
> +      (version (git-version "0" revision commit))
> +      (source
> +       (origin
> +         (method git-fetch)
> +         (uri
> +          (git-reference
> +           (url "https://github.com/dylanaraps/sbase")

The homepage points to <https://git.suckless.org/sbase/>.  This Github
repo seems to be private or deleted.  Guix wasn’t able to clone it.

--8<---------------cut here---------------start------------->8---
fatal: could not read Username for 'https://github.com': No such device or address
Failed to do a shallow fetch; retrying a full fetch...
fatal: could not read Username for 'https://github.com': No such device or address
git-fetch: '/gnu/store/avdv1l8zyfnjm8z5f9c4y5fgncqb03zc-git-minimal-2.34.0/bin/git fetch origin' failed with exit code 128
--8<---------------cut here---------------end--------------->8---

> +           (commit commit)))
> +         (file-name (git-file-name name version))
> +         (sha256
> +          (base32 "119v1lpgsx8bx9h57wg454ddhzz2awqavl3wrn35a704vifg28g0"))))
> +      (build-system gnu-build-system)
> +      (arguments
> +       `(#:tests? #f ; There are no tests.
> +         #:make-flags
> +         (list (string-append "CC=" ,(cc-for-target))
> +               (string-append "PREFIX=" %output))

Use gexps instead (untested)

  ,#~(list (string-append "CC=" #$(cc-for-target))
           (string-append "PREFIX=" #$output))
        
> +         #:phases
> +         (modify-phases %standard-phases
> +           (delete 'configure))))
> +      (home-page "https://core.suckless.org/sbase/")
> +      (synopsis "Collection of unix tools that are portable across unix-systems")

Capitalize “unix”.

> +      (description
> +  "@command{sbase} is a collection of unix tools that are portable across
> +  unix-systems.")

Likewise

> +      (license license:expat))))

LICENSE says MIT/X Consortium[1], so it should be ‘license:x11’

[1]: <https://en.wikipedia.org/wiki/MIT_License#Minor_ambiguity_and_variants>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 861 bytes --]

[bug#53825] [PATCH v2] gnu: Add sbase.

[jgart via Guix-patches via]

* gnu/packages/suckless.scm (sbase): New variable.
---

Hi Xinglu,

Not sure how dylanaraps got in that url... :)

Something bugged out or I didn't notice.

Anyways here is version 2 with all of your suggestions. 

Thanks for the review, Much appreciated!

all best,

jgart

 gnu/packages/suckless.scm | 33 +++++++++++++++++++++++++++++++++
 1 file changed, 33 insertions(+)

diff --git a/gnu/packages/suckless.scm b/gnu/packages/suckless.scm
index 708eb2c338..6aedb2b3ba 100644
--- a/gnu/packages/suckless.scm
+++ b/gnu/packages/suckless.scm
@@ -988,6 +988,39 @@ (define-public snooze
 running a command.")
     (license license:cc0)))
 
+(define-public sbase
+  ;; There are no tagged releases.
+  (let ((commit "2c2a7f54ab55a022a617e510b6e00c3e2736fabd")
+        (revision "0"))
+    (package
+      (name "sbase")
+      (version (git-version "0" revision commit))
+      (source
+       (origin
+         (method git-fetch)
+         (uri
+          (git-reference
+           (url "https://git.suckless.org/sbase/")
+           (commit commit)))
+         (file-name (git-file-name name version))
+         (sha256
+          (base32 "119v1lpgsx8bx9h57wg454ddhzz2awqavl3wrn35a704vifg28g0"))))
+      (build-system gnu-build-system)
+      (arguments
+       `(#:tests? #f ; There are no tests.
+         #:make-flags
+         ,#~(list (string-append "CC=" #$(cc-for-target))
+                  (string-append "PREFIX=" #$output))
+         #:phases
+         (modify-phases %standard-phases
+           (delete 'configure))))
+      (home-page "https://core.suckless.org/sbase/")
+      (synopsis "Collection of unix tools that are portable across unix-systems")
+      (description
+  "@command{sbase} is a collection of Unix tools that are portable across
+  Unix-systems.")
+      (license license:x11))))
+
 (define-public scron
   (package
     (name "scron")
-- 
2.35.0

[bug#53825] [PATCH v2] gnu: Add sbase.

[Xinglu Chen]

[-- Attachment #1: Type: text/plain, Size: 2102 bytes --]

Hi,

jgart schrieb am Sonntag der 06. Februar 2022 um 21:17 -05:

> * gnu/packages/suckless.scm (sbase): New variable.
> ---
>
> Hi Xinglu,
>
> Not sure how dylanaraps got in that url... :)
>
> Something bugged out or I didn't notice.
>
> Anyways here is version 2 with all of your suggestions. 
>
> Thanks for the review, Much appreciated!
>
> all best,
>
> jgart
>
>  gnu/packages/suckless.scm | 33 +++++++++++++++++++++++++++++++++
>  1 file changed, 33 insertions(+)
>
> diff --git a/gnu/packages/suckless.scm b/gnu/packages/suckless.scm
> index 708eb2c338..6aedb2b3ba 100644
> --- a/gnu/packages/suckless.scm
> +++ b/gnu/packages/suckless.scm
> @@ -988,6 +988,39 @@ (define-public snooze
>  running a command.")
>      (license license:cc0)))
>  
> +(define-public sbase
> +  ;; There are no tagged releases.
> +  (let ((commit "2c2a7f54ab55a022a617e510b6e00c3e2736fabd")
> +        (revision "0"))
> +    (package
> +      (name "sbase")
> +      (version (git-version "0" revision commit))
> +      (source
> +       (origin
> +         (method git-fetch)
> +         (uri
> +          (git-reference
> +           (url "https://git.suckless.org/sbase/")
> +           (commit commit)))
> +         (file-name (git-file-name name version))
> +         (sha256
> +          (base32 "119v1lpgsx8bx9h57wg454ddhzz2awqavl3wrn35a704vifg28g0"))))
> +      (build-system gnu-build-system)
> +      (arguments
> +       `(#:tests? #f ; There are no tests.
> +         #:make-flags
> +         ,#~(list (string-append "CC=" #$(cc-for-target))
> +                  (string-append "PREFIX=" #$output))
> +         #:phases
> +         (modify-phases %standard-phases
> +           (delete 'configure))))
> +      (home-page "https://core.suckless.org/sbase/")
> +      (synopsis "Collection of unix tools that are portable across
> unix-systems")

“unix” isn’t capitalized.  Whoever merges the patch can probably do it
for you though; no need to send a new reroll.

Otherwise, LGTM.  I didn’t test if all the binaries worked though.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 861 bytes --]

[bug#53825] [PATCH v3] gnu: Add sbase.

[jgart via Guix-patches via]

* gnu/packages/suckless.scm (sbase): New variable.
---

Hi, 

Here is version 3 with the fix Xinglu mentioned.

I haven't tested all the binaries.

all best,

jgart

https://whereiseveryone.srht.site/
gemini://whereiseveryone.srht.site/


 gnu/packages/suckless.scm | 33 +++++++++++++++++++++++++++++++++
 1 file changed, 33 insertions(+)

diff --git a/gnu/packages/suckless.scm b/gnu/packages/suckless.scm
index 708eb2c338..198e17384e 100644
--- a/gnu/packages/suckless.scm
+++ b/gnu/packages/suckless.scm
@@ -988,6 +988,39 @@ (define-public snooze
 running a command.")
     (license license:cc0)))
 
+(define-public sbase
+  ;; There are no tagged releases.
+  (let ((commit "2c2a7f54ab55a022a617e510b6e00c3e2736fabd")
+        (revision "0"))
+    (package
+      (name "sbase")
+      (version (git-version "0" revision commit))
+      (source
+       (origin
+         (method git-fetch)
+         (uri
+          (git-reference
+           (url "https://git.suckless.org/sbase/")
+           (commit commit)))
+         (file-name (git-file-name name version))
+         (sha256
+          (base32 "119v1lpgsx8bx9h57wg454ddhzz2awqavl3wrn35a704vifg28g0"))))
+      (build-system gnu-build-system)
+      (arguments
+       `(#:tests? #f ; There are no tests.
+         #:make-flags
+         ,#~(list (string-append "CC=" #$(cc-for-target))
+                  (string-append "PREFIX=" #$output))
+         #:phases
+         (modify-phases %standard-phases
+           (delete 'configure))))
+      (home-page "https://core.suckless.org/sbase/")
+      (synopsis "Collection of Unix tools that are portable across unix-systems")
+      (description
+  "@command{sbase} is a collection of Unix tools that are portable across
+  Unix-systems.")
+      (license license:x11))))
+
 (define-public scron
   (package
     (name "scron")
-- 
2.35.0

[bug#53825] [PATCH] gnu: Add sbase.

[Maxime Devos]

[-- Attachment #1: Type: text/plain, Size: 498 bytes --]


> +      (license license:x11))))

The license does not have the

  Except as contained in this notice, the name of the X Consortium
  shall not be used in advertising or otherwise to promote the sale,
  use or other dealings in this Software without prior written
  authorization from the X Consortium.

  X Window System is a trademark of X Consortium, Inc.

clause, so this seems to be the license:expat?  Looks like the first
line in LICENSE is incorrect.

Greetings,
Maxime.

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 260 bytes --]

bug#53825: [PATCH] gnu: Add sbase.

[Maxim Cournoyer]

Hi,

jgart <jgart@dismail.de> writes:

> * gnu/packages/suckless.scm (sbase): New variable.
> ---
>
> Hi, 
>
> Here is version 3 with the fix Xinglu mentioned.
>
> I haven't tested all the binaries.
>
> all best,
>
> jgart
>
> https://whereiseveryone.srht.site/
> gemini://whereiseveryone.srht.site/

I've adjusted it like so:

--8<---------------cut here---------------start------------->8---
modified   gnu/packages/suckless.scm
@@ -12,6 +12,7 @@
 ;;; Copyright © 2021 Alexandru-Sergiu Marton <brown121407@posteo.ro>
 ;;; Copyright © 2021 Nikolay Korotkiy <sikmir@disroot.org>
 ;;; Copyright © 2022 Jai Vetrivelan <jaivetrivelan@gmail.com>
+;;; Copyright © 2022 jgart <jgart@dismail.de>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -1011,19 +1012,19 @@ (define-public sbase
           (base32 "119v1lpgsx8bx9h57wg454ddhzz2awqavl3wrn35a704vifg28g0"))))
       (build-system gnu-build-system)
       (arguments
-       `(#:tests? #f ; There are no tests.
-         #:make-flags
-         ,#~(list (string-append "CC=" #$(cc-for-target))
-                  (string-append "PREFIX=" #$output))
-         #:phases
-         (modify-phases %standard-phases
-           (delete 'configure))))
+       (list
+        #:tests? #f                     ;no test suite
+        #:make-flags #~(list (string-append "CC=" #$(cc-for-target))
+                             (string-append "PREFIX=" #$output))
+        #:phases
+        #~(modify-phases %standard-phases
+            (delete 'configure))))
       (home-page "https://core.suckless.org/sbase/")
-      (synopsis "Collection of Unix tools that are portable across unix-systems")
-      (description
-  "@command{sbase} is a collection of Unix tools that are portable across
-  Unix-systems.")
-      (license license:x11))))
+      (synopsis "Collection of UNIX tools")
+      (description "@command{sbase} is a collection of UNIX tools similar to those of GNU
+Coreutils, containing utilities commands such as @command{grep}, @command{cp},
+@command{rm}, etc.")
+      (license license:expat))))
 
 (define-public scron
   (package
--8<---------------cut here---------------end--------------->8---

Reverting the license to Expat as pointed by Maxime, fully capitalizing
UNIX, using a gexp for the phases and adding a few commands to the
description to give a better idea.  I've also removed the bits "portable
across UNIX systems" as on Guix that's not useful (the tools are as
portable as Guix itself is).

Pushed as 5299628b90.

Thanks!

Maxim