unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: jgart via Guix-patches via <guix-patches@gnu.org>
To: Maxime Devos <maximedevos@telenet.be>
Cc: 53829@debbugs.gnu.org
Subject: [bug#53829] [PATCH] gnu: Add jj.
Date: Sun, 6 Feb 2022 20:20:48 -0500	[thread overview]
Message-ID: <20220206202048.GB30057@gac.attlocal.net> (raw)
In-Reply-To: <1d41d5773d56b59f331cec4921c10417cd86d426.camel@telenet.be>

On Sun, 06 Feb 2022 23:10:24 +0100 Maxime Devos <maximedevos@telenet.be> wrote:
> jgart via Guix-patches via schreef op zo 06-02-2022 om 16:50 [-0500]:
> > +         (list (string-append "CC=" ,(cc-for-target))
> > +               (string-append "PREFIX=" %output))
> 
> %output -> #$output (put a ,#~ after #:make-flags).
> 
> Maybe likewise in 'install' (YMMV)

Hi Maxime,

Thank you for the review! Could you explain the reason for this change? Is
there a mailing list thread I can read regarding the practice of using
gexps for those variables in #:make-flags. It would be much appreciated.

I'm just trying to understand it a bit better.

all best,

jgart




  reply	other threads:[~2022-02-07  1:22 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-06 21:50 [bug#53829] [PATCH] gnu: Add jj jgart via Guix-patches via
2022-02-06 22:10 ` Maxime Devos
2022-02-07  1:20   ` jgart via Guix-patches via [this message]
2022-02-07  9:56     ` Maxime Devos
2022-02-07 15:30       ` jgart via Guix-patches via
2022-02-07  2:27 ` [bug#53829] [PATCH v2] " jgart via Guix-patches via
2022-03-03 22:44   ` bug#53829: [PATCH] " Ludovic Courtès
2022-03-04  0:21     ` [bug#53829] " jgart via Guix-patches via

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220206202048.GB30057@gac.attlocal.net \
    --to=guix-patches@gnu.org \
    --cc=53829@debbugs.gnu.org \
    --cc=jgart@dismail.de \
    --cc=maximedevos@telenet.be \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).