* [bug#52596] [guix-artwork PATCH] website: Relabel stable/latest to release/current.
@ 2021-12-18 10:40 zimoun
2021-12-18 15:22 ` pelzflorian (Florian Pelz)
0 siblings, 1 reply; 15+ messages in thread
From: zimoun @ 2021-12-18 10:40 UTC (permalink / raw)
To: 52596; +Cc: zimoun, Leo Famulari, Tobias Geerinckx-Rice
* website/apps/base/templates/components.scm (navbar): Relabel.
* website/apps/base/templates/help.scm (help-t): Relabel.
* website/apps/download/templates/download-latest.scm (download-latest-t):
Relabel.
---
Hi,
This discussion [1] points that the current label stable/latest for:
- things related to release
- things related to current master
is confusing. Mainly because 'stable' has other meaning in other distro.
Moreover, 'latest' does not imply less stable or buggy than 'stable' itself.
Instead, the label 'release/current' appears to be more accurate for a
rolling-release.
WDYT?
1: <http://logs.guix.gnu.org/guix/2021-12-17.log#201813>
Cheers,
simon
website/apps/base/templates/components.scm | 8 ++++----
website/apps/base/templates/help.scm | 7 +++----
website/apps/download/templates/download-latest.scm | 13 +++++++------
3 files changed, 14 insertions(+), 14 deletions(-)
diff --git a/website/apps/base/templates/components.scm b/website/apps/base/templates/components.scm
index e2a74d3..4488549 100644
--- a/website/apps/base/templates/components.scm
+++ b/website/apps/base/templates/components.scm
@@ -399,11 +399,11 @@ manual.
#:items
(list
(C_ "website menu"
- (menu-item #:label "Stable"
+ (menu-item #:label "Release"
#:active-item active-item
#:url (guix-url "download/")))
(C_ "website menu"
- (menu-item #:label "Latest"
+ (menu-item #:label "Current"
#:active-item active-item
#:url (guix-url "download/latest/")))))
@@ -417,11 +417,11 @@ manual.
#:active-item active-item
#:url (guix-url "help/")))
(C_ "website menu"
- (menu-item #:label "GNU Guix Manual (stable)"
+ (menu-item #:label "GNU Guix Manual (release)"
#:active-item active-item
#:url (guix-url "manual/")))
(C_ "website menu"
- (menu-item #:label "GNU Guix Manual (latest)"
+ (menu-item #:label "GNU Guix Manual (current)"
#:active-item active-item
#:url (guix-url "manual/devel/")))
(C_ "website menu"
diff --git a/website/apps/base/templates/help.scm b/website/apps/base/templates/help.scm
index 3d54ae1..fb25bd5 100644
--- a/website/apps/base/templates/help.scm
+++ b/website/apps/base/templates/help.scm
@@ -51,7 +51,7 @@ system|GNU Hurd|GNU Guix package manager|Help resources") #\|)
online. You may also find more information about Guix by running "
,(G_ `(code "info guix")) "."))
(p
- ,(link-more #:label (G_ "Read stable manual")
+ ,(link-more #:label `(G_ "Read manual " ,(latest-guix-version) "")
#:url (guix-url "manual/en" #:localize #f)))
(p
(a (@ (href ,(guix-url "manual/de" #:localize #f))) "Deutsch") " | "
@@ -71,13 +71,12 @@ system|GNU Hurd|GNU Guix package manager|Help resources") #\|)
(img
(@ (src ,(guix-url "static/base/img/manual-latest-icon.png"))
(alt "")))
- ,(G_ `(h3 "GNU Guix Manual (Latest)"))
+ ,(G_ `(h3 "GNU Guix Manual (Current)"))
,(G_
`(p
"This version of the manual is updated frequently to
include the latest changes from Guix's source files. It is
- more up-to-date than the manual for the stable release of
- Guix."))
+ more up-to-date than the manual for the release of Guix."))
(p
,(link-more #:label (G_ "Read latest manual")
#:url (guix-url "manual/devel/" #:localize #f))))
diff --git a/website/apps/download/templates/download-latest.scm b/website/apps/download/templates/download-latest.scm
index 17eaadf..3d328aa 100644
--- a/website/apps/download/templates/download-latest.scm
+++ b/website/apps/download/templates/download-latest.scm
@@ -143,10 +143,10 @@
(define (download-latest-t)
"Return the Download latest page in SHTML."
(theme
- #:title (C_ "webpage title" '("Download latest"))
+ #:title (C_ "webpage title" '("Download current"))
#:description
- (G_ "Download latest GNU Guix System images built by the Cuirass continuous
-integration system.")
+ (G_ "Download latest development GNU Guix System images built
+by the Cuirass continuous integration system.")
#:keywords
(string-split ;TRANSLATORS: |-separated list of webpage keywords
(G_ "GNU|Linux|Unix|Free software|Libre software|Operating \
@@ -158,12 +158,12 @@ Package manager") #\|)
(guix-url "static/base/css/download.css"))
#:crumbs
(list (crumb (C_ "website menu" "Download") (guix-url "download/"))
- (crumb (C_ "website menu" "Latest") "./"))
+ (crumb (C_ "website menu" "Current") "./"))
#:content
`(main
(section
(@ (class "page"))
- ,(G_ `(h2 "Download latest images"))
+ ,(G_ `(h2 "Download latest developement images"))
;; TRANSLATORS: Continuous Integration is a section name
;; in the English (en) manual.
,(G_
@@ -175,7 +175,8 @@ Package manager") #\|)
" continuous integration system at "
(a (@ (href ,ci-url)) "ci.guix.gnu.org")
". These images are " ,(G_ `(b "development snapshots"))
- ", you might prefer to use stable images that can be found "
+ ", you might prefer to use well-tested released images
+that can be found "
,(G_ `(a (@ (href ,(guix-url "download/"))) "here."))))
(div
(@ (class "centered-block limit-width"))
base-commit: ceaad7ee0c237fc5cd58a542247e9eaaea68e2bf
--
2.33.1
^ permalink raw reply related [flat|nested] 15+ messages in thread
* [bug#52596] [guix-artwork PATCH] website: Relabel stable/latest to release/current.
2021-12-18 10:40 [bug#52596] [guix-artwork PATCH] website: Relabel stable/latest to release/current zimoun
@ 2021-12-18 15:22 ` pelzflorian (Florian Pelz)
2021-12-18 15:43 ` zimoun
0 siblings, 1 reply; 15+ messages in thread
From: pelzflorian (Florian Pelz) @ 2021-12-18 15:22 UTC (permalink / raw)
To: zimoun; +Cc: Tobias Geerinckx-Rice, 52596, Leo Famulari
Hello simon. Thank you for the patch, even though I disagree.
On Sat, Dec 18, 2021 at 11:40:38AM +0100, zimoun wrote:
> This discussion [1] points that the current label stable/latest for:
>
> - things related to release
> - things related to current master
>
> is confusing. Mainly because 'stable' has other meaning in other distro.
> Moreover, 'latest' does not imply less stable or buggy than 'stable' itself.
>
> Instead, the label 'release/current' appears to be more accurate for a
> rolling-release.
>
> WDYT?
>
> 1: <http://logs.guix.gnu.org/guix/2021-12-17.log#201813>
The term 'release' seems technical and hard-to-translate. Stable may
raise wrong expectations, but one word cannot convey all the
difference between the images anyway. I think the criticism of our QA
is too negative, even though more QA would have been better.
However there are few reasons to read the stable manual. Hmm.
> diff --git a/website/apps/base/templates/help.scm b/website/apps/base/templates/help.scm
> index 3d54ae1..fb25bd5 100644
> --- a/website/apps/base/templates/help.scm
> +++ b/website/apps/base/templates/help.scm
> @@ -51,7 +51,7 @@ system|GNU Hurd|GNU Guix package manager|Help resources") #\|)
> online. You may also find more information about Guix by running "
> ,(G_ `(code "info guix")) "."))
> (p
> - ,(link-more #:label (G_ "Read stable manual")
> + ,(link-more #:label `(G_ "Read manual " ,(latest-guix-version) "")
This should be
,(link-more #:label (G_ (string-append "Read manual " (latest-guix-version) "")))
with string-append like further below for
,(G_ (string-append "Page " (number->string active-page) " of "
(number->string pages) ". Go to another page: ")))
> ,(link-more #:label (G_ "Read latest manual")
> #:url (guix-url "manual/devel/" #:localize #f))))
> diff --git a/website/apps/download/templates/download-latest.scm b/website/apps/download/templates/download-latest.scm
> [...]
> #:content
> `(main
> (section
> (@ (class "page"))
> - ,(G_ `(h2 "Download latest images"))
> + ,(G_ `(h2 "Download latest developement images"))
There is a typo, but more importantly the meaning of development
images is hard to understand.
This is a difficult topic. ;)
Regards,
Florian
^ permalink raw reply [flat|nested] 15+ messages in thread
* [bug#52596] [guix-artwork PATCH] website: Relabel stable/latest to release/current.
2021-12-18 15:22 ` pelzflorian (Florian Pelz)
@ 2021-12-18 15:43 ` zimoun
2021-12-18 19:36 ` pelzflorian (Florian Pelz)
0 siblings, 1 reply; 15+ messages in thread
From: zimoun @ 2021-12-18 15:43 UTC (permalink / raw)
To: pelzflorian (Florian Pelz), Julien Lepiller
Cc: Tobias Geerinckx-Rice, 52596, Leo Famulari
Hi Florian,
Thanks for your comments.
On Sat, 18 Dec 2021 at 16:22, pelzflorian (Florian Pelz)
<pelzflorian@pelzflorian.de> wrote:
> On Sat, Dec 18, 2021 at 11:40:38AM +0100, zimoun wrote:
> > This discussion [1] points that the current label stable/latest for:
> >
> > - things related to release
> > - things related to current master
> >
> > is confusing. Mainly because 'stable' has other meaning in other distro.
> > Moreover, 'latest' does not imply less stable or buggy than 'stable' itself.
> >
> > Instead, the label 'release/current' appears to be more accurate for a
> > rolling-release.
> >
> > WDYT?
> >
> > 1: <http://logs.guix.gnu.org/guix/2021-12-17.log#201813>
>
> The term 'release' seems technical and hard-to-translate. Stable may
> raise wrong expectations, but one word cannot convey all the
> difference between the images anyway. I think the criticism of our QA
> is too negative, even though more QA would have been better.
I do not have a strong opinion about the term to replace 'stable'.
However, I have a strong opinion that this label stable/latest is
confusing, at least in the nav bar. Especially if you come from other
distros. For instance, stable never receives fixes, so it is not
'stable' but 'frozen'.
Initially, I wanted to replace 'stable' by the current version number;
something using (latest-guix-version). I think it is the best: clear
and easy to translate. However, I had some hard time with all these
quote, backquote, unquote, so I gave up. :-)
> However there are few reasons to read the stable manual. Hmm.
One reason at least is to have this manual open when you are
installing or playing with the images inside a VM, etc.
> This should be
>
> ,(link-more #:label (G_ (string-append "Read manual " (latest-guix-version) "")))
Thanks.
> > - ,(G_ `(h2 "Download latest images"))
> > + ,(G_ `(h2 "Download latest developement images"))
>
> There is a typo, but more importantly the meaning of development
> images is hard to understand.
Indeed typo. :-)
> This is a difficult topic. ;)
Yeah, naming is a difficult topic. I think that 'stable/latest' is an
inaccurate label for what it really is. I think it should be
'1.3.0/current' or whatever better for current.
In French website, 'latest' is translated as 'Développement' and
'actuel'; which are both more accurate that 'latest' and they could be
translated back as 'current'.
Cheers,
simon
^ permalink raw reply [flat|nested] 15+ messages in thread
* [bug#52596] [guix-artwork PATCH] website: Relabel stable/latest to release/current.
2021-12-18 15:43 ` zimoun
@ 2021-12-18 19:36 ` pelzflorian (Florian Pelz)
2021-12-19 9:21 ` zimoun
0 siblings, 1 reply; 15+ messages in thread
From: pelzflorian (Florian Pelz) @ 2021-12-18 19:36 UTC (permalink / raw)
To: zimoun; +Cc: Julien Lepiller, Tobias Geerinckx-Rice, 52596, Leo Famulari
Hi simon.
What matters is that users try first to install with the stable Guix
System image, because it is more likely to succeed, but if it does not
succeed, they can try the other one. In this regard, the terms
stable/latest seem fine to me. 1.3.0/current might reverse the order.
On Sat, Dec 18, 2021 at 04:43:57PM +0100, zimoun wrote:
> However, I have a strong opinion that this label stable/latest is
> confusing, at least in the nav bar. Especially if you come from other
> distros. For instance, stable never receives fixes, so it is not
> 'stable' but 'frozen'.
The discussion on IRC provess you right that users get confused.
> Initially, I wanted to replace 'stable' by the current version number;
> something using (latest-guix-version). I think it is the best: clear
> and easy to translate. However, I had some hard time with all these
> quote, backquote, unquote, so I gave up. :-)
I agree that the "stable" manual is better described as 1.3.0 (like
what your patch does) and not as stable. But I am unsure if the
stable manual is needed at all. You have a more experienced judgment
here though.
Regards,
Florian
^ permalink raw reply [flat|nested] 15+ messages in thread
* [bug#52596] [guix-artwork PATCH] website: Relabel stable/latest to release/current.
2021-12-18 19:36 ` pelzflorian (Florian Pelz)
@ 2021-12-19 9:21 ` zimoun
2021-12-19 10:40 ` pelzflorian (Florian Pelz)
2021-12-24 17:34 ` pelzflorian (Florian Pelz)
0 siblings, 2 replies; 15+ messages in thread
From: zimoun @ 2021-12-19 9:21 UTC (permalink / raw)
To: pelzflorian (Florian Pelz)
Cc: Julien Lepiller, Tobias Geerinckx-Rice, 52596, Leo Famulari
Hi Florian,
On Sat, 18 Dec 2021 at 20:36, "pelzflorian (Florian Pelz)" <pelzflorian@pelzflorian.de> wrote:
> What matters is that users try first to install with the stable Guix
> System image, because it is more likely to succeed, but if it does not
> succeed, they can try the other one. In this regard, the terms
> stable/latest seem fine to me. 1.3.0/current might reverse the order.
I agree with the aim. I disagree with the term to express it and I
think that ’stable’ is not clear in this regard. That’s why I proposed
’release’ instead, whereas I agree it is maybe not the best for
translation.
Well, maybe ’standard / latest’? Or something else than latest as
development, current, or whatever else.
> On Sat, Dec 18, 2021 at 04:43:57PM +0100, zimoun wrote:
>> However, I have a strong opinion that this label stable/latest is
>> confusing, at least in the nav bar. Especially if you come from other
>> distros. For instance, stable never receives fixes, so it is not
>> 'stable' but 'frozen'.
>
> The discussion on IRC provess you right that users get confused.
I also see the same confusion here and there. Often I answer that once
clicked, the download page explains what it is and thus one just has to
read to the difference. That’s not true for the manual though.
Read explanation for something intuitive implies something is not
optimal, hence the proposed patch and discussion. :-)
>> Initially, I wanted to replace 'stable' by the current version number;
>> something using (latest-guix-version). I think it is the best: clear
>> and easy to translate. However, I had some hard time with all these
>> quote, backquote, unquote, so I gave up. :-)
>
> I agree that the "stable" manual is better described as 1.3.0 (like
> what your patch does) and not as stable. But I am unsure if the
> stable manual is needed at all. You have a more experienced judgment
> here though.
Well, keep the frozen manual for the current release is another
question. For sure, I never use it and I never point to it.
I lack imagination and the only user-case I can think of is: read it
using another device while installing.
Therefore, maybe it would simplify if the navbar Help would contain only
“Guix Manual”. And the navbar Download would contain Standard, where
the Standard webpage would contain a link for the manual in case it is
useful.
Instead of Standard, it could be (latest-guix-version) but I failed to
do it. :-)
WDYT?
Cheers,
simon
Note that <https://www.gnu.org/manual/> points to
<https://www.gnu.org/software/guix/manual/>.
^ permalink raw reply [flat|nested] 15+ messages in thread
* [bug#52596] [guix-artwork PATCH] website: Relabel stable/latest to release/current.
2021-12-19 9:21 ` zimoun
@ 2021-12-19 10:40 ` pelzflorian (Florian Pelz)
2021-12-23 1:21 ` pelzflorian (Florian Pelz)
2021-12-24 17:34 ` pelzflorian (Florian Pelz)
1 sibling, 1 reply; 15+ messages in thread
From: pelzflorian (Florian Pelz) @ 2021-12-19 10:40 UTC (permalink / raw)
To: zimoun; +Cc: Julien Lepiller, Tobias Geerinckx-Rice, 52596, Leo Famulari
On Sun, Dec 19, 2021 at 10:21:29AM +0100, zimoun wrote:
> Therefore, maybe it would simplify if the navbar Help would contain only
> “Guix Manual”. And the navbar Download would contain Standard, where
> the Standard webpage would contain a link for the manual in case it is
> useful.
Yes. I agree with your patch if Release is replaced by Standard and
the (G_ "Read manual ") is replaced as I wrote in my first mail and
the typo is addressed.
OK, the 1.3.0 manual is probably needed when changing the config file.
I do not know if it is needed on foreign distros.
R.I.P. stable, but you have shown there is confusion.
I have not test-built the website with the patch yet though.
Regards,
Florian
^ permalink raw reply [flat|nested] 15+ messages in thread
* [bug#52596] [guix-artwork PATCH] website: Relabel stable/latest to release/current.
2021-12-19 9:21 ` zimoun
2021-12-19 10:40 ` pelzflorian (Florian Pelz)
@ 2021-12-24 17:34 ` pelzflorian (Florian Pelz)
2021-12-29 16:40 ` zimoun
1 sibling, 1 reply; 15+ messages in thread
From: pelzflorian (Florian Pelz) @ 2021-12-24 17:34 UTC (permalink / raw)
To: zimoun; +Cc: Julien Lepiller, Tobias Geerinckx-Rice, 52596, Leo Famulari
[-- Attachment #1: Type: text/plain, Size: 1059 bytes --]
Sorry for not having pushed yet. (Actually I had somehow assumed you
had commit access ...).
On Sun, Dec 19, 2021 at 10:21:29AM +0100, zimoun wrote:
> Well, maybe ’standard / latest’? Or something else than latest as
> development, current, or whatever else.
Actually yes.
I would like to push the attached patch
"website: Relabel stable/latest to standard/latest."
which is your patch but:
- Typo is fixed and G_ is used correctly.
- With latest remaining latest. I don't think there is much
difference, so better not invalidate existing translations. Also
latest is arguably more accurate than current.
- The sum of your changes grants copyright IMHO, so I added copyright
headers for you for all changed files.
Note that Luis Felipe opted for
;;; Public domain 2021 Luis Felipe López Acevedo
instead of
;;; Copyright © 2021 Simon Tournier <zimon.toutoune@gmail.com>
so I better ask first which you prefer.
- Also changing Help/GNU Guix Manual (stable)
to Help/GNU Guix Manual 1.3.0 as you proposed.
OK?
Regards,
Florian
[-- Attachment #2: website-Relabel-stable-latest-to-standard-latest.patch --]
[-- Type: text/plain, Size: 5741 bytes --]
From: zimoun <zimon.toutoune@gmail.com>
Date: Sat, 18 Dec 2021 11:40:38 +0100
Subject: [PATCH] website: Relabel stable/latest to standard/latest.
* website/apps/base/templates/components.scm (navbar): Relabel.
* website/apps/base/templates/help.scm (help-t): Relabel.
* website/apps/download/templates/download-latest.scm (download-latest-t):
Relabel.
Signed-off-by: Florian Pelz <pelzflorian@pelzflorian.de>
---
website/apps/base/templates/components.scm | 12 +++++++-----
website/apps/base/templates/help.scm | 7 ++++---
website/apps/download/templates/download-latest.scm | 10 ++++++----
3 files changed, 17 insertions(+), 12 deletions(-)
diff --git a/website/apps/base/templates/components.scm b/website/apps/base/templates/components.scm
index e2a74d3..b354d48 100644
--- a/website/apps/base/templates/components.scm
+++ b/website/apps/base/templates/components.scm
@@ -1,5 +1,6 @@
;;; GNU Guix web site
;;; Copyright © 2019 Florian Pelz <pelzflorian@pelzflorian.de>
+;;; Copyright © 2021 Simon Tournier <zimon.toutoune@gmail.com>
;;; Initially written by sirgazil who waives all
;;; copyright interest on this file.
@@ -399,7 +400,7 @@ manual.
#:items
(list
(C_ "website menu"
- (menu-item #:label "Stable"
+ (menu-item #:label "Standard"
#:active-item active-item
#:url (guix-url "download/")))
(C_ "website menu"
@@ -416,10 +417,11 @@ manual.
(menu-item #:label "All"
#:active-item active-item
#:url (guix-url "help/")))
- (C_ "website menu"
- (menu-item #:label "GNU Guix Manual (stable)"
- #:active-item active-item
- #:url (guix-url "manual/")))
+ (menu-item #:label (C_ "website menu"
+ (string-append "GNU Guix Manual "
+ (latest-guix-version) ""))
+ #:active-item active-item
+ #:url (guix-url "manual/"))
(C_ "website menu"
(menu-item #:label "GNU Guix Manual (latest)"
#:active-item active-item
diff --git a/website/apps/base/templates/help.scm b/website/apps/base/templates/help.scm
index 3d54ae1..98bba39 100644
--- a/website/apps/base/templates/help.scm
+++ b/website/apps/base/templates/help.scm
@@ -1,5 +1,6 @@
;;; GNU Guix web site
;;; Public domain 2021 Luis Felipe López Acevedo
+;;; Copyright © 2021 Simon Tournier <zimon.toutoune@gmail.com>
;;; Initially written by sirgazil who waives all
;;; copyright interest on this file.
@@ -51,7 +52,8 @@ system|GNU Hurd|GNU Guix package manager|Help resources") #\|)
online. You may also find more information about Guix by running "
,(G_ `(code "info guix")) "."))
(p
- ,(link-more #:label (G_ "Read stable manual")
+ ,(link-more #:label (G_ (string-append "Read manual "
+ (latest-guix-version) ""))
#:url (guix-url "manual/en" #:localize #f)))
(p
(a (@ (href ,(guix-url "manual/de" #:localize #f))) "Deutsch") " | "
@@ -76,8 +78,7 @@ system|GNU Hurd|GNU Guix package manager|Help resources") #\|)
`(p
"This version of the manual is updated frequently to
include the latest changes from Guix's source files. It is
- more up-to-date than the manual for the stable release of
- Guix."))
+ more up-to-date than the manual for the release of Guix."))
(p
,(link-more #:label (G_ "Read latest manual")
#:url (guix-url "manual/devel/" #:localize #f))))
diff --git a/website/apps/download/templates/download-latest.scm b/website/apps/download/templates/download-latest.scm
index 17eaadf..cdcecb7 100644
--- a/website/apps/download/templates/download-latest.scm
+++ b/website/apps/download/templates/download-latest.scm
@@ -1,4 +1,5 @@
;;; GNU Guix web site
+;;; Copyright © 2021 Simon Tournier <zimon.toutoune@gmail.com>
;;; Initially written by sirgazil who waives all
;;; copyright interest on this file.
;;;
@@ -145,8 +146,8 @@
(theme
#:title (C_ "webpage title" '("Download latest"))
#:description
- (G_ "Download latest GNU Guix System images built by the Cuirass continuous
-integration system.")
+ (G_ "Download latest development GNU Guix System images built
+by the Cuirass continuous integration system.")
#:keywords
(string-split ;TRANSLATORS: |-separated list of webpage keywords
(G_ "GNU|Linux|Unix|Free software|Libre software|Operating \
@@ -163,7 +164,7 @@ Package manager") #\|)
`(main
(section
(@ (class "page"))
- ,(G_ `(h2 "Download latest images"))
+ ,(G_ `(h2 "Download latest development images"))
;; TRANSLATORS: Continuous Integration is a section name
;; in the English (en) manual.
,(G_
@@ -175,7 +176,8 @@ Package manager") #\|)
" continuous integration system at "
(a (@ (href ,ci-url)) "ci.guix.gnu.org")
". These images are " ,(G_ `(b "development snapshots"))
- ", you might prefer to use stable images that can be found "
+ ", you might prefer to use well-tested released images
+that can be found "
,(G_ `(a (@ (href ,(guix-url "download/"))) "here."))))
(div
(@ (class "centered-block limit-width"))
base-commit: 336f7905428a858e32ea8064317a6cc03fa64afe
--
2.34.0
^ permalink raw reply related [flat|nested] 15+ messages in thread
* [bug#52596] [guix-artwork PATCH] website: Relabel stable/latest to release/current.
2021-12-24 17:34 ` pelzflorian (Florian Pelz)
@ 2021-12-29 16:40 ` zimoun
2021-12-29 19:42 ` pelzflorian (Florian Pelz)
0 siblings, 1 reply; 15+ messages in thread
From: zimoun @ 2021-12-29 16:40 UTC (permalink / raw)
To: pelzflorian (Florian Pelz)
Cc: Julien Lepiller, Tobias Geerinckx-Rice, 52596, Leo Famulari
Hi Florian,
On Fri, 24 Dec 2021 at 18:34, "pelzflorian (Florian Pelz)" <pelzflorian@pelzflorian.de> wrote:
> Sorry for not having pushed yet. (Actually I had somehow assumed you
> had commit access ...).
Sorry for the delay. Indeed, I do not have commit access. :-)
> On Sun, Dec 19, 2021 at 10:21:29AM +0100, zimoun wrote:
>> Well, maybe ’standard / latest’? Or something else than latest as
>> development, current, or whatever else.
>
> Actually yes.
Thanks for the follow up.
> I would like to push the attached patch
> "website: Relabel stable/latest to standard/latest."
LGTM, thanks for the various fixes.
> - The sum of your changes grants copyright IMHO, so I added copyright
> headers for you for all changed files.
> Note that Luis Felipe opted for
> ;;; Public domain 2021 Luis Felipe López Acevedo
> instead of
> ;;; Copyright © 2021 Simon Tournier <zimon.toutoune@gmail.com>
> so I better ask first which you prefer.
All is fine. Since I considered it was trivial changes, I appeared to
me not necessary for the Copyright line. :-) Thanks for taking care of
all that.
> - Also changing Help/GNU Guix Manual (stable)
> to Help/GNU Guix Manual 1.3.0 as you proposed.
With fresh eyes, maybe “Guix Manual” is enough here.
> From: zimoun <zimon.toutoune@gmail.com>
> Date: Sat, 18 Dec 2021 11:40:38 +0100
> Subject: [PATCH] website: Relabel stable/latest to standard/latest.
>
> * website/apps/base/templates/components.scm (navbar): Relabel.
> * website/apps/base/templates/help.scm (help-t): Relabel.
> * website/apps/download/templates/download-latest.scm (download-latest-t):
> Relabel.
>
> Signed-off-by: Florian Pelz <pelzflorian@pelzflorian.de>
> ---
> website/apps/base/templates/components.scm | 12 +++++++-----
> website/apps/base/templates/help.scm | 7 ++++---
> website/apps/download/templates/download-latest.scm | 10 ++++++----
> 3 files changed, 17 insertions(+), 12 deletions(-)
LGTM.
Cheers,
simon
^ permalink raw reply [flat|nested] 15+ messages in thread
* [bug#52596] [guix-artwork PATCH] website: Relabel stable/latest to release/current.
2021-12-29 16:40 ` zimoun
@ 2021-12-29 19:42 ` pelzflorian (Florian Pelz)
2021-12-29 20:07 ` Leo Famulari
2021-12-29 20:07 ` zimoun
0 siblings, 2 replies; 15+ messages in thread
From: pelzflorian (Florian Pelz) @ 2021-12-29 19:42 UTC (permalink / raw)
To: zimoun; +Cc: Julien Lepiller, Tobias Geerinckx-Rice, 52596, Leo Famulari
On Wed, Dec 29, 2021 at 05:40:45PM +0100, zimoun wrote:
> On Fri, 24 Dec 2021 at 18:34, "pelzflorian (Florian Pelz)" <pelzflorian@pelzflorian.de> wrote:
> > - Also changing Help/GNU Guix Manual (stable)
> > to Help/GNU Guix Manual 1.3.0 as you proposed.
>
> With fresh eyes, maybe “Guix Manual” is enough here.
I have pushed as-is (commit 2f5793cf543edc6fee4fe1351b9b30dfce116dea),
because the Help/All page calls it GNU Guix Manual 1.3.0 too.
Also I think it is good now. The 1.3.0 makes clear the difference to
latest. The only downside to naming it 1.3.0 that I see is that the
guix.gnu.org/manual URL will change away from 1.3.0 on the next
release.
Thank you Simon!
Regards,
Florian
^ permalink raw reply [flat|nested] 15+ messages in thread
* [bug#52596] [guix-artwork PATCH] website: Relabel stable/latest to release/current.
2021-12-29 19:42 ` pelzflorian (Florian Pelz)
@ 2021-12-29 20:07 ` Leo Famulari
2021-12-29 22:53 ` pelzflorian (Florian Pelz)
2021-12-29 20:07 ` zimoun
1 sibling, 1 reply; 15+ messages in thread
From: Leo Famulari @ 2021-12-29 20:07 UTC (permalink / raw)
To: pelzflorian (Florian Pelz)
Cc: Julien Lepiller, Tobias Geerinckx-Rice, 52596, zimoun
On Wed, Dec 29, 2021 at 08:42:57PM +0100, pelzflorian (Florian Pelz) wrote:
> On Wed, Dec 29, 2021 at 05:40:45PM +0100, zimoun wrote:
> > On Fri, 24 Dec 2021 at 18:34, "pelzflorian (Florian Pelz)" <pelzflorian@pelzflorian.de> wrote:
> > > - Also changing Help/GNU Guix Manual (stable)
> > > to Help/GNU Guix Manual 1.3.0 as you proposed.
> >
> > With fresh eyes, maybe “Guix Manual” is enough here.
>
> I have pushed as-is (commit 2f5793cf543edc6fee4fe1351b9b30dfce116dea),
> because the Help/All page calls it GNU Guix Manual 1.3.0 too.
>
> Also I think it is good now. The 1.3.0 makes clear the difference to
> latest. The only downside to naming it 1.3.0 that I see is that the
> guix.gnu.org/manual URL will change away from 1.3.0 on the next
> release.
Maybe we can paremeterize the responsible code so that it's updated
automatically?
^ permalink raw reply [flat|nested] 15+ messages in thread
* [bug#52596] [guix-artwork PATCH] website: Relabel stable/latest to release/current.
2021-12-29 20:07 ` Leo Famulari
@ 2021-12-29 22:53 ` pelzflorian (Florian Pelz)
2021-12-30 15:49 ` zimoun
0 siblings, 1 reply; 15+ messages in thread
From: pelzflorian (Florian Pelz) @ 2021-12-29 22:53 UTC (permalink / raw)
To: Leo Famulari; +Cc: Julien Lepiller, Tobias Geerinckx-Rice, 52596, zimoun
On Wed, Dec 29, 2021 at 03:07:10PM -0500, Leo Famulari wrote:
> On Wed, Dec 29, 2021 at 08:42:57PM +0100, pelzflorian (Florian Pelz) wrote:
> > The only downside to naming it 1.3.0 that I see is that the
> > guix.gnu.org/manual URL will change away from 1.3.0 on the next
> > release.
> Maybe we can paremeterize the responsible code so that it's updated
> automatically?
Leo, we could create https://guix.gnu.org/manual/1.3.0/ and make the
navbar’s Help/GNU Guix Manual 1.3.0 point to
https://guix.gnu.org/manual/1.3.0/ so the meaning of the URL will not
change in the future. This is what I meant; I had expressed myself
badly so I’m unsure now if you really mean that.
It is all unnecessary, I think; IMHO we do not even need both
https://guix.gnu.org/manual/ and https://guix.gnu.org/manual/devel/,
except when users manually change /etc/config.scm without guix pull.
Or do foreign distro users need the old manual to install? But why?
The label Help/GNU Guix Manual 1.3.0 already uses
(define latest-guix-version
(make-parameter "1.3.0"))
so the label will automatically become Help/GNU Guix Manual 1.4.0 or
whatever the next release will be called.
Regards,
Florian
^ permalink raw reply [flat|nested] 15+ messages in thread
* [bug#52596] [guix-artwork PATCH] website: Relabel stable/latest to release/current.
2021-12-29 22:53 ` pelzflorian (Florian Pelz)
@ 2021-12-30 15:49 ` zimoun
2021-12-30 17:03 ` pelzflorian (Florian Pelz)
0 siblings, 1 reply; 15+ messages in thread
From: zimoun @ 2021-12-30 15:49 UTC (permalink / raw)
To: pelzflorian (Florian Pelz)
Cc: Julien Lepiller, Tobias Geerinckx-Rice, 52596, Leo Famulari
Hi Florian,
I am still seeing the old version, even after refreshing. All is it ok?
Cheers,
simon
^ permalink raw reply [flat|nested] 15+ messages in thread
* [bug#52596] [guix-artwork PATCH] website: Relabel stable/latest to release/current.
2021-12-30 15:49 ` zimoun
@ 2021-12-30 17:03 ` pelzflorian (Florian Pelz)
0 siblings, 0 replies; 15+ messages in thread
From: pelzflorian (Florian Pelz) @ 2021-12-30 17:03 UTC (permalink / raw)
To: zimoun; +Cc: Julien Lepiller, Tobias Geerinckx-Rice, 52596, Leo Famulari
On Thu, Dec 30, 2021 at 04:49:21PM +0100, zimoun wrote:
> Hi Florian,
>
> I am still seeing the old version, even after refreshing. All is it ok?
>
>
> Cheers,
> simon
I don’t know about builds on berlin. A local build of the de_DE
website was successful.
Regards,
Florian
^ permalink raw reply [flat|nested] 15+ messages in thread
* [bug#52596] [guix-artwork PATCH] website: Relabel stable/latest to release/current.
2021-12-29 19:42 ` pelzflorian (Florian Pelz)
2021-12-29 20:07 ` Leo Famulari
@ 2021-12-29 20:07 ` zimoun
1 sibling, 0 replies; 15+ messages in thread
From: zimoun @ 2021-12-29 20:07 UTC (permalink / raw)
To: pelzflorian (Florian Pelz)
Cc: Julien Lepiller, Tobias Geerinckx-Rice, 52596, Leo Famulari
Hi Florian,
On Wed, 29 Dec 2021 at 20:42, "pelzflorian (Florian Pelz)" <pelzflorian@pelzflorian.de> wrote:
> On Wed, Dec 29, 2021 at 05:40:45PM +0100, zimoun wrote:
>> On Fri, 24 Dec 2021 at 18:34, "pelzflorian (Florian Pelz)" <pelzflorian@pelzflorian.de> wrote:
>> > - Also changing Help/GNU Guix Manual (stable)
>> > to Help/GNU Guix Manual 1.3.0 as you proposed.
>>
>> With fresh eyes, maybe “Guix Manual” is enough here.
>
> I have pushed as-is (commit 2f5793cf543edc6fee4fe1351b9b30dfce116dea),
> because the Help/All page calls it GNU Guix Manual 1.3.0 too.
Cool!
Well, I think “GNU Guix Manual“ is superfluous in the Help
navbar. “Manual“ seems enough, IMHO. Similarly for “Guix Reference
Card”, I would be weird that this reference card points to something
else. For instance, it is only “Cookbook“ and not “GNU Guix Cookbook”,
in the Help navbar.
Then, the webpage “mentioning GNU Guix …” is fine.
> Also I think it is good now. The 1.3.0 makes clear the difference to
> latest. The only downside to naming it 1.3.0 that I see is that the
> guix.gnu.org/manual URL will change away from 1.3.0 on the next
> release.
Personally, I prefer light and straight navigation bar than one with too
many redundant information. But all tastes are around. ;-)
Cheers,
simon
^ permalink raw reply [flat|nested] 15+ messages in thread
end of thread, other threads:[~2021-12-30 17:06 UTC | newest]
Thread overview: 15+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-12-18 10:40 [bug#52596] [guix-artwork PATCH] website: Relabel stable/latest to release/current zimoun
2021-12-18 15:22 ` pelzflorian (Florian Pelz)
2021-12-18 15:43 ` zimoun
2021-12-18 19:36 ` pelzflorian (Florian Pelz)
2021-12-19 9:21 ` zimoun
2021-12-19 10:40 ` pelzflorian (Florian Pelz)
2021-12-23 1:21 ` pelzflorian (Florian Pelz)
2021-12-24 17:34 ` pelzflorian (Florian Pelz)
2021-12-29 16:40 ` zimoun
2021-12-29 19:42 ` pelzflorian (Florian Pelz)
2021-12-29 20:07 ` Leo Famulari
2021-12-29 22:53 ` pelzflorian (Florian Pelz)
2021-12-30 15:49 ` zimoun
2021-12-30 17:03 ` pelzflorian (Florian Pelz)
2021-12-29 20:07 ` zimoun
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).