From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id gOtiGJ4VsWHJBgAAgWs5BA (envelope-from ) for ; Wed, 08 Dec 2021 21:29:18 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id IIglFJ4VsWFSJAAAB5/wlQ (envelope-from ) for ; Wed, 08 Dec 2021 20:29:18 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id E83DB8FC0 for ; Wed, 8 Dec 2021 21:29:17 +0100 (CET) Received: from localhost ([::1]:43398 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mv3Yz-0005Mz-3H for larch@yhetil.org; Wed, 08 Dec 2021 15:29:17 -0500 Received: from eggs.gnu.org ([209.51.188.92]:52588) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mv3Yk-0005Ld-Gh for guix-patches@gnu.org; Wed, 08 Dec 2021 15:29:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:58242) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mv3Yk-0000B1-9I for guix-patches@gnu.org; Wed, 08 Dec 2021 15:29:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mv3Yk-0005pZ-4y for guix-patches@gnu.org; Wed, 08 Dec 2021 15:29:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#51838] [PATCH v3 00/43] guix: node-build-system: Support compiling add-ons with node-gyp. Resent-From: Philip McGrath Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 08 Dec 2021 20:29:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51838 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 51838@debbugs.gnu.org Cc: Timothy Sample , Pierre Langlois , Jelle Licht , Liliana Marie Prikler Received: via spool by 51838-submit@debbugs.gnu.org id=B51838.163899533022295 (code B ref 51838); Wed, 08 Dec 2021 20:29:02 +0000 Received: (at 51838) by debbugs.gnu.org; 8 Dec 2021 20:28:50 +0000 Received: from localhost ([127.0.0.1]:41534 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mv3YY-0005nQ-5k for submit@debbugs.gnu.org; Wed, 08 Dec 2021 15:28:50 -0500 Received: from mail-ua1-f53.google.com ([209.85.222.53]:37394) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mv3YT-0005mn-EF for 51838@debbugs.gnu.org; Wed, 08 Dec 2021 15:28:48 -0500 Received: by mail-ua1-f53.google.com with SMTP id o1so6932765uap.4 for <51838@debbugs.gnu.org>; Wed, 08 Dec 2021 12:28:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=philipmcgrath.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=azzG4iAm+UuqtJpRweu3X7VU3tTuNL0hhjc5m0vjdaU=; b=P4L6i7o5oBkCp99pLtwWDKkGCEGrxYYRH4RKl0cyMKUwUxerPOyzPOnFPzMZCy8AK2 50NY4IkxwKmdqOK6uxMXGMin5j4yp+w1O5XT2AhOKQ3t6NwxjzRrgVfeiAE+PA1cAAdz A+ryo6ib+YUui4MQK3YZm+Ow3ezGLrziwOH0lCWrXXc45tO9wWbAidUQRmDUlNbcrT5J PYTXFPf61UFU2WEMIUjqxae6ys7JixCV+jwlTZ8OxL+V1wgOq+JjiWFBLt6RO5mMNI33 2gmrpHuCHJBtHo5daYj58jV0nVJ78dJgJqUg2P4I5odaReDMirv9TApvsYtmG81glRPN sbzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=azzG4iAm+UuqtJpRweu3X7VU3tTuNL0hhjc5m0vjdaU=; b=XBiJ1p2JXeKN4QMvev2XRFsIy3CTDpGeQ5iTV5DKrwiph08xFykjuYD3gyFrFEceM+ l3XFgI1U8uNxGSbhlTB+bExW6cd1yzr5+JAjKpo33G9QA/YfDVSvYWoFTaP5ro5RDghb kgfvp8JC78KJCPgxmWye0gshSkHHc1YDFJ75YX+9pznMXwRnatJpskMoO9EuksC+q94O PbtO5nlWpV4wyplFpVWyVJNtSqECxaufbiivt8dEDeTxQYSVA0yp7bNf2nbSwybvFmJ1 qfTtqj87Qj0WaZqLPsH7MqAWYLpKIhddBnMP8Ri34h616vExLlJw6WwMKuGQx2ziniyB T1Hg== X-Gm-Message-State: AOAM531qcPqLJ7bqIo9eH73tA3QoICx8+eNp5oAa1XYwtju4TzlukJeE 2ztCC3C4E0PsZKgoXSECH4w12r5DsN3vPGX8/GE= X-Google-Smtp-Source: ABdhPJxvSjUAz2+QTxe/XqXvTrFTryqHUVQxwLkjM3BLjTVVok+LSYZ+HYmq9tVVtBudqjAWFRtFZw== X-Received: by 2002:a67:2f05:: with SMTP id v5mr1046038vsv.25.1638995319749; Wed, 08 Dec 2021 12:28:39 -0800 (PST) Received: from localhost (c-73-125-89-242.hsd1.fl.comcast.net. [73.125.89.242]) by smtp.gmail.com with ESMTPSA id s10sm2465334vkf.9.2021.12.08.12.28.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 08 Dec 2021 12:28:39 -0800 (PST) From: Philip McGrath Date: Wed, 8 Dec 2021 15:27:55 -0500 Message-Id: <20211208202838.752542-1-philip@philipmcgrath.com> X-Mailer: git-send-email 2.32.0 In-Reply-To: <46a042bc08eb72a068b1e8c69bfe28cf2d4b2e53.camel@gmail.com> References: <46a042bc08eb72a068b1e8c69bfe28cf2d4b2e53.camel@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1638995358; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=azzG4iAm+UuqtJpRweu3X7VU3tTuNL0hhjc5m0vjdaU=; b=cWnSqYyiV1rCcGfjtkoExKsc4VUmiph0/zFuYinNyx+poBOSNb+aZEWh4pEoDIVmCKNL4a vdpaKB+CV4xGgd27CZ8tuOmjJIFyA9dSQTmE8yFpLfi8NwG6cP3OfIjpx5fLvNxUDB3vjf Vf/WkH/y4106tRRlgz1VSLEBBtcPOXWIn24e4+8MnZOBzE4hUIRuPvfL3jRWgj5dAhxU+o DxJYUPKMhVwuQtSZekwIoCNe7P0VJflyznn17+fH4F21GF5dUsHSBkFNF3Zirwf7yAb5up m9iS4XtfSQ4QiX0+yNiwTlisPzw+k5GVtou51hNQu6j7htEdfW+CjIJ6evEV6Q== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1638995358; a=rsa-sha256; cv=none; b=IMo2QEq/GTeDagFSx7vWj4/QmEBdx5glPrVwF+e20Cg9G+rCxS42u9XQok7PkAu5y8o74k 68e/aNs1UKx46bBGPJbGkiK9GELm9tEhOgmYq7LRDGddJpy0dYztPAKOE7N+aJFrUqn2Ej EbNmYSkjUOrqL+ij2QWMsxeDEhYX3BfIOI6sxmxiYATxXwgaMzpYSODC0rSODLTVeXf+ei JGIbFshMwu9maf0FAQf7SmWzwfLBz8NMyxgXh4jGMWMDD3hW9FyTH3T59K9qcq8SqnN7GI QUVYHweNTgJuJASk6REIV3BFEDEo9a2B5z7ry50dth0Xbb8I5tokwEZoiVYYJQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=philipmcgrath.com header.s=google header.b=P4L6i7o5; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 1.05 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=philipmcgrath.com header.s=google header.b=P4L6i7o5; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: E83DB8FC0 X-Spam-Score: 1.05 X-Migadu-Scanner: scn1.migadu.com X-TUID: h0sTPHuqyX4Q Hi! Here is a v3 of this patch series, hopefully incorporating all of the suggestions. In particular, as Timothy suggested in , I've tried to make sure the earlier patches, at least through #:absent-dependencies, are able to be applied even if there is more discussion needed on the later patches. As I mentioned in , while experimenting with v2 of this series, I discovered an issue with the install script automatically generated by npm. Patch 21 ``guix: node-build-system: Add avoid-node-gyp-rebuild phase.'' fixed the issue: I explain the details in comments there. This series also adds two additional leaf packages, `node-segfault-handler' and `node-serialport', that confirm these patches can support additional styles of native addons. In particular, because the native addon for `node-serialport' is actually in one of the intermediate packages, `node-serialport-bindings', it serves as a test case for the new `avoid-node-gyp-rebuild' phase. I've also put these patches up at , if anyone finds that useful. -Philip Philip McGrath (43): gnu: node: Avoid duplicating build phases. gnu: node: Update to 10.24.1 for bootstrapping. gnu: node: Patch shebangs in node_modules. gnu: node: Add an npmrc file to set nodedir. guix: node-build-system: Refactor patch-dependencies phase. guix: node-build-system: Add #:absent-dependencies argument. gnu: node-semver-bootstrap: Use #:absent-dependencies. gnu: node-ms-bootstrap: Use #:absent-dependencies. gnu: node-binary-search-bootstrap: Use #:absent-dependencies. gnu: node-debug-bootstrap: Use #:absent-dependencies. gnu: node-llparse-builder-bootstrap: Use #:absent-dependencies. gnu: node-llparse-frontend-bootstrap: Use #:absent-dependencies. gnu: node-llparse-bootstrap: Use #:absent-dependencies. gnu: node-semver: Use #:absent-dependencies. gnu: node-wrappy: Use #:absent-dependencies. gnu: node-once: Use #:absent-dependencies. gnu: node-irc-colors: Use #:absent-dependencies. gnu: node-irc: Use #:absent-dependencies. guix: node-build-system: Add implicit libuv input. guix: node-build-system: Add delete-lockfiles phase. guix: node-build-system: Add avoid-node-gyp-rebuild phase. gnu: Add node-inherits. gnu: Add node-safe-buffer. gnu: Add node-string-decoder. gnu: Add node-readable-stream. gnu: Add node-nan. gnu: Add node-openzwave-shared. gnu: Add node-addon-api. gnu: Add node-sqlite3. gnu: Add node-file-uri-to-path. gnu: Add node-bindings. gnu: Add node-segfault-handler. gnu: Add node-serialport-binding-abstract. gnu: Add node-serialport-parser-delimiter. gnu: Add node-serialport-parser-readling. gnu: Add node-serialport-bindings. gnu: Add node-serialport-parser-regex. gnu: Add node-serialport-parser-ready. gnu: Add node-serialport-parser-inter-byte-timeout. gnu: Add node-serialport-parser-cctalk. gnu: Add node-serialport-parser-byte-length. gnu: Add node-serialport-stream. gnu: Add node-serialport. gnu/packages/node-xyz.scm | 833 +++++++++++++++++++++++++++++-- gnu/packages/node.scm | 219 ++++---- gnu/packages/zwave.scm | 65 +++ guix/build-system/node.scm | 28 +- guix/build/node-build-system.scm | 129 ++++- 5 files changed, 1119 insertions(+), 155 deletions(-) -- 2.32.0