From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id sNpZOWISn2FzSgEAgWs5BA (envelope-from ) for ; Thu, 25 Nov 2021 05:34:42 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id q4kdNWISn2EyZgAA1q6Kng (envelope-from ) for ; Thu, 25 Nov 2021 04:34:42 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id AB57331935 for ; Thu, 25 Nov 2021 05:34:42 +0100 (CET) Received: from localhost ([::1]:47650 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mq6T3-0001sH-Q4 for larch@yhetil.org; Wed, 24 Nov 2021 23:34:41 -0500 Received: from eggs.gnu.org ([209.51.188.92]:55870) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mq6Sb-0001s2-HF for guix-patches@gnu.org; Wed, 24 Nov 2021 23:34:14 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:43923) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mq6SQ-0001zC-HU for guix-patches@gnu.org; Wed, 24 Nov 2021 23:34:13 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mq6SQ-0006Fu-Eq for guix-patches@gnu.org; Wed, 24 Nov 2021 23:34:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#49469] [PATCH] gnu: Add python-pysox. Resent-From: jgart Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 25 Nov 2021 04:34:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49469 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Arun Isaac Cc: 49469@debbugs.gnu.org Received: via spool by 49469-submit@debbugs.gnu.org id=B49469.163781482424022 (code B ref 49469); Thu, 25 Nov 2021 04:34:02 +0000 Received: (at 49469) by debbugs.gnu.org; 25 Nov 2021 04:33:44 +0000 Received: from localhost ([127.0.0.1]:55469 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mq6S8-0006FN-5m for submit@debbugs.gnu.org; Wed, 24 Nov 2021 23:33:44 -0500 Received: from mx1.dismail.de ([78.46.223.134]:33442) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mq6S3-0006F6-KJ for 49469@debbugs.gnu.org; Wed, 24 Nov 2021 23:33:42 -0500 Received: from mx1.dismail.de (localhost [127.0.0.1]) by mx1.dismail.de (OpenSMTPD) with ESMTP id 40e23f81; Thu, 25 Nov 2021 05:33:31 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=dismail.de; h=date :message-id:from:to:cc:subject:in-reply-to:references :mime-version:content-type:content-transfer-encoding; s= 20190914; bh=Ul6MqD67T/eux03xrLlSXwPEkML4YMEEPhc+vRvAd1M=; b=O09 u+jgOAGspTb4dyzspFQmWJMZf/GV+ZPNAXkkARmmZpGmzJkhvwH6/+VT3GkECODL SErtsD9gN+Dvsn1skgUb/HzpMBthmME4na7fL6AlZXtZe1Q5TbGfbs+umW6NnnsM XPMkRl8/NPYwxcZqGecskoWx9YXd8uawDLUuDyW9zClsYHn9V0AwrL3gVben+Bxh GG+dATtF+Y9hWZ57i0RMXyWbiTYdTilimk1t5TF+H2RlN9znzqCa1iBb8p0Ryizt j6TMQu9A4XrkBSuQ4KysB7PHUjLmCu4zTtGRX7S3ba4Q+mbWlAiTTKhfxVko7cN9 ZnXWVVIV8Z9+OZNc4Kw== Received: from smtp2.dismail.de ( [10.240.26.12]) by mx1.dismail.de (OpenSMTPD) with ESMTP id c3f87c2f; Thu, 25 Nov 2021 05:33:31 +0100 (CET) Received: from smtp2.dismail.de (localhost [127.0.0.1]) by smtp2.dismail.de (OpenSMTPD) with ESMTP id fc2801b7; Thu, 25 Nov 2021 05:33:31 +0100 (CET) Received: by dismail.de (OpenSMTPD) with ESMTPSA id eab1caef (TLSv1.3:AEAD-AES256-GCM-SHA384:256:NO); Thu, 25 Nov 2021 05:33:30 +0100 (CET) Date: Wed, 24 Nov 2021 23:33:28 -0500 Message-ID: <20211124233328.GB22950@gac.attlocal.net> In-Reply-To: <87k0gx8qsh.fsf@systemreboot.net> References: <20211010061525.11302-1-jgart@dismail.de> <20211010061525.11302-2-jgart@dismail.de> <87k0gx8qsh.fsf@systemreboot.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" Reply-to: jgart X-ACL-Warn: , jgart via Guix-patches From: jgart via Guix-patches via X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1637814882; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=CAz4H7RD1JJ3Ffv5zAaGLgMXoD8u7QI3zDD2DuA6f4k=; b=Zs4O6dOFDMbgeByexrr32bUF+fEY1f7rPV7aadOGDrfYeb2O9RsP5jWgTgW2zD182k4anO sZdWY7anmPFj0Wr6Fh0rbW5sM70mtZcpZtqYVcAZ1H1cnRde5+uH5daFThU1qGTwYgEhfI GVEua23SnMl0zwpPQIAGjXO95ske/b9VkTZaJXuEbxgB7t+Rc07Vpj52sQ6i+lrsX5VRDy Yrsbwa/ZUbIv01Cnr1FMa6zUvkCGFa7nft50L3kOg+rjgOz+79bySprmgvjAoxc2W7UMBd BSToJvHQb/HSA68z7BIFLh0gjb+iDlfhq6zZR0X2Thc2DjvVr39MAKWaaDlpEw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1637814882; a=rsa-sha256; cv=none; b=bUVO4GF7hb4WXH7g3sSHe7cvgnI5kunUTvpMfdEDdn9MG5F75Us2HBfXOf+f+bfvRW6RLE pwPXgY+Abx5+Y+eCnjas4jJcdd3motAi1qiaAlcZG5IxRClY5Yp4Ln/CExgDAaxv1sa0w9 WujPeBbPUPXlfyQYnqkeIUd/sEsJT5d03MeDrmRWkT5WHAF/6XWDOMf1RxJdfcRV2+bHpj 5RRnn5gp6Vv43ulR2B5I6lxJ9foGP1+DZpHn6h3YJs8YEj4MLzKXJxkpYBaqfdDQPrGE2i i18DVNqBlmha6OiTsaCLBx5P1fZrQBnI09quqqecPvpeq+iYIPalvYg582Xa3g== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=dismail.de header.s=20190914 header.b="O09 u+jg"; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -3.49 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=dismail.de header.s=20190914 header.b="O09 u+jg"; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: AB57331935 X-Spam-Score: -3.49 X-Migadu-Scanner: scn0.migadu.com X-TUID: 3lsIu9fGLGqs On Wed, 24 Nov 2021 21:55:02 +0530 Arun Isaac wrote: > > Hi jgart, > > Just a gentle reminder. I was wondering if you missed my last mail on > this patch. > > Thanks, > Arun Hi Arun, Thank you for taking the time to review these patches. Oddly enough, PyPi does not include the data folder that contains the audio files required for testing: https://github.com/rabitt/pysox/tree/master/tests/data Here is a snippet of the log showing test failures from not finding the data folder with the audio files: /gnu/store/grnpyl2q67cyymcx7p27h5l64i23i4bn-python-pysox-1.4.1/lib/python3.8/site-packages/sox/file_info.py:248: OSError ________________ TestTransformerVol.test_limiter_gain_vol_up_db ________________ self = def test_limiter_gain_vol_up_db(self): tfm = new_transformer() tfm.vol(2.0, gain_type='db', limiter_gain=0.05) actual_args = tfm.effects expected_args = ['vol', '2.000000', 'dB', '0.050000'] self.assertEqual(expected_args, actual_args) actual_log = tfm.effects_log expected_log = ['vol'] self.assertEqual(expected_log, actual_log) > actual_res = tfm.build(INPUT_FILE, OUTPUT_FILE) tests/test_transform.py:5322: _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ /gnu/store/grnpyl2q67cyymcx7p27h5l64i23i4bn-python-pysox-1.4.1/lib/python3.8/site-packages/sox/transform.py:593: in build input_format, input_filepath = self._parse_inputs( /gnu/store/grnpyl2q67cyymcx7p27h5l64i23i4bn-python-pysox-1.4.1/lib/python3.8/site-packages/sox/transform.py:493: in _parse_inputs file_info.validate_input_file(input_filepath) _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ input_filepath = '/tmp/guix-build-python-pysox-1.4.1.drv-0/sox-1.4.1/tests/data/input.wav' def validate_input_file(input_filepath): '''Input file validation function. Checks that file exists and can be processed by SoX. Parameters ---------- input_filepath : str The input filepath. ''' if not os.path.exists(input_filepath): > raise IOError( "input_filepath {} does not exist.".format(input_filepath) ) E OSError: input_filepath /tmp/guix-build-python-pysox-1.4.1.drv-0/sox-1.4.1/tests/data/input.wav does not exist. /gnu/store/grnpyl2q67cyymcx7p27h5l64i23i4bn-python-pysox-1.4.1/lib/python3.8/site-packages/sox/file_info.py:248: OSError ================= 282 failed, 373 passed, 10 skipped in 51.02s ================= Next email will contain the new patch set with your suggestions. I've included a copyright statement also. Thank you! all best, jgart