unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / Atom feed
* [bug#47852] [PATCH] gnu: Add sc-im
@ 2021-04-17 21:52 jgart via Guix-patches via
  2021-04-17 22:22 ` ElenQ Technology
                   ` (4 more replies)
  0 siblings, 5 replies; 21+ messages in thread
From: jgart via Guix-patches via @ 2021-04-17 21:52 UTC (permalink / raw)
  To: 47852; +Cc: Raghav Gururajan, raghavgururajan, Oliver Loaiza, ekaitz, hello

[-- Attachment #1: Type: text/plain, Size: 767 bytes --]

Hi Guix!

Attached is a patch for sc-im, a terminal based spreadsheet program providing a vim-like experience.

I constructed this package starting from a template provided by Ekaitz that I found below dating from over a year ago: 

https://gitlab.com/ekaitz-zarraga/guix-packages/-/blob/master/sc-im.scm

I added Ekaitz as a co-author and added both of our copyrights to the top of the file.

This new version of sc-im is from 16 days ago.

I'm currently getting the following two linter warnings:

the source file name should contain the package name
permanent redirect from https://github.com/andmarti1424/sc-im.git to https://github.com/andmarti1424/sc-im

Any suggestions for what I need to adjust to make those pass?

best regards,

jgart

[-- Attachment #2: 0001-gnu-Add-sc-im.patch --]
[-- Type: application/octet-stream, Size: 4252 bytes --]

From 62b2b692329f8db791db08700821111238ed40be Mon Sep 17 00:00:00 2001
From: jgart <jgart@dismail.de>
Date: Sat, 17 Apr 2021 17:43:16 -0400
Subject: [PATCH] gnu: Add sc-im.

    * gnu/packages/visidata.scm: New file.
    * gnu/local.mk (GNU_SYSTEM_MODULES): Add it.

    Co-authored-by: Ekaitz Zarraga <ekaitz@elenq.tech>
---
 gnu/local.mk           |  1 +
 gnu/packages/sc-im.scm | 79 ++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 80 insertions(+)
 create mode 100644 gnu/packages/sc-im.scm

diff --git a/gnu/local.mk b/gnu/local.mk
index 50b11a8ca2..ade8b400d0 100644
--- a/gnu/local.mk
+++ b/gnu/local.mk
@@ -496,6 +496,7 @@ GNU_SYSTEM_MODULES =				\
   %D%/packages/sawfish.scm			\
   %D%/packages/scanner.scm			\
   %D%/packages/scheme.scm			\
+  %D%/packages/sc-im.scm			\
   %D%/packages/screen.scm			\
   %D%/packages/scribus.scm			\
   %D%/packages/scsi.scm				\
diff --git a/gnu/packages/sc-im.scm b/gnu/packages/sc-im.scm
new file mode 100644
index 0000000000..082d40d51c
--- /dev/null
+++ b/gnu/packages/sc-im.scm
@@ -0,0 +1,79 @@
+;;; GNU Guix --- Functional package management for GNU
+;;; Copyright © 2020 Ekaitz Zarraga <ekaitz@elenq.tech>
+;;; Copyright © 2021 jgart <jgart@dismail.de>
+;;;
+;;; This file is part of GNU Guix.
+;;;
+;;; GNU Guix is free software; you can redistribute it and/or modify it
+;;; under the terms of the GNU General Public License as published by
+;;; the Free Software Foundation; either version 3 of the License, or (at
+;;; your option) any later version.
+;;;
+;;; GNU Guix is distributed in the hope that it will be useful, but
+;;; WITHOUT ANY WARRANTY; without even the implied warranty of
+;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+;;; GNU General Public License for more details.
+;;;
+;;; You should have received a copy of the GNU General Public License
+;;; along with GNU Guix.  If not, see <http://www.gnu.org/licenses/>.
+
+(define-module (gnu packages sc-im)
+  #:use-module (guix packages)
+  #:use-module (guix git-download)
+  #:use-module (guix download)
+  #:use-module (guix build-system gnu)
+  #:use-module ((guix licenses) #:prefix license:)
+  #:use-module (gnu packages)
+  #:use-module (gnu packages base)
+  #:use-module (gnu packages pkg-config)
+  #:use-module (gnu packages maths)
+  #:use-module (gnu packages statistics)
+  #:use-module (gnu packages xml)
+  #:use-module (gnu packages compression)
+  #:use-module (gnu packages bison)
+  #:use-module (gnu packages ncurses))
+
+(define-public sc-im
+  (let ((commit-ref "75ae3806844821cba1b2e3fdb9237d737944e850"))
+    (package
+      (name "sc-im")
+      (version "0.8.1")
+      (source (origin
+                (method git-fetch)
+                (uri
+                  (git-reference
+                    (url "https://github.com/andmarti1424/sc-im.git")
+                    (commit commit-ref)))
+                (sha256
+                  (base32
+                    "1i1yq5mh9d7yi1bkgaq4p1lr8zrxhlvqmjnj33wmg5v6vpfim1h0"))))
+      (build-system gnu-build-system)
+      (arguments
+        ;; There are no tests at the moment.
+        ;; https://github.com/andmarti1424/sc-im/issues/537
+        ;; https://github.com/andmarti1424/sc-im/pull/385
+        `(#:tests? #f
+          #:make-flags (list "-C" "src" "CC=gcc"
+                         (string-append "prefix=" (assoc-ref %outputs "out")))
+          #:phases
+            (modify-phases
+               %standard-phases
+                 (delete 'configure))))
+      (inputs
+        `(("gnuplot" ,gnuplot)
+          ("libxls" ,libxls)
+          ("libxlsxwriter" ,libxlsxwriter)
+          ("libxml2" ,libxml2)
+          ("libzip" ,libzip)
+          ("ncurses" ,ncurses)))
+      (native-inputs
+        `(("pkg-config" ,pkg-config)
+          ("which" ,which)
+          ("bison" ,bison)))
+      (synopsis "Spreadsheet program with vim-like keybindings")
+      (description
+ "@code{sc-im} is a highly configurable spreadsheet program
+ providing a vim-like experience.  @code{sc-im} supports @{gnuplot} interaction,
+ functions for sorting and filtering, 256 color support, and much more.")
+      (home-page "https://github.com/andmarti1424/sc-im")
+      (license license:bsd-4))))
-- 
2.29.3


^ permalink raw reply	[flat|nested] 21+ messages in thread

* [bug#47852] [PATCH] gnu: Add sc-im
  2021-04-17 21:52 [bug#47852] [PATCH] gnu: Add sc-im jgart via Guix-patches via
@ 2021-04-17 22:22 ` ElenQ Technology
  2021-04-17 23:29 ` Jack Hill
                   ` (3 subsequent siblings)
  4 siblings, 0 replies; 21+ messages in thread
From: ElenQ Technology @ 2021-04-17 22:22 UTC (permalink / raw)
  To: jgart; +Cc: rg, olv345, 47852, raghavgururajan

Hey!

‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
On Saturday, April 17, 2021 11:52 PM, jgart <jgart@dismail.de> wrote:

> Hi Guix!
>
> Attached is a patch for sc-im, a terminal based spreadsheet program providing a vim-like experience.
>
> I constructed this package starting from a template provided by Ekaitz that I found below dating from over a year ago:
>
> https://gitlab.com/ekaitz-zarraga/guix-packages/-/blob/master/sc-im.scm
>
> I added Ekaitz as a co-author and added both of our copyrights to the top of the file.
>
> This new version of sc-im is from 16 days ago.
>
> I'm currently getting the following two linter warnings:
>
> the source file name should contain the package name
> permanent redirect from https://github.com/andmarti1424/sc-im.git to https://github.com/andmarti1424/sc-im
>
> Any suggestions for what I need to adjust to make those pass?
>
> best regards,
>
> jgart


I didn't expect this!

My original package was broken, but I left it in my repo so IDK
if taking that as a base was a good idea.
I was trying to package a more complete solution and I left
the package broken... I'm not sure about all the compile flags
you set, you may be missing some interesting plugin support.

I'm taking a look to it.

The first issue related with the name of the package is this:

```
guix/gnu/packages/sc-im.scm:41:14: sc-im@0.8.1: the source file name should contain the package name
```

In order to solve this you can use this in the origin desc:

```
        (file-name (git-file-name name version))
```

This is going to clone the repo to an specific filename that
matches Guix's naming style and it's going to remove the
warning.

The second:

```
gnu/packages/sc-im.scm:41:14: sc-im@0.8.1: permanent redirect from https://github.com/andmarti1424/sc-im.git to https://github.com/andmarti1424/sc-im
```

Just change the url by the other and you're done.

Also I wouldn't add the whole package in an independent file.
It may fit better in other of the categories.

HTH!

Thanks for keeping my name there, but you can clear it with
no issue, this is all your merit, my man.

Best,
Ekaitz




^ permalink raw reply	[flat|nested] 21+ messages in thread

* [bug#47852] [PATCH] gnu: Add sc-im
  2021-04-17 21:52 [bug#47852] [PATCH] gnu: Add sc-im jgart via Guix-patches via
  2021-04-17 22:22 ` ElenQ Technology
@ 2021-04-17 23:29 ` Jack Hill
  2021-04-17 23:54 ` jgart via Guix-patches via
                   ` (2 subsequent siblings)
  4 siblings, 0 replies; 21+ messages in thread
From: Jack Hill @ 2021-04-17 23:29 UTC (permalink / raw)
  To: jgart
  Cc: Oliver Loaiza, ekaitz, raghavgururajan, hello, Raghav Gururajan, 47852

[-- Attachment #1: Type: text/plain, Size: 5112 bytes --]

On Sat, 17 Apr 2021, jgart via Guix-patches via wrote:

> Hi Guix!
>
> Attached is a patch for sc-im, a terminal based spreadsheet program providing a vim-like experience.

Interesting program, thanks for working on the package

> I added Ekaitz as a co-author and added both of our copyrights to the top of the file.

Glad to see this work being picket up and that we can collaborate across 
time.

> This new version of sc-im is from 16 days ago.
>
> I'm currently getting the following two linter warnings:
>
> the source file name should contain the package name
> permanent redirect from https://github.com/andmarti1424/sc-im.git to https://github.com/andmarti1424/sc-im
>
> Any suggestions for what I need to adjust to make those pass?

I have some inline suggestions as follows:


From 62b2b692329f8db791db08700821111238ed40be Mon Sep 17 00:00:00 2001
From: jgart <jgart@dismail.de>
Date: Sat, 17 Apr 2021 17:43:16 -0400
Subject: [PATCH] gnu: Add sc-im.

     * gnu/packages/visidata.scm: New file.

Should be sc-im.scm there :)

I have no opinion on if this warrants its own file, but I expect others 
would be willing to comment.

     * gnu/local.mk (GNU_SYSTEM_MODULES): Add it.

     Co-authored-by: Ekaitz Zarraga <ekaitz@elenq.tech>


+;;; GNU Guix --- Functional package management for GNU
+;;; Copyright © 2020 Ekaitz Zarraga <ekaitz@elenq.tech>
+;;; Copyright © 2021 jgart <jgart@dismail.de>
+;;;
+;;; This file is part of GNU Guix.
+;;;
+;;; GNU Guix is free software; you can redistribute it and/or modify it
+;;; under the terms of the GNU General Public License as published by
+;;; the Free Software Foundation; either version 3 of the License, or (at
+;;; your option) any later version.
+;;;
+;;; GNU Guix is distributed in the hope that it will be useful, but
+;;; WITHOUT ANY WARRANTY; without even the implied warranty of
+;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+;;; GNU General Public License for more details.
+;;;
+;;; You should have received a copy of the GNU General Public License
+;;; along with GNU Guix.  If not, see <http://www.gnu.org/licenses/>.
+
+(define-module (gnu packages sc-im)
+  #:use-module (guix packages)
+  #:use-module (guix git-download)
+  #:use-module (guix download)
+  #:use-module (guix build-system gnu)
+  #:use-module ((guix licenses) #:prefix license:)
+  #:use-module (gnu packages)
+  #:use-module (gnu packages base)
+  #:use-module (gnu packages pkg-config)
+  #:use-module (gnu packages maths)
+  #:use-module (gnu packages statistics)
+  #:use-module (gnu packages xml)
+  #:use-module (gnu packages compression)
+  #:use-module (gnu packages bison)
+  #:use-module (gnu packages ncurses))
+
+(define-public sc-im
+  (let ((commit-ref "75ae3806844821cba1b2e3fdb9237d737944e850"))
+    (package
+      (name "sc-im")
+      (version "0.8.1")
+      (source (origin
+                (method git-fetch)
+                (uri
+                  (git-reference
+                    (url "https://github.com/andmarti1424/sc-im.git")
+                    (commit commit-ref)))

You can remove the .git from the url to clear up the permanent redirect 
lint warning.

In other packages, we use the tag directly with something like

(commit (string-append "v" version))

and are thus able to forgo the let binding. Unless there is a reason to 
think upstream will move the tag to a different commit, I recommend doing 
that here too.

Also, adding `(file-name (git-file-name name version))` to the origin 
specification will clear up the file name lint warning.

+                (sha256
+                  (base32
+                    "1i1yq5mh9d7yi1bkgaq4p1lr8zrxhlvqmjnj33wmg5v6vpfim1h0"))))
+      (build-system gnu-build-system)
+      (arguments
+        ;; There are no tests at the moment.
+        ;; https://github.com/andmarti1424/sc-im/issues/537
+        ;; https://github.com/andmarti1424/sc-im/pull/385
+        `(#:tests? #f

Thanks for adding the comment about the lack of test.

+          #:make-flags (list "-C" "src" "CC=gcc"

We prefer `(string-append "CC=" ,(cc-for-target))` which helps when 
cross-compiling

+                         (string-append "prefix=" (assoc-ref %outputs "out")))
+          #:phases
+            (modify-phases
+               %standard-phases
+                 (delete 'configure))))
+      (inputs
+        `(("gnuplot" ,gnuplot)
+          ("libxls" ,libxls)
+          ("libxlsxwriter" ,libxlsxwriter)
+          ("libxml2" ,libxml2)
+          ("libzip" ,libzip)
+          ("ncurses" ,ncurses)))
+      (native-inputs
+        `(("pkg-config" ,pkg-config)
+          ("which" ,which)
+          ("bison" ,bison)))
+      (synopsis "Spreadsheet program with vim-like keybindings")
+      (description
+ "@code{sc-im} is a highly configurable spreadsheet program
+ providing a vim-like experience.  @code{sc-im} supports @{gnuplot} interaction,
+ functions for sorting and filtering, 256 color support, and much more.")
+      (home-page "https://github.com/andmarti1424/sc-im")
+      (license license:bsd-4))))
-- 
2.29.3


Can you send an updated patch?

Best,
Jack

^ permalink raw reply	[flat|nested] 21+ messages in thread

* [bug#47852] [PATCH] gnu: Add sc-im
  2021-04-17 21:52 [bug#47852] [PATCH] gnu: Add sc-im jgart via Guix-patches via
  2021-04-17 22:22 ` ElenQ Technology
  2021-04-17 23:29 ` Jack Hill
@ 2021-04-17 23:54 ` jgart via Guix-patches via
  2021-04-18  0:32 ` jgart via Guix-patches via
  2021-11-19  1:22 ` [bug#47852] [PATCH 1/2 v6] " jgart via Guix-patches via
  4 siblings, 0 replies; 21+ messages in thread
From: jgart via Guix-patches via @ 2021-04-17 23:54 UTC (permalink / raw)
  To: 47852; +Cc: Raghav Gururajan, hello, Oliver Loaiza, raghavgururajan

[-- Attachment #1: Type: text/plain, Size: 3622 bytes --]

Attached is the updated patch with Ekaitz's suggestions. The linter is now a happy gnu!

> Also I wouldn't add the whole package in an independent file.
> It may fit better in other of the categories.

I thought of that but I couldn't find a place I was happy with.

calcurse and visidata are two other packages that also have their own file. 

Maybe these two packages can be merged in the future with sc-im?

> I'm not sure about all the compile flags
> you set, you may be missing some interesting plugin support.

I left lua support out since that is an optional feature.

The sc-im package in nixpkgs also leaves it out:

https://github.com/NixOS/nixpkgs/blob/nixos-unstable/pkgs/applications/misc/sc-im/default.nix#L35

I'm waiting until sc-im has guile support. ;)

Let me know if there are any other compiler features you think should be included.

I left tmux as the clipboard. It is already set in the Makefile by default.

I'll probably inherit from this package and substitute* for xclip instead, locally.

Does upstream guix prefer two versions of this package (A version compiled with tmux support and a version compiled with xclip support)?

all the best,

jgart

ps

Ekaitz, Saludos desde Miami!

Vas a venir a el guix meetup el próximo sábado? Cambié la hora a una hora normal ;)

https://events.nixnet.services/events/27955ca1-0aee-4ec5-be20-48e6c45fd0f6



April 17, 2021 6:22 PM, "ElenQ Technology" <hello@elenq.tech> wrote:

> Hey!
> 
> ‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
> On Saturday, April 17, 2021 11:52 PM, jgart <jgart@dismail.de> wrote:
> 
>> Hi Guix!
>> 
>> Attached is a patch for sc-im, a terminal based spreadsheet program providing a vim-like
>> experience.
>> 
>> I constructed this package starting from a template provided by Ekaitz that I found below dating
>> from over a year ago:
>> 
>> https://gitlab.com/ekaitz-zarraga/guix-packages/-/blob/master/sc-im.scm
>> 
>> I added Ekaitz as a co-author and added both of our copyrights to the top of the file.
>> 
>> This new version of sc-im is from 16 days ago.
>> 
>> I'm currently getting the following two linter warnings:
>> 
>> the source file name should contain the package name
>> permanent redirect from https://github.com/andmarti1424/sc-im.git to
>> https://github.com/andmarti1424/sc-im
>> 
>> Any suggestions for what I need to adjust to make those pass?
>> 
>> best regards,
>> 
>> jgart
> 
> I didn't expect this!
> 
> My original package was broken, but I left it in my repo so IDK
> if taking that as a base was a good idea.
> I was trying to package a more complete solution and I left
> the package broken... 
> 
> I'm taking a look to it.
> 
> The first issue related with the name of the package is this:
> 
> ```
> guix/gnu/packages/sc-im.scm:41:14: sc-im@0.8.1: the source file name should contain the package
> name
> ```
> 
> In order to solve this you can use this in the origin desc:
> 
> ```
> (file-name (git-file-name name version))
> ```
> 
> This is going to clone the repo to an specific filename that
> matches Guix's naming style and it's going to remove the
> warning.
> 
> The second:
> 
> ```
> gnu/packages/sc-im.scm:41:14: sc-im@0.8.1: permanent redirect from
> https://github.com/andmarti1424/sc-im.git to https://github.com/andmarti1424/sc-im
> ```
> 
> Just change the url by the other and you're done.
> 
> 
> HTH!
> 
> Thanks for keeping my name there, but you can clear it with
> no issue, this is all your merit, my man.
> 
> Best,
> Ekaitz

[-- Attachment #2: 0001-gnu-Add-sc-im.patch --]
[-- Type: application/octet-stream, Size: 4310 bytes --]

From 0809167ce22e4d10fa113bb9276b191cfc458da3 Mon Sep 17 00:00:00 2001
From: jgart <jgart@dismail.de>
Date: Sat, 17 Apr 2021 17:43:16 -0400
Subject: [PATCH] gnu: Add sc-im.

    * gnu/packages/visidata.scm: New file.
    * gnu/local.mk (GNU_SYSTEM_MODULES): Add it.

    Co-authored-by: Ekaitz Zarraga <ekaitz@elenq.tech>
---
 gnu/local.mk           |  1 +
 gnu/packages/sc-im.scm | 80 ++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 81 insertions(+)
 create mode 100644 gnu/packages/sc-im.scm

diff --git a/gnu/local.mk b/gnu/local.mk
index 50b11a8ca2..ade8b400d0 100644
--- a/gnu/local.mk
+++ b/gnu/local.mk
@@ -496,6 +496,7 @@ GNU_SYSTEM_MODULES =				\
   %D%/packages/sawfish.scm			\
   %D%/packages/scanner.scm			\
   %D%/packages/scheme.scm			\
+  %D%/packages/sc-im.scm			\
   %D%/packages/screen.scm			\
   %D%/packages/scribus.scm			\
   %D%/packages/scsi.scm				\
diff --git a/gnu/packages/sc-im.scm b/gnu/packages/sc-im.scm
new file mode 100644
index 0000000000..3c13d61148
--- /dev/null
+++ b/gnu/packages/sc-im.scm
@@ -0,0 +1,80 @@
+;;; GNU Guix --- Functional package management for GNU
+;;; Copyright © 2020 Ekaitz Zarraga <ekaitz@elenq.tech>
+;;; Copyright © 2021 jgart <jgart@dismail.de>
+;;;
+;;; This file is part of GNU Guix.
+;;;
+;;; GNU Guix is free software; you can redistribute it and/or modify it
+;;; under the terms of the GNU General Public License as published by
+;;; the Free Software Foundation; either version 3 of the License, or (at
+;;; your option) any later version.
+;;;
+;;; GNU Guix is distributed in the hope that it will be useful, but
+;;; WITHOUT ANY WARRANTY; without even the implied warranty of
+;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+;;; GNU General Public License for more details.
+;;;
+;;; You should have received a copy of the GNU General Public License
+;;; along with GNU Guix.  If not, see <http://www.gnu.org/licenses/>.
+
+(define-module (gnu packages sc-im)
+  #:use-module (guix packages)
+  #:use-module (guix git-download)
+  #:use-module (guix download)
+  #:use-module (guix build-system gnu)
+  #:use-module ((guix licenses) #:prefix license:)
+  #:use-module (gnu packages)
+  #:use-module (gnu packages base)
+  #:use-module (gnu packages pkg-config)
+  #:use-module (gnu packages maths)
+  #:use-module (gnu packages statistics)
+  #:use-module (gnu packages xml)
+  #:use-module (gnu packages compression)
+  #:use-module (gnu packages bison)
+  #:use-module (gnu packages ncurses))
+
+(define-public sc-im
+  (let ((commit-ref "75ae3806844821cba1b2e3fdb9237d737944e850"))
+    (package
+      (name "sc-im")
+      (version "0.8.1")
+      (source (origin
+                (method git-fetch)
+                (uri
+                  (git-reference
+                    (url "https://github.com/andmarti1424/sc-im")
+                    (commit commit-ref)))
+                    (file-name (git-file-name name version))
+                (sha256
+                  (base32
+                    "1i1yq5mh9d7yi1bkgaq4p1lr8zrxhlvqmjnj33wmg5v6vpfim1h0"))))
+      (build-system gnu-build-system)
+      (arguments
+        ;; There are no tests at the moment.
+        ;; https://github.com/andmarti1424/sc-im/issues/537
+        ;; https://github.com/andmarti1424/sc-im/pull/385
+        `(#:tests? #f
+          #:make-flags (list "-C" "src" "CC=gcc"
+                         (string-append "prefix=" (assoc-ref %outputs "out")))
+          #:phases
+            (modify-phases
+               %standard-phases
+                 (delete 'configure))))
+      (inputs
+        `(("gnuplot" ,gnuplot)
+          ("libxls" ,libxls)
+          ("libxlsxwriter" ,libxlsxwriter)
+          ("libxml2" ,libxml2)
+          ("libzip" ,libzip)
+          ("ncurses" ,ncurses)))
+      (native-inputs
+        `(("pkg-config" ,pkg-config)
+          ("which" ,which)
+          ("bison" ,bison)))
+      (synopsis "Spreadsheet program with vim-like keybindings")
+      (description
+ "@code{sc-im} is a highly configurable spreadsheet program
+ providing a vim-like experience.  @code{sc-im} supports @{gnuplot} interaction,
+ functions for sorting and filtering, 256 color support, and much more.")
+      (home-page "https://github.com/andmarti1424/sc-im")
+      (license license:bsd-4))))
-- 
2.29.3


^ permalink raw reply	[flat|nested] 21+ messages in thread

* [bug#47852] [PATCH] gnu: Add sc-im
  2021-04-17 21:52 [bug#47852] [PATCH] gnu: Add sc-im jgart via Guix-patches via
                   ` (2 preceding siblings ...)
  2021-04-17 23:54 ` jgart via Guix-patches via
@ 2021-04-18  0:32 ` jgart via Guix-patches via
  2021-04-18  9:25   ` Xinglu Chen
  2021-04-18 15:39   ` jgart via Guix-patches via
  2021-11-19  1:22 ` [bug#47852] [PATCH 1/2 v6] " jgart via Guix-patches via
  4 siblings, 2 replies; 21+ messages in thread
From: jgart via Guix-patches via @ 2021-04-18  0:32 UTC (permalink / raw)
  To: 47852; +Cc: Raghav Gururajan, jackhill, hello, Oliver Loaiza, raghavgururajan

[-- Attachment #1: Type: text/plain, Size: 4014 bytes --]

I attached an updated patch also including Jack's suggestions.

Thank you Raghav for help with sanity debugging over xmpp.

prefix is not PREFIX ;)

all the best,

jgart

April 17, 2021 7:54 PM, "jgart" <jgart@dismail.de> wrote:

> Attached is the updated patch with Ekaitz's suggestions. The linter is now a happy gnu!
> 
>> Also I wouldn't add the whole package in an independent file.
>> It may fit better in other of the categories.
> 
> I thought of that but I couldn't find a place I was happy with.
> 
> calcurse and visidata are two other packages that also have their own file.
> 
> Maybe these two packages can be merged in the future with sc-im?
> 
>> I'm not sure about all the compile flags
>> you set, you may be missing some interesting plugin support.
> 
> I left lua support out since that is an optional feature.
> 
> The sc-im package in nixpkgs also leaves it out:
> 
> https://github.com/NixOS/nixpkgs/blob/nixos-unstable/pkgs/applications/misc/sc-im/default.nix#L35
> 
> I'm waiting until sc-im has guile support. ;)
> 
> Let me know if there are any other compiler features you think should be included.
> 
> I left tmux as the clipboard. It is already set in the Makefile by default.
> 
> I'll probably inherit from this package and substitute* for xclip instead, locally.
> 
> Does upstream guix prefer two versions of this package (A version compiled with tmux support and a
> version compiled with xclip support)?
> 
> all the best,
> 
> jgart
> 
> ps
> 
> Ekaitz, Saludos desde Miami!
> 
> Vas a venir a el guix meetup el próximo sábado? Cambié la hora a una hora normal ;)
> 
> https://events.nixnet.services/events/27955ca1-0aee-4ec5-be20-48e6c45fd0f6
> 
> April 17, 2021 6:22 PM, "ElenQ Technology" <hello@elenq.tech> wrote:
> 
>> Hey!
>> 
>> ‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
>> On Saturday, April 17, 2021 11:52 PM, jgart <jgart@dismail.de> wrote:
>> 
>>> Hi Guix!
>>> 
>>> Attached is a patch for sc-im, a terminal based spreadsheet program providing a vim-like
>>> experience.
>>> 
>>> I constructed this package starting from a template provided by Ekaitz that I found below dating
>>> from over a year ago:
>>> 
>>> https://gitlab.com/ekaitz-zarraga/guix-packages/-/blob/master/sc-im.scm
>>> 
>>> I added Ekaitz as a co-author and added both of our copyrights to the top of the file.
>>> 
>>> This new version of sc-im is from 16 days ago.
>>> 
>>> I'm currently getting the following two linter warnings:
>>> 
>>> the source file name should contain the package name
>>> permanent redirect from https://github.com/andmarti1424/sc-im.git to
>>> https://github.com/andmarti1424/sc-im
>>> 
>>> Any suggestions for what I need to adjust to make those pass?
>>> 
>>> best regards,
>>> 
>>> jgart
>> 
>> I didn't expect this!
>> 
>> My original package was broken, but I left it in my repo so IDK
>> if taking that as a base was a good idea.
>> I was trying to package a more complete solution and I left
>> the package broken...
>> 
>> I'm taking a look to it.
>> 
>> The first issue related with the name of the package is this:
>> 
>> ```
>> guix/gnu/packages/sc-im.scm:41:14: sc-im@0.8.1: the source file name should contain the package
>> name
>> ```
>> 
>> In order to solve this you can use this in the origin desc:
>> 
>> ```
>> (file-name (git-file-name name version))
>> ```
>> 
>> This is going to clone the repo to an specific filename that
>> matches Guix's naming style and it's going to remove the
>> warning.
>> 
>> The second:
>> 
>> ```
>> gnu/packages/sc-im.scm:41:14: sc-im@0.8.1: permanent redirect from
>> https://github.com/andmarti1424/sc-im.git to https://github.com/andmarti1424/sc-im
>> ```
>> 
>> Just change the url by the other and you're done.
>> 
>> HTH!
>> 
>> Thanks for keeping my name there, but you can clear it with
>> no issue, this is all your merit, my man.
>> 
>> Best,
>> Ekaitz

[-- Attachment #2: 0001-gnu-Add-sc-im.patch --]
[-- Type: application/octet-stream, Size: 4378 bytes --]

From aa1c940ebe14b6d3999f6cb57fc42b98d5b0cb3d Mon Sep 17 00:00:00 2001
From: jgart <jgart@dismail.de>
Date: Sat, 17 Apr 2021 17:43:16 -0400
Subject: [PATCH] gnu: Add sc-im.

    * gnu/packages/visidata.scm: New file.
    * gnu/local.mk (GNU_SYSTEM_MODULES): Add it.

    Co-authored-by: Ekaitz Zarraga <ekaitz@elenq.tech>
---
 gnu/local.mk           |  1 +
 gnu/packages/sc-im.scm | 82 ++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 83 insertions(+)
 create mode 100644 gnu/packages/sc-im.scm

diff --git a/gnu/local.mk b/gnu/local.mk
index 50b11a8ca2..ade8b400d0 100644
--- a/gnu/local.mk
+++ b/gnu/local.mk
@@ -496,6 +496,7 @@ GNU_SYSTEM_MODULES =				\
   %D%/packages/sawfish.scm			\
   %D%/packages/scanner.scm			\
   %D%/packages/scheme.scm			\
+  %D%/packages/sc-im.scm			\
   %D%/packages/screen.scm			\
   %D%/packages/scribus.scm			\
   %D%/packages/scsi.scm				\
diff --git a/gnu/packages/sc-im.scm b/gnu/packages/sc-im.scm
new file mode 100644
index 0000000000..8ff482365d
--- /dev/null
+++ b/gnu/packages/sc-im.scm
@@ -0,0 +1,82 @@
+;;; GNU Guix --- Functional package management for GNU
+;;; Copyright © 2020 Ekaitz Zarraga <ekaitz@elenq.tech>
+;;; Copyright © 2021 jgart <jgart@dismail.de>
+;;;
+;;; This file is part of GNU Guix.
+;;;
+;;; GNU Guix is free software; you can redistribute it and/or modify it
+;;; under the terms of the GNU General Public License as published by
+;;; the Free Software Foundation; either version 3 of the License, or (at
+;;; your option) any later version.
+;;;
+;;; GNU Guix is distributed in the hope that it will be useful, but
+;;; WITHOUT ANY WARRANTY; without even the implied warranty of
+;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+;;; GNU General Public License for more details.
+;;;
+;;; You should have received a copy of the GNU General Public License
+;;; along with GNU Guix.  If not, see <http://www.gnu.org/licenses/>.
+
+(define-module (gnu packages sc-im)
+  #:use-module (guix packages)
+  #:use-module (guix git-download)
+  #:use-module (guix download)
+  #:use-module (guix utils)
+  #:use-module (guix build-system gnu)
+  #:use-module ((guix licenses) #:prefix license:)
+  #:use-module (gnu packages)
+  #:use-module (gnu packages base)
+  #:use-module (gnu packages pkg-config)
+  #:use-module (gnu packages maths)
+  #:use-module (gnu packages statistics)
+  #:use-module (gnu packages xml)
+  #:use-module (gnu packages compression)
+  #:use-module (gnu packages bison)
+  #:use-module (gnu packages ncurses))
+
+(define-public sc-im
+  (let ((commit-ref "75ae3806844821cba1b2e3fdb9237d737944e850"))
+    (package
+      (name "sc-im")
+      (version "0.8.1")
+      (source (origin
+                (method git-fetch)
+                (uri
+                  (git-reference
+                    (url "https://github.com/andmarti1424/sc-im")
+                    (commit commit-ref)))
+                    (file-name (git-file-name name version))
+                (sha256
+                  (base32
+                    "1i1yq5mh9d7yi1bkgaq4p1lr8zrxhlvqmjnj33wmg5v6vpfim1h0"))))
+      (build-system gnu-build-system)
+      (arguments
+        ;; There are no tests at the moment.
+        ;; https://github.com/andmarti1424/sc-im/issues/537
+        ;; https://github.com/andmarti1424/sc-im/pull/385
+        `(#:tests? #f
+          #:make-flags (list "-C" "src"
+                          (string-append "CC=" ,(cc-for-target))
+                          (string-append "prefix=" %output))
+          #:phases
+            (modify-phases
+               %standard-phases
+                 (delete 'configure))))
+      (inputs
+        `(("gnuplot" ,gnuplot)
+          ("libxls" ,libxls)
+          ("libxlsxwriter" ,libxlsxwriter)
+          ("libxml2" ,libxml2)
+          ("libzip" ,libzip)
+          ("ncurses" ,ncurses)))
+      (native-inputs
+        `(("pkg-config" ,pkg-config)
+          ("which" ,which)
+          ("bison" ,bison)))
+      (synopsis "Spreadsheet program with vim-like keybindings")
+      (description
+ "@code{sc-im} is a highly configurable spreadsheet program
+ providing a vim-like experience.  @code{sc-im} supports @{gnuplot} interaction,
+ functions for sorting and filtering, 256 color support, and much more.")
+      (home-page "https://github.com/andmarti1424/sc-im")
+      (license license:bsd-4))))
-- 
2.29.3


^ permalink raw reply	[flat|nested] 21+ messages in thread

* [bug#47852] [PATCH] gnu: Add sc-im
  2021-04-18  0:32 ` jgart via Guix-patches via
@ 2021-04-18  9:25   ` Xinglu Chen
  2021-04-18 15:39   ` jgart via Guix-patches via
  1 sibling, 0 replies; 21+ messages in thread
From: Xinglu Chen @ 2021-04-18  9:25 UTC (permalink / raw)
  To: jgart, 47852
  Cc: Raghav Gururajan, jackhill, raghavgururajan, Oliver Loaiza, hello

Thank you for working on this! I have some comments to add.

>     * gnu/packages/visidata.scm: New file.
>     * gnu/local.mk (GNU_SYSTEM_MODULES): Add it.

I suggest adding it to (gnu packages terminals) instead of creating a
new file.  You will find asciinema and fzf there.

> +(define-public sc-im
> +  (let ((commit-ref "75ae3806844821cba1b2e3fdb9237d737944e850"))
> +    (package
> +      (name "sc-im")
> +      (version "0.8.1")
> +      (source (origin
> +                (method git-fetch)
> +                (uri
> +                  (git-reference
> +                    (url "https://github.com/andmarti1424/sc-im")
> +                    (commit commit-ref)))

Why not just use ‘version’, or (string-append ... version) if needed?

> +                    (file-name (git-file-name name version))

Indentation is a bit off here.

> +      (synopsis "Spreadsheet program with vim-like keybindings")
> +      (description
> + "@code{sc-im} is a highly configurable spreadsheet program
> + providing a vim-like experience.  @code{sc-im} supports @{gnuplot} interaction,
> + functions for sorting and filtering, 256 color support, and much more.")
> +      (home-page "https://github.com/andmarti1424/sc-im")

Nit: ‘home-page’ usually goes above ‘synopsis’.





^ permalink raw reply	[flat|nested] 21+ messages in thread

* [bug#47852] [PATCH] gnu: Add sc-im
  2021-04-18  0:32 ` jgart via Guix-patches via
  2021-04-18  9:25   ` Xinglu Chen
@ 2021-04-18 15:39   ` jgart via Guix-patches via
  2021-04-18 16:40     ` Xinglu Chen
                       ` (2 more replies)
  1 sibling, 3 replies; 21+ messages in thread
From: jgart via Guix-patches via @ 2021-04-18 15:39 UTC (permalink / raw)
  To: Xinglu Chen, 47852
  Cc: Raghav Gururajan, jackhill, raghavgururajan, Oliver Loaiza, hello

[-- Attachment #1: Type: text/plain, Size: 2246 bytes --]

Hi Xinglu,

I appreciate your review. I attached an updated patch with your suggestions. Thank you for pointing those out. 

I moved home-page closer to the top so that I can reuse it in the url field. 

I've seen a few examples in gnu/packages of this practice and I think it is quite nice.

> I suggest adding it to (gnu packages terminals) instead of creating a
> new file. You will find asciinema and fzf there.

I'm not sure if it makes sense to me for sc-im to go into terminals. 

It seems like terminals has mostly terminal emulators. 

Like I pointed out in my previous email, why wouldn't calcurse and visidata also go into the terminals module?

sc-im is a spreadsheet program for the terminal in the same way that calcurse is a calendar program for the terminal.

Maybe we can do a clean up soon and put all these programs in a new module? 

Let me know if there is anything else I should change.

all the best,

jgart


April 18, 2021 5:25 AM, "Xinglu Chen" <public@yoctocell.xyz> wrote:

> Thank you for working on this! I have some comments to add.
> 
>> * gnu/packages/visidata.scm: New file.
>> * gnu/local.mk (GNU_SYSTEM_MODULES): Add it.
> 
> I suggest adding it to (gnu packages terminals) instead of creating a
> new file. You will find asciinema and fzf there.
> 
>> +(define-public sc-im
>> + (let ((commit-ref "75ae3806844821cba1b2e3fdb9237d737944e850"))
>> + (package
>> + (name "sc-im")
>> + (version "0.8.1")
>> + (source (origin
>> + (method git-fetch)
>> + (uri
>> + (git-reference
>> + (url "https://github.com/andmarti1424/sc-im")
>> + (commit commit-ref)))
> 
> Why not just use ‘version’, or (string-append ... version) if needed?
> 
>> + (file-name (git-file-name name version))
> 
> Indentation is a bit off here.
> 
>> + (synopsis "Spreadsheet program with vim-like keybindings")
>> + (description
>> + "@code{sc-im} is a highly configurable spreadsheet program
>> + providing a vim-like experience. @code{sc-im} supports @{gnuplot} interaction,
>> + functions for sorting and filtering, 256 color support, and much more.")
>> + (home-page "https://github.com/andmarti1424/sc-im")
> 
> Nit: ‘home-page’ usually goes above ‘synopsis’.

[-- Attachment #2: 0001-gnu-Add-sc-im.patch --]
[-- Type: application/octet-stream, Size: 4290 bytes --]

From 9e3343a2ced46f6af124f44c276b8bfe8aa924d4 Mon Sep 17 00:00:00 2001
From: jgart <jgart@dismail.de>
Date: Sat, 17 Apr 2021 17:43:16 -0400
Subject: [PATCH] gnu: Add sc-im.

    * gnu/packages/visidata.scm: New file.
    * gnu/local.mk (GNU_SYSTEM_MODULES): Add it.

    Co-authored-by: Ekaitz Zarraga <ekaitz@elenq.tech>
---
 gnu/local.mk           |  1 +
 gnu/packages/sc-im.scm | 81 ++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 82 insertions(+)
 create mode 100644 gnu/packages/sc-im.scm

diff --git a/gnu/local.mk b/gnu/local.mk
index 50b11a8ca2..ade8b400d0 100644
--- a/gnu/local.mk
+++ b/gnu/local.mk
@@ -496,6 +496,7 @@ GNU_SYSTEM_MODULES =				\
   %D%/packages/sawfish.scm			\
   %D%/packages/scanner.scm			\
   %D%/packages/scheme.scm			\
+  %D%/packages/sc-im.scm			\
   %D%/packages/screen.scm			\
   %D%/packages/scribus.scm			\
   %D%/packages/scsi.scm				\
diff --git a/gnu/packages/sc-im.scm b/gnu/packages/sc-im.scm
new file mode 100644
index 0000000000..43ab768552
--- /dev/null
+++ b/gnu/packages/sc-im.scm
@@ -0,0 +1,81 @@
+;;; GNU Guix --- Functional package management for GNU
+;;; Copyright © 2020 Ekaitz Zarraga <ekaitz@elenq.tech>
+;;; Copyright © 2021 jgart <jgart@dismail.de>
+;;;
+;;; This file is part of GNU Guix.
+;;;
+;;; GNU Guix is free software; you can redistribute it and/or modify it
+;;; under the terms of the GNU General Public License as published by
+;;; the Free Software Foundation; either version 3 of the License, or (at
+;;; your option) any later version.
+;;;
+;;; GNU Guix is distributed in the hope that it will be useful, but
+;;; WITHOUT ANY WARRANTY; without even the implied warranty of
+;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+;;; GNU General Public License for more details.
+;;;
+;;; You should have received a copy of the GNU General Public License
+;;; along with GNU Guix.  If not, see <http://www.gnu.org/licenses/>.
+
+(define-module (gnu packages sc-im)
+  #:use-module (guix packages)
+  #:use-module (guix git-download)
+  #:use-module (guix download)
+  #:use-module (guix utils)
+  #:use-module (guix build-system gnu)
+  #:use-module ((guix licenses) #:prefix license:)
+  #:use-module (gnu packages)
+  #:use-module (gnu packages base)
+  #:use-module (gnu packages pkg-config)
+  #:use-module (gnu packages maths)
+  #:use-module (gnu packages statistics)
+  #:use-module (gnu packages xml)
+  #:use-module (gnu packages compression)
+  #:use-module (gnu packages bison)
+  #:use-module (gnu packages ncurses))
+
+(define-public sc-im
+    (package
+      (name "sc-im")
+      (version "0.8.1")
+      (home-page "https://github.com/andmarti1424/sc-im")
+      (source (origin
+                (method git-fetch)
+                (uri
+                  (git-reference
+                    (url home-page)
+                    (commit (string-append version))))
+                (file-name (git-file-name name version))
+                (sha256
+                  (base32
+                    "1i1yq5mh9d7yi1bkgaq4p1lr8zrxhlvqmjnj33wmg5v6vpfim1h0"))))
+      (build-system gnu-build-system)
+      (arguments
+        ;; There are no tests at the moment.
+        ;; https://github.com/andmarti1424/sc-im/issues/537
+        ;; https://github.com/andmarti1424/sc-im/pull/385
+        `(#:tests? #f
+          #:make-flags (list "-C" "src"
+                          (string-append "CC=" ,(cc-for-target))
+                          (string-append "prefix=" %output))
+          #:phases
+            (modify-phases
+               %standard-phases
+                 (delete 'configure))))
+      (inputs
+        `(("gnuplot" ,gnuplot)
+          ("libxls" ,libxls)
+          ("libxlsxwriter" ,libxlsxwriter)
+          ("libxml2" ,libxml2)
+          ("libzip" ,libzip)
+          ("ncurses" ,ncurses)))
+      (native-inputs
+        `(("pkg-config" ,pkg-config)
+          ("which" ,which)
+          ("bison" ,bison)))
+      (synopsis "Spreadsheet program with vim-like keybindings")
+      (description
+ "@code{sc-im} is a highly configurable spreadsheet program
+ providing a vim-like experience.  @code{sc-im} supports @{gnuplot} interaction,
+ functions for sorting and filtering, 256 color support, and much more.")
+      (license license:bsd-4)))
-- 
2.29.3


^ permalink raw reply	[flat|nested] 21+ messages in thread

* [bug#47852] [PATCH] gnu: Add sc-im
  2021-04-18 15:39   ` jgart via Guix-patches via
@ 2021-04-18 16:40     ` Xinglu Chen
  2021-04-18 16:57     ` jgart via Guix-patches via
  2021-04-20  5:00     ` Leo Famulari
  2 siblings, 0 replies; 21+ messages in thread
From: Xinglu Chen @ 2021-04-18 16:40 UTC (permalink / raw)
  To: jgart, 47852
  Cc: Raghav Gururajan, jackhill, raghavgururajan, Oliver Loaiza, hello

Hi,

On Sun, Apr 18 2021, jgart wrote:

> I appreciate your review. I attached an updated patch with your
> suggestions. Thank you for pointing those out.

You are welcome!

> I moved home-page closer to the top so that I can reuse it in the url
> field.

Good idea.

>> I suggest adding it to (gnu packages terminals) instead of creating a
>> new file. You will find asciinema and fzf there.
>
> I'm not sure if it makes sense to me for sc-im to go into terminals.
>
> It seems like terminals has mostly terminal emulators.
>
> Like I pointed out in my previous email, why wouldn't calcurse and
> visidata also go into the terminals module?

I don’t know why those two programs are in their own files, but after
taking a closer look, I found that some programs are put in different
modules based on the program’s purpose.  For example, bashtop, htop, and
nnn all go in (gnu packages admin), and neomutt/mutt are put in (gnu
packages mail).  By that logic maybe it would make sense to put sc-im in
(gnu packages maths) or (gnu packages statistics)?

> sc-im is a spreadsheet program for the terminal in the same way that
> calcurse is a calendar program for the terminal.

In the same way that asciinema is a screen recorder for the terminal ;)

> Maybe we can do a clean up soon and put all these programs in a new
> module?

That would probably be a good idea.  The way packages are categorized is
still a little confusing to me. :)





^ permalink raw reply	[flat|nested] 21+ messages in thread

* [bug#47852] [PATCH] gnu: Add sc-im
  2021-04-18 15:39   ` jgart via Guix-patches via
  2021-04-18 16:40     ` Xinglu Chen
@ 2021-04-18 16:57     ` jgart via Guix-patches via
  2021-04-19 15:33       ` Xinglu Chen
  2021-04-19 16:46       ` jgart via Guix-patches via
  2021-04-20  5:00     ` Leo Famulari
  2 siblings, 2 replies; 21+ messages in thread
From: jgart via Guix-patches via @ 2021-04-18 16:57 UTC (permalink / raw)
  To: Xinglu Chen, 47852
  Cc: Raghav Gururajan, jackhill, raghavgururajan, Oliver Loaiza, hello

> In the same way that asciinema is a screen recorder for the terminal ;)
> 

Yes, it's currently not consistent what's included in the terminals module.

Asciinema should probably go somewhere else.

Maybe we need a terminal-apps module like haskell-apps and rust-apps. 

We can put all of these terminal programs in this new module. I think that would make things clearer.

What do you think?

>> Maybe we can do a clean up soon and put all these programs in a new
>> module?
> That would probably be a good idea. The way packages are categorized is
> still a little confusing to me. :)

Let's plan on that. I'd be happy help with clean up.

BTW, I'm hosting a guix packaging meetup in 6 days. 

If you'd like to work on any of this together in a group or a new package/upgrade stop by:

https://events.nixnet.services/events/27955ca1-0aee-4ec5-be20-48e6c45fd0f6

all the best,

jgart


April 18, 2021 12:41 PM, "Xinglu Chen" <public@yoctocell.xyz> wrote:

> Hi,
> 
> On Sun, Apr 18 2021, jgart wrote:
> 
>> I appreciate your review. I attached an updated patch with your
>> suggestions. Thank you for pointing those out.
> 
> You are welcome!
> 
>> I moved home-page closer to the top so that I can reuse it in the url
>> field.
> 
> Good idea.
> 
>>> I suggest adding it to (gnu packages terminals) instead of creating a
>>> new file. You will find asciinema and fzf there.
>> 
>> I'm not sure if it makes sense to me for sc-im to go into terminals.
>> 
>> It seems like terminals has mostly terminal emulators.
>> 
>> Like I pointed out in my previous email, why wouldn't calcurse and
>> visidata also go into the terminals module?
> 
> I don’t know why those two programs are in their own files, but after
> taking a closer look, I found that some programs are put in different
> modules based on the program’s purpose. For example, bashtop, htop, and
> nnn all go in (gnu packages admin), and neomutt/mutt are put in (gnu
> packages mail). By that logic maybe it would make sense to put sc-im in
> (gnu packages maths) or (gnu packages statistics)?
> 
>> sc-im is a spreadsheet program for the terminal in the same way that
>> calcurse is a calendar program for the terminal.
> 
> In the same way that asciinema is a screen recorder for the terminal ;)
> 
>> Maybe we can do a clean up soon and put all these programs in a new
>> module?
> 
> That would probably be a good idea. The way packages are categorized is
> still a little confusing to me. :)




^ permalink raw reply	[flat|nested] 21+ messages in thread

* [bug#47852] [PATCH] gnu: Add sc-im
  2021-04-18 16:57     ` jgart via Guix-patches via
@ 2021-04-19 15:33       ` Xinglu Chen
  2021-04-19 16:46       ` jgart via Guix-patches via
  1 sibling, 0 replies; 21+ messages in thread
From: Xinglu Chen @ 2021-04-19 15:33 UTC (permalink / raw)
  To: jgart, 47852
  Cc: Raghav Gururajan, jackhill, raghavgururajan, Oliver Loaiza, hello

On Sun, Apr 18 2021, jgart wrote:

>> In the same way that asciinema is a screen recorder for the terminal ;)
>> 
>
> Yes, it's currently not consistent what's included in the terminals module.
>
> Asciinema should probably go somewhere else.
>
> Maybe we need a terminal-apps module like haskell-apps and rust-apps.
>
> We can put all of these terminal programs in this new module. I think
> that would make things clearer.
>
> What do you think?

Hmm, I dunno, that would require moving a lot of packages.  Probably
better to start a new thread regarding how to categorize packages.





^ permalink raw reply	[flat|nested] 21+ messages in thread

* [bug#47852] [PATCH] gnu: Add sc-im
  2021-04-18 16:57     ` jgart via Guix-patches via
  2021-04-19 15:33       ` Xinglu Chen
@ 2021-04-19 16:46       ` jgart via Guix-patches via
  2021-04-19 21:48         ` Ekaitz Zarraga
                           ` (3 more replies)
  1 sibling, 4 replies; 21+ messages in thread
From: jgart via Guix-patches via @ 2021-04-19 16:46 UTC (permalink / raw)
  To: Xinglu Chen, 47852
  Cc: Oliver Loaiza, raghavgururajan, rprior, hello, Raghav Gururajan,
	jackhill

Yes, I think it would be better if we did this in a new issue. 

Ryan Prior suggested tui-apps as a new module name.

I like that!

sc-im, visidata, newsboat, and calcurse fit that bill. There's probably others that can go in there.

April 19, 2021 11:33 AM, "Xinglu Chen" <public@yoctocell.xyz> wrote:

> On Sun, Apr 18 2021, jgart wrote:
> 
>>> In the same way that asciinema is a screen recorder for the terminal ;)
>> 
>> Yes, it's currently not consistent what's included in the terminals module.
>> 
>> Asciinema should probably go somewhere else.
>> 
>> Maybe we need a terminal-apps module like haskell-apps and rust-apps.
>> 
>> We can put all of these terminal programs in this new module. I think
>> that would make things clearer.
>> 
>> What do you think?
> 
> Hmm, I dunno, that would require moving a lot of packages. Probably
> better to start a new thread regarding how to categorize packages.




^ permalink raw reply	[flat|nested] 21+ messages in thread

* [bug#47852] [PATCH] gnu: Add sc-im
  2021-04-19 16:46       ` jgart via Guix-patches via
@ 2021-04-19 21:48         ` Ekaitz Zarraga
  2021-04-20  4:57         ` Leo Famulari
                           ` (2 subsequent siblings)
  3 siblings, 0 replies; 21+ messages in thread
From: Ekaitz Zarraga @ 2021-04-19 21:48 UTC (permalink / raw)
  To: jgart
  Cc: Oliver Loaiza, raghavgururajan, rprior, Xinglu Chen,
	Raghav Gururajan, jackhill, 47852


‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
On Monday, April 19, 2021 6:46 PM, jgart <jgart@dismail.de> wrote:

> ElenQ Technology
Ethical InnovationYes, I think it would be better if we did this in a new issue.
>
> Ryan Prior suggested tui-apps as a new module name.
>
> I like that!
>
> sc-im, visidata, newsboat, and calcurse fit that bill. There's probably others that can go in there.


The main issue here in my opinion is what are we judging as a better
description of a program: the interface or what the program actually
does.

`newsboat`, `vim` and `sc-im` don't have anything in common from a
functionality perspective. But `sc-im` does have things in common
with `libreoffice calc`, `gnumeric` or others.

So...

What do we want to be the main point of the programs: their UI or
their goal?




^ permalink raw reply	[flat|nested] 21+ messages in thread

* [bug#47852] [PATCH] gnu: Add sc-im
  2021-04-19 16:46       ` jgart via Guix-patches via
  2021-04-19 21:48         ` Ekaitz Zarraga
@ 2021-04-20  4:57         ` Leo Famulari
  2021-04-22 19:56         ` jgart via Guix-patches via
  2021-04-23  9:22         ` jgart via Guix-patches via
  3 siblings, 0 replies; 21+ messages in thread
From: Leo Famulari @ 2021-04-20  4:57 UTC (permalink / raw)
  To: 47852; +Cc: olv345, raghavgururajan, rprior, public, hello, rg, jackhill

On Mon, Apr 19, 2021 at 04:46:10PM +0000, jgart via Guix-patches via wrote:
> Yes, I think it would be better if we did this in a new issue. 
> 
> Ryan Prior suggested tui-apps as a new module name.
> 
> I like that!
> 
> sc-im, visidata, newsboat, and calcurse fit that bill. There's probably others that can go in there.

I think we should avoid moving packages around unless there is a
compelling reason to do it.

There are a few reasons not to move packages. It makes the Git history
harder to use (`git log` and `git blame`), it can make Git merges of
long-running branches trickier, and it can break 3rd party channels. And
sometimes it's annoyingly hard work to properly move or duplicate the
copyright attributions to the new file.

In general, the location of the packages is not something that users see
or care about, but it does matter for developers. To me, the conceptual
satisfaction of a nicely defined category does not justify the headaches
that can result from moving packages around.




^ permalink raw reply	[flat|nested] 21+ messages in thread

* [bug#47852] [PATCH] gnu: Add sc-im
  2021-04-18 15:39   ` jgart via Guix-patches via
  2021-04-18 16:40     ` Xinglu Chen
  2021-04-18 16:57     ` jgart via Guix-patches via
@ 2021-04-20  5:00     ` Leo Famulari
  2 siblings, 0 replies; 21+ messages in thread
From: Leo Famulari @ 2021-04-20  5:00 UTC (permalink / raw)
  To: 47852; +Cc: olv345, raghavgururajan, public, hello, rg, jackhill

On Sun, Apr 18, 2021 at 03:39:05PM +0000, jgart via Guix-patches via wrote:
> sc-im is a spreadsheet program for the terminal in the same way that calcurse is a calendar program for the terminal.

I think it's fine to put it in its own module. But since we are talking
about categories, I would suggest putting it in a new (gnu packages
spreadsheets) module.




^ permalink raw reply	[flat|nested] 21+ messages in thread

* [bug#47852] [PATCH] gnu: Add sc-im
  2021-04-19 16:46       ` jgart via Guix-patches via
  2021-04-19 21:48         ` Ekaitz Zarraga
  2021-04-20  4:57         ` Leo Famulari
@ 2021-04-22 19:56         ` jgart via Guix-patches via
  2021-04-23  9:22         ` jgart via Guix-patches via
  3 siblings, 0 replies; 21+ messages in thread
From: jgart via Guix-patches via @ 2021-04-22 19:56 UTC (permalink / raw)
  To: Ekaitz Zarraga
  Cc: Oliver Loaiza, raghavgururajan, rprior, Xinglu Chen,
	Raghav Gururajan, jackhill, 47852

> What do we want to be the main point of the programs: their UI or
> their goal?

I think it depends on how many tui programs we have so far. 

If we have many tui programs then we should probably start categorizing them.

I would prefer for them to be catalogued based on their intended usage or goal, as you suggested.

Estoy alobao, let's move this to a guix-devel thread. I'll open one soon for us to continue there.

--
jgart

April 19, 2021 5:48 PM, "Ekaitz Zarraga" <ekaitz@elenq.tech> wrote:

> ‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
> On Monday, April 19, 2021 6:46 PM, jgart <jgart@dismail.de> wrote:
> 
>> ElenQ Technology
> 
> Ethical InnovationYes, I think it would be better if we did this in a new issue.
> 
>> Ryan Prior suggested tui-apps as a new module name.
>> 
>> I like that!
>> 
>> sc-im, visidata, newsboat, and calcurse fit that bill. There's probably others that can go in
>> there.
> 
> The main issue here in my opinion is what are we judging as a better
> description of a program: the interface or what the program actually
> does.
> 
> `newsboat`, `vim` and `sc-im` don't have anything in common from a
> functionality perspective. But `sc-im` does have things in common
> with `libreoffice calc`, `gnumeric` or others.
> 
> So...
> 
> What do we want to be the main point of the programs: their UI or
> their goal?




^ permalink raw reply	[flat|nested] 21+ messages in thread

* [bug#47852] [PATCH] gnu: Add sc-im
  2021-04-19 16:46       ` jgart via Guix-patches via
                           ` (2 preceding siblings ...)
  2021-04-22 19:56         ` jgart via Guix-patches via
@ 2021-04-23  9:22         ` jgart via Guix-patches via
  2021-04-23 16:41           ` Leo Famulari
  3 siblings, 1 reply; 21+ messages in thread
From: jgart via Guix-patches via @ 2021-04-23  9:22 UTC (permalink / raw)
  To: leo
  Cc: Ekaitz Zarraga, Oliver Loaiza, raghavgururajan, rprior,
	Xinglu Chen, Raghav Gururajan, jackhill, 47852

[-- Attachment #1: Type: text/plain, Size: 1214 bytes --]

Leo, for some reason I didn't get your email in the thread. Maybe, you didn't CC me?

Anyways, attached is the new patch with your suggestions. I think (gnu packages spreadsheets) is what we were going for.

Thanks!

all the best,

jgart

April 19, 2021 5:48 PM, "Ekaitz Zarraga" <ekaitz@elenq.tech> wrote:

> ‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
> On Monday, April 19, 2021 6:46 PM, jgart <jgart@dismail.de> wrote:
> 
>> ElenQ Technology
> 
> Ethical InnovationYes, I think it would be better if we did this in a new issue.
> 
>> Ryan Prior suggested tui-apps as a new module name.
>> 
>> I like that!
>> 
>> sc-im, visidata, newsboat, and calcurse fit that bill. There's probably others that can go in
>> there.
> 
> The main issue here in my opinion is what are we judging as a better
> description of a program: the interface or what the program actually
> does.
> 
> `newsboat`, `vim` and `sc-im` don't have anything in common from a
> functionality perspective. But `sc-im` does have things in common
> with `libreoffice calc`, `gnumeric` or others.
> 
> So...
> 
> What do we want to be the main point of the programs: their UI or
> their goal?

[-- Attachment #2: 0001-gnu-Add-sc-im.patch --]
[-- Type: application/octet-stream, Size: 4289 bytes --]

From e9a85070eeaa5c8b3d9404ae7782938ba2be831e Mon Sep 17 00:00:00 2001
From: jgart <jgart@dismail.de>
Date: Fri, 23 Apr 2021 04:11:11 -0400
Subject: [PATCH]  gnu: Add sc-im.

    * gnu/packages/spreadsheets.scm: New file.
    * gnu/local.mk (GNU_SYSTEM_MODULES): Add it.
---
 gnu/local.mk                  |  1 +
 gnu/packages/spreadsheets.scm | 81 +++++++++++++++++++++++++++++++++++
 2 files changed, 82 insertions(+)
 create mode 100644 gnu/packages/spreadsheets.scm

diff --git a/gnu/local.mk b/gnu/local.mk
index 50b11a8ca2..96ba564530 100644
--- a/gnu/local.mk
+++ b/gnu/local.mk
@@ -496,6 +496,7 @@ GNU_SYSTEM_MODULES =				\
   %D%/packages/sawfish.scm			\
   %D%/packages/scanner.scm			\
   %D%/packages/scheme.scm			\
+  %D%/packages/spreadsheets.scm			\
   %D%/packages/screen.scm			\
   %D%/packages/scribus.scm			\
   %D%/packages/scsi.scm				\
diff --git a/gnu/packages/spreadsheets.scm b/gnu/packages/spreadsheets.scm
new file mode 100644
index 0000000000..36e3447cbf
--- /dev/null
+++ b/gnu/packages/spreadsheets.scm
@@ -0,0 +1,81 @@
+;;; GNU Guix --- Functional package management for GNU
+;;; Copyright © 2020 Ekaitz Zarraga <ekaitz@elenq.tech>
+;;; Copyright © 2021 jgart <jgart@dismail.de>
+;;;
+;;; This file is part of GNU Guix.
+;;;
+;;; GNU Guix is free software; you can redistribute it and/or modify it
+;;; under the terms of the GNU General Public License as published by
+;;; the Free Software Foundation; either version 3 of the License, or (at
+;;; your option) any later version.
+;;;
+;;; GNU Guix is distributed in the hope that it will be useful, but
+;;; WITHOUT ANY WARRANTY; without even the implied warranty of
+;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+;;; GNU General Public License for more details.
+;;;
+;;; You should have received a copy of the GNU General Public License
+;;; along with GNU Guix.  If not, see <http://www.gnu.org/licenses/>.
+
+(define-module (gnu packages spreadsheets)
+  #:use-module (guix packages)
+  #:use-module (guix git-download)
+  #:use-module (guix download)
+  #:use-module (guix utils)
+  #:use-module (guix build-system gnu)
+  #:use-module ((guix licenses) #:prefix license:)
+  #:use-module (gnu packages)
+  #:use-module (gnu packages base)
+  #:use-module (gnu packages pkg-config)
+  #:use-module (gnu packages maths)
+  #:use-module (gnu packages statistics)
+  #:use-module (gnu packages xml)
+  #:use-module (gnu packages compression)
+  #:use-module (gnu packages bison)
+  #:use-module (gnu packages ncurses))
+
+(define-public sc-im
+    (package
+      (name "sc-im")
+      (version "v0.8.1")
+      (home-page "https://github.com/andmarti1424/sc-im")
+      (source (origin
+                (method git-fetch)
+                (uri
+                  (git-reference
+                    (url home-page)
+                    (commit (string-append version))))
+                (file-name (git-file-name name version))
+                (sha256
+                  (base32
+                    "1i1yq5mh9d7yi1bkgaq4p1lr8zrxhlvqmjnj33wmg5v6vpfim1h0"))))
+      (build-system gnu-build-system)
+      (arguments
+        ;; There are no tests at the moment.
+        ;; https://github.com/andmarti1424/sc-im/issues/537
+        ;; https://github.com/andmarti1424/sc-im/pull/385
+        `(#:tests? #f
+          #:make-flags (list "-C" "src"
+                          (string-append "CC=" ,(cc-for-target))
+                          (string-append "prefix=" %output))
+          #:phases
+            (modify-phases
+               %standard-phases
+                 (delete 'configure))))
+      (inputs
+        `(("gnuplot" ,gnuplot)
+          ("libxls" ,libxls)
+          ("libxlsxwriter" ,libxlsxwriter)
+          ("libxml2" ,libxml2)
+          ("libzip" ,libzip)
+          ("ncurses" ,ncurses)))
+      (native-inputs
+        `(("pkg-config" ,pkg-config)
+          ("which" ,which)
+          ("bison" ,bison)))
+      (synopsis "Spreadsheet program with vim-like keybindings")
+      (description
+ "@code{sc-im} is a highly configurable spreadsheet program
+ providing a vim-like experience.  @code{sc-im} supports @{gnuplot} interaction,
+ functions for sorting and filtering, 256 color support, and much more.")
+      (license license:bsd-4)))
-- 
2.29.3


^ permalink raw reply	[flat|nested] 21+ messages in thread

* [bug#47852] [PATCH] gnu: Add sc-im
  2021-04-23  9:22         ` jgart via Guix-patches via
@ 2021-04-23 16:41           ` Leo Famulari
  0 siblings, 0 replies; 21+ messages in thread
From: Leo Famulari @ 2021-04-23 16:41 UTC (permalink / raw)
  To: jgart
  Cc: Ekaitz Zarraga, Oliver Loaiza, raghavgururajan, rprior,
	Xinglu Chen, Raghav Gururajan, jackhill, 47852

On Fri, Apr 23, 2021 at 09:22:23AM +0000, jgart wrote:
> Leo, for some reason I didn't get your email in the thread. Maybe, you didn't CC me?

Yeah, but it was unintentional.

I did "reply all" but, for you, it replied to "jgart via Guix-patches
via <guix-patches@gnu.org>".

Who knows why that happened?




^ permalink raw reply	[flat|nested] 21+ messages in thread

* [bug#47852] [PATCH 1/2 v6] gnu: Add sc-im.
  2021-04-17 21:52 [bug#47852] [PATCH] gnu: Add sc-im jgart via Guix-patches via
                   ` (3 preceding siblings ...)
  2021-04-18  0:32 ` jgart via Guix-patches via
@ 2021-11-19  1:22 ` jgart via Guix-patches via
  2021-11-19  1:22   ` [bug#47852] [PATCH 2/2] gnu: Move visidata to (gnu packages spreadsheet-apps) jgart via Guix-patches via
  2021-11-22 21:20   ` [bug#47852] [PATCH 1/2 v6] gnu: Add sc-im Leo Famulari
  4 siblings, 2 replies; 21+ messages in thread
From: jgart via Guix-patches via @ 2021-11-19  1:22 UTC (permalink / raw)
  To: 47852; +Cc: jgart

    * gnu/packages/spreadsheet-apps.scm: New file.
    * gnu/local.mk (GNU_SYSTEM_MODULES): Add it.
---
 gnu/local.mk                      |  1 +
 gnu/packages/spreadsheet-apps.scm | 81 +++++++++++++++++++++++++++++++
 2 files changed, 82 insertions(+)
 create mode 100644 gnu/packages/spreadsheet-apps.scm

diff --git a/gnu/local.mk b/gnu/local.mk
index 7cc06c8212..06e97878a6 100644
--- a/gnu/local.mk
+++ b/gnu/local.mk
@@ -519,6 +519,7 @@ GNU_SYSTEM_MODULES =				\
   %D%/packages/sawfish.scm			\
   %D%/packages/scanner.scm			\
   %D%/packages/scheme.scm			\
+  %D%/packages/spreadsheets-apps.scm			\
   %D%/packages/screen.scm			\
   %D%/packages/scribus.scm			\
   %D%/packages/scsi.scm				\
diff --git a/gnu/packages/spreadsheet-apps.scm b/gnu/packages/spreadsheet-apps.scm
new file mode 100644
index 0000000000..a2d82a111e
--- /dev/null
+++ b/gnu/packages/spreadsheet-apps.scm
@@ -0,0 +1,81 @@
+;;; GNU Guix --- Functional package management for GNU
+;;; Copyright © 2020 Ekaitz Zarraga <ekaitz@elenq.tech>
+;;; Copyright © 2021 Jorge Gomez <jgart@dismail.de>
+;;;
+;;; This file is part of GNU Guix.
+;;;
+;;; GNU Guix is free software; you can redistribute it and/or modify it
+;;; under the terms of the GNU General Public License as published by
+;;; the Free Software Foundation; either version 3 of the License, or (at
+;;; your option) any later version.
+;;;
+;;; GNU Guix is distributed in the hope that it will be useful, but
+;;; WITHOUT ANY WARRANTY; without even the implied warranty of
+;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+;;; GNU General Public License for more details.
+;;;
+;;; You should have received a copy of the GNU General Public License
+;;; along with GNU Guix.  If not, see <http://www.gnu.org/licenses/>.
+
+(define-module (gnu packages spreadsheet-apps)
+  #:use-module (guix packages)
+  #:use-module (guix git-download)
+  #:use-module (guix download)
+  #:use-module (guix utils)
+  #:use-module (guix build-system gnu)
+  #:use-module ((guix licenses) #:prefix license:)
+  #:use-module (gnu packages)
+  #:use-module (gnu packages base)
+  #:use-module (gnu packages pkg-config)
+  #:use-module (gnu packages maths)
+  #:use-module (gnu packages statistics)
+  #:use-module (gnu packages xml)
+  #:use-module (gnu packages compression)
+  #:use-module (gnu packages bison)
+  #:use-module (gnu packages ncurses))
+
+(define-public sc-im
+    (package
+      (name "sc-im")
+      (version "0.8.2")
+      (home-page "https://github.com/andmarti1424/sc-im")
+      (source (origin
+                (method git-fetch)
+                (uri
+                  (git-reference
+                    (url home-page)
+                    (commit (string-append "v" version))))
+                (file-name (git-file-name name version))
+                (sha256
+                  (base32
+                    "1nrjnw8sg75i0hkcbvjv7gydjddxjm27d5m1qczpg29fk9991q8z"))))
+      (build-system gnu-build-system)
+      (arguments
+        ;; There are no tests at the moment.
+        ;; https://github.com/andmarti1424/sc-im/issues/537
+        ;; https://github.com/andmarti1424/sc-im/pull/385
+        `(#:tests? #f
+          #:make-flags (list "-C" "src"
+                          (string-append "CC=" ,(cc-for-target))
+                          (string-append "prefix=" %output))
+          #:phases
+            (modify-phases
+               %standard-phases
+                 (delete 'configure))))
+      (inputs
+        `(("gnuplot" ,gnuplot)
+          ("libxls" ,libxls)
+          ("libxlsxwriter" ,libxlsxwriter)
+          ("libxml2" ,libxml2)
+          ("libzip" ,libzip)
+          ("ncurses" ,ncurses)))
+      (native-inputs
+        `(("pkg-config" ,pkg-config)
+          ("which" ,which)
+          ("bison" ,bison)))
+      (synopsis "Spreadsheet program with vim-like keybindings")
+      (description
+ "@code{sc-im} is a highly configurable spreadsheet program
+ providing a vim-like experience.  @code{sc-im} supports @{gnuplot} interaction,
+ functions for sorting and filtering, 256 color support, and much more.")
+      (license license:bsd-4)))
-- 
2.33.1





^ permalink raw reply	[flat|nested] 21+ messages in thread

* [bug#47852] [PATCH 2/2] gnu: Move visidata to (gnu packages spreadsheet-apps).
  2021-11-19  1:22 ` [bug#47852] [PATCH 1/2 v6] " jgart via Guix-patches via
@ 2021-11-19  1:22   ` jgart via Guix-patches via
  2021-11-22 21:20   ` [bug#47852] [PATCH 1/2 v6] gnu: Add sc-im Leo Famulari
  1 sibling, 0 replies; 21+ messages in thread
From: jgart via Guix-patches via @ 2021-11-19  1:22 UTC (permalink / raw)
  To: 47852; +Cc: jgart

See <http://issues.guix.gnu.org/47852>.

* gnu/packages/visidata.scm (visidata): Move from here…
* gnu/packages/spreadsheet-apps.scm (visidata): …to here.
---
 gnu/packages/spreadsheet-apps.scm | 54 +++++++++++++++++++++++---
 gnu/packages/visidata.scm         | 64 -------------------------------
 2 files changed, 49 insertions(+), 69 deletions(-)
 delete mode 100644 gnu/packages/visidata.scm

diff --git a/gnu/packages/spreadsheet-apps.scm b/gnu/packages/spreadsheet-apps.scm
index a2d82a111e..cf479f83c6 100644
--- a/gnu/packages/spreadsheet-apps.scm
+++ b/gnu/packages/spreadsheet-apps.scm
@@ -1,4 +1,5 @@
 ;;; GNU Guix --- Functional package management for GNU
+;;; Copyright © 2020 Ryan Prior <rprior@protonmail.com>
 ;;; Copyright © 2020 Ekaitz Zarraga <ekaitz@elenq.tech>
 ;;; Copyright © 2021 Jorge Gomez <jgart@dismail.de>
 ;;;
@@ -22,17 +23,25 @@ (define-module (gnu packages spreadsheet-apps)
   #:use-module (guix git-download)
   #:use-module (guix download)
   #:use-module (guix utils)
+  #:use-module (guix build utils)
+  #:use-module (guix download)
   #:use-module (guix build-system gnu)
+  #:use-module (guix build-system python)
   #:use-module ((guix licenses) #:prefix license:)
   #:use-module (gnu packages)
   #:use-module (gnu packages base)
-  #:use-module (gnu packages pkg-config)
+  #:use-module (gnu packages bison)
+  #:use-module (gnu packages check)
+  #:use-module (gnu packages compression)
   #:use-module (gnu packages maths)
-  #:use-module (gnu packages statistics)
+  #:use-module (gnu packages ncurses)
+  #:use-module (gnu packages time)
+  #:use-module (gnu packages pkg-config)
+  #:use-module (gnu packages python-web)
+  #:use-module (gnu packages python-xyz)
   #:use-module (gnu packages xml)
-  #:use-module (gnu packages compression)
-  #:use-module (gnu packages bison)
-  #:use-module (gnu packages ncurses))
+  #:use-module (gnu packages statistics)
+  #:use-module (gnu packages xml))
 
 (define-public sc-im
     (package
@@ -79,3 +88,38 @@ (define-public sc-im
  providing a vim-like experience.  @code{sc-im} supports @{gnuplot} interaction,
  functions for sorting and filtering, 256 color support, and much more.")
       (license license:bsd-4)))
+
+(define-public visidata
+  (package
+    (name "visidata")
+    (version "2.5")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (pypi-uri "visidata" version))
+       (sha256
+        (base32
+         "19fbjr9j91pcazcz0bqx3qrasmr8xdsb13haf5lfbpyxj23f7f1j"))))
+    (build-system python-build-system)
+    (arguments
+     '(#:phases
+       (modify-phases %standard-phases
+         (replace 'check
+           (lambda* (#:key tests? #:allow-other-keys)
+             (when tests? (invoke "pytest"))
+             #t)))))
+    (inputs
+     `(("dateutil" ,python-dateutil)
+       ("requests" ,python-requests)
+       ("lxml" ,python-lxml)
+       ("openpyxl" ,python-openpyxl)
+       ("xlrd" ,python-xlrd)))
+    (native-inputs
+     `(("pytest" ,python-pytest)))
+    (synopsis "Terminal spreadsheet multitool for discovering and arranging data")
+    (description
+     "VisiData is an interactive multitool for tabular data.  It combines the
+clarity of a spreadsheet, the efficiency of the terminal, and the power of
+Python, into a lightweight utility which can handle millions of rows.")
+    (home-page "https://www.visidata.org/")
+    (license license:gpl3)))
diff --git a/gnu/packages/visidata.scm b/gnu/packages/visidata.scm
deleted file mode 100644
index a1b16e5ca6..0000000000
--- a/gnu/packages/visidata.scm
+++ /dev/null
@@ -1,64 +0,0 @@
-;;; GNU Guix --- Functional package management for GNU
-;;; Copyright © 2020 Ryan Prior <rprior@protonmail.com>
-;;;
-;;; This file is part of GNU Guix.
-;;;
-;;; GNU Guix is free software; you can redistribute it and/or modify it
-;;; under the terms of the GNU General Public License as published by
-;;; the Free Software Foundation; either version 3 of the License, or (at
-;;; your option) any later version.
-;;;
-;;; GNU Guix is distributed in the hope that it will be useful, but
-;;; WITHOUT ANY WARRANTY; without even the implied warranty of
-;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-;;; GNU General Public License for more details.
-;;;
-;;; You should have received a copy of the GNU General Public License
-;;; along with GNU Guix.  If not, see <http://www.gnu.org/licenses/>.
-
-(define-module (gnu packages visidata)
-  #:use-module (gnu packages check)
-  #:use-module (gnu packages time)
-  #:use-module (gnu packages python-web)
-  #:use-module (gnu packages python-xyz)
-  #:use-module (gnu packages xml)
-  #:use-module (guix build-system python)
-  #:use-module (guix build utils)
-  #:use-module (guix download)
-  #:use-module ((guix licenses) #:prefix license:)
-  #:use-module (guix packages))
-
-(define-public visidata
-  (package
-    (name "visidata")
-    (version "2.5")
-    (source
-     (origin
-       (method url-fetch)
-       (uri (pypi-uri "visidata" version))
-       (sha256
-        (base32
-         "19fbjr9j91pcazcz0bqx3qrasmr8xdsb13haf5lfbpyxj23f7f1j"))))
-    (build-system python-build-system)
-    (arguments
-     '(#:phases
-       (modify-phases %standard-phases
-         (replace 'check
-           (lambda* (#:key tests? #:allow-other-keys)
-             (when tests? (invoke "pytest"))
-             #t)))))
-    (inputs
-     `(("dateutil" ,python-dateutil)
-       ("requests" ,python-requests)
-       ("lxml" ,python-lxml)
-       ("openpyxl" ,python-openpyxl)
-       ("xlrd" ,python-xlrd)))
-    (native-inputs
-     `(("pytest" ,python-pytest)))
-    (synopsis "Terminal spreadsheet multitool for discovering and arranging data")
-    (description
-     "VisiData is an interactive multitool for tabular data.  It combines the
-clarity of a spreadsheet, the efficiency of the terminal, and the power of
-Python, into a lightweight utility which can handle millions of rows.")
-    (home-page "https://www.visidata.org/")
-    (license license:gpl3)))
-- 
2.33.1





^ permalink raw reply	[flat|nested] 21+ messages in thread

* [bug#47852] [PATCH 1/2 v6] gnu: Add sc-im.
  2021-11-19  1:22 ` [bug#47852] [PATCH 1/2 v6] " jgart via Guix-patches via
  2021-11-19  1:22   ` [bug#47852] [PATCH 2/2] gnu: Move visidata to (gnu packages spreadsheet-apps) jgart via Guix-patches via
@ 2021-11-22 21:20   ` Leo Famulari
  2021-11-22 23:23     ` jgart via Guix-patches via
  1 sibling, 1 reply; 21+ messages in thread
From: Leo Famulari @ 2021-11-22 21:20 UTC (permalink / raw)
  To: 47852; +Cc: 47852-done, jgart

On Thu, Nov 18, 2021 at 08:22:18PM -0500, jgart via Guix-patches via wrote:
>     * gnu/packages/spreadsheet-apps.scm: New file.
>     * gnu/local.mk (GNU_SYSTEM_MODULES): Add it.

Thanks!

I pushed as 10fad03fcf6fdd2edbdab5f939e3c0edb11a88e2 with the following
changes:

* I named the module (gnu packages spreadsheet)
* I removed some unused or duplicated module imports
* I removed the visidata module from GNU_SYSTEM_MODULES
* And I specified the licenses without a prefix, since they are not
needed in this module yet. We only need to prefix licenses when there is
a namespace collision between licenses and same-named packages, for
example with 'expat'.




^ permalink raw reply	[flat|nested] 21+ messages in thread

* [bug#47852] [PATCH 1/2 v6] gnu: Add sc-im.
  2021-11-22 21:20   ` [bug#47852] [PATCH 1/2 v6] gnu: Add sc-im Leo Famulari
@ 2021-11-22 23:23     ` jgart via Guix-patches via
  0 siblings, 0 replies; 21+ messages in thread
From: jgart via Guix-patches via @ 2021-11-22 23:23 UTC (permalink / raw)
  To: Leo Famulari; +Cc: 47852-done, 47852

On Mon, 22 Nov 2021 16:20:27 -0500 Leo Famulari <leo@famulari.name> wrote:
> On Thu, Nov 18, 2021 at 08:22:18PM -0500, jgart via Guix-patches via wrote:
> >     * gnu/packages/spreadsheet-apps.scm: New file.
> >     * gnu/local.mk (GNU_SYSTEM_MODULES): Add it.
> 
> Thanks!
> 
> I pushed as 10fad03fcf6fdd2edbdab5f939e3c0edb11a88e2 with the following
> changes:
> 
> * I named the module (gnu packages spreadsheet)
> * I removed some unused or duplicated module imports
> * I removed the visidata module from GNU_SYSTEM_MODULES

Oops I had forgotten to do that.

> * And I specified the licenses without a prefix, since they are not
> needed in this module yet. We only need to prefix licenses when there is
> a namespace collision between licenses and same-named packages, for
> example with 'expat'.

That's good to know. I always wondered what was the reason for prefixing licenses... Now I know :)

Thank you! Much appreciated.

all best,

jgart




^ permalink raw reply	[flat|nested] 21+ messages in thread

end of thread, other threads:[~2021-11-22 23:25 UTC | newest]

Thread overview: 21+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-17 21:52 [bug#47852] [PATCH] gnu: Add sc-im jgart via Guix-patches via
2021-04-17 22:22 ` ElenQ Technology
2021-04-17 23:29 ` Jack Hill
2021-04-17 23:54 ` jgart via Guix-patches via
2021-04-18  0:32 ` jgart via Guix-patches via
2021-04-18  9:25   ` Xinglu Chen
2021-04-18 15:39   ` jgart via Guix-patches via
2021-04-18 16:40     ` Xinglu Chen
2021-04-18 16:57     ` jgart via Guix-patches via
2021-04-19 15:33       ` Xinglu Chen
2021-04-19 16:46       ` jgart via Guix-patches via
2021-04-19 21:48         ` Ekaitz Zarraga
2021-04-20  4:57         ` Leo Famulari
2021-04-22 19:56         ` jgart via Guix-patches via
2021-04-23  9:22         ` jgart via Guix-patches via
2021-04-23 16:41           ` Leo Famulari
2021-04-20  5:00     ` Leo Famulari
2021-11-19  1:22 ` [bug#47852] [PATCH 1/2 v6] " jgart via Guix-patches via
2021-11-19  1:22   ` [bug#47852] [PATCH 2/2] gnu: Move visidata to (gnu packages spreadsheet-apps) jgart via Guix-patches via
2021-11-22 21:20   ` [bug#47852] [PATCH 1/2 v6] gnu: Add sc-im Leo Famulari
2021-11-22 23:23     ` jgart via Guix-patches via

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).