Le Mon, 18 Oct 2021 10:39:04 +0200, Ludovic Courtès a écrit : > Hi! > > Julien Lepiller skribis: > > > Thanks for the reviews! I've managed to use conditions, which was > > not easy because I didn't notice there was already a "condition" > > defined, and that lead to weird error messages. Attached is the > > updated patch. > > Oh, I see. > > > From 0cadac6c3dabea8b986cd59d97c84beaf7a33325 Mon Sep 17 00:00:00 > > 2001 Message-Id: > > <0cadac6c3dabea8b986cd59d97c84beaf7a33325.1634350078.git.julien@lepiller.eu> > > From: Julien Lepiller Date: Fri, 8 Oct 2021 > > 04:58:27 +0200 Subject: [PATCH] import: opam: Do not fail when > > refreshing. > > > > Because we throw an error when a package is not in the opam > > repository, the updater would crash when encountering a package > > that is not in opam but uses the ocaml-build-system, such as opam > > itself. This catches the error and continues without updating said > > package, and lets us update the rest of the packages. > > > > * guix/scripts/import/opam.scm (guix-import-opam): Catch not-found > > condition and leave. > > * guix/import/opam.scm (&opam-not-found-error): New condition type. > > (opam-fetch): Raise condition instead of leaving. > > (latest-release): Catch not-found condition and warn. > > (conditional): Rename from `condition'. > > * tests/opam.scm (parse-conditions): Change accordingly. > > LGTM, thanks! > > Ludo’. I forgot to remove the catch #t around the whole body of the function. I noticed that guard* was raising &non-continuable so I tried to fix it by using raise-continuable from (ice-9 exceptions). Is this the correct solution?