unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / Atom feed
* [bug#51148] [PATCH] gnu: Add python-tinydb.
@ 2021-10-12  5:44 jgart via Guix-patches via
  2021-11-11  5:24 ` Vinicius Monego
                   ` (3 more replies)
  0 siblings, 4 replies; 7+ messages in thread
From: jgart via Guix-patches via @ 2021-10-12  5:44 UTC (permalink / raw)
  To: 51148; +Cc: jgart

* gnu/packages/databases.scm (python-tinydb): New variable.
---
 gnu/packages/databases.scm | 40 ++++++++++++++++++++++++++++++++++++++
 1 file changed, 40 insertions(+)

diff --git a/gnu/packages/databases.scm b/gnu/packages/databases.scm
index b1dd44da1c..60970b9c8e 100644
--- a/gnu/packages/databases.scm
+++ b/gnu/packages/databases.scm
@@ -579,6 +579,46 @@ the API, and provides features such as:
 @end itemize")
     (license license:bsd-3)))
 
+(define-public python-tinydb
+  (package
+    (name "python-tinydb")
+    (version "4.5.2")
+    (source (origin
+              (method url-fetch)
+              (uri (pypi-uri "tinydb" version))
+              (sha256
+               (base32
+                "1x9c4s42930wwal3ds0plwb57kg5c3gj7kbpy64c29vq478b463x"))))
+    (build-system python-build-system)
+    (arguments
+       ;; PyPi tarball does not contain tests and github repository does not 
+       ;; have a setup.py file (only pyproject).
+      `(#:tests? #f
+        #:phases
+        (modify-phases %standard-phases
+          (replace 'check
+            (lambda* (#:key inputs outputs tests? #:allow-other-keys)
+              (when tests?
+                (add-installed-pythonpath inputs outputs)
+                (setenv "PYTHONPATH" (string-append ".:" (getenv "PYTHONPATH")))
+                (invoke "pytest")))))))
+    (native-inputs
+      `(("python-pytest" ,python-pytest)
+        ("python-pytest-cov" ,python-pytest-cov)
+        ("python-pycodestyle" ,python-pycodestyle)
+        ("python-pyyaml" ,python-pyyaml)))
+    (propagated-inputs
+      `(("python-typing-extensions" ,python-typing-extensions)))
+    (home-page "https://github.com/msiemens/tinydb")
+    (synopsis
+      "TinyDB is a lightweight document oriented database")
+    (description
+"TinyDB is a lightweight document oriented database optimized for
+your happiness.  It's written in pure Python and has no external
+dependencies.  The targets are small apps that would be blown away by a
+SQL-DB or an external database server.")
+    (license license:expat)))
+
 (define-public python-pylibmc
   (package
     (name "python-pylibmc")
-- 
2.33.0





^ permalink raw reply	[flat|nested] 7+ messages in thread

* [bug#51148] [PATCH] gnu: Add python-tinydb.
  2021-10-12  5:44 [bug#51148] [PATCH] gnu: Add python-tinydb jgart via Guix-patches via
@ 2021-11-11  5:24 ` Vinicius Monego
  2021-11-11  5:26 ` Vinicius Monego
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 7+ messages in thread
From: Vinicius Monego @ 2021-11-11  5:24 UTC (permalink / raw)
  To: jgart, 51148

Hi jgart,

Em ter, 2021-10-12 às 01:44 -0400, jgart escreveu:
> * gnu/packages/databases.scm (python-tinydb): New variable.
> ---
>  gnu/packages/databases.scm | 40

Don't miss your copyright in this file.

> ++++++++++++++++++++++++++++++++++++++
>  1 file changed, 40 insertions(+)
> 
> diff --git a/gnu/packages/databases.scm 
> b/gnu/packages/databases.scm
> index b1dd44da1c..60970b9c8e 100644
> --- a/gnu/packages/databases.scm
> +++ b/gnu/packages/databases.scm
> @@ -579,6 +579,46 @@ the API, and provides features such as:
>  @end itemize")
>      (license license:bsd-3)))
>  
> +(define-public python-tinydb
> +  (package
> +    (name "python-tinydb")
> +    (version "4.5.2")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (pypi-uri "tinydb" version))
> +              (sha256
> +               (base32
> +               
> "1x9c4s42930wwal3ds0plwb57kg5c3gj7kbpy64c29vq478b463x"))))
> +    (build-system python-build-system)

The indentation is off below.

> +    (arguments
> +       ;; PyPi tarball does not contain tests and github repository
> does not 
> +       ;; have a setup.py file (only pyproject).

I recently noticed this pattern of shipping only Poetry in the
repository while at the same time not shipping tests in PyPI. I don't
know why this is happening or what we can do about it in guix, the best
for now is to source from PyPI and skip tests like in this package.

> +      `(#:tests? #f
> +        #:phases
> +        (modify-phases %standard-phases
> +          (replace 'check
> +            (lambda* (#:key inputs outputs tests? #:allow-other-
> keys)
> +              (when tests?
> +                (add-installed-pythonpath inputs outputs)
> +                (setenv "PYTHONPATH" (string-append ".:" (getenv
> "PYTHONPATH")))

The two lines above are redundant. The second line is the manual way of
doing what the first one does. But if we don't have a way to run the
tests, I'd not override the check phase.

> +                (invoke "pytest")))))))
> +    (native-inputs
> +      `(("python-pytest" ,python-pytest)
> +        ("python-pytest-cov" ,python-pytest-cov)
> +        ("python-pycodestyle" ,python-pycodestyle)
> +        ("python-pyyaml" ,python-pyyaml)))

Test-related native inputs are also useless if tests can't run.

> +    (propagated-inputs
> +      `(("python-typing-extensions" ,python-typing-extensions)))
> +    (home-page "https://github.com/msiemens/tinydb")
> +    (synopsis
> +      "TinyDB is a lightweight document oriented database")

Same line for the synopsis.

> +    (description
> +"TinyDB is a lightweight document oriented database optimized for
> +your happiness.  It's written in pure Python and has no external
> +dependencies.  The targets are small apps that would be blown away
> by a
> +SQL-DB or an external database server.")

I'd suggest "TinyDB is a small document oriented database written in
pure Python with no external dependencies. [...]"

> +    (license license:expat)))
> +
>  (define-public python-pylibmc
>    (package
>      (name "python-pylibmc")






^ permalink raw reply	[flat|nested] 7+ messages in thread

* [bug#51148] [PATCH] gnu: Add python-tinydb.
  2021-10-12  5:44 [bug#51148] [PATCH] gnu: Add python-tinydb jgart via Guix-patches via
  2021-11-11  5:24 ` Vinicius Monego
@ 2021-11-11  5:26 ` Vinicius Monego
  2021-11-11 16:31 ` jgart via Guix-patches via
  2021-11-12  3:45 ` [bug#51148] [PATCH v3] " jgart via Guix-patches via
  3 siblings, 0 replies; 7+ messages in thread
From: Vinicius Monego @ 2021-11-11  5:26 UTC (permalink / raw)
  To: jgart, 51148

Hi jgart,

Em ter, 2021-10-12 às 01:44 -0400, jgart escreveu:
> * gnu/packages/databases.scm (python-tinydb): New variable.
> ---
>  gnu/packages/databases.scm | 40

Don't miss your copyright in this file.

> ++++++++++++++++++++++++++++++++++++++
>  1 file changed, 40 insertions(+)
> 
> diff --git a/gnu/packages/databases.scm 
> b/gnu/packages/databases.scm
> index b1dd44da1c..60970b9c8e 100644
> --- a/gnu/packages/databases.scm
> +++ b/gnu/packages/databases.scm
> @@ -579,6 +579,46 @@ the API, and provides features such as:
>  @end itemize")
>      (license license:bsd-3)))
>  
> +(define-public python-tinydb
> +  (package
> +    (name "python-tinydb")
> +    (version "4.5.2")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (pypi-uri "tinydb" version))
> +              (sha256
> +               (base32
> +               
> "1x9c4s42930wwal3ds0plwb57kg5c3gj7kbpy64c29vq478b463x"))))
> +    (build-system python-build-system)

The indentation is off below.

> +    (arguments
> +       ;; PyPi tarball does not contain tests and github repository
> does not 
> +       ;; have a setup.py file (only pyproject).

I recently noticed this pattern of shipping only Poetry in the
repository while at the same time not shipping tests in PyPI. I don't
know why this is happening or what we can do about it in guix, the best
for now is to source from PyPI and skip tests like in this package.

> +      `(#:tests? #f
> +        #:phases
> +        (modify-phases %standard-phases
> +          (replace 'check
> +            (lambda* (#:key inputs outputs tests? #:allow-other-
> keys)
> +              (when tests?
> +                (add-installed-pythonpath inputs outputs)
> +                (setenv "PYTHONPATH" (string-append ".:" (getenv
> "PYTHONPATH")))

The two lines above are redundant. The second line is the manual way of
doing what the first one does. But if we don't have a way to run the
tests, I'd not override the check phase.

> +                (invoke "pytest")))))))
> +    (native-inputs
> +      `(("python-pytest" ,python-pytest)
> +        ("python-pytest-cov" ,python-pytest-cov)
> +        ("python-pycodestyle" ,python-pycodestyle)
> +        ("python-pyyaml" ,python-pyyaml)))

Test-related native inputs are also useless if tests can't run.

> +    (propagated-inputs
> +      `(("python-typing-extensions" ,python-typing-extensions)))
> +    (home-page "https://github.com/msiemens/tinydb")
> +    (synopsis
> +      "TinyDB is a lightweight document oriented database")

Same line for the synopsis.

> +    (description
> +"TinyDB is a lightweight document oriented database optimized for
> +your happiness.  It's written in pure Python and has no external
> +dependencies.  The targets are small apps that would be blown away
> by a
> +SQL-DB or an external database server.")

I'd suggest "TinyDB is a small document oriented database written in
pure Python with no external dependencies. [...]".

> +    (license license:expat)))
> +
>  (define-public python-pylibmc
>    (package
>      (name "python-pylibmc")






^ permalink raw reply	[flat|nested] 7+ messages in thread

* [bug#51148] [PATCH] gnu: Add python-tinydb.
  2021-10-12  5:44 [bug#51148] [PATCH] gnu: Add python-tinydb jgart via Guix-patches via
  2021-11-11  5:24 ` Vinicius Monego
  2021-11-11  5:26 ` Vinicius Monego
@ 2021-11-11 16:31 ` jgart via Guix-patches via
  2021-11-12  3:45 ` [bug#51148] [PATCH v3] " jgart via Guix-patches via
  3 siblings, 0 replies; 7+ messages in thread
From: jgart via Guix-patches via @ 2021-11-11 16:31 UTC (permalink / raw)
  To: 51148; +Cc: Vinicius Monego, jgart

Hi Vinicius,

Attached are the changes you requested.

Thanks for the code review.

It's much appreciated!

* gnu/packages/databases.scm (python-tinydb): New variable.
---
 gnu/packages/databases.scm | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)

diff --git a/gnu/packages/databases.scm b/gnu/packages/databases.scm
index 92a7aa2761..2495ad8a28 100644
--- a/gnu/packages/databases.scm
+++ b/gnu/packages/databases.scm
@@ -4072,6 +4072,29 @@ (define-public freetds
 connecting to MS SQL and Sybase servers over TCP/IP.")
     (license license:lgpl2.0+)))
 
+(define-public python-tinydb
+  (package
+    (name "python-tinydb")
+    (version "4.5.2")
+    (source (origin
+      (method url-fetch)
+      (uri (pypi-uri "tinydb" version))
+      (sha256
+       (base32 "1x9c4s42930wwal3ds0plwb57kg5c3gj7kbpy64c29vq478b463x"))))
+    (build-system python-build-system)
+    ;; PyPi tarball does not contain tests and github repository does not
+    ;; have a setup.py file (only pyproject).
+    (arguments `(#:tests? #f))
+    (propagated-inputs
+      `(("python-typing-extensions" ,python-typing-extensions)))
+    (home-page "https://github.com/msiemens/tinydb")
+    (synopsis "TinyDB is a lightweight document oriented database")
+    (description
+"TinyDB is a small document oriented database written in pure Python
+with no external dependencies.  The targets are small apps that would
+be blown away by a SQL-DB or an external database server.")
+    (license license:expat)))
+
 (define-public sequeler
   (package
     (name "sequeler")
-- 
2.33.1





^ permalink raw reply	[flat|nested] 7+ messages in thread

* [bug#51148] [PATCH v3] gnu: Add python-tinydb.
  2021-10-12  5:44 [bug#51148] [PATCH] gnu: Add python-tinydb jgart via Guix-patches via
                   ` (2 preceding siblings ...)
  2021-11-11 16:31 ` jgart via Guix-patches via
@ 2021-11-12  3:45 ` jgart via Guix-patches via
  2021-11-23  8:22   ` bug#51148: [PATCH] " Ludovic Courtès
  3 siblings, 1 reply; 7+ messages in thread
From: jgart via Guix-patches via @ 2021-11-12  3:45 UTC (permalink / raw)
  To: 51148; +Cc: Vinicius Monego, jgart

I forgot to add the copyright at the top.

Attached is version 3 of the patchset.

* gnu/packages/databases.scm (python-tinydb): New variable.
---
 gnu/packages/databases.scm | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)

diff --git a/gnu/packages/databases.scm b/gnu/packages/databases.scm
index 92a7aa2761..87fa1da895 100644
--- a/gnu/packages/databases.scm
+++ b/gnu/packages/databases.scm
@@ -53,6 +53,7 @@
 ;;; Copyright © 2021 Simon Streit <simon@netpanic.org>
 ;;; Copyright © 2021 Alexandre Hannud Abdo <abdo@member.fsf.org>
 ;;; Copyright © 2021 Simon Tournier <zimon.toutoune@gmail.com>
+;;; Copyright © 2021 Jorge Gomez <jgart@dismail.de>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -4072,6 +4073,29 @@ (define-public freetds
 connecting to MS SQL and Sybase servers over TCP/IP.")
     (license license:lgpl2.0+)))
 
+(define-public python-tinydb
+  (package
+    (name "python-tinydb")
+    (version "4.5.2")
+    (source (origin
+      (method url-fetch)
+      (uri (pypi-uri "tinydb" version))
+      (sha256
+       (base32 "1x9c4s42930wwal3ds0plwb57kg5c3gj7kbpy64c29vq478b463x"))))
+    (build-system python-build-system)
+    ;; PyPi tarball does not contain tests and github repository does not
+    ;; have a setup.py file (only pyproject).
+    (arguments `(#:tests? #f))
+    (propagated-inputs
+      `(("python-typing-extensions" ,python-typing-extensions)))
+    (home-page "https://github.com/msiemens/tinydb")
+    (synopsis "TinyDB is a lightweight document oriented database")
+    (description
+"TinyDB is a small document oriented database written in pure Python
+with no external dependencies.  The targets are small apps that would
+be blown away by a SQL-DB or an external database server.")
+    (license license:expat)))
+
 (define-public sequeler
   (package
     (name "sequeler")
-- 
2.33.1





^ permalink raw reply	[flat|nested] 7+ messages in thread

* bug#51148: [PATCH] gnu: Add python-tinydb.
  2021-11-12  3:45 ` [bug#51148] [PATCH v3] " jgart via Guix-patches via
@ 2021-11-23  8:22   ` Ludovic Courtès
  2021-11-23  8:37     ` [bug#51148] " jgart via Guix-patches via
  0 siblings, 1 reply; 7+ messages in thread
From: Ludovic Courtès @ 2021-11-23  8:22 UTC (permalink / raw)
  To: jgart; +Cc: 51148-done, Vinicius Monego

Hi,

jgart <jgart@dismail.de> skribis:

> I forgot to add the copyright at the top.

In the meantime another line had been added for you.  :-)

> Attached is version 3 of the patchset.
>
> * gnu/packages/databases.scm (python-tinydb): New variable.

I applied and tweaked indentation.

Thanks, and thanks Vinicius for reviewing,
Ludo’.




^ permalink raw reply	[flat|nested] 7+ messages in thread

* [bug#51148] [PATCH] gnu: Add python-tinydb.
  2021-11-23  8:22   ` bug#51148: [PATCH] " Ludovic Courtès
@ 2021-11-23  8:37     ` jgart via Guix-patches via
  0 siblings, 0 replies; 7+ messages in thread
From: jgart via Guix-patches via @ 2021-11-23  8:37 UTC (permalink / raw)
  To: Ludovic Courtès; +Cc: 51148-done, Vinicius Monego

On Tue, 23 Nov 2021 09:22:39 +0100 Ludovic Courtès <ludo@gnu.org> wrote:

Thanks Ludo and Vinicius!

all best,

jgart




^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2021-11-23  8:38 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-12  5:44 [bug#51148] [PATCH] gnu: Add python-tinydb jgart via Guix-patches via
2021-11-11  5:24 ` Vinicius Monego
2021-11-11  5:26 ` Vinicius Monego
2021-11-11 16:31 ` jgart via Guix-patches via
2021-11-12  3:45 ` [bug#51148] [PATCH v3] " jgart via Guix-patches via
2021-11-23  8:22   ` bug#51148: [PATCH] " Ludovic Courtès
2021-11-23  8:37     ` [bug#51148] " jgart via Guix-patches via

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).