From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id BG3cDZj9emGgtgAAgWs5BA (envelope-from ) for ; Thu, 28 Oct 2021 21:44:24 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id 8GvwCJj9emHEQwAAB5/wlQ (envelope-from ) for ; Thu, 28 Oct 2021 19:44:24 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 7D25B102F7 for ; Thu, 28 Oct 2021 21:44:23 +0200 (CEST) Received: from localhost ([::1]:59544 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mgBK2-0006lv-N9 for larch@yhetil.org; Thu, 28 Oct 2021 15:44:22 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46024) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mgBJj-0006bF-1W for guix-patches@gnu.org; Thu, 28 Oct 2021 15:44:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:41743) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mgBJi-0002LT-Pi for guix-patches@gnu.org; Thu, 28 Oct 2021 15:44:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mgBJi-0002Hy-Eh for guix-patches@gnu.org; Thu, 28 Oct 2021 15:44:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#51467] [PATCH core-updates-frozen] gnu: gtk+: Fix testsuite failure on non-x86_64 platforms. Resent-From: Thiago Jung Bauermann Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 28 Oct 2021 19:44:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 51467 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 51467@debbugs.gnu.org Cc: Thiago Jung Bauermann X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.16354502358776 (code B ref -1); Thu, 28 Oct 2021 19:44:02 +0000 Received: (at submit) by debbugs.gnu.org; 28 Oct 2021 19:43:55 +0000 Received: from localhost ([127.0.0.1]:53289 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mgBJb-0002HU-7n for submit@debbugs.gnu.org; Thu, 28 Oct 2021 15:43:55 -0400 Received: from lists.gnu.org ([209.51.188.17]:34426) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mgBJW-0002HK-Mx for submit@debbugs.gnu.org; Thu, 28 Oct 2021 15:43:54 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45960) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mgBJV-0006XN-P4 for guix-patches@gnu.org; Thu, 28 Oct 2021 15:43:50 -0400 Received: from mx.kolabnow.com ([212.103.80.155]:32866) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mgBJQ-0002Ij-Hv for guix-patches@gnu.org; Thu, 28 Oct 2021 15:43:47 -0400 Received: from localhost (unknown [127.0.0.1]) by mx.kolabnow.com (Postfix) with ESMTP id CB03B1237 for ; Thu, 28 Oct 2021 21:43:41 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kolabnow.com; h= content-transfer-encoding:content-type:content-type:mime-version :message-id:date:date:subject:subject:from:from:received :received:received; s=dkim20160331; t=1635450221; x=1637264622; bh=TwmdjSgWUagqHAH/ipOrkSm5ah8SDqkyo1CAH49BHwk=; b=KO5JRYxKgsN3 PjgKpJGgQR5RNrLqOehDbNBOI/nguwDQC1FjOXEuSOaE1M+JSkzYkFVJtkDsA2Yd v4yjBA8ZClZ4fkbgKm3WzMOm0rsKvyD2oupngxZoUrbmxLWjWbTgrlft+en6NkKG QmlAMcMdc88KO1s0IHDV8v7bqKfp80mVJid3fJP62P5DLJJqdz673jybekWY1GRS CTcSAmaqU1MoKlKwLdvlu+dIMBx54p5oNfvr8Z0CdICYjbuGT7s1x0ocr1wn8G1V zYPJjxt7YSDm59WX+lxNbgQSZVM10iOdEmfTATIjSl0jCBuzU6ViEXbD7sHP4qSW M/+jfhY3/VamqBa2umKhZbMB59tkhKXL8ZOvoB/BQB2C9OXM0kT9sKTt/VAunyJv G0kMSdj/dmXUaPiwix2K8a/8GQJGmSHytcuxIUnJQtzdZFtLwpXxSMgPCVBZagPx zfj76ic9RwyjqVoE45CB6penTrG2O7tEydv8ag474TU4/jt2+WbPs/2yj9oZzZ2h e7X98H4CB9g6K//8UKs4BbMT+LWNsxPm6EV7SEwj+VI0amC7r67jxBIq1PptKE5s nfqa8qqFxTLedjUA79EvQtRDCEoMNHBCMAG1YBD7RBKxXvgtojMPfVznO+ZsOWxQ r8LPC38mb7+F5PYgYWlPao4L9EQOQzE= X-Virus-Scanned: amavisd-new at mykolab.com Received: from mx.kolabnow.com ([127.0.0.1]) by localhost (ext-mx-out001.mykolab.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 7Wm1CNUrN2z0 for ; Thu, 28 Oct 2021 21:43:41 +0200 (CEST) Received: from int-mx001.mykolab.com (unknown [10.9.13.1]) by mx.kolabnow.com (Postfix) with ESMTPS id 1A0AD10C2 for ; Thu, 28 Oct 2021 21:43:39 +0200 (CEST) Received: from ext-subm002.mykolab.com (unknown [10.9.6.2]) by int-mx001.mykolab.com (Postfix) with ESMTPS id 98BB5263A; Thu, 28 Oct 2021 21:43:39 +0200 (CEST) Date: Thu, 28 Oct 2021 16:43:23 -0300 Message-Id: <20211028194323.50370-1-bauermann@kolabnow.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=212.103.80.155; envelope-from=bauermann@kolabnow.com; helo=mx.kolabnow.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" Reply-to: Thiago Jung Bauermann X-ACL-Warn: , Thiago Jung Bauermann via Guix-patches From: Thiago Jung Bauermann via Guix-patches via X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1635450263; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=TwmdjSgWUagqHAH/ipOrkSm5ah8SDqkyo1CAH49BHwk=; b=DUSOpnqSoKA6syycncPZ+uJ09JwBoh1vOeYAcMo+B+7R1pMpPkhOmqiwfE7Rvpi4Xmn5qu BYNVG3+65PW/9gKrX0IC5+Ctyi7pcaxIKiio6W9fnvQnIFDXvVGDFxMZQTFqIcI8/7B2zh 5q1KZ1WJ/U8qnfUDVLJgoLWcL9WJzUur5QsAEsdORbZkTAhmoMIPYqjw6V8xpyKQEsBPBv B14A5mrgj1Ir0NpvryegdAJ4cIRI2JqNy/tRlY4Z6ZqZw8iIku73lNJllQxxg/AO/9zvDr lXD4jksq0jDdptoGevKzzuHnwARNWlUMgn3nnC7WTEtUN1Eumk/3CacdReOaKQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1635450263; a=rsa-sha256; cv=none; b=QEwBEfuecQZd4H5YgIJaoxJxPMuYSUjvGbY/qEH8okV221DXanxpKEKmy7S43UUVvXDntf 1r0AOfomhbB/fuKFXWEo3B/Q2o/EXi6NDPduELv/RXZrv43e49A1Q9Zlm0bRvs6TXGM3J+ rQ/whFvqlA5mkNJtoHooG6M8QT+vv8cN/iINA02u9cOO8nICDIN98d/v7GWlmlSeQk2ZE3 qRsB7TX3alVapVZ4CZTPwY1AbTsdjZYrmuM3hCvNCtXsoOHhucMaDHUFh3QXNHx4QnhTM7 YuLpoUMtMkPjMR4McS9wgoe+uBaz/EJCJY9F94F2oIg5x7iEwtfjh2JK4ARILQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=kolabnow.com header.s=dkim20160331 header.b=KO5JRYxK; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -2.93 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=kolabnow.com header.s=dkim20160331 header.b=KO5JRYxK; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 7D25B102F7 X-Spam-Score: -2.93 X-Migadu-Scanner: scn0.migadu.com X-TUID: 8ysJzFbDRWcO On non-x86_64 platforms, gtk+ is linked with a gdk-pixbuf version that doesn’t support SVG. This causes the ‘tree-relationships’ test to fail because it tries to fetch SVG icons in some of the tests. Therefore, we need to disable the test when SVG support isn’t available. * gnu/packages/gtk.scm (gtk+)[arguments]<#:phases>{disable-failing-tests}: Disable ‘tree-relationships’ test on non-x86_64 platforms. --- Hello, Considering that the core-updates-frozen-batched-changes branch will soon make GTK+ depend on Rust (via an updated mozjs package), perhaps this patch is somewhat pointless. But I thought it would be at least a bit useful to have this information recorded. Also, there's a good change that polkit will switch from mozjs to duktape as its Javascript engine. In that case it will be useful again to have this patch in. With this patch, GTK+ builds again on core-updates-frozen on powerpc64le-linux. This patch doesn't change the package derivation on x86_64-linux Thanks, Thiago. gnu/packages/gtk.scm | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/gnu/packages/gtk.scm b/gnu/packages/gtk.scm index fadd0794c5dd..40fc2c93d681 100644 --- a/gnu/packages/gtk.scm +++ b/gnu/packages/gtk.scm @@ -1106,7 +1106,12 @@ (define-public gtk+ '())) (substitute* "testsuite/a11y/Makefile.in" (("accessibility-dump tree-performance text children derive") - "tree-performance text children derive")) + "tree-performance text children derive") + ;; The ‘tree-relationships’ test needs SVG support. + ,@(if (not (target-x86-64?)) + '((("value misc tree-relationships util") + "value misc util")) + '())) (substitute* "testsuite/reftests/Makefile.in" (("TEST_PROGS = gtk-reftest") "TEST_PROGS = "))