unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Julien Lepiller <julien@lepiller.eu>
To: "pelzflorian (Florian Pelz)" <pelzflorian@pelzflorian.de>
Cc: 51122-done@debbugs.gnu.org
Subject: bug#51122: [PATCH v2] maint: Factorize po xref translation.
Date: Sun, 17 Oct 2021 22:12:29 +0200	[thread overview]
Message-ID: <20211017221229.071626be@tachikoma.lepiller.eu> (raw)
In-Reply-To: <20211016184502.x3gxejejudogx5l5@pelzflorian.localdomain>

Le Sat, 16 Oct 2021 20:45:02 +0200,
"pelzflorian (Florian Pelz)" <pelzflorian@pelzflorian.de> a écrit :

> On Sat, Oct 16, 2021 at 04:12:15AM +0200, Julien Lepiller wrote:
> > I managed to change the dependency to only guix/po.go, and to make
> > it not phony, so the translated manuals don't get rebuilt on every
> > make invocation anymore. I checked again that "make" from a clean
> > checkout and "make as-derivation" still work.  
> 
> Good, thank you!  I had thought it would be more complicated than
> moving out the PHONY directive, but all works OK:
> 
> Without patch, the fuzzy references cause make to fail for Weblate’s
> version of the Spanish manual.  With patch, make runs through fine as
> you write.  GUIX_ALLOW_ME_TO_USE_PRIVATE_COMMIT=yes make
> update-guix-package && git commit and guix pull and still works, guix
> build guix failed in check but for unrelated reasons, so the patch
> LGTM.  Except:
> 
> As we discussed before, you only remove code from guix/self.scm, so
> you should not add a copyright line.
> 
> Regards,
> Florian

Thanks, pushed as 0623138ffa5b066afc25547ffdeb97753cb0ee9a, and
followed by an nls update.




      reply	other threads:[~2021-10-17 20:13 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-10 21:32 [bug#51122] [PATCH] maint: Factorize po xref translation Julien Lepiller
2021-10-10 21:37 ` Julien Lepiller
2021-10-11  8:45   ` pelzflorian (Florian Pelz)
2021-10-11 12:46     ` [bug#51122] [PATCH v2] " Julien Lepiller
2021-10-11 17:17       ` pelzflorian (Florian Pelz)
2021-10-11 22:06         ` Julien Lepiller
2021-10-12 15:56           ` pelzflorian (Florian Pelz)
2021-10-12 18:09             ` pelzflorian (Florian Pelz)
2021-10-12 19:25               ` Julien Lepiller
2021-10-16  2:12                 ` Julien Lepiller
2021-10-16 18:45                   ` pelzflorian (Florian Pelz)
2021-10-17 20:12                     ` Julien Lepiller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211017221229.071626be@tachikoma.lepiller.eu \
    --to=julien@lepiller.eu \
    --cc=51122-done@debbugs.gnu.org \
    --cc=pelzflorian@pelzflorian.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).