From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id FYs3M/kda2FY3AAAgWs5BA (envelope-from ) for ; Sat, 16 Oct 2021 20:46:17 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id CftULvkda2G7GwAAB5/wlQ (envelope-from ) for ; Sat, 16 Oct 2021 18:46:17 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 69D3037060 for ; Sat, 16 Oct 2021 20:46:17 +0200 (CEST) Received: from localhost ([::1]:55434 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mbohE-0007vz-EW for larch@yhetil.org; Sat, 16 Oct 2021 14:46:16 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45346) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mboh1-0007ui-2U for guix-patches@gnu.org; Sat, 16 Oct 2021 14:46:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:59735) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mboh0-0003R8-Ow for guix-patches@gnu.org; Sat, 16 Oct 2021 14:46:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mboh0-0004xg-Cp for guix-patches@gnu.org; Sat, 16 Oct 2021 14:46:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#51122] [PATCH v2] maint: Factorize po xref translation. Resent-From: "pelzflorian (Florian Pelz)" Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 16 Oct 2021 18:46:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51122 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Julien Lepiller Cc: 51122@debbugs.gnu.org Received: via spool by 51122-submit@debbugs.gnu.org id=B51122.163440992419024 (code B ref 51122); Sat, 16 Oct 2021 18:46:02 +0000 Received: (at 51122) by debbugs.gnu.org; 16 Oct 2021 18:45:24 +0000 Received: from localhost ([127.0.0.1]:43048 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mbogH-0004wf-80 for submit@debbugs.gnu.org; Sat, 16 Oct 2021 14:45:24 -0400 Received: from pelzflorian.de ([5.45.111.108]:42094 helo=mail.pelzflorian.de) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mbogE-0004wW-Dn for 51122@debbugs.gnu.org; Sat, 16 Oct 2021 14:45:15 -0400 Received: from pelzflorian.localdomain (unknown [5.45.111.108]) by mail.pelzflorian.de (Postfix) with ESMTPSA id 33B733606A0; Sat, 16 Oct 2021 20:45:12 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=pelzflorian.de; s=mail; t=1634409913; bh=mEVzMcjQZKh4ibAAxRjlQSATCt0oVvh+fUyY/QDTEiM=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=s+hXImeZzvE28UZWlMSkeN7W2Zf93H95VbNx5Wt0iKTGi4aFDjUFdLqARAh5v4Haw J9MqOlWVm76jafjcasV+OSIEseZN+gHIp13mw9n/pGFWBwoqT1seyHpT20miCYcZtb gw/kgRFnOd3DiaU5TZIXsJ7iZh36crxjpgmxbCuI= Date: Sat, 16 Oct 2021 20:45:02 +0200 From: "pelzflorian (Florian Pelz)" Message-ID: <20211016184502.x3gxejejudogx5l5@pelzflorian.localdomain> References: <8a210e8ceaadfa600e60b0b97a1e7aba04b2bb02.1633901513.git.julien@lepiller.eu> <20211010233711.23bb1e9e@tachikoma.lepiller.eu> <20211011082415.j6wera4b5t4mtnxa@pelzflorian.localdomain> <20211011144626.0049af43@tachikoma.lepiller.eu> <20211011171603.3m7spi6bwlhpgjiv@pelzflorian.localdomain> <20211012000657.11daa7a3@tachikoma.lepiller.eu> <20211012155611.vbhkyxjmqlc3ja77@pelzflorian.localdomain> <20211012180941.i7c26gyz3yyqsdd6@pelzflorian.localdomain> <5EFA87E6-D0D0-4D28-99D4-2CCC7E00EDD0@lepiller.eu> <20211016041215.1005a12b@tachikoma.lepiller.eu> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20211016041215.1005a12b@tachikoma.lepiller.eu> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1634409977; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=xMKV7r4WeJjfEJ9xkf4pyrgqKd1OwI71C3Z6T+In8a0=; b=VDrZcbUoItvfwvIAoRIoqg2H+BP27x3W0PCnEIVeo/4TzRrbXSK8yIz4hwKPi7wV6bWRFk iA66tjG683Ou8/YGoBiMA558mysmoogUh8bQxDCTl1FDAzBeTvXt5oIjjmY4ihdfnOP/8g DG+q2HSXKAGE/syv84CdGUK+l79qeODpQ2+FxGfkrV2ZeTBXinwCvc5vtPKOUqR9pHLxdG IeltqhQEhrJmRTMG2vg+QKo5t5GqerE11QvxhEgP0ysKPdza3x5ibYz/jvTXPCfXCnNxPF Bj6PKFvnTR++dHAlbRGCaOOTRTNppG0ibtlffyTbBOVt0p+/prdvn97K1mRt0w== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1634409977; a=rsa-sha256; cv=none; b=gXfpGJ5O3tKJdng0WKHg8FEfQ9s0rsK5y9+5liADNQuYhTuNfoUwh2lWbkYco5YQAJKSYI uEX3SfaheIKJd7xLz1+xxu3Bl7bkicRR8hmy/FgEf7KZAANSPX7nLdMa9+JDGwFfgqfiAQ XxpRjovEPIf6JvaSOCJFhQwvjUSkAaUrOsOxSGGAB7OxM73CDP8fHa7KKh6Vy3T/kkeIWn PVAtJtucktVGnn8Z5Jx5nhNKhgS5E2Syrwd3PLFaN7QCSXy08JiMDqveT7mW8O/LKuhJjk yaYMM4YApCf5LCdNLhzutRQfamVYMsE8Rke8wbO4GSNilOKwU64oHH4nUn5OtA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=pelzflorian.de header.s=mail header.b=s+hXImeZ; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -1.82 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=pelzflorian.de header.s=mail header.b=s+hXImeZ; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 69D3037060 X-Spam-Score: -1.82 X-Migadu-Scanner: scn1.migadu.com X-TUID: w8wgK7fdo2RM On Sat, Oct 16, 2021 at 04:12:15AM +0200, Julien Lepiller wrote: > I managed to change the dependency to only guix/po.go, and to make it > not phony, so the translated manuals don't get rebuilt on every make > invocation anymore. I checked again that "make" from a clean checkout > and "make as-derivation" still work. Good, thank you! I had thought it would be more complicated than moving out the PHONY directive, but all works OK: Without patch, the fuzzy references cause make to fail for Weblate’s version of the Spanish manual. With patch, make runs through fine as you write. GUIX_ALLOW_ME_TO_USE_PRIVATE_COMMIT=yes make update-guix-package && git commit and guix pull and still works, guix build guix failed in check but for unrelated reasons, so the patch LGTM. Except: As we discussed before, you only remove code from guix/self.scm, so you should not add a copyright line. Regards, Florian