* [bug#51113] [PATCH] gnu: Add snooze.
@ 2021-10-10 7:53 jgart via Guix-patches via
2021-10-13 19:28 ` Nicolas Goaziou
2021-10-13 21:28 ` jgart via Guix-patches via
0 siblings, 2 replies; 5+ messages in thread
From: jgart via Guix-patches via @ 2021-10-10 7:53 UTC (permalink / raw)
To: 51113; +Cc: jgart
* gnu/packages/suckless.scm (snooze): New variable.
---
gnu/packages/suckless.scm | 31 +++++++++++++++++++++++++++++++
1 file changed, 31 insertions(+)
diff --git a/gnu/packages/suckless.scm b/gnu/packages/suckless.scm
index b24eced379..1643c89990 100644
--- a/gnu/packages/suckless.scm
+++ b/gnu/packages/suckless.scm
@@ -873,6 +873,37 @@ It is a front end for ii-like chat programs. It uses @code{tail -f} to get the
chat output in the background.")
(license license:isc))))
+(define-public snooze
+ (package
+ (name "snooze")
+ (version "0.5")
+ (source
+ (origin
+ (method git-fetch)
+ (uri
+ (git-reference
+ (url "https://github.com/leahneukirchen/snooze")
+ (commit (string-append "v" version))))
+ (file-name (git-file-name name version))
+ (sha256
+ (base32 "02ng3r1gzgpyjia4b60i11dj5bhn3xjsdcbwmxaam6dzb33dmgib"))))
+ (build-system gnu-build-system)
+ (arguments
+ `(#:tests? #f
+ #:make-flags
+ (list (string-append "CC=" ,(cc-for-target))
+ (string-append "DESTDIR=" %output)
+ "PREFIX=")
+ #:phases
+ (modify-phases %standard-phases
+ (delete 'configure))))
+ (home-page "https://github.com/leahneukirchen/snooze")
+ (synopsis "Run a command at a particular time")
+ (description
+"@command{snooze} is a new tool for waiting until a particular time and then
+running a command.")
+ (license license:cc0)))
+
(define-public scron
(package
(name "scron")
--
2.33.0
^ permalink raw reply related [flat|nested] 5+ messages in thread* [bug#51113] [PATCH] gnu: Add snooze.
2021-10-10 7:53 [bug#51113] [PATCH] gnu: Add snooze jgart via Guix-patches via
@ 2021-10-13 19:28 ` Nicolas Goaziou
2021-10-19 6:16 ` jgart via Guix-patches via
2021-10-13 21:28 ` jgart via Guix-patches via
1 sibling, 1 reply; 5+ messages in thread
From: Nicolas Goaziou @ 2021-10-13 19:28 UTC (permalink / raw)
To: 51113; +Cc: jgart
Hello,
jgart via Guix-patches via <guix-patches@gnu.org> writes:
> * gnu/packages/suckless.scm (snooze): New variable.
Thank you. Some comments follow.
> + (arguments
> + `(#:tests? #f
Could you add a comment explaining why tests are disabled? I assume
upstream does not provide any.
> + #:make-flags
> + (list (string-append "CC=" ,(cc-for-target))
> + (string-append "DESTDIR=" %output)
> + "PREFIX=")
It may be worth explaining in a comment why PREFIX is reset.
> + #:phases
> + (modify-phases %standard-phases
> + (delete 'configure))))
> + (home-page "https://github.com/leahneukirchen/snooze")
> + (synopsis "Run a command at a particular time")
> + (description
> +"@command{snooze} is a new tool for waiting until a particular time and then
> +running a command.")
I would remove "new" from the description.
Otherwise, LGTM. Could you send an updated patch?
Regards,
--
Nicolas Goaziou
^ permalink raw reply [flat|nested] 5+ messages in thread* [bug#51113] [PATCH] gnu: Add snooze.
2021-10-13 19:28 ` Nicolas Goaziou
@ 2021-10-19 6:16 ` jgart via Guix-patches via
0 siblings, 0 replies; 5+ messages in thread
From: jgart via Guix-patches via @ 2021-10-19 6:16 UTC (permalink / raw)
To: Nicolas Goaziou; +Cc: 51113
On Wed, 13 Oct 2021 21:28:48 +0200 Nicolas Goaziou <mail@nicolasgoaziou.fr> wrote:
> Hello,
>
> jgart via Guix-patches via <guix-patches@gnu.org> writes:
>
> > * gnu/packages/suckless.scm (snooze): New variable.
>
> Thank you. Some comments follow.
>
> > + (arguments
> > + `(#:tests? #f
>
> Could you add a comment explaining why tests are disabled? I assume
> upstream does not provide any.
>
> > + #:make-flags
> > + (list (string-append "CC=" ,(cc-for-target))
> > + (string-append "DESTDIR=" %output)
> > + "PREFIX=")
>
> It may be worth explaining in a comment why PREFIX is reset.
>
> > + #:phases
> > + (modify-phases %standard-phases
> > + (delete 'configure))))
> > + (home-page "https://github.com/leahneukirchen/snooze")
> > + (synopsis "Run a command at a particular time")
> > + (description
> > +"@command{snooze} is a new tool for waiting until a particular time and then
> > +running a command.")
>
> I would remove "new" from the description.
>
> Otherwise, LGTM. Could you send an updated patch?
Hi Nicolas,
I forgot to CC you.
The updated patch is above. Thank you for taking the time to review the patch.
all best,
jgart
^ permalink raw reply [flat|nested] 5+ messages in thread
* [bug#51113] [PATCH] gnu: Add snooze.
2021-10-10 7:53 [bug#51113] [PATCH] gnu: Add snooze jgart via Guix-patches via
2021-10-13 19:28 ` Nicolas Goaziou
@ 2021-10-13 21:28 ` jgart via Guix-patches via
2021-10-21 22:13 ` bug#51113: " Nicolas Goaziou
1 sibling, 1 reply; 5+ messages in thread
From: jgart via Guix-patches via @ 2021-10-13 21:28 UTC (permalink / raw)
To: 51113; +Cc: jgart, Nicolas Goaziou
Hi Nicolas, thanks for reviewing the patch.
Here's a new patch with your suggestions.
* gnu/packages/suckless.scm (snooze): New variable.
---
gnu/packages/suckless.scm | 33 +++++++++++++++++++++++++++++++++
1 file changed, 33 insertions(+)
diff --git a/gnu/packages/suckless.scm b/gnu/packages/suckless.scm
index b24eced379..d207a2300b 100644
--- a/gnu/packages/suckless.scm
+++ b/gnu/packages/suckless.scm
@@ -873,6 +873,39 @@ It is a front end for ii-like chat programs. It uses @code{tail -f} to get the
chat output in the background.")
(license license:isc))))
+(define-public snooze
+ (package
+ (name "snooze")
+ (version "0.5")
+ (source
+ (origin
+ (method git-fetch)
+ (uri
+ (git-reference
+ (url "https://github.com/leahneukirchen/snooze")
+ (commit (string-append "v" version))))
+ (file-name (git-file-name name version))
+ (sha256
+ (base32 "02ng3r1gzgpyjia4b60i11dj5bhn3xjsdcbwmxaam6dzb33dmgib"))))
+ (build-system gnu-build-system)
+ (arguments
+ `(#:tests? #f ; There are no tests.
+ #:make-flags
+ (list (string-append "CC=" ,(cc-for-target))
+ (string-append "DESTDIR=" %output)
+ ;; Set prefix path to root of package path in store instead
+ ;; of /usr/local.
+ (string-append "PREFIX=" %output))
+ #:phases
+ (modify-phases %standard-phases
+ (delete 'configure))))
+ (home-page "https://github.com/leahneukirchen/snooze")
+ (synopsis "Run a command at a particular time")
+ (description
+"@command{snooze} is a tool for waiting until a particular time and then
+running a command.")
+ (license license:cc0)))
+
(define-public scron
(package
(name "scron")
--
2.33.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-10-21 22:35 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-10-10 7:53 [bug#51113] [PATCH] gnu: Add snooze jgart via Guix-patches via
2021-10-13 19:28 ` Nicolas Goaziou
2021-10-19 6:16 ` jgart via Guix-patches via
2021-10-13 21:28 ` jgart via Guix-patches via
2021-10-21 22:13 ` bug#51113: " Nicolas Goaziou
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).