unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: "pelzflorian (Florian Pelz)" <pelzflorian@pelzflorian.de>
To: Julien Lepiller <julien@lepiller.eu>
Cc: 51122@debbugs.gnu.org
Subject: [bug#51122] [PATCH v2] maint: Factorize po xref translation.
Date: Tue, 12 Oct 2021 17:56:11 +0200	[thread overview]
Message-ID: <20211012155611.vbhkyxjmqlc3ja77@pelzflorian.localdomain> (raw)
In-Reply-To: <20211012000657.11daa7a3@tachikoma.lepiller.eu>

On Tue, Oct 12, 2021 at 12:06:57AM +0200, Julien Lepiller wrote:
> Le Mon, 11 Oct 2021 19:17:28 +0200,
> "pelzflorian (Florian Pelz)" <pelzflorian@pelzflorian.de> a écrit :
> > Also POXREF is run twice for each
> > guix.??.texi file.  Maybe I did something wrong, maybe it is your
> > patch.  Not sure.  Testing takes long anyway.
> It only runs it once here, but there are three files to translate:
> guix.xx.texi, guix-cookbook.xx.texi and contributing.xx.texi.

At least when depending on make-core-go instead of make-go, it does
POXREF each file twice, in between printing “Updating
doc/version.texi”.  Anyway, this is more important:

> It looks like depending on make-go or make-core-go means we rebuild the
> texi files everytime we run "make", so that's not great :/.

We definitely want to compile guix/build/po.scm, I think, because it
should be run each time a guix-manual.LL.po or guix-cookbook.LL.po
file changes.

GNU Make manual says
<https://www.gnu.org/software/make/manual/html_node/Phony-Targets.html#Phony-Targets>:
> A phony target should not be a prerequisite of a real target file; if
> it is, its recipe will be run every time make goes to update that
> file.

But Makefile.am defines guile-compilation-rule to create a Phony target.

This is bad for us because likely there should not be duplicate code
to compile guix/build/po.scm and to compile the rest.

So I presume part of guile-compilation-rule must be split off?

Regards,
Florian




  reply	other threads:[~2021-10-12 15:57 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-10 21:32 [bug#51122] [PATCH] maint: Factorize po xref translation Julien Lepiller
2021-10-10 21:37 ` Julien Lepiller
2021-10-11  8:45   ` pelzflorian (Florian Pelz)
2021-10-11 12:46     ` [bug#51122] [PATCH v2] " Julien Lepiller
2021-10-11 17:17       ` pelzflorian (Florian Pelz)
2021-10-11 22:06         ` Julien Lepiller
2021-10-12 15:56           ` pelzflorian (Florian Pelz) [this message]
2021-10-12 18:09             ` pelzflorian (Florian Pelz)
2021-10-12 19:25               ` Julien Lepiller
2021-10-16  2:12                 ` Julien Lepiller
2021-10-16 18:45                   ` pelzflorian (Florian Pelz)
2021-10-17 20:12                     ` bug#51122: " Julien Lepiller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211012155611.vbhkyxjmqlc3ja77@pelzflorian.localdomain \
    --to=pelzflorian@pelzflorian.de \
    --cc=51122@debbugs.gnu.org \
    --cc=julien@lepiller.eu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).