From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id KAxML9NxZGH1pwAAgWs5BA (envelope-from ) for ; Mon, 11 Oct 2021 19:18:11 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id uPrlKtNxZGFOEgAAB5/wlQ (envelope-from ) for ; Mon, 11 Oct 2021 17:18:11 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 1C30C1D144 for ; Mon, 11 Oct 2021 19:18:11 +0200 (CEST) Received: from localhost ([::1]:55768 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mZywE-0001vE-6V for larch@yhetil.org; Mon, 11 Oct 2021 13:18:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52700) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mZyw6-0001tY-J8 for guix-patches@gnu.org; Mon, 11 Oct 2021 13:18:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:49276) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mZyw6-0006gL-7V for guix-patches@gnu.org; Mon, 11 Oct 2021 13:18:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mZyw5-0000oG-UL for guix-patches@gnu.org; Mon, 11 Oct 2021 13:18:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#51122] [PATCH v2] maint: Factorize po xref translation. Resent-From: "pelzflorian (Florian Pelz)" Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 11 Oct 2021 17:18:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51122 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Julien Lepiller Cc: 51122@debbugs.gnu.org Received: via spool by 51122-submit@debbugs.gnu.org id=B51122.16339726642930 (code B ref 51122); Mon, 11 Oct 2021 17:18:01 +0000 Received: (at 51122) by debbugs.gnu.org; 11 Oct 2021 17:17:44 +0000 Received: from localhost ([127.0.0.1]:60822 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mZyvo-0000l5-5k for submit@debbugs.gnu.org; Mon, 11 Oct 2021 13:17:44 -0400 Received: from pelzflorian.de ([5.45.111.108]:33078 helo=mail.pelzflorian.de) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mZyvi-0000g7-DT for 51122@debbugs.gnu.org; Mon, 11 Oct 2021 13:17:42 -0400 Received: from pelzflorian.localdomain (unknown [5.45.111.108]) by mail.pelzflorian.de (Postfix) with ESMTPSA id 1403236069D; Mon, 11 Oct 2021 19:17:37 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=pelzflorian.de; s=mail; t=1633972657; bh=Y+sSpwFDqupkQ4gZj6dhcznqOFfhtBaUuOROKtcJZLw=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=Ry+CGe6s3D/KIcUWlCyN9zkqb+eqPBs7Q2aaRNykHXfZW1Fn+UNHx+thqXIQWIhQy 7ZkSWXGgm33P2B2NlWW41b7j+Buyy2yzYraVCQpXVh6jDw0TyXIbxUdxs0ks4vuRXj kJ79d+RduTlikR26ws0YnqqEUvIFthWx7IF6iEYE= Date: Mon, 11 Oct 2021 19:17:28 +0200 From: "pelzflorian (Florian Pelz)" Message-ID: <20211011171603.3m7spi6bwlhpgjiv@pelzflorian.localdomain> References: <8a210e8ceaadfa600e60b0b97a1e7aba04b2bb02.1633901513.git.julien@lepiller.eu> <20211010233711.23bb1e9e@tachikoma.lepiller.eu> <20211011082415.j6wera4b5t4mtnxa@pelzflorian.localdomain> <20211011144626.0049af43@tachikoma.lepiller.eu> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20211011144626.0049af43@tachikoma.lepiller.eu> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1633972691; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=J+99UAcr30gEvrWoGPLdALE5Nz753LX6p3BbQkeYlAk=; b=WW3AGrAfiJ4afC25vjlhMJQRyJw7oilgNRf8csp483XrWi0PzjuPILQJxLDkllZ7A7W1Ap Yq3U3oCZtWEKAa5fYLh+IBdM/Vh5GJqcEV+4N9autjIckwsRIDuMSyH1F0U11Cuo1FvNz7 7kdHcO7Waqhpm4xjWnZymZqD027P8g6kiIi/2FxkSV4tghHE4LW7oe9v2DpnF1bbnLjh+f kN96/0fvw4kiQ4JhW8JMgPvHLvan4dSLtIm4egr2l+qUthzL9nW4vqjwsgyEuqLhTFEp42 MgNE4K71qSNF7WSgLiMe0jjasWn7QYc/FyMJAmGD5N0UDXwcaiZbxbsd9eUKCA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1633972691; a=rsa-sha256; cv=none; b=jbVQS+fd9MfpyEbM353Oj29LI08LuSDo6bKMQuFbQP8kIej7sEROXcFgE0wY3MPMWymYP0 V5sGK/mDRU38iZFdz1UV3gc7l7V6dvesz1tu/abj/A4jkj+j2mZwXo1Z+0S8Ck/Hu5AY9U ZIFnCm8pQtEuHdFIuZWlt+WnGNFaNIo0Qb8tODiJdLjh8StdYMxUq81gvd5aSgVmupDLzc KdV3r1+OelijiZxj90n0RcPwE0Opege4F4WTcl1NA3ppi2WL0NRUVgzGVQgnX/tKRjAzd2 SEGKwB9mOzu1MGUMH9p39/bvkAknLbyEzXr84egR9stEOxDrB4g4hXHa0EFK2w== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=pelzflorian.de header.s=mail header.b=Ry+CGe6s; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -1.42 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=pelzflorian.de header.s=mail header.b=Ry+CGe6s; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 1C30C1D144 X-Spam-Score: -1.42 X-Migadu-Scanner: scn0.migadu.com X-TUID: 6d4SHWtaOApx Thanks Julien! On Mon, Oct 11, 2021 at 02:46:26PM +0200, Julien Lepiller wrote: > Thanks for the quick review! I've updated the commit message and > updated the copyright headers in guix/build/po.scm and guix/self.scm. In guix/self.scm you only removed code. I don’t think a copyright header is needed there. > I had to make the texi files depend on make-go because otherwise, I get > messages like "guix/build/po.scm is newer than compiled > .../guix/build/po.go" and it takes forever to build that file, once for > each texi. For some reason, it's almost instantaneous when building in > make-go. make-core-go instead of make-go is enough in my testing, but something more fine-grained would save time. Also POXREF is run twice for each guix.??.texi file. Maybe I did something wrong, maybe it is your patch. Not sure. Testing takes long anyway. Regards, Florian