From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id 2f2WANz5Y2FA3AAAgWs5BA (envelope-from ) for ; Mon, 11 Oct 2021 10:46:20 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id QDVfNdv5Y2GEbwAA1q6Kng (envelope-from ) for ; Mon, 11 Oct 2021 08:46:19 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 73BAD37403 for ; Mon, 11 Oct 2021 10:46:19 +0200 (CEST) Received: from localhost ([::1]:60832 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mZqws-0002Dk-K7 for larch@yhetil.org; Mon, 11 Oct 2021 04:46:18 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55178) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mZqwd-0002Bq-Ci for guix-patches@gnu.org; Mon, 11 Oct 2021 04:46:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:44998) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mZqwc-0003A4-8W for guix-patches@gnu.org; Mon, 11 Oct 2021 04:46:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mZqwc-00005s-6v for guix-patches@gnu.org; Mon, 11 Oct 2021 04:46:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#51122] [PATCH] maint: Factorize po xref translation. Resent-From: "pelzflorian (Florian Pelz)" Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 11 Oct 2021 08:46:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51122 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Julien Lepiller Cc: 51122@debbugs.gnu.org Received: via spool by 51122-submit@debbugs.gnu.org id=B51122.1633941960348 (code B ref 51122); Mon, 11 Oct 2021 08:46:02 +0000 Received: (at 51122) by debbugs.gnu.org; 11 Oct 2021 08:46:00 +0000 Received: from localhost ([127.0.0.1]:56544 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mZqwZ-00005Y-QT for submit@debbugs.gnu.org; Mon, 11 Oct 2021 04:45:59 -0400 Received: from pelzflorian.de ([5.45.111.108]:60858 helo=mail.pelzflorian.de) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mZqwV-00005O-Vw for 51122@debbugs.gnu.org; Mon, 11 Oct 2021 04:45:58 -0400 Received: from pelzflorian.localdomain (unknown [5.45.111.108]) by mail.pelzflorian.de (Postfix) with ESMTPSA id D243636069D; Mon, 11 Oct 2021 10:45:53 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=pelzflorian.de; s=mail; t=1633941954; bh=Vaeq6cTaxWUQd17t7cBG5PPZa8jjFjJ0kvkrN2E5mCg=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=zzHZRNbEb6F+GI+5YzVuvTs94L+wOMppQvFDGxPvgx/t/nYsl9n/rg7grZeDBVDeb Vc2AobVzCVPDfE/t1iFwxn0X6HATC7FOlbIzPnrOJFAY177km0C3Wk0j0VvZAXmQU6 6vz0JsdXN5LguWpMXPMrpMztZ1dwe6p9ZWTe4dkI= Date: Mon, 11 Oct 2021 10:45:45 +0200 From: "pelzflorian (Florian Pelz)" Message-ID: <20211011082415.j6wera4b5t4mtnxa@pelzflorian.localdomain> References: <8a210e8ceaadfa600e60b0b97a1e7aba04b2bb02.1633901513.git.julien@lepiller.eu> <20211010233711.23bb1e9e@tachikoma.lepiller.eu> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20211010233711.23bb1e9e@tachikoma.lepiller.eu> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1633941979; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=EddHUBUnyuWjzzbdJh9QSSL5WGnhpSKls8+DKdsfnaE=; b=Jw3mAhxqGwCiWduwJgmNtVupml5W0anLIlMZcpTKKRT5Yo+BKeKDoiNQ8IBZSANc7+C9+c BLxPDSFF8QYmqdGLu7cfzp+WmC2E5q6YJqVald7k1gRKyO6qrGYSlcwInme4kq2ibqD83L orqlVl4ArqzmlDgGhhf4QO6XFaagqaZI2LsSMrC1khaKjWoppYJmBLtUCDbmuNog0hsJx3 smsjH3dM+67nSoE63iUSc0OJ2Sylji0nXvExqcuahP0B8ocUrASEzekXLTCwpenJQkmpUz q83r5teobSEWMvm6SLJTfgKYoFLB5Mdxk5i8E/f22l8iDvDRvxUncH5CosOckw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1633941979; a=rsa-sha256; cv=none; b=uKSA4DYsY7xznUKHg0iqjQhaRaZhhGHO039t8xpP6kVqtG2nXzLhOcZ8OGxUCyqIp5NwJv Z1lStvuGDlFcwxanAo9H/DFTmfeD/QzRZRTOJNzEzLvbNvK1R2u3sUQ8piTCn3gGoecIRn IlWwlkwm+xyng4+qCWUAsI+UUIhdbjyTmeUL7lQDDYgDgkUnTQserJRMEZU9damtNX0eZ1 8pJVp59g0qVJIxGSyebDoY8XrLFrQ6TDDWsTWTGpgkOcc9QYxRCtJ5SUqz7fWhbBdZ9fFP S1KzpsQ+Qbkz8rOWmKX0imXJAJFUpN/kyB0rzy32s/SpfhHWI7jj2CF0LCaLpw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=pelzflorian.de header.s=mail header.b=zzHZRNbE; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -1.81 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=pelzflorian.de header.s=mail header.b=zzHZRNbE; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 73BAD37403 X-Spam-Score: -1.81 X-Migadu-Scanner: scn1.migadu.com X-TUID: 7TdAeHhHwcTZ Hi Julien! Thank you for replacing that hard-to-read sed script. 65;6003;1c On Sun, Oct 10, 2021 at 11:37:11PM +0200, Julien Lepiller wrote: > For info, I built "make" and "make as-derivation" successfully with > this patch. I need it because with recent changes in guix.texi, a lot > of text has become fuzzy, including node names, which are translated by > the current xref_command (in doc/local.mk), when they shouldn't. I > improved the method we used for guix pull, and used it instead. I think you should add to the commit message that your patch Fixes fuzzy translations being inserted. Your changes to guix/build/po.scm do more than just move code (which you mentioned in the commit message): you added parsing of “#, fuzzy” flags. You should update the copyright header for guix/build/po.scm. Otherwise LGTM, but I haven’t tested yet. (make now converts the xref after scheme modules are compiled, I think(?), so testing PO files takes longer for me on a clean checkout. But it is fine.) Regards, Florian