unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: "pelzflorian (Florian Pelz)" <pelzflorian@pelzflorian.de>
To: Julien Lepiller <julien@lepiller.eu>
Cc: 51122@debbugs.gnu.org
Subject: [bug#51122] [PATCH] maint: Factorize po xref translation.
Date: Mon, 11 Oct 2021 10:45:45 +0200	[thread overview]
Message-ID: <20211011082415.j6wera4b5t4mtnxa@pelzflorian.localdomain> (raw)
In-Reply-To: <20211010233711.23bb1e9e@tachikoma.lepiller.eu>

Hi Julien!  Thank you for replacing that hard-to-read sed script.
65;6003;1c
On Sun, Oct 10, 2021 at 11:37:11PM +0200, Julien Lepiller wrote:
> For info, I built "make" and "make as-derivation" successfully with
> this patch. I need it because with recent changes in guix.texi, a lot
> of text has become fuzzy, including node names, which are translated by
> the current xref_command (in doc/local.mk), when they shouldn't. I
> improved the method we used for guix pull, and used it instead.

I think you should add to the commit message that your patch Fixes
fuzzy translations being inserted.

Your changes to guix/build/po.scm do more than just move code (which
you mentioned in the commit message): you added parsing of “#, fuzzy”
flags.

You should update the copyright header for guix/build/po.scm.

Otherwise LGTM, but I haven’t tested yet.  (make now converts the xref
after scheme modules are compiled, I think(?), so testing PO files
takes longer for me on a clean checkout.  But it is fine.)

Regards,
Florian




  reply	other threads:[~2021-10-11  8:46 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-10 21:32 [bug#51122] [PATCH] maint: Factorize po xref translation Julien Lepiller
2021-10-10 21:37 ` Julien Lepiller
2021-10-11  8:45   ` pelzflorian (Florian Pelz) [this message]
2021-10-11 12:46     ` [bug#51122] [PATCH v2] " Julien Lepiller
2021-10-11 17:17       ` pelzflorian (Florian Pelz)
2021-10-11 22:06         ` Julien Lepiller
2021-10-12 15:56           ` pelzflorian (Florian Pelz)
2021-10-12 18:09             ` pelzflorian (Florian Pelz)
2021-10-12 19:25               ` Julien Lepiller
2021-10-16  2:12                 ` Julien Lepiller
2021-10-16 18:45                   ` pelzflorian (Florian Pelz)
2021-10-17 20:12                     ` bug#51122: " Julien Lepiller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211011082415.j6wera4b5t4mtnxa@pelzflorian.localdomain \
    --to=pelzflorian@pelzflorian.de \
    --cc=51122@debbugs.gnu.org \
    --cc=julien@lepiller.eu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).