unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / Atom feed
* [bug#50593] [PATCH core-updates-frozen] gnu: gtk+: Fix testsuite failure on non-x86_64 platforms
@ 2021-09-14 23:24 Thiago Jung Bauermann via Guix-patches via
  2021-09-19 18:18 ` bug#50593: " Mathieu Othacehe
  0 siblings, 1 reply; 3+ messages in thread
From: Thiago Jung Bauermann via Guix-patches via @ 2021-09-14 23:24 UTC (permalink / raw)
  To: 50593; +Cc: Thiago Jung Bauermann

On non-x86_64 platforms, gtk+ is linked with a gdk-pixbuf version that
doesn’t support SVG.  This causes the ‘icontheme’ test to fail because it
tries to fetch SVG icons in some of the tests.

Therefore, we need to disable the test when SVG support isn’t available.

* gnu/packages/gtk.scm (gtk+)[propagated-inputs]: Use the ‘target-x86-64?’
convenience function.
[arguments]<#:phases>{disable-failing-tests}: Disable ‘icontheme’ test on
non-x86_64 platforms.
---

Hello,

This patch doesn’t change the gtk+ output derivations on x86_64-linux, so
it won’t cause any rebuilds there.

And together with the one in issue 50521, it allows gtk+ to build on
powerpc64le-linux. In fact, I can even build GTK+ apps such as Emacs and
Transmission! Unfortunately, GNOME apps need SVG support because of the
icon theme. And rust doesn’t build on powerpc64le-linux (mrustc errors out
with “Unknown target name ''”).

Thanks,
Thiago

 gnu/packages/gtk.scm | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

diff --git a/gnu/packages/gtk.scm b/gnu/packages/gtk.scm
index 24c24d56530f..876071235ef4 100644
--- a/gnu/packages/gtk.scm
+++ b/gnu/packages/gtk.scm
@@ -958,8 +958,7 @@ application suites.")
        ("freetype" ,freetype)
        ;; SVG support is optional and requires librsvg, which pulls in rust.
        ;; Rust is not supported well on every architecture yet.
-       ("gdk-pixbuf" ,(if (string-prefix? "x86_64" (or (%current-target-system)
-                                                       (%current-system)))
+       ("gdk-pixbuf" ,(if (target-x86-64?)
                           gdk-pixbuf+svg
                           gdk-pixbuf))
        ("glib" ,glib)
@@ -1028,7 +1027,12 @@ application suites.")
                (("notify no-gtk-init object objects-finalize papersize rbtree")
                 "no-gtk-init papersize rbtree")
                (("stylecontext templates textbuffer textiter treemodel treepath")
-                "stylecontext textbuffer textiter treemodel treepath"))
+                "stylecontext textbuffer textiter treemodel treepath")
+               ;; The ‘icontheme’ test needs SVG support.
+               ,@(if (not (target-x86-64?))
+                     '((("floating focus gestures grid gtkmenu icontheme keyhash listbox")
+                        "floating focus gestures grid gtkmenu keyhash listbox"))
+                     '()))
              (substitute* "testsuite/a11y/Makefile.in"
                (("accessibility-dump tree-performance text children derive")
                 "tree-performance text children derive"))




^ permalink raw reply	[flat|nested] 3+ messages in thread

* bug#50593: [PATCH core-updates-frozen] gnu: gtk+: Fix testsuite failure on non-x86_64 platforms
  2021-09-14 23:24 [bug#50593] [PATCH core-updates-frozen] gnu: gtk+: Fix testsuite failure on non-x86_64 platforms Thiago Jung Bauermann via Guix-patches via
@ 2021-09-19 18:18 ` Mathieu Othacehe
  2021-09-20  2:17   ` [bug#50593] " Thiago Jung Bauermann via Guix-patches via
  0 siblings, 1 reply; 3+ messages in thread
From: Mathieu Othacehe @ 2021-09-19 18:18 UTC (permalink / raw)
  To: Thiago Jung Bauermann; +Cc: 50593-done


Hello Thiago,

> And together with the one in issue 50521, it allows gtk+ to build on
> powerpc64le-linux. In fact, I can even build GTK+ apps such as Emacs and
> Transmission! Unfortunately, GNOME apps need SVG support because of the
> icon theme. And rust doesn’t build on powerpc64le-linux (mrustc errors out
> with “Unknown target name ''”).

Nice one, pushed as b452fe87e0c6e7634a2cb44274fa46832c763b40.

Thanks,

Mathieu




^ permalink raw reply	[flat|nested] 3+ messages in thread

* [bug#50593] [PATCH core-updates-frozen] gnu: gtk+: Fix testsuite failure on non-x86_64 platforms
  2021-09-19 18:18 ` bug#50593: " Mathieu Othacehe
@ 2021-09-20  2:17   ` Thiago Jung Bauermann via Guix-patches via
  0 siblings, 0 replies; 3+ messages in thread
From: Thiago Jung Bauermann via Guix-patches via @ 2021-09-20  2:17 UTC (permalink / raw)
  To: Mathieu Othacehe; +Cc: 50593-done

Hello Mathieu,

Em domingo, 19 de setembro de 2021, às 15:18:28 -03, Mathieu Othacehe 
escreveu:
> Hello Thiago,
> 
> > And together with the one in issue 50521, it allows gtk+ to build on
> > powerpc64le-linux. In fact, I can even build GTK+ apps such as Emacs
> > and
> > Transmission! Unfortunately, GNOME apps need SVG support because of the
> > icon theme. And rust doesn’t build on powerpc64le-linux (mrustc errors
> > out with “Unknown target name ''”).
> 
> Nice one, pushed as b452fe87e0c6e7634a2cb44274fa46832c763b40.

Great! Thank you!

-- 
Thanks,
Thiago






^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-09-20  2:18 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-14 23:24 [bug#50593] [PATCH core-updates-frozen] gnu: gtk+: Fix testsuite failure on non-x86_64 platforms Thiago Jung Bauermann via Guix-patches via
2021-09-19 18:18 ` bug#50593: " Mathieu Othacehe
2021-09-20  2:17   ` [bug#50593] " Thiago Jung Bauermann via Guix-patches via

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).